mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-30 12:44:10 +08:00
e15c3eb45b
The following patch fixes several outstanding overload resolution problems
with rvalue references and cv qualifiers in the test suite. The tests for
these problems typically passed with one compiler version and failed with
another. This behavior occurs because of the ordering of the overloaded
functions in the debug info. So the first best match "won out" over the
a subsequent better match.
One of the bugs addressed by this patch is the failure of rank_one_type to
account for type equality of two overloads based on CV qualifiers. This was
leading directly to problems evaluating rvalue reference overload quality,
but it is also highlighted in gdb.cp/oranking.exp, where two test KFAIL as
a result of this shortcoming.
I found the overload resolution code committed with the rvalue reference
patch (f9aeb8d49) needlessly over-complicated, and I have greatly simplified
it. This fixes some KFAILing tests in gdb.exp/rvalue-ref-overload.exp.
gdb/ChangeLog
* gdbtypes.c (LVALUE_REFERENCE_TO_RVALUE_BINDING_BADNESS)
DIFFERENT_REFERENCE_TYPE_BADNESS): Remove.
(CV_CONVERSION_BADNESS): Define.
(rank_one_type): Remove overly restrictive rvalue reference
rank checks.
Add cv-qualifier checks and subranks for type equality.
* gdbtypes.h (REFERENCE_CONVERSION_RVALUE,
REFERENCE_CONVERSION_CONST_LVALUE, CV_CONVERSION_BADNESS,
CV_CONVERSION_CONST, CV_CONVERSION_VOLATILE): Declare.
gdb/testsuite/ChangeLog
* gdb.cp/oranking.cc (test15): New function.
(main): Call test15 and declare additional variables for testing.
* gdb.cp/oranking.exp: Remove kfail status for "p foo4(&a)" and
"p foo101('abc')" tests.
* gdb.cp/rvalue-ref-overloads.exp: Remove kfail status for
"lvalue reference overload" test.
* gdb.cp/rvalue-ref-params.exp: Remove kfail status for
"print value of f1 on Child&& in f2" test.
69 lines
2.2 KiB
Plaintext
69 lines
2.2 KiB
Plaintext
# Copyright 1998-2017 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This file is part of the gdb testsuite
|
|
|
|
# Tests for overloaded member functions with rvalue reference parameters,
|
|
# based on gdb.cp/overload.exp.
|
|
|
|
if {[skip_cplus_tests]} { continue }
|
|
|
|
load_lib "cp-support.exp"
|
|
|
|
standard_testfile .cc
|
|
|
|
if {[prepare_for_testing $testfile.exp $testfile $srcfile \
|
|
{debug c++ additional_flags="-std=gnu++11"}]} {
|
|
return -1
|
|
}
|
|
|
|
# Set it up at a breakpoint so we can play with the variable values.
|
|
|
|
if {![runto 'marker1']} {
|
|
untested "couldn't run to marker1"
|
|
return -1
|
|
}
|
|
|
|
# Prevent symbol on address 0x0 being printed.
|
|
gdb_test_no_output "set print symbol off"
|
|
gdb_test "up" ".*main.*" "up from marker1"
|
|
|
|
# Print the monster class type.
|
|
cp_test_ptype_class "foo_rr_instance1" "" "class" "foo" \
|
|
{
|
|
{ method public "foo(void);" }
|
|
{ method public "foo(foo_lval_ref);" }
|
|
{ method public "foo(foo_rval_ref);" }
|
|
{ method public "~foo();" }
|
|
{ method public "int overload1arg(foo_lval_ref);" }
|
|
{ method public "int overload1arg(foo_rval_ref);" }
|
|
}
|
|
|
|
gdb_test "print foo_rr_instance1.overload1arg(arg)" \
|
|
"\\$\[0-9\]+ = 1" \
|
|
"print call overloaded func foo & arg"
|
|
|
|
gdb_test "print foo_rr_instance1.overload1arg(static_cast<foo&&>(arg))" \
|
|
"\\$\[0-9\]+ = 2" \
|
|
"print call overloaded func foo && arg"
|
|
|
|
# Test lvalue vs rvalue function overloads
|
|
gdb_test "print f (i)" "= 1" "lvalue reference overload"
|
|
|
|
gdb_test "print f (ci)" "= 2" "lvalue reference to const overload"
|
|
|
|
setup_kfail "c++/15372" "*-*-*"
|
|
gdb_test "print f (3)" "= 3" "rvalue reference overload"
|