mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-02-05 12:53:16 +08:00
e68cb8e001
While the previous commit made "p method()::static_var" (no
single-quotes) Just Work, if users (or frontends) try wrapping the
expression with quotes, they'll get:
(gdb) p 'S::method()::static_var'
'S::method()::static_var' has unknown type; cast it to its declared type
even if we _do_ have debug info for that variable. That's better than
the bogus/confusing value what GDB would print before the
stop-assuming-int patch:
(gdb) p 'S::method()::static_var'
$1 = 1
but I think it'd still be nice to make this case Just Work too.
In this case, due to the quoting, the C/C++ parser (c-exp.y)
interprets the whole expression/string as a single symbol name, and we
end up calling lookup_symbol on that name. There's no debug symbol
with that fully-qualified name, but since the compiler gives the
static variable a mangled linkage name exactly like the above, it
appears in the mininal symbols:
$ nm -A local-static | c++filt | grep static_var
local-static:0000000000601040 d S::method()::static_var
... and that's what GDB happens to find/print. This only happens in
C++, note, since for C the compiler uses different linkage names:
local-static-c:0000000000601040 d static_var.1848
So while (in C++, not C) function local static variables are given a
mangled name that demangles to the same syntax that GDB
documents/expects as the way to access function local statics, there's
no global symbol in the debug info with that name at all. The debug
info for a static local variable for a non-inline function looks like
this:
<1><2a1>: Abbrev Number: 19 (DW_TAG_subprogram)
...
<2><2f7>: Abbrev Number: 20 (DW_TAG_variable)
<2f8> DW_AT_name : (indirect string, offset: 0x4e9): static_var
<2fc> DW_AT_decl_file : 1
<2fd> DW_AT_decl_line : 64
<2fe> DW_AT_type : <0x25>
<302> DW_AT_location : 9 byte block: 3 40 10 60 0 0 0 0 0 (DW_OP_addr: 601040)
and for an inline function, it looks like this (linkage name run
through c++filt for convenience):
<2><21b>: Abbrev Number: 16 (DW_TAG_variable)
<21c> DW_AT_name : (indirect string, offset: 0x21a): static_var
<220> DW_AT_decl_file : 1
<221> DW_AT_decl_line : 48
<222> DW_AT_linkage_name: (indirect string, offset: 0x200): S::inline_method()::static_var
<226> DW_AT_type : <0x25>
<22a> DW_AT_external : 1
<22a> DW_AT_location : 9 byte block: 3 a0 10 60 0 0 0 0 0 (DW_OP_addr: 6010a0)
(The inline case makes the variable external so that the linker can
merge the different inlined copies. It seems like GCC never outputs
the linkage name for non-extern globals.)
When we read the DWARF, we record the static_var variable as a regular
variable of the containing function's block. This makes stopping in
the function and printing the variable as usual. The variable just so
happens to have a memory address as location.
So one way to make "p 'S::method()::static_var'" work would be to
record _two_ copies of the symbols for these variables. One in the
function's scope/block, with "static_var" as name, as we currently do,
and another in the static or global blocks (depending on whether the
symbol is external), with a fully-qualified name. I wrote a prototype
patch for that, and it works. For the non-inline case above, since
the debug info doesn't point to the linkage same, that patch built the
physname of the static local variable as the concat of the physname of
the containing function, plus "::", plus the variable's name. We
could make that approach work for C too, though it kind of feels
awkward to record fake symbol names like that in C.
The other approach I tried is to change the C++ symbol lookup routines
instead. This is the approach this commit takes. We can already
lookup up symbol in namespaces and classes, so this feels like a good
fit, and was easy enough. The advantage is that this doesn't require
recording extra symbols.
The test in gdb.cp/m-static.exp that exposed the need for this is
removed, since the same functionality is now covered by
gdb.cp/local-static.exp.
gdb/ChangeLog:
2017-09-04 Pedro Alves <palves@redhat.com>
* cp-namespace.c (cp_search_static_and_baseclasses): Handle
function/method scopes; lookup the nested name as a function local
static variable.
gdb/testsuite/ChangeLog:
2017-09-04 Pedro Alves <palves@redhat.com>
* gdb.base/local-static.exp: Also test with
class::method::variable wholly quoted.
* gdb.cp/m-static.exp (class::method::variable): Remove test.
194 lines
7.6 KiB
Plaintext
194 lines
7.6 KiB
Plaintext
# Copyright 2002-2017 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Tests for member static data
|
|
# 2002-05-13 Benjamin Kosnik <bkoz@redhat.com>
|
|
# 2002-08-22 David Carlton <carlton@math.stanford.edu>
|
|
|
|
# This file is part of the gdb testsuite
|
|
|
|
if { [skip_cplus_tests] } { continue }
|
|
|
|
#
|
|
# test running programs
|
|
#
|
|
|
|
standard_testfile .cc m-static1.cc
|
|
|
|
if [get_compiler_info] {
|
|
return -1
|
|
}
|
|
|
|
if {[prepare_for_testing "failed to prepare" $testfile \
|
|
[list $srcfile $srcfile2] {debug c++}]} {
|
|
return -1
|
|
}
|
|
|
|
if ![runto_main] then {
|
|
perror "couldn't run to breakpoint"
|
|
continue
|
|
}
|
|
|
|
get_debug_format
|
|
set non_dwarf [expr ! [test_debug_format "DWARF 2"]]
|
|
|
|
# First, run to after we've constructed all the objects:
|
|
|
|
gdb_breakpoint [gdb_get_line_number "constructs-done"]
|
|
gdb_continue_to_breakpoint "end of constructors"
|
|
|
|
|
|
# One.
|
|
|
|
# simple object, static const bool
|
|
gdb_test "print test1.test" "\\$\[0-9\]* = true" "simple object, static const bool"
|
|
|
|
# simple object, static const int
|
|
gdb_test "print test1.key1" "\\$\[0-9\]* = 5" "simple object, static const int"
|
|
|
|
# simple object, static long
|
|
gdb_test "print test1.key2" "\\$\[0-9\]* = 77" "simple object, static long"
|
|
|
|
# simple object, static enum
|
|
gdb_test "print test1.value" "\\$\[0-9\]* = oriental" "simple object, static enum"
|
|
|
|
if { [is_aarch32_target] } {
|
|
gdb_test "print test5.single_constructor" \
|
|
{ = {single_constructor \*\(single_constructor \* const\)} 0x[0-9a-f]+ <single_constructor::single_constructor\(\)>} \
|
|
"simple object instance, print constructor"
|
|
gdb_test "ptype test5.single_constructor" \
|
|
{type = class single_constructor {\r\n public:\r\n single_constructor\(void\);\r\n ~single_constructor\(\);\r\n} \*\(single_constructor \* const\)} \
|
|
"simple object instance, ptype constructor"
|
|
gdb_test "ptype single_constructor::single_constructor" \
|
|
{type = class single_constructor {\r\n public:\r\n single_constructor\(void\);\r\n ~single_constructor\(\);\r\n} \*\(single_constructor \* const\)} \
|
|
"simple object class, ptype constructor"
|
|
|
|
gdb_test "print test1.~gnu_obj_1" \
|
|
{ = {void \*\(gnu_obj_1 \* const, int\)} 0x[0-9a-f]+ <gnu_obj_1::~gnu_obj_1\(\)>} \
|
|
"simple object instance, print destructor"
|
|
gdb_test "ptype test1.~gnu_obj_1" \
|
|
{type = void \*\(gnu_obj_1 \* const, int\)} \
|
|
"simple object instance, ptype destructor"
|
|
|
|
gdb_test "print test1.'~gnu_obj_1'" \
|
|
{ = {void \*\(gnu_obj_1 \*( const)?, int\)} 0x[0-9a-f]+ <gnu_obj_1::~gnu_obj_1\(\)>} \
|
|
"simple object instance, print quoted destructor"
|
|
|
|
gdb_test "ptype gnu_obj_1::'~gnu_obj_1'" \
|
|
{type = void \*\(gnu_obj_1 \* const\)} \
|
|
"simple object class, ptype quoted destructor"
|
|
} else {
|
|
gdb_test "print test5.single_constructor" \
|
|
{ = {void \(single_constructor \* const\)} 0x[0-9a-f]+ <single_constructor::single_constructor\(\)>} \
|
|
"simple object instance, print constructor"
|
|
gdb_test "ptype test5.single_constructor" \
|
|
{type = void \(single_constructor \* const\)} \
|
|
"simple object instance, ptype constructor"
|
|
gdb_test "ptype single_constructor::single_constructor" \
|
|
{type = void \(single_constructor \* const\)} \
|
|
"simple object class, ptype constructor"
|
|
|
|
gdb_test "print test1.~gnu_obj_1" \
|
|
{ = {void \(gnu_obj_1 \* const, int\)} 0x[0-9a-f]+ <gnu_obj_1::~gnu_obj_1\(\)>} \
|
|
"simple object instance, print destructor"
|
|
gdb_test "ptype test1.~gnu_obj_1" \
|
|
{type = void \(gnu_obj_1 \* const, int\)} \
|
|
"simple object instance, ptype destructor"
|
|
|
|
gdb_test "print test1.'~gnu_obj_1'" \
|
|
{ = {void \(gnu_obj_1 \*( const)?, int\)} 0x[0-9a-f]+ <gnu_obj_1::~gnu_obj_1\(\)>} \
|
|
"simple object instance, print quoted destructor"
|
|
|
|
gdb_test "ptype gnu_obj_1::'~gnu_obj_1'" \
|
|
{type = void \(gnu_obj_1 \* const\)} \
|
|
"simple object class, ptype quoted destructor"
|
|
}
|
|
|
|
# Two.
|
|
|
|
# derived template object, base static const bool
|
|
gdb_test "print test2.test" "\\$\[0-9\]* = true" "derived template object, base static const bool"
|
|
|
|
# derived template object, base static const int
|
|
gdb_test "print test2.key1" "\\$\[0-9\]* = 5" "derived template object, base static const int"
|
|
|
|
# derived template object, base static long
|
|
gdb_test "print test2.key2" "\\$\[0-9\]* = 77" "derived template object, base static long"
|
|
|
|
# derived template object, base static enum
|
|
gdb_test "print test2.value" "\\$\[0-9\].* = oriental" "derived template object, base static enum"
|
|
|
|
# derived template object, static enum
|
|
gdb_test "print test2.value_derived" "\\$\[0-9\].* = etruscan" "derived template object, static enum"
|
|
|
|
# Three.
|
|
|
|
# template object, static derived template data member's base static const bool
|
|
gdb_test "print test3.data.test" "\\$\[0-9\].* = true" "template object, static const bool"
|
|
|
|
# template object, static derived template data member's base static const int
|
|
gdb_test "print test3.data.key1" "\\$\[0-9\].* = 5" "template object, static const int"
|
|
|
|
# template object, static derived template data member's base static long
|
|
gdb_test "print test3.data.key2" "\\$\[0-9\].* = 77" "template object, static long"
|
|
|
|
# template object, static derived template data member's base static enum
|
|
gdb_test "print test3.data.value" "\\$\[0-9\].* = oriental" "template object, static enum"
|
|
|
|
# template object, static derived template data member's static enum
|
|
gdb_test "print test3.data.value_derived" "\\$\[0-9\].* = etruscan" "template object, static derived enum"
|
|
|
|
# 2002-08-16
|
|
# Four.
|
|
|
|
# static const int initialized in another file.
|
|
gdb_test "print test4.elsewhere" "\\$\[0-9\].* = 221" "static const int initialized elsewhere"
|
|
|
|
# static const int that nobody initializes. From PR gdb/635.
|
|
if {[test_compiler_info {gcc-[0-3]-*}]
|
|
|| [test_compiler_info {gcc-4-[0-4]-*}]} {
|
|
# There was an extra CU-level DW_TAG_variable as DW_AT_declaration
|
|
# with DW_AT_name = nowhere
|
|
# and DW_AT_MIPS_linkage_name = _ZN9gnu_obj_47nowhereE .
|
|
setup_xfail *-*-*
|
|
}
|
|
gdb_test "print test4.nowhere" "<optimized out>" "static const int initialized nowhere (print field)"
|
|
|
|
# Same, but print the whole struct.
|
|
gdb_test "print test4" "static nowhere = <optimized out>.*" "static const int initialized nowhere (whole struct)"
|
|
|
|
# static const initialized in the class definition, PR gdb/11702.
|
|
if { $non_dwarf } { setup_xfail *-*-* }
|
|
gdb_test "print test4.everywhere" "\\$\[0-9\].* = 317" "static const int initialized in class definition"
|
|
if { $non_dwarf } { setup_xfail *-*-* }
|
|
gdb_test "print test4.somewhere" "\\$\[0-9\].* = 3.14\[0-9\]*" "static const float initialized in class definition"
|
|
|
|
# Also make sure static const members can be found via "info var".
|
|
if { $non_dwarf } { setup_xfail *-*-* }
|
|
gdb_test "info variable everywhere" "File .*/m-static\[.\]h.*const int gnu_obj_4::everywhere;" "info variable everywhere"
|
|
|
|
# Perhaps at some point test4 should also include a test for a static
|
|
# const int that was initialized in the header file. But I'm not sure
|
|
# that GDB's current behavior in such situations is either consistent
|
|
# across platforms or optimal, so I'm not including one now.
|
|
|
|
# Step into test1.method and examine the method-scoped static.
|
|
# This is a regression test for PR 9708.
|
|
gdb_test "step" "gnu_obj_1::method.*"
|
|
gdb_test "print svar" " = true"
|
|
|
|
gdb_exit
|
|
return 0
|