mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 04:31:49 +08:00
23ec1e32b1
Complement commit e17b0c351f ("MIPS/BFD: Respect the ELF gABI dynamic
symbol table sort requirement") and correct an inconsistency in dynamic
symbol accounting data causing an assertion failure in the MIPS backend:
ld: BFD (GNU Binutils) 2.28.51.20170330 assertion fail
../../binutils-gdb/bfd/elfxx-mips.c:3860
in the course of making a GOT entry in a static binary to satisfy a GOT
relocation present in input, due to the local dynamic symbol count not
having been established.
To do so let backends request `_bfd_elf_link_renumber_dynsyms' to be
always called, rather than where a dynamic binary is linked only, and
then make this request in the MIPS backend.
bfd/
PR ld/21334
* elf-bfd.h (elf_backend_data): Add `always_renumber_dynsyms'
member.
* elfxx-target.h [!elf_backend_always_renumber_dynsyms]
(elf_backend_always_renumber_dynsyms): Define.
(elfNN_bed): Initialize `always_renumber_dynsyms' member.
* elfxx-mips.h (elf_backend_always_renumber_dynsyms): Define.
* elflink.c (bfd_elf_size_dynamic_sections): Also call
`_bfd_elf_link_renumber_dynsyms' if the backend has requested
it.
(bfd_elf_size_dynsym_hash_dynstr): Likewise.
ld/
PR ld/21334
* testsuite/ld-mips-elf/pr21334.dd: New test.
* testsuite/ld-mips-elf/pr21334.gd: New test.
* testsuite/ld-mips-elf/pr21334.ld: New test linker script.
* testsuite/ld-mips-elf/pr21334.s: New test source.
* testsuite/ld-mips-elf/mips-elf.exp: Run the new tests.
198 lines
8.6 KiB
C
198 lines
8.6 KiB
C
/* MIPS ELF specific backend routines.
|
|
Copyright (C) 2002-2017 Free Software Foundation, Inc.
|
|
|
|
This file is part of BFD, the Binary File Descriptor library.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
|
MA 02110-1301, USA. */
|
|
|
|
#include "elf/common.h"
|
|
#include "elf/internal.h"
|
|
#include "elf/mips.h"
|
|
|
|
extern bfd_boolean _bfd_mips_elf_mkobject
|
|
(bfd *);
|
|
extern bfd_boolean _bfd_mips_elf_new_section_hook
|
|
(bfd *, asection *);
|
|
extern void _bfd_mips_elf_symbol_processing
|
|
(bfd *, asymbol *);
|
|
extern unsigned int _bfd_mips_elf_eh_frame_address_size
|
|
(bfd *, asection *);
|
|
extern bfd_boolean _bfd_mips_elf_name_local_section_symbols
|
|
(bfd *);
|
|
extern bfd_boolean _bfd_mips_elf_section_processing
|
|
(bfd *, Elf_Internal_Shdr *);
|
|
extern bfd_boolean _bfd_mips_elf_section_from_shdr
|
|
(bfd *, Elf_Internal_Shdr *, const char *, int);
|
|
extern bfd_boolean _bfd_mips_elf_fake_sections
|
|
(bfd *, Elf_Internal_Shdr *, asection *);
|
|
extern bfd_boolean _bfd_mips_elf_section_from_bfd_section
|
|
(bfd *, asection *, int *);
|
|
extern bfd_boolean _bfd_mips_elf_add_symbol_hook
|
|
(bfd *, struct bfd_link_info *, Elf_Internal_Sym *,
|
|
const char **, flagword *, asection **, bfd_vma *);
|
|
extern int _bfd_mips_elf_link_output_symbol_hook
|
|
(struct bfd_link_info *, const char *, Elf_Internal_Sym *,
|
|
asection *, struct elf_link_hash_entry *);
|
|
extern bfd_boolean _bfd_mips_elf_create_dynamic_sections
|
|
(bfd *, struct bfd_link_info *);
|
|
extern bfd_boolean _bfd_mips_elf_check_relocs
|
|
(bfd *, struct bfd_link_info *, asection *, const Elf_Internal_Rela *);
|
|
extern bfd_boolean _bfd_mips_elf_adjust_dynamic_symbol
|
|
(struct bfd_link_info *, struct elf_link_hash_entry *);
|
|
extern bfd_boolean _bfd_mips_elf_always_size_sections
|
|
(bfd *, struct bfd_link_info *);
|
|
extern bfd_boolean _bfd_mips_elf_size_dynamic_sections
|
|
(bfd *, struct bfd_link_info *);
|
|
extern bfd_boolean _bfd_mips_elf_relocate_section
|
|
(bfd *, struct bfd_link_info *, bfd *, asection *, bfd_byte *,
|
|
Elf_Internal_Rela *, Elf_Internal_Sym *, asection **);
|
|
extern bfd_boolean _bfd_mips_elf_finish_dynamic_symbol
|
|
(bfd *, struct bfd_link_info *, struct elf_link_hash_entry *,
|
|
Elf_Internal_Sym *);
|
|
extern bfd_boolean _bfd_mips_vxworks_finish_dynamic_symbol
|
|
(bfd *, struct bfd_link_info *, struct elf_link_hash_entry *,
|
|
Elf_Internal_Sym *);
|
|
extern bfd_boolean _bfd_mips_elf_finish_dynamic_sections
|
|
(bfd *, struct bfd_link_info *);
|
|
extern bfd_boolean _bfd_mips_elf_sort_relocs_p
|
|
(asection *);
|
|
extern void _bfd_mips_elf_final_write_processing
|
|
(bfd *, bfd_boolean);
|
|
extern int _bfd_mips_elf_additional_program_headers
|
|
(bfd *, struct bfd_link_info *);
|
|
extern bfd_boolean _bfd_mips_elf_modify_segment_map
|
|
(bfd *, struct bfd_link_info *);
|
|
extern asection * _bfd_mips_elf_gc_mark_hook
|
|
(asection *, struct bfd_link_info *, Elf_Internal_Rela *,
|
|
struct elf_link_hash_entry *, Elf_Internal_Sym *);
|
|
extern bfd_boolean _bfd_mips_elf_gc_sweep_hook
|
|
(bfd *, struct bfd_link_info *, asection *, const Elf_Internal_Rela *);
|
|
extern void _bfd_mips_elf_copy_indirect_symbol
|
|
(struct bfd_link_info *, struct elf_link_hash_entry *,
|
|
struct elf_link_hash_entry *);
|
|
extern bfd_boolean _bfd_mips_elf_ignore_discarded_relocs
|
|
(asection *);
|
|
extern bfd_boolean _bfd_mips_elf_is_target_special_symbol
|
|
(bfd *abfd, asymbol *sym);
|
|
extern bfd_boolean _bfd_mips_elf_find_nearest_line
|
|
(bfd *, asymbol **, asection *, bfd_vma,
|
|
const char **, const char **, unsigned int *, unsigned int *);
|
|
extern bfd_boolean _bfd_mips_elf_find_inliner_info
|
|
(bfd *, const char **, const char **, unsigned int *);
|
|
extern bfd_boolean _bfd_mips_elf_set_section_contents
|
|
(bfd *, asection *, const void *, file_ptr, bfd_size_type);
|
|
extern bfd_byte *_bfd_elf_mips_get_relocated_section_contents
|
|
(bfd *, struct bfd_link_info *, struct bfd_link_order *,
|
|
bfd_byte *, bfd_boolean, asymbol **);
|
|
extern bfd_boolean _bfd_mips_elf_relax_section
|
|
(bfd *abfd, asection *sec, struct bfd_link_info *link_info,
|
|
bfd_boolean *again);
|
|
extern struct bfd_link_hash_table *_bfd_mips_elf_link_hash_table_create
|
|
(bfd *);
|
|
extern struct bfd_link_hash_table *_bfd_mips_vxworks_link_hash_table_create
|
|
(bfd *);
|
|
extern bfd_boolean _bfd_mips_elf_final_link
|
|
(bfd *, struct bfd_link_info *);
|
|
extern bfd_boolean _bfd_mips_elf_merge_private_bfd_data
|
|
(bfd *, struct bfd_link_info *);
|
|
extern bfd_boolean _bfd_mips_elf_set_private_flags
|
|
(bfd *, flagword);
|
|
extern const char * _bfd_mips_fp_abi_string
|
|
(int);
|
|
extern bfd_boolean _bfd_mips_elf_print_private_bfd_data
|
|
(bfd *, void *);
|
|
extern bfd_boolean _bfd_mips_elf_discard_info
|
|
(bfd *, struct elf_reloc_cookie *, struct bfd_link_info *);
|
|
extern bfd_boolean _bfd_mips_elf_write_section
|
|
(bfd *, struct bfd_link_info *, asection *, bfd_byte *);
|
|
|
|
extern bfd_boolean _bfd_mips_elf_read_ecoff_info
|
|
(bfd *, asection *, struct ecoff_debug_info *);
|
|
extern void _bfd_mips_elf_reloc_unshuffle
|
|
(bfd *, int, bfd_boolean, bfd_byte *);
|
|
extern void _bfd_mips_elf_reloc_shuffle
|
|
(bfd *, int, bfd_boolean, bfd_byte *);
|
|
extern bfd_reloc_status_type _bfd_mips_elf_gprel16_with_gp
|
|
(bfd *, asymbol *, arelent *, asection *, bfd_boolean, void *, bfd_vma);
|
|
extern bfd_reloc_status_type _bfd_mips_elf32_gprel16_reloc
|
|
(bfd *, arelent *, asymbol *, void *, asection *, bfd *, char **);
|
|
extern bfd_reloc_status_type _bfd_mips_elf_hi16_reloc
|
|
(bfd *, arelent *, asymbol *, void *, asection *, bfd *, char **);
|
|
extern bfd_reloc_status_type _bfd_mips_elf_got16_reloc
|
|
(bfd *, arelent *, asymbol *, void *, asection *, bfd *, char **);
|
|
extern bfd_reloc_status_type _bfd_mips_elf_lo16_reloc
|
|
(bfd *, arelent *, asymbol *, void *, asection *, bfd *, char **);
|
|
extern bfd_reloc_status_type _bfd_mips_elf_generic_reloc
|
|
(bfd *, arelent *, asymbol *, void *, asection *, bfd *, char **);
|
|
extern unsigned long _bfd_elf_mips_mach
|
|
(flagword);
|
|
extern bfd_vma _bfd_mips_elf_sign_extend
|
|
(bfd_vma, int);
|
|
extern void _bfd_mips_elf_merge_symbol_attribute
|
|
(struct elf_link_hash_entry *, const Elf_Internal_Sym *, bfd_boolean, bfd_boolean);
|
|
extern char *_bfd_mips_elf_get_target_dtag (bfd_vma);
|
|
extern bfd_boolean _bfd_mips_elf_ignore_undef_symbol
|
|
(struct elf_link_hash_entry *);
|
|
extern void _bfd_mips_elf_use_plts_and_copy_relocs
|
|
(struct bfd_link_info *);
|
|
extern void _bfd_mips_elf_linker_flags
|
|
(struct bfd_link_info *, bfd_boolean, bfd_boolean);
|
|
extern bfd_boolean _bfd_mips_elf_init_stubs
|
|
(struct bfd_link_info *,
|
|
asection *(*) (const char *, asection *, asection *));
|
|
extern bfd_vma _bfd_mips_elf_plt_sym_val
|
|
(bfd_vma, const asection *, const arelent *rel);
|
|
extern long _bfd_mips_elf_get_synthetic_symtab
|
|
(bfd *, long, asymbol **, long, asymbol **, asymbol **);
|
|
extern bfd_boolean _bfd_mips_elf_gc_mark_extra_sections
|
|
(struct bfd_link_info *, elf_gc_mark_hook_fn);
|
|
extern void _bfd_mips_post_process_headers
|
|
(bfd *abfd, struct bfd_link_info *link_info);
|
|
|
|
extern const struct bfd_elf_special_section _bfd_mips_elf_special_sections [];
|
|
|
|
extern bfd_boolean _bfd_mips_elf_common_definition (Elf_Internal_Sym *);
|
|
|
|
extern int _bfd_mips_elf_compact_eh_encoding (struct bfd_link_info *);
|
|
extern int _bfd_mips_elf_cant_unwind_opcode (struct bfd_link_info *);
|
|
|
|
static inline bfd_boolean
|
|
gprel16_reloc_p (unsigned int r_type)
|
|
{
|
|
return (r_type == R_MIPS_GPREL16
|
|
|| r_type == R_MIPS16_GPREL
|
|
|| r_type == R_MICROMIPS_GPREL16
|
|
|| r_type == R_MICROMIPS_GPREL7_S2);
|
|
}
|
|
|
|
static inline bfd_boolean
|
|
literal_reloc_p (int r_type)
|
|
{
|
|
return r_type == R_MIPS_LITERAL || r_type == R_MICROMIPS_LITERAL;
|
|
}
|
|
|
|
#define elf_backend_common_definition _bfd_mips_elf_common_definition
|
|
#define elf_backend_name_local_section_symbols \
|
|
_bfd_mips_elf_name_local_section_symbols
|
|
#define elf_backend_special_sections _bfd_mips_elf_special_sections
|
|
#define elf_backend_eh_frame_address_size _bfd_mips_elf_eh_frame_address_size
|
|
#define elf_backend_merge_symbol_attribute _bfd_mips_elf_merge_symbol_attribute
|
|
#define elf_backend_ignore_undef_symbol _bfd_mips_elf_ignore_undef_symbol
|
|
#define elf_backend_post_process_headers _bfd_mips_post_process_headers
|
|
#define elf_backend_compact_eh_encoding _bfd_mips_elf_compact_eh_encoding
|
|
#define elf_backend_cant_unwind_opcode _bfd_mips_elf_cant_unwind_opcode
|
|
#define elf_backend_always_renumber_dynsyms TRUE
|