binutils-gdb/gdbserver
Luis Machado 19007d9556 Fix TBI handling for watchpoints
When inserting hw watchpoints, we take care of masking off the top byte
of the address (and sign-extending it if needed).  This guarantees we won't
pass tagged addresses to the kernel via ptrace.

However, from the kernel documentation on tagged pointers...

"Non-zero tags are not preserved when delivering signals. This means that
signal handlers in applications making use of tags cannot rely on the tag
information for user virtual addresses being maintained for fields inside
siginfo_t.

One exception to this rule is for signals raised in response to watchpoint
debug exceptions, where the tag information will be preserved."

So the stopped data address after a hw watchpoint hit can be potentially
tagged, and we don't handle this in GDB at the moment.  This results in
GDB missing a hw watchpoint hit and attempting to step over an unsteppable
hw watchpoint, causing it to spin endlessly.

The following patch fixes this by adjusting the stopped data address and adds
some tests to expose the problem.

gdb/ChangeLog:

2020-12-16  Luis Machado  <luis.machado@linaro.org>

	* aarch64-linux-nat.c
	(aarch64_linux_nat_target::stopped_data_address): Handle the TBI.

gdbserver/ChangeLog:

2020-12-16  Luis Machado  <luis.machado@linaro.org>

	* linux-aarch64-low.cc (address_significant): New function.
	(aarch64_target::low_stopped_data_address): Handle the TBI.

gdb/testsuite/ChangeLog:

2020-12-16  Luis Machado  <luis.machado@linaro.org>

	* gdb.arch/aarch64-tagged-pointer.c (main): Add a few more
	pointer-based memory accesses.
	* gdb.arch/aarch64-tagged-pointer.exp: Exercise additional
	hw watchpoint cases.
2020-12-16 10:05:56 -03:00
..
.dir-locals.el
.gitattributes
.gitignore
acinclude.m4 gdbserver: replace AC_TRY_COMPILE in acinclude.m4 2020-10-31 08:31:00 -04:00
aclocal.m4
ax.cc gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
ax.h [gdbserver] Add missing include of gdbsupport/agent.h 2020-06-29 12:14:10 +02:00
ChangeLog Fix TBI handling for watchpoints 2020-12-16 10:05:56 -03:00
config.in gdbserver: re-generate configure 2020-10-24 12:44:19 -04:00
configure gdbserver: replace AC_TRY_COMPILE in acinclude.m4 2020-10-31 08:31:00 -04:00
configure.ac gdbserver: modernize configure.ac 2020-10-31 08:30:58 -04:00
configure.srv gdbserver: Add GNU/Linux support for ARC 2020-10-07 17:46:23 +02:00
debug.cc
debug.h
dll.cc gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
dll.h
fork-child.cc
gdb_proc_service.h
gdbreplay.cc
gdbthread.h
hostio-errno.cc
hostio.cc
hostio.h
i387-fp.cc
i387-fp.h
inferiors.cc Fix undefined behavior in gdbserver 2020-10-20 10:36:04 -06:00
inferiors.h gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
linux-aarch32-low.cc
linux-aarch32-low.h
linux-aarch32-tdesc.cc
linux-aarch32-tdesc.h
linux-aarch64-ipa.cc
linux-aarch64-low.cc Fix TBI handling for watchpoints 2020-12-16 10:05:56 -03:00
linux-aarch64-tdesc.cc
linux-aarch64-tdesc.h
linux-amd64-ipa.cc
linux-arc-low.cc gdb: Delay releasing target_desc_up in more cases 2020-10-09 11:45:44 +01:00
linux-arm-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-arm-tdesc.cc
linux-arm-tdesc.h
linux-i386-ipa.cc
linux-ia64-low.cc gdbserver/linux-ia64-low: fix a build-breaking typo 2020-05-16 10:45:40 +02:00
linux-low.cc gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
linux-low.h Make target_wait options use enum flags 2020-09-18 14:20:44 -06:00
linux-m68k-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-mips-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-nios2-low.cc gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
linux-ppc-ipa.cc gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
linux-ppc-low.cc gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
linux-ppc-tdesc-init.h
linux-riscv-low.cc gdb: Have allocate_target_description return a unique_ptr 2020-10-08 10:14:14 +01:00
linux-s390-ipa.cc
linux-s390-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-s390-tdesc.h
linux-sh-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-sparc-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-tic6x-low.cc gdbserver/linux-low: delete 'linux_target_ops' and 'the_low_target' 2020-04-02 15:11:32 +02:00
linux-x86-low.cc gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
linux-x86-tdesc.cc
linux-x86-tdesc.h
linux-xtensa-low.cc gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
Makefile.in gdbsupport: make use of safe-ctype functions from libiberty 2020-12-11 22:04:28 +00:00
mem-break.cc
mem-break.h
netbsd-aarch64-low.cc Add NetBSD/aarch64 gdbserver support 2020-10-07 14:39:59 +02:00
netbsd-amd64-low.cc Fix whitespace formatting 2020-10-07 15:08:31 +02:00
netbsd-i386-low.cc Add NetBSD/i386 gdbserver support 2020-10-02 00:41:21 +02:00
netbsd-low.cc gdb::handle_eintr, remove need to specify return type 2020-10-26 18:57:40 +00:00
netbsd-low.h Refactor the NetBSD amd64 gdbserver support 2020-10-02 00:39:20 +02:00
notif.cc
notif.h
proc-service.cc gdbserver/linux-low: turn 'regs_info' into a method 2020-04-02 15:11:23 +02:00
proc-service.list
README gdbserver: small cleanup of README file 2020-06-12 16:01:35 -04:00
regcache.cc gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
regcache.h
remote-utils.cc gdb: give names to event loop file handlers 2020-10-02 14:46:56 -04:00
remote-utils.h
server.cc gdbserver: add missing --disable-packet options to help text 2020-11-11 09:08:31 +00:00
server.h gdbserver: remove support for ARM/WinCE 2020-06-12 16:06:45 -04:00
symbol.cc
target.cc Make target_wait options use enum flags 2020-09-18 14:20:44 -06:00
target.h Make target_wait options use enum flags 2020-09-18 14:20:44 -06:00
tdesc.cc gdb: Have allocate_target_description return a unique_ptr 2020-10-08 10:14:14 +01:00
tdesc.h gdb/riscv: delete target descriptions when gdb exits 2020-07-17 21:15:32 +01:00
thread-db.cc gdbserver: handle running threads in qXfer:threads:read 2020-07-22 12:32:53 +01:00
tracepoint.cc gdb, gdbserver, gdbsupport: fix leading space vs tabs issues 2020-11-02 10:28:45 -05:00
tracepoint.h
utils.cc Remove gdb_fildes_t 2020-04-13 14:10:04 -06:00
utils.h Remove gdb_fildes_t 2020-04-13 14:10:04 -06:00
win32-i386-low.cc Enable hardware breakpoints for gdbserver on Windows 2020-05-15 10:55:21 +02:00
win32-low.cc Handle 64bit breakpoints of WOW64 processes as SIGINT 2020-09-24 19:01:22 +02:00
win32-low.h Handle 64bit breakpoints of WOW64 processes as SIGINT 2020-09-24 19:01:22 +02:00
x86-low.cc
x86-low.h
x86-tdesc.h
xtensa-xtregs.cc

		   README for GDBserver & GDBreplay
		    by Stu Grossman and Fred Fish

Introduction:

This is GDBserver, a remote server for Un*x-like systems.  It can be used to
control the execution of a program on a target system from a GDB on a different
host.  GDB and GDBserver communicate using the standard remote serial protocol.
They communicate via either a serial line or a TCP connection.

For more information about GDBserver, see the GDB manual:

    https://sourceware.org/gdb/current/onlinedocs/gdb/Remote-Protocol.html

Usage (server (target) side):

First, you need to have a copy of the program you want to debug put onto
the target system.  The program can be stripped to save space if needed, as
GDBserver doesn't care about symbols.  All symbol handling is taken care of by
the GDB running on the host system.

To use the server, you log on to the target system, and run the `gdbserver'
program.  You must tell it (a) how to communicate with GDB, (b) the name of
your program, and (c) its arguments.  The general syntax is:

	target> gdbserver COMM PROGRAM [ARGS ...]

For example, using a serial port, you might say:

	target> gdbserver /dev/com1 emacs foo.txt

This tells GDBserver to debug emacs with an argument of foo.txt, and to
communicate with GDB via /dev/com1.  GDBserver now waits patiently for the
host GDB to communicate with it.

To use a TCP connection, you could say:

	target> gdbserver host:2345 emacs foo.txt

This says pretty much the same thing as the last example, except that we are
going to communicate with the host GDB via TCP.  The `host:2345' argument means
that we are expecting to see a TCP connection to local TCP port 2345.
(Currently, the `host' part is ignored.)  You can choose any number you want for
the port number as long as it does not conflict with any existing TCP ports on
the target system.  This same port number must be used in the host GDB's
`target remote' command, which will be described shortly. Note that if you chose
a port number that conflicts with another service, GDBserver will print an error
message and exit.

On some targets, GDBserver can also attach to running programs.  This is
accomplished via the --attach argument.  The syntax is:

	target> gdbserver --attach COMM PID

PID is the process ID of a currently running process.  It isn't necessary
to point GDBserver at a binary for the running process.

Usage (host side):

You need an unstripped copy of the target program on your host system, since
GDB needs to examine it's symbol tables and such.  Start up GDB as you normally
would, with the target program as the first argument.  (You may need to use the
--baud option if the serial line is running at anything except 9600 baud.)
Ie: `gdb TARGET-PROG', or `gdb --baud BAUD TARGET-PROG'.  After that, the only
new command you need to know about is `target remote'.  It's argument is either
a device name (usually a serial device, like `/dev/ttyb'), or a HOST:PORT
descriptor.  For example:

	(gdb) target remote /dev/ttyb

communicates with the server via serial line /dev/ttyb, and:

	(gdb) target remote the-target:2345

communicates via a TCP connection to port 2345 on host `the-target', where
you previously started up GDBserver with the same port number.  Note that for
TCP connections, you must start up GDBserver prior to using the `target remote'
command, otherwise you may get an error that looks something like
`Connection refused'.

Building GDBserver:

See the `configure.srv` file for the list of host triplets you can build
GDBserver for.

Building GDBserver for your host is very straightforward.  If you build
GDB natively on a host which GDBserver supports, it will be built
automatically when you build GDB.  You can also build just GDBserver:

	% mkdir obj
	% cd obj
	% path-to-toplevel-sources/configure --disable-gdb
	% make all-gdbserver

(If you have a combined binutils+gdb tree, you may want to also
disable other directories when configuring, e.g., binutils, gas, gold,
gprof, and ld.)

If you prefer to cross-compile to your target, then you can also build
GDBserver that way.  For example:

	% export CC=your-cross-compiler
	% path-to-topevel-sources/configure --disable-gdb
	% make all-gdbserver

Using GDBreplay:

A special hacked down version of GDBserver can be used to replay remote
debug log files created by GDB.  Before using the GDB "target" command to
initiate a remote debug session, use "set remotelogfile <filename>" to tell
GDB that you want to make a recording of the serial or tcp session.  Note
that when replaying the session, GDB communicates with GDBreplay via tcp,
regardless of whether the original session was via a serial link or tcp.

Once you are done with the remote debug session, start GDBreplay and
tell it the name of the log file and the host and port number that GDB
should connect to (typically the same as the host running GDB):

	$ gdbreplay logfile host:port

Then start GDB (preferably in a different screen or window) and use the
"target" command to connect to GDBreplay:

	(gdb) target remote host:port

Repeat the same sequence of user commands to GDB that you gave in the
original debug session.  GDB should not be able to tell that it is talking
to GDBreplay rather than a real target, all other things being equal.  Note
that GDBreplay echos the command lines to stderr, as well as the contents of
the packets it sends and receives.  The last command echoed by GDBreplay is
the next command that needs to be typed to GDB to continue the session in
sync with the original session.