binutils-gdb/gdb/testsuite/gdb.python/py-pp-registration.exp
Sergio Durigan Junior d60a92216e Uniquify test names from gdb.python/{py-objfile.exp,py-pp-registration.exp}
While running some regression tests, I noticed that the two Python
tests mentioned in the $SUBJECT contain non-unique names.  This is a
violation of our guidelines:

  <https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique>

And also makes things harder for BuildBot.  So I hacked both testcases
and made every test name unique.  I guess this could be considered an
obvious patch, but I decided to post it before pushing because others
may have different opinions about the names.

OK to apply?

gdb/testsuite/ChangeLog:
2015-07-28  Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdb.python/py-objfile.exp: Make some tests have unique names.
	* gdb.python/py-pp-registration.exp: Likewise.
2015-07-28 17:39:16 -04:00

122 lines
3.5 KiB
Plaintext

# Copyright (C) 2010-2015 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# This file is part of the GDB testsuite. It tests python pretty
# printer registration.
load_lib gdb-python.exp
standard_testfile
if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} {
return -1
}
# Skip all tests if Python scripting is not enabled.
if { [skip_python_tests] } { continue }
set remote_python_file [gdb_remote_download host \
${srcdir}/${subdir}/${testfile}.py]
if ![runto_main ] {
fail "Can't run to main"
return -1
}
proc prepare_test { } {
global testfile remote_python_file
# Start with a fresh gdb.
clean_restart ${testfile}
set run_to_here [gdb_get_line_number {break to inspect} ${testfile}.c ]
if ![runto ${testfile}.c:$run_to_here message] {
return 0
}
gdb_test_no_output "python exec (open ('${remote_python_file}').read ())" \
"read file"
gdb_test_no_output "py progspace = gdb.current_progspace()"
gdb_test_no_output "py my_pretty_printer1 = build_pretty_printer1()"
gdb_test_no_output "py my_pretty_printer2 = build_pretty_printer2()"
return 1
}
proc test_printers { s_prefix } {
global hex
gdb_test "print flt" " = x=<42> y=<43>" \
"print flt"
gdb_test "print s" " = ${s_prefix} a=<1> b=<$hex>" \
"print s"
}
# Test registration with verbose off.
with_test_prefix "verbose off" {
if ![prepare_test] {
return -1
}
gdb_test_no_output "set verbose off"
gdb_test_no_output "py gdb.printing.register_pretty_printer(gdb, lookup_function_lookup_test)"
gdb_test_no_output "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer1)"
test_printers "s1"
}
# Test registration with verbose on.
with_test_prefix "verbose on" {
if ![prepare_test] {
return -1
}
gdb_test_no_output "set verbose on"
gdb_test "py gdb.printing.register_pretty_printer(gdb, lookup_function_lookup_test)" \
"Registering global lookup_function_lookup_test pretty-printer ..."
gdb_test "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer1)" \
"Registering pp-test pretty-printer for .*/py-pp-registration ..."
test_printers "s1"
}
# Exercise the "replace" argument to register_pretty_printer.
with_test_prefix "replace" {
if ![prepare_test] {
return -1
}
gdb_test_no_output "py gdb.printing.register_pretty_printer(gdb, lookup_function_lookup_test)"
gdb_test_no_output "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer1)"
gdb_test "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer2, replace=False)" \
"RuntimeError: pretty-printer already registered: pp-test\r\nError while executing Python code."
with_test_prefix "test printers 1" {
test_printers "s1"
}
gdb_test_no_output "py gdb.printing.register_pretty_printer(progspace, my_pretty_printer2, replace=True)"
with_test_prefix "test printers 2" {
test_printers "s2"
}
}