mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-27 03:51:15 +08:00
d42c267e9b
This patch uses the new %L _bfd_error_handler support for printing bfd_vma arguments, and fixes a many other format and/or argument errors in error messages. bfd/ * binary.c (binary_set_section_contents): Don't print filepos in error message. (coff_write_object_contents): Cast size_t for error message. (coff_slurp_line_table): Don't use bfd_vma symndx. (coff_slurp_reloc_table): Remove unneeded cast. * dwarf2.c (read_section): Cast bfd_int64_t to long long for error message. (find_abstract_instance_name): Likewise. * elf32-arm.c (arm_type_of_stub): Correct error arg order. (bfd_elf32_arm_stm32l4xx_erratum_scan): Don't cast error arg. (elf32_arm_check_relocs): Make r_symndx an int. * elf32-cris.c (cris_elf_check_relocs): Delete extraneous %s in format string. * elf32-metag.c (elf_metag_relocate_section): Delete extra error message arg. * elf32-nds32.c (nds32_elf_ex9_build_hash_table): Rewrite bogus error message. * elf32-i386.c (elf_i386_check_relocs): Make r_symndx an int. * elf32-s390.c (elf_s390_check_relocs): Likewise. * elf32-tic6x.c (elf32_tic6x_check_relocs): Likewise. * elf32-tilepro.c (tilepro_elf_check_relocs): Likewise. * elf32-xtensa.c (elf_xtensa_check_relocs): Likewise. * elf64-s390.c (elf_s390_check_relocs): Likewise. * elf64-x86-64.c (elf_x86_64_check_relocs): Likewise. * elfnn-aarch64.c (elfNN_aarch64_check_relocs): Likewise. * elfnn-riscv.c (riscv_elf_check_relocs): Likewise. * elfxx-sparc.c (_bfd_sparc_elf_check_relocs): Likewise. * elfxx-tilegx.c (tilegx_elf_check_relocs): Likewise. * elf64-mmix.c (_bfd_mmix_after_linker_allocation): Cast size_t args and use %lu for error message. * elflink.c (elf_link_adjust_relocs): Delete extra error message arg. * mmo.c (mmo_scan): Make stab_loc a file_ptr. Cast expression for error message. * elf32-arm.c (elf32_arm_tls_relax): Correct format string and args in error message. (elf32_arm_final_link_relocate): Likewise. * coff-arm.c (bfd_arm_process_before_allocation): Likewise. * coffcode.h (styp_to_sec_flags): Likewise. * cofflink.c (_bfd_coff_write_global_sym): Likewise. * ecoff.c (_bfd_ecoff_slurp_symbol_table): Likewise. * elf32-arc.c (arc_elf_merge_private_bfd_data): Likewise. * elf32-bfin.c (bfinfdpic_check_relocs): Likewise. (elf32_bfin_merge_private_bfd_data): Likewise. * elf32-cris.c (cris_elf_relocate_section): Likewise. * elf32-frv.c (frv_elf_merge_private_bfd_data): Likewise. * elf32-i370.c (i370_elf_merge_private_bfd_data): Likewise. (i370_elf_relocate_section): Likewise. * elf32-iq2000.c (iq2000_elf_merge_private_bfd_data): Likewise. * elf32-m32c.c (m32c_elf_merge_private_bfd_data): Likewise. * elf32-m68hc1x.c (_bfd_m68hc11_elf_merge_private_bfd_data): Likewise. * elf32-mcore.c (mcore_elf_relocate_section): Likewise. * elf32-mep.c (mep_elf_merge_private_bfd_data): Likewise. * elf32-mt.c (mt_elf_merge_private_bfd_data): Likewise. * elf64-sparc.c (elf64_sparc_merge_private_bfd_data): Likewise. * elfxx-mips.c (mips_elf_merge_obj_e_flags): Likewise. (_bfd_mips_elf_merge_private_bfd_data): Likewise. * ieee.c (ieee_write_id, read_id): Likewise. * mach-o.c (bfd_mach_o_write_contents): Likewise. (bfd_mach_o_layout_commands, bfd_mach_o_read_section_32): Likewise. (bfd_mach_o_read_section_64, bfd_mach_o_read_symtab_symbol): Likewise. (bfd_mach_o_read_command, bfd_mach_o_header_p): Likewise. * peXXigen.c (_bfd_XXi_swap_aouthdr_in): Likewise. * stabs.c (_bfd_link_section_stabs): Likewise. * coff-arm.c (coff_arm_relocate_section): Use L modifier in error format. * coff-mcore.c (coff_mcore_relocate_section): Likewise. * coff-ppc.c (coff_ppc_relocate_section): Likewise. * coff-rs6000.c (xcoff_reloc_type_toc): Likewise. * coff-sh.c (sh_relax_section): Likewise. (sh_relax_delete_bytes, sh_swap_insns): Likewise. * coff-tic80.c (coff_tic80_relocate_section): Likewise. * coffcode.h (coff_slurp_reloc_table): Likewise. * coffgen.c (_bfd_coff_get_external_symbols): Likewise. (_bfd_coff_read_string_table): Likewise. * cofflink.c (_bfd_coff_generic_relocate_section): Likewise. * compress.c (bfd_get_full_section_contents): Likewise. * dwarf2.c (read_formatted_entries, decode_line_info): Likewise. * elf-m10300.c (mn10300_elf_relocate_section): Likewise. * elf.c (bfd_elf_string_from_elf_section): Likewise. * elf32-arc.c (arc_special_overflow_checks): Likewise. * elf32-arm.c (elf32_arm_tls_relax): Likewise. (elf32_arm_final_link_relocate, elf32_arm_relocate_section): Likewise. (elf32_arm_write_section): Likewise. * elf32-bfin.c (bfin_relocate_section): Likewise. (bfinfdpic_relocate_section): Likewise. * elf32-hppa.c (hppa_build_one_stub): Likewise. (final_link_relocate, elf32_hppa_relocate_section): Likewise. * elf32-i386.c (elf_i386_tls_transition): Likewise. (elf_i386_relocate_section): Likewise. * elf32-ip2k.c (ip2k_final_link_relocate): Likewise. * elf32-lm32.c (lm32_elf_finish_dynamic_sections): Likewise. * elf32-m32r.c (m32r_elf_relocate_section): Likewise. * elf32-m68k.c (elf_m68k_relocate_section): Likewise. * elf32-metag.c (elf_metag_relocate_section): Likewise. * elf32-nds32.c (unrecognized_reloc_msg): Likewise. (nds32_elf_relax_longcall1, nds32_elf_relax_longcall2): Likewise. (nds32_elf_relax_longcall3, nds32_elf_relax_longjump1): Likewise. (nds32_elf_relax_longjump2, nds32_elf_relax_longjump3): Likewise. (nds32_elf_relax_longcall4, nds32_elf_relax_longcall5): Likewise. (nds32_elf_relax_longcall6, nds32_elf_relax_longjump4): Likewise. (nds32_elf_relax_longjump5, nds32_elf_relax_longjump6): Likewise. (nds32_elf_relax_longjump7, nds32_elf_relax_loadstore): Likewise. (nds32_elf_relax_ptr, nds32_elf_ex9_build_hash_table): Likewise. * elf32-nios2.c (nios2_elf32_relocate_section): Likewise. * elf32-rx.c (UNSAFE_FOR_PID): Likewise. * elf32-s390.c (invalid_tls_insn, elf_s390_relocate_section): Likewise. * elf32-score.c (s3_bfd_score_elf_check_relocs): Likewise. * elf32-score7.c (s7_bfd_score_elf_check_relocs): Likewise. * elf32-sh.c (sh_elf_relax_section): Likewise. (sh_elf_relax_delete_bytes, sh_elf_swap_insns): Likewise. (sh_elf_relocate_section): Likewise. * elf32-sh64.c (shmedia_prepare_reloc): Likewise. * elf32-spu.c (spu_elf_relocate_section): Likewise. * elf32-tic6x.c (elf32_tic6x_relocate_section): Likewise. * elf32-tilepro.c (tilepro_elf_relocate_section): Likewise. * elf32-v850.c (v850_elf_relax_section): Likewise. * elf32-vax.c (elf_vax_check_relocs): Likewise. (elf_vax_relocate_section): Likewise. * elf32-xtensa.c (elf_xtensa_relocate_section): Likewise. (extend_ebb_bounds_forward, extend_ebb_bounds_backward): Likewise. (compute_text_actions, compute_ebb_proposed_actions): Likewise. (do_fix_for_relocatable_link): Likewise. * elf64-alpha.c (elf64_alpha_relax_got_load): Likewise. (elf64_alpha_relax_with_lituse): Likewise. * elf64-hppa.c (elf64_hppa_finish_dynamic_symbol): Likewise. (elf_hppa_final_link_relocate): Likewise. * elf64-ia64-vms.c (elf64_ia64_relax_section): Likewise. (elf64_ia64_choose_gp, elf64_ia64_relocate_section): Likewise. (elf64_vms_link_add_object_symbols): Likewise. * elf64-mmix.c (mmix_elf_perform_relocation): Likewise. (mmix_final_link_relocate): Likewise. * elf64-s390.c (invalid_tls_insn): Likewise. (elf_s390_relocate_section): Likewise. * elf64-sh64.c (sh_elf64_relocate_section): Likewise. * elf64-x86-64.c (elf_x86_64_tls_transition): Likewise. (elf_x86_64_relocate_section): Likewise. * elfcode.h (elf_slurp_symbol_table): Likewise. * elfcore.h (elf_core_file_p): Likewise. * elflink.c (elf_link_read_relocs_from_section): Likewise. * elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Likewise. (elfNN_aarch64_relocate_section): Likewise. * elfnn-ia64.c (elfNN_ia64_relax_section): Likewise. (elfNN_ia64_choose_gp, elfNN_ia64_relocate_section): Likewise. * elfnn-riscv.c (riscv_elf_relocate_section): Likewise. * elfxx-mips.c (_bfd_mips_elf_check_relocs): Likewise. (_bfd_mips_elf_relocate_section): Likewise. (_bfd_mips_elf_finish_dynamic_symbol, mips_finish_exec_plt): Likewise. * elfxx-sparc.c (_bfd_sparc_elf_relocate_section): Likewise. * elfxx-tilegx.c (tilegx_elf_relocate_section): Likewise. * ieee.c (ieee_slurp_external_symbols): Likewise. * ihex.c (ihex_write_object_content): Likewise. * mach-o.c (bfd_mach_o_build_exec_seg_command): Likewise. * merge.c (_bfd_merged_section_offset): Likewise. * mmo.c (mmo_write_loc_chunk): Likewise. (mmo_write_object_contents): Likewise. * peXXigen.c (_bfd_XX_bfd_copy_private_bfd_data_common): Likewise. * stabs.c (_bfd_link_section_stabs): Likewise. * xcofflink.c (xcoff_link_add_symbols, xcoff_find_tc0): Likewise. ld/ * testsuite/ld-arc/nps-1b.err: Update. * testsuite/ld-x86-64/ilp32-11.d: Update.
316 lines
9.2 KiB
C
316 lines
9.2 KiB
C
/* ELF core file support for BFD.
|
|
Copyright (C) 1995-2017 Free Software Foundation, Inc.
|
|
|
|
This file is part of BFD, the Binary File Descriptor library.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
|
MA 02110-1301, USA. */
|
|
|
|
char*
|
|
elf_core_file_failing_command (bfd *abfd)
|
|
{
|
|
return elf_tdata (abfd)->core->command;
|
|
}
|
|
|
|
int
|
|
elf_core_file_failing_signal (bfd *abfd)
|
|
{
|
|
return elf_tdata (abfd)->core->signal;
|
|
}
|
|
|
|
int
|
|
elf_core_file_pid (bfd *abfd)
|
|
{
|
|
return elf_tdata (abfd)->core->pid;
|
|
}
|
|
|
|
bfd_boolean
|
|
elf_core_file_matches_executable_p (bfd *core_bfd, bfd *exec_bfd)
|
|
{
|
|
char* corename;
|
|
|
|
/* xvecs must match if both are ELF files for the same target. */
|
|
|
|
if (core_bfd->xvec != exec_bfd->xvec)
|
|
{
|
|
bfd_set_error (bfd_error_system_call);
|
|
return FALSE;
|
|
}
|
|
|
|
/* See if the name in the corefile matches the executable name. */
|
|
corename = elf_tdata (core_bfd)->core->program;
|
|
if (corename != NULL)
|
|
{
|
|
const char* execname = strrchr (exec_bfd->filename, '/');
|
|
|
|
execname = execname ? execname + 1 : exec_bfd->filename;
|
|
|
|
if (strcmp (execname, corename) != 0)
|
|
return FALSE;
|
|
}
|
|
|
|
return TRUE;
|
|
}
|
|
|
|
/* Core files are simply standard ELF formatted files that partition
|
|
the file using the execution view of the file (program header table)
|
|
rather than the linking view. In fact, there is no section header
|
|
table in a core file.
|
|
|
|
The process status information (including the contents of the general
|
|
register set) and the floating point register set are stored in a
|
|
segment of type PT_NOTE. We handcraft a couple of extra bfd sections
|
|
that allow standard bfd access to the general registers (.reg) and the
|
|
floating point registers (.reg2). */
|
|
|
|
const bfd_target *
|
|
elf_core_file_p (bfd *abfd)
|
|
{
|
|
Elf_External_Ehdr x_ehdr; /* Elf file header, external form. */
|
|
Elf_Internal_Ehdr *i_ehdrp; /* Elf file header, internal form. */
|
|
Elf_Internal_Phdr *i_phdrp; /* Elf program header, internal form. */
|
|
unsigned int phindex;
|
|
const struct elf_backend_data *ebd;
|
|
bfd_size_type amt;
|
|
|
|
/* Read in the ELF header in external format. */
|
|
if (bfd_bread (&x_ehdr, sizeof (x_ehdr), abfd) != sizeof (x_ehdr))
|
|
{
|
|
if (bfd_get_error () != bfd_error_system_call)
|
|
goto wrong;
|
|
else
|
|
goto fail;
|
|
}
|
|
|
|
/* Check the magic number. */
|
|
if (! elf_file_p (&x_ehdr))
|
|
goto wrong;
|
|
|
|
/* FIXME: Check EI_VERSION here ! */
|
|
|
|
/* Check the address size ("class"). */
|
|
if (x_ehdr.e_ident[EI_CLASS] != ELFCLASS)
|
|
goto wrong;
|
|
|
|
/* Check the byteorder. */
|
|
switch (x_ehdr.e_ident[EI_DATA])
|
|
{
|
|
case ELFDATA2MSB: /* Big-endian. */
|
|
if (! bfd_big_endian (abfd))
|
|
goto wrong;
|
|
break;
|
|
case ELFDATA2LSB: /* Little-endian. */
|
|
if (! bfd_little_endian (abfd))
|
|
goto wrong;
|
|
break;
|
|
default:
|
|
goto wrong;
|
|
}
|
|
|
|
/* Give abfd an elf_obj_tdata. */
|
|
if (! (*abfd->xvec->_bfd_set_format[bfd_core]) (abfd))
|
|
goto fail;
|
|
|
|
/* Swap in the rest of the header, now that we have the byte order. */
|
|
i_ehdrp = elf_elfheader (abfd);
|
|
elf_swap_ehdr_in (abfd, &x_ehdr, i_ehdrp);
|
|
|
|
#if DEBUG & 1
|
|
elf_debug_file (i_ehdrp);
|
|
#endif
|
|
|
|
ebd = get_elf_backend_data (abfd);
|
|
|
|
/* Check that the ELF e_machine field matches what this particular
|
|
BFD format expects. */
|
|
|
|
if (ebd->elf_machine_code != i_ehdrp->e_machine
|
|
&& (ebd->elf_machine_alt1 == 0
|
|
|| i_ehdrp->e_machine != ebd->elf_machine_alt1)
|
|
&& (ebd->elf_machine_alt2 == 0
|
|
|| i_ehdrp->e_machine != ebd->elf_machine_alt2))
|
|
{
|
|
const bfd_target * const *target_ptr;
|
|
|
|
if (ebd->elf_machine_code != EM_NONE)
|
|
goto wrong;
|
|
|
|
/* This is the generic ELF target. Let it match any ELF target
|
|
for which we do not have a specific backend. */
|
|
|
|
for (target_ptr = bfd_target_vector; *target_ptr != NULL; target_ptr++)
|
|
{
|
|
const struct elf_backend_data *back;
|
|
|
|
if ((*target_ptr)->flavour != bfd_target_elf_flavour)
|
|
continue;
|
|
back = xvec_get_elf_backend_data (*target_ptr);
|
|
if (back->s->arch_size != ARCH_SIZE)
|
|
continue;
|
|
if (back->elf_machine_code == i_ehdrp->e_machine
|
|
|| (back->elf_machine_alt1 != 0
|
|
&& i_ehdrp->e_machine == back->elf_machine_alt1)
|
|
|| (back->elf_machine_alt2 != 0
|
|
&& i_ehdrp->e_machine == back->elf_machine_alt2))
|
|
{
|
|
/* target_ptr is an ELF backend which matches this
|
|
object file, so reject the generic ELF target. */
|
|
goto wrong;
|
|
}
|
|
}
|
|
}
|
|
|
|
/* If there is no program header, or the type is not a core file, then
|
|
we are hosed. */
|
|
if (i_ehdrp->e_phoff == 0 || i_ehdrp->e_type != ET_CORE)
|
|
goto wrong;
|
|
|
|
/* Does BFD's idea of the phdr size match the size
|
|
recorded in the file? */
|
|
if (i_ehdrp->e_phentsize != sizeof (Elf_External_Phdr))
|
|
goto wrong;
|
|
|
|
/* If the program header count is PN_XNUM(0xffff), the actual
|
|
count is in the first section header. */
|
|
if (i_ehdrp->e_shoff != 0 && i_ehdrp->e_phnum == PN_XNUM)
|
|
{
|
|
Elf_External_Shdr x_shdr;
|
|
Elf_Internal_Shdr i_shdr;
|
|
file_ptr where = (file_ptr) i_ehdrp->e_shoff;
|
|
|
|
/* Seek to the section header table in the file. */
|
|
if (bfd_seek (abfd, where, SEEK_SET) != 0)
|
|
goto fail;
|
|
|
|
/* Read the first section header at index 0, and convert to internal
|
|
form. */
|
|
if (bfd_bread (&x_shdr, sizeof (x_shdr), abfd) != sizeof (x_shdr))
|
|
goto fail;
|
|
elf_swap_shdr_in (abfd, &x_shdr, &i_shdr);
|
|
|
|
if (i_shdr.sh_info != 0)
|
|
{
|
|
i_ehdrp->e_phnum = i_shdr.sh_info;
|
|
if (i_ehdrp->e_phnum != i_shdr.sh_info)
|
|
goto wrong;
|
|
}
|
|
}
|
|
|
|
/* Sanity check that we can read all of the program headers.
|
|
It ought to be good enough to just read the last one. */
|
|
if (i_ehdrp->e_phnum > 1)
|
|
{
|
|
Elf_External_Phdr x_phdr;
|
|
Elf_Internal_Phdr i_phdr;
|
|
file_ptr where;
|
|
|
|
/* Check that we don't have a totally silly number of
|
|
program headers. */
|
|
if (i_ehdrp->e_phnum > (unsigned int) -1 / sizeof (x_phdr)
|
|
|| i_ehdrp->e_phnum > (unsigned int) -1 / sizeof (i_phdr))
|
|
goto wrong;
|
|
|
|
where = (file_ptr)(i_ehdrp->e_phoff + (i_ehdrp->e_phnum - 1) * sizeof (x_phdr));
|
|
if ((bfd_size_type) where <= i_ehdrp->e_phoff)
|
|
goto wrong;
|
|
|
|
if (bfd_seek (abfd, where, SEEK_SET) != 0)
|
|
goto fail;
|
|
if (bfd_bread (&x_phdr, sizeof (x_phdr), abfd) != sizeof (x_phdr))
|
|
goto fail;
|
|
}
|
|
|
|
/* Move to the start of the program headers. */
|
|
if (bfd_seek (abfd, (file_ptr) i_ehdrp->e_phoff, SEEK_SET) != 0)
|
|
goto wrong;
|
|
|
|
/* Allocate space for the program headers. */
|
|
amt = sizeof (*i_phdrp) * i_ehdrp->e_phnum;
|
|
i_phdrp = (Elf_Internal_Phdr *) bfd_alloc (abfd, amt);
|
|
if (!i_phdrp)
|
|
goto fail;
|
|
|
|
elf_tdata (abfd)->phdr = i_phdrp;
|
|
|
|
/* Read and convert to internal form. */
|
|
for (phindex = 0; phindex < i_ehdrp->e_phnum; ++phindex)
|
|
{
|
|
Elf_External_Phdr x_phdr;
|
|
|
|
if (bfd_bread (&x_phdr, sizeof (x_phdr), abfd) != sizeof (x_phdr))
|
|
goto fail;
|
|
|
|
elf_swap_phdr_in (abfd, &x_phdr, i_phdrp + phindex);
|
|
}
|
|
|
|
/* Set the machine architecture. Do this before processing the
|
|
program headers since we need to know the architecture type
|
|
when processing the notes of some systems' core files. */
|
|
if (! bfd_default_set_arch_mach (abfd, ebd->arch, 0)
|
|
/* It's OK if this fails for the generic target. */
|
|
&& ebd->elf_machine_code != EM_NONE)
|
|
goto fail;
|
|
|
|
/* Let the backend double check the format and override global
|
|
information. We do this before processing the program headers
|
|
to allow the correct machine (as opposed to just the default
|
|
machine) to be set, making it possible for grok_prstatus and
|
|
grok_psinfo to rely on the mach setting. */
|
|
if (ebd->elf_backend_object_p != NULL
|
|
&& ! ebd->elf_backend_object_p (abfd))
|
|
goto wrong;
|
|
|
|
/* Process each program header. */
|
|
for (phindex = 0; phindex < i_ehdrp->e_phnum; ++phindex)
|
|
if (! bfd_section_from_phdr (abfd, i_phdrp + phindex, (int) phindex))
|
|
goto fail;
|
|
|
|
/* Check for core truncation. */
|
|
{
|
|
bfd_size_type high = 0;
|
|
struct stat statbuf;
|
|
for (phindex = 0; phindex < i_ehdrp->e_phnum; ++phindex)
|
|
{
|
|
Elf_Internal_Phdr *p = i_phdrp + phindex;
|
|
if (p->p_filesz)
|
|
{
|
|
bfd_size_type current = p->p_offset + p->p_filesz;
|
|
if (high < current)
|
|
high = current;
|
|
}
|
|
}
|
|
if (bfd_stat (abfd, &statbuf) == 0)
|
|
{
|
|
if ((bfd_size_type) statbuf.st_size < high)
|
|
{
|
|
_bfd_error_handler
|
|
/* xgettext:c-format */
|
|
(_("warning: %B is truncated: expected core file "
|
|
"size >= %Lu, found: %llu"),
|
|
abfd, high, (unsigned long long) statbuf.st_size);
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Save the entry point from the ELF header. */
|
|
bfd_get_start_address (abfd) = i_ehdrp->e_entry;
|
|
return abfd->xvec;
|
|
|
|
wrong:
|
|
bfd_set_error (bfd_error_wrong_format);
|
|
fail:
|
|
return NULL;
|
|
}
|