binutils-gdb/gdb/common
Sergio Durigan Junior 3c025cfe5e Move 'is_regular_file' from common-utils.c to filestuff.c
There is no reason for 'is_regular_file' to be in common-utils.c; it
belongs to 'filestuff.c'.  This commit moves the function definition
and its prototype to the appropriate files.

The motivation behind this move is a failure that happens on certain
cross-compilation environments when compiling the IPA library, due to
the way gnulib probes the need for a 'stat' call replacement.  Because
configure checks when cross-compiling are more limited, gnulib decides
that it needs to substitute the 'stat' calls its own 'rpl_stat';
however, the IPA library doesn't link with gnulib, which leads to an
error when compiling 'common-utils.c':

  ...
  /opt/x86-core2--musl--bleeding-edge-2018.09-1/bin/i686-buildroot-linux-musl-g++  -shared -fPIC -Wl,--soname=libinproctrace.so -Wl,--no-undefined -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os      -I. -I. -I./../common -I./../regformats -I./.. -I./../../include -I./../gnulib/import -Ibuild-gnulib-gdbserver/import -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized  -DGDBSERVER \
   -Wl,--dynamic-list=./proc-service.list -o libinproctrace.so ax-ipa.o common-utils-ipa.o errors-ipa.o format-ipa.o print-utils-ipa.o regcache-ipa.o remote-utils-ipa.o rsp-low-ipa.o tdesc-ipa.o tracepoint-ipa.o utils-ipa.o vec-ipa.o linux-i386-ipa.o linux-x86-tdesc-ipa.o arch/i386-ipa.o -ldl -pthread
  /opt/x86-core2--musl--bleeding-edge-2018.09-1/lib/gcc/i686-buildroot-linux-musl/8.2.0/../../../../i686-buildroot-linux-musl/bin/ld: common-utils-ipa.o: in function `is_regular_file(char const*, int*)':
  common-utils.c:(.text+0x695): undefined reference to `rpl_stat'
  collect2: error: ld returned 1 exit status
  Makefile:413: recipe for target 'libinproctrace.so' failed
  make[1]: *** [libinproctrace.so] Error 1
  ...

More details can also be found at:

  https://sourceware.org/ml/gdb-patches/2018-09/msg00304.html

The most simple fix for this problem is to move 'is_regular_file' to
'filestuff.c', which is not used by IPA.  This ends up making the
files more logically organized as well, since 'is_regular_file' is a
file operation.

No regressions found.

gdb/ChangeLog:
2018-09-12  Sergio Durigan Junior  <sergiodj@redhat.com>

	* common/common-utils.c: Don't include '<sys/stat.h>'.
	(is_regular_file): Move to...
	* common/filestuff.c (is_regular_file): ... here.
	* common/common-utils.h (is_regular_file): Move to...
	* common/filestuff.h (is_regular_file): ... here.
2018-09-12 13:58:30 -04:00
..
agent.c Get rid of -Wodr warning (PR build/23399) 2018-08-28 17:23:16 -04:00
agent.h Get rid of -Wodr warning (PR build/23399) 2018-08-28 17:23:16 -04:00
array-view.h Add selftests for range_contains and insert_into_bit_range_vector 2018-04-09 15:47:12 -04:00
ax.def Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
break-common.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
btrace-common.c Remove cleanups from btrace code 2018-06-08 07:05:49 -06:00
btrace-common.h Remove cleanups from btrace code 2018-06-08 07:05:49 -06:00
buffer.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
buffer.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
byte-vector.h Make target_read_alloc & al return vectors 2018-04-07 13:19:12 -04:00
cleanups.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
cleanups.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
common-debug.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
common-debug.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
common-defs.h Define _FORTIFY_SOURCE in common-defs.h 2018-08-13 10:02:00 -06:00
common-exceptions.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
common-exceptions.h Mark END_CATCH as ATTRIBUTE_NORETURN (-Wmaybe-uninitialized warnings) 2018-05-30 14:18:47 +01:00
common-gdbthread.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
common-inferior.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
common-regcache.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
common-regcache.h Add regcache raw_compare method 2018-06-11 10:09:30 +01:00
common-types.h Avoid -Wnarrowing warnings in struct tramp_frame instances 2018-08-27 12:00:10 -06:00
common-utils.c Move 'is_regular_file' from common-utils.c to filestuff.c 2018-09-12 13:58:30 -04:00
common-utils.h Move 'is_regular_file' from common-utils.c to filestuff.c 2018-09-12 13:58:30 -04:00
common.host Add common/ dir in build directories 2018-02-19 09:37:24 +00:00
common.m4 Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
create-version.sh Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
def-vector.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
default-init-alloc.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
enum-flags.h Fix typo in common/enum-flags.h example 2018-06-05 18:22:25 +01:00
environ.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
environ.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
errors.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
errors.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
fileio.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
fileio.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
filestuff.c Move 'is_regular_file' from common-utils.c to filestuff.c 2018-09-12 13:58:30 -04:00
filestuff.h Move 'is_regular_file' from common-utils.c to filestuff.c 2018-09-12 13:58:30 -04:00
format.c Make format_pieces recognize the \e escape sequence 2018-05-17 13:06:11 -04:00
format.h Make format_pieces recognize the \e escape sequence 2018-05-17 13:06:11 -04:00
function-view.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
gdb_assert.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
gdb_locale.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
gdb_optional.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
gdb_ref_ptr.h Introduce ref_ptr::new_reference 2018-04-30 11:33:11 -06:00
gdb_setjmp.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
gdb_signals.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
gdb_splay_tree.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
gdb_string_view.h Add gdb::string_view 2018-04-09 14:20:46 -04:00
gdb_string_view.tcc Add gdb::string_view 2018-04-09 14:20:46 -04:00
gdb_sys_time.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
gdb_tilde_expand.c Create new common/pathstuff.[ch] 2018-02-28 11:34:39 -05:00
gdb_tilde_expand.h Create new common/pathstuff.[ch] 2018-02-28 11:34:39 -05:00
gdb_unique_ptr.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
gdb_unlinker.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
gdb_vecs.c Remove free_char_ptr_vec 2018-03-02 23:22:10 -05:00
gdb_vecs.h Remove const_char_ptr typedef 2018-05-29 08:52:55 -06:00
gdb_wait.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
hash_enum.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
host-defs.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
job-control.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
job-control.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
mingw-strerror.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
netstuff.c Implement IPv6 support for GDB/gdbserver 2018-07-11 19:41:31 -04:00
netstuff.h Implement IPv6 support for GDB/gdbserver 2018-07-11 19:41:31 -04:00
new-op.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
observable.h Convert observers to C++ 2018-03-19 09:37:49 -06:00
offset-type.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
pathstuff.c Add DWARF index cache 2018-08-07 18:14:20 -04:00
pathstuff.h Add DWARF index cache 2018-08-07 18:14:20 -04:00
poison.h Introduce obstack_new, poison other "typed" obstack functions 2018-05-20 21:06:36 -04:00
posix-strerror.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
preprocessor.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
print-utils.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
print-utils.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
ptid.c Remove ptid_equal 2018-07-03 11:36:46 -06:00
ptid.h Remove ptid_equal 2018-07-03 11:36:46 -06:00
queue.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
refcounted-object.h Use thread_info and inferior pointers more throughout 2018-06-21 17:09:31 +01:00
rsp-low.c Get rid of VEC(static_tracepoint_marker_p) 2018-03-22 00:27:19 -04:00
rsp-low.h Get rid of VEC(static_tracepoint_marker_p) 2018-03-22 00:27:19 -04:00
run-time-clock.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
run-time-clock.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
scoped_fd.h common: add scoped_fd 2018-02-09 14:03:18 +01:00
scoped_mmap.c Fix some gettext ARI warnings 2018-08-09 13:17:56 -04:00
scoped_mmap.h Introduce mmap_file function 2018-08-07 18:10:29 -04:00
scoped_restore.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
selftest.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
selftest.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
signals-state-save-restore.c gdb/common/signals-state-save-restore.c: Fix typos 2018-01-15 20:03:20 +00:00
signals-state-save-restore.h Fix regression: cannot start with LD_PRELOAD=libSegFault.so (PR gdb/18653#c7) 2018-01-05 18:26:18 +00:00
signals.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
symbol.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
tdesc.c Simple unused variable removals 2018-07-22 13:20:01 -06:00
tdesc.h Remove xml file references from target descriptions 2018-04-18 20:49:37 +01:00
traits.h Fix copy-pasto, allocate objfile_per_bfd_storage with obstack_new 2018-05-20 23:19:35 -04:00
underlying.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
valid-expr.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
vec.c Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
vec.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
version.h Update copyright year range in all GDB files 2018-01-02 07:38:06 +04:00
x86-xstate.h gdb/x86: Handle kernels using compact xsave format 2018-05-08 18:03:46 +01:00
xml-utils.c Add xml_escape_text_append and use it 2018-03-08 18:04:46 -05:00
xml-utils.h Add xml_escape_text_append and use it 2018-03-08 18:04:46 -05:00