mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-06 12:09:26 +08:00
3bab069c29
get_stab_string_offset currently creates the stabstr section if not already present, in the process keeping a reference to the malloc'd section name string. Really, the name belongs in bfd_alloc'd memory or some obstack so that it doesn't show as a memory leak on exit. s_stab_generic at least does allocate the name for the stab section on an obstack, but doesn't tidy that as well as it could. Return paths after issuing a warning don't release the memory, nor the memory for the "string" copy. This patch fixes these problems. s_stab_generic is rearranged so that creation of the sections occurs earlier, before any potential uses of the note obstack during expression parsing. That makes it possible to always free the section name strings unless used to create new sections. I've also avoided get_absolute_expression_and_terminator as I see that function might skip over end-of-line, and lack of a --input_line_pointer might have caused the following source line to be ignored. (Other uses of this function in gas are OK.) * config/obj-coff.c (obj_coff_init_stab_section): Add stabstr param. Pass to get_stab_string_offset rather than name of section. * config/obj-som.c (obj_som_init_stab_section): Likewise. * config/obj-elf.c (obj_elf_init_stab_section): Likewise. (elf_init_stab_section): Adjust. * config/obj-coff.h (INIT_STAB_SECTION): Update. (obj_coff_init_stab_section): Update prototype. * config/obj-som.h: Similarly. * config/obj-elf.h: Similarly. * config/obj-multi.h (INIT_STAB_SECTION): Update. * obj.h (struct format_ops <init_stab_section>): Update. * read.h (get_stab_string_offset): Update prototype. * stabs.c (cached_sec): Delete. (stabs_begin): Adjust to suit. (get_stab_string_offset): Add stabstr param, delete stabstr_name and free_stabstr_secname params. Don't make stabstr section here. (eat_comma): New function. (s_stab_generic): Replace stab_secname_obstack_end param with bool freenames. Move creation of stab and stabstr sections earlier, so the names can be freed earlier before possible use of notes obstack during expression parsing. Tidy error paths ensuring "string" is freed. Use get_absolute_expression in place of get_absolute_expression_and_terminator. (s_stab): Adjust. (s_xstab): Use notes_concat to make stabstr section name.
90 lines
3.0 KiB
C
90 lines
3.0 KiB
C
/* obj.h - defines the object dependent hooks for all object
|
|
format backends.
|
|
|
|
Copyright (C) 1987-2023 Free Software Foundation, Inc.
|
|
|
|
This file is part of GAS, the GNU Assembler.
|
|
|
|
GAS is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3, or (at your option)
|
|
any later version.
|
|
|
|
GAS is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with GAS; see the file COPYING. If not, write to the Free
|
|
Software Foundation, 51 Franklin Street - Fifth Floor, Boston, MA
|
|
02110-1301, USA. */
|
|
|
|
char *obj_default_output_file_name (void);
|
|
void obj_emit_relocations (char **where, fixS * fixP,
|
|
relax_addressT segment_address_in_file);
|
|
void obj_emit_strings (char **where);
|
|
void obj_emit_symbols (char **where, symbolS * symbols);
|
|
#ifndef obj_read_begin_hook
|
|
void obj_read_begin_hook (void);
|
|
#endif
|
|
|
|
#ifndef obj_symbol_new_hook
|
|
void obj_symbol_new_hook (symbolS * symbolP);
|
|
#endif
|
|
|
|
void obj_symbol_to_chars (char **where, symbolS * symbolP);
|
|
|
|
extern const pseudo_typeS obj_pseudo_table[];
|
|
|
|
struct ecoff_extr;
|
|
|
|
struct format_ops {
|
|
int flavor;
|
|
unsigned dfl_leading_underscore : 1;
|
|
unsigned emit_section_symbols : 1;
|
|
void (*begin) (void);
|
|
void (*end) (void);
|
|
void (*app_file) (const char *);
|
|
void (*frob_symbol) (symbolS *, int *);
|
|
void (*frob_file) (void);
|
|
void (*frob_file_before_adjust) (void);
|
|
void (*frob_file_before_fix) (void);
|
|
void (*frob_file_after_relocs) (void);
|
|
bfd_vma (*s_get_size) (symbolS *);
|
|
void (*s_set_size) (symbolS *, bfd_vma);
|
|
bfd_vma (*s_get_align) (symbolS *);
|
|
void (*s_set_align) (symbolS *, bfd_vma);
|
|
int (*s_get_other) (symbolS *);
|
|
void (*s_set_other) (symbolS *, int);
|
|
int (*s_get_desc) (symbolS *);
|
|
void (*s_set_desc) (symbolS *, int);
|
|
int (*s_get_type) (symbolS *);
|
|
void (*s_set_type) (symbolS *, int);
|
|
void (*copy_symbol_attributes) (symbolS *, symbolS *);
|
|
void (*generate_asm_lineno) (void);
|
|
void (*process_stab) (int, const char *, int, int, int);
|
|
int (*separate_stab_sections) (void);
|
|
void (*init_stab_section) (segT, segT);
|
|
int (*sec_sym_ok_for_reloc) (asection *);
|
|
void (*pop_insert) (void);
|
|
/* For configurations using ECOFF_DEBUGGING, this callback is used. */
|
|
void (*ecoff_set_ext) (symbolS *, struct ecoff_extr *);
|
|
|
|
void (*read_begin_hook) (void);
|
|
void (*symbol_new_hook) (symbolS *);
|
|
void (*symbol_clone_hook) (symbolS *, symbolS *);
|
|
void (*adjust_symtab) (void);
|
|
};
|
|
|
|
extern const struct format_ops elf_format_ops;
|
|
extern const struct format_ops ecoff_format_ops;
|
|
extern const struct format_ops coff_format_ops;
|
|
extern const struct format_ops aout_format_ops;
|
|
|
|
#ifndef this_format
|
|
COMMON const struct format_ops *this_format;
|
|
#endif
|
|
|
|
/* end of obj.h */
|