Go to file
Pierre-Marie de Rodat d0d8478068 gdb/gdbtypes: fix handling of typedef layers between array types
When a dynamic array type contains a typedef-wrapped array, an assertion
failure occurs during type resolution.  This is what happens in the
following Ada case:

    type Rec_Type is record
       I : Integer;
       B : Boolean;
    end record;

    type Vec_Type is array (1 .. 4) of Rec_Type;

    type Array_Type is array (Positive range <>) of Vec_Type;

If users try to print or even pass to an inferior call a variable A of
type Array_Type, GDB will raise an error:

    (gdb) print a
    ../../src/gdb/gdbtypes.c:1807: internal-error:
    resolve_dynamic_array: Assertion `TYPE_CODE (type) ==
    TYPE_CODE_ARRAY' failed.
    A problem internal to GDB has been detected,
    further debugging may prove unreliable.
    Quit this debugging session? (y or n)

What happens is that during dynamic array type resolution, we first peel
TYPE_CODE_TYPEDEF layers wrapping the array element type and check if
its type is itself TYPE_CODE_ARRAY.  If it is, we pass the
typedef-wrapped type to a recursive call to resolve_dynamic_array
whereas this function expects only TYPE_CODE_ARRAY types.

This patch makes it pass the peeled type to the recursive call so that
type resolution can continue smoothly.

gdb/ChangeLog:

	* gdbtypes.c (resolve_dynamic_array): Pass the peeled element
	type to the recursive call instead of the original (maybe
	TYPE_CODE_TYPEDEF) type.

gdb/testsuite/ChangeLog:

	* gdb.ada/var_arr_typedef.exp: New testcase.
	* gdb.ada/var_arr_typedef/pack.adb: New file.
	* gdb.ada/var_arr_typedef/pack.ads: New file.
	* gdb.ada/var_arr_typedef/var_arr_typedef.adb: New file.
2015-07-23 14:59:58 +02:00
bfd Automatic date update in version.in 2015-07-23 00:00:07 +00:00
binutils readelf display of 0x800...000 addend 2015-07-23 00:45:54 +09:30
config Sync config files with GCC 2015-07-14 09:18:16 -07:00
cpu
elfcpp
etc
gas Fix memory operand size for vcvtt?ps2u?qq instructions 2015-07-22 13:26:21 -07:00
gdb gdb/gdbtypes: fix handling of typedef layers between array types 2015-07-23 14:59:58 +02:00
gold Don't compare symbol addresses directly 2015-07-22 03:38:00 -07:00
gprof
include [ARM] Support correctly spelled ARMv6KZ architecture names 2015-07-21 09:43:35 +01:00
intl
ld Make binutils abort message GDB friendly 2015-07-20 05:53:31 -07:00
libdecnumber Sync config/warnings.m4 with GCC 2015-07-14 08:39:12 -07:00
libiberty Sync config/warnings.m4 with GCC 2015-07-14 08:39:12 -07:00
opcodes Fix ubsan signed integer overflow 2015-07-23 12:52:46 +09:30
readline
sim Remove extraneous whitespace from ARM sim sources. 2015-07-14 12:06:33 +01:00
texinfo
zlib
.cvsignore
.gitattributes
.gitignore
ChangeLog Sync Makefile.tpl with GCC 2015-07-14 09:52:36 -07:00
compile
config-ml.in
config.guess
config.rpath
config.sub
configure Sync toplevel configure with GCC 2015-07-14 08:17:27 -07:00
configure.ac Sync toplevel configure with GCC 2015-07-14 08:17:27 -07:00
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
COPYING.LIBGLOSS
COPYING.NEWLIB
depcomp
djunpack.bat
install-sh
libtool.m4
lt~obsolete.m4
ltgcc.m4
ltmain.sh
ltoptions.m4
ltsugar.m4
ltversion.m4
MAINTAINERS
Makefile.def
Makefile.in Sync Makefile.tpl with GCC 2015-07-14 09:52:36 -07:00
Makefile.tpl Sync Makefile.tpl with GCC 2015-07-14 09:52:36 -07:00
makefile.vms
missing
mkdep
mkinstalldirs
move-if-change
README
README-maintainer-mode
setup.com
src-release.sh
symlink-tree
ylwrap

		   README for GNU development tools

This directory contains various GNU compilers, assemblers, linkers, 
debuggers, etc., plus their support routines, definitions, and documentation.

If you are receiving this as part of a GDB release, see the file gdb/README.
If with a binutils release, see binutils/README;  if with a libg++ release,
see libg++/README, etc.  That'll give you info about this
package -- supported targets, how to use it, how to report bugs, etc.

It is now possible to automatically configure and build a variety of
tools with one command.  To build all of the tools contained herein,
run the ``configure'' script here, e.g.:

	./configure 
	make

To install them (by default in /usr/local/bin, /usr/local/lib, etc),
then do:
	make install

(If the configure script can't determine your type of computer, give it
the name as an argument, for instance ``./configure sun4''.  You can
use the script ``config.sub'' to test whether a name is recognized; if
it is, config.sub translates it to a triplet specifying CPU, vendor,
and OS.)

If you have more than one compiler on your system, it is often best to
explicitly set CC in the environment before running configure, and to
also set CC when running make.  For example (assuming sh/bash/ksh):

	CC=gcc ./configure
	make

A similar example using csh:

	setenv CC gcc
	./configure
	make

Much of the code and documentation enclosed is copyright by
the Free Software Foundation, Inc.  See the file COPYING or
COPYING.LIB in the various directories, for a description of the
GNU General Public License terms under which you can copy the files.

REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info
on where and how to report problems.