mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
fdf95218bc
When building with clang 13 (and -std=gnu++17 to work around an issue in
string_view-selftests.c), we run into a few Wimplicit-exception-spec-mismatch
warnings:
...
src/gdbsupport/new-op.cc:102:1: error: function previously declared with an \
explicit exception specification redeclared with an implicit exception \
specification [-Werror,-Wimplicit-exception-spec-mismatch]
operator delete (void *p)
^
/usr/include/c++/11/new:130:6: note: previous declaration is here
void operator delete(void*) _GLIBCXX_USE_NOEXCEPT
^
...
These are due to recent commit 5fff6115fe
"Fix
LD_PRELOAD=/usr/lib64/libasan.so.6 gdb".
Fix this by adding the missing noexcept.
Build on x86_64-linux, using gcc 7.5.0 and clang 13.0.0.
143 lines
3.9 KiB
C++
143 lines
3.9 KiB
C++
/* Replace operator new/new[], for GDB, the GNU debugger.
|
|
|
|
Copyright (C) 2016-2021 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
/* GCC does not understand __has_feature. */
|
|
#if !defined(__has_feature)
|
|
# define __has_feature(x) 0
|
|
#endif
|
|
|
|
#if !__has_feature(address_sanitizer) && !defined(__SANITIZE_ADDRESS__)
|
|
#include "common-defs.h"
|
|
#include "host-defs.h"
|
|
#include <new>
|
|
|
|
/* These are declared in <new> starting C++14. Add these here to enable
|
|
compilation using C++11. */
|
|
extern void operator delete (void *p, std::size_t) noexcept;
|
|
extern void operator delete[] (void *p, std::size_t) noexcept;
|
|
|
|
/* Override operator new / operator new[], in order to internal_error
|
|
on allocation failure and thus query the user for abort/core
|
|
dump/continue, just like xmalloc does. We don't do this from a
|
|
new-handler function instead (std::set_new_handler) because we want
|
|
to catch allocation errors from within global constructors too.
|
|
|
|
Skip overriding if building with -fsanitize=address though.
|
|
Address sanitizer wants to override operator new/delete too in
|
|
order to detect malloc+delete and new+free mismatches. Our
|
|
versions would mask out ASan's, with the result of losing that
|
|
useful mismatch detection.
|
|
|
|
Note that C++ implementations could either have their throw
|
|
versions call the nothrow versions (libstdc++), or the other way
|
|
around (clang/libc++). For that reason, we replace both throw and
|
|
nothrow variants and call malloc directly. */
|
|
|
|
void *
|
|
operator new (std::size_t sz)
|
|
{
|
|
/* malloc (0) is unpredictable; avoid it. */
|
|
if (sz == 0)
|
|
sz = 1;
|
|
|
|
void *p = malloc (sz); /* ARI: malloc */
|
|
if (p == NULL)
|
|
{
|
|
/* If the user decides to continue debugging, throw a
|
|
gdb_quit_bad_alloc exception instead of a regular QUIT
|
|
gdb_exception. The former extends both std::bad_alloc and a
|
|
QUIT gdb_exception. This is necessary because operator new
|
|
can only ever throw std::bad_alloc, or something that extends
|
|
it. */
|
|
try
|
|
{
|
|
malloc_failure (sz);
|
|
}
|
|
catch (gdb_exception &ex)
|
|
{
|
|
throw gdb_quit_bad_alloc (std::move (ex));
|
|
}
|
|
}
|
|
return p;
|
|
}
|
|
|
|
void *
|
|
operator new (std::size_t sz, const std::nothrow_t&) noexcept
|
|
{
|
|
/* malloc (0) is unpredictable; avoid it. */
|
|
if (sz == 0)
|
|
sz = 1;
|
|
return malloc (sz); /* ARI: malloc */
|
|
}
|
|
|
|
void *
|
|
operator new[] (std::size_t sz)
|
|
{
|
|
return ::operator new (sz);
|
|
}
|
|
|
|
void*
|
|
operator new[] (std::size_t sz, const std::nothrow_t&) noexcept
|
|
{
|
|
return ::operator new (sz, std::nothrow);
|
|
}
|
|
|
|
/* Define also operators delete as one can LD_PRELOAD=libasan.so.*
|
|
without recompiling the program with -fsanitize=address and then one would
|
|
get false positive alloc-dealloc-mismatch (malloc vs operator delete [])
|
|
errors from AddressSanitizers. */
|
|
|
|
void
|
|
operator delete (void *p) noexcept
|
|
{
|
|
free (p);
|
|
}
|
|
|
|
void
|
|
operator delete (void *p, const std::nothrow_t&) noexcept
|
|
{
|
|
return ::operator delete (p);
|
|
}
|
|
|
|
void
|
|
operator delete (void *p, std::size_t) noexcept
|
|
{
|
|
return ::operator delete (p, std::nothrow);
|
|
}
|
|
|
|
void
|
|
operator delete[] (void *p) noexcept
|
|
{
|
|
return ::operator delete (p);
|
|
}
|
|
|
|
void
|
|
operator delete[] (void *p, const std::nothrow_t&) noexcept
|
|
{
|
|
return ::operator delete (p, std::nothrow);
|
|
}
|
|
|
|
void
|
|
operator delete[] (void *p, std::size_t) noexcept
|
|
{
|
|
return ::operator delete[] (p, std::nothrow);
|
|
}
|
|
|
|
#endif
|