Go to file
Simon Marchi cd3f655cc7 gdb: add accessors for field (and call site) location
Add accessors for the various location values in struct field.  This
lets us assert that when we get a location value of a certain kind (say,
bitpos), the field's location indeed contains a value of that kind.

Remove the SET_FIELD_* macros, instead use the new setters directly.
Update the FIELD_* macros used to access field locations to go through
the getters.  They will be removed in a subsequent patch.

There are places where the FIELD_* macros are used on call_site_target
structures, because it contains members of the same name (loc_kind and
loc).  For now, I have replicated the getters/setters in
call_site_target.  But we could perhaps eventually factor them in a
"location" structure that can be used at both places.

Note that the field structure, being zero-initialized, defaults to a
bitpos location with value 0.  While writing this patch, I tried to make
it default to an "unset" location, to catch places where we would miss
setting a field's location.  However, I found that some places relied on
the default being "bitpos 0", so I left it as-is.  This change could
always be done as follow-up work, making these places explicitly set the
"bitpos 0" location.

I found two issues to fix:

 - I got some failures in the gdb.base/infcall-nested-structs-c++.exp
   test.  They were caused by two functions in amd64-tdep.c using
   TYPE_FIELD_BITPOS before checking if the location is of the bitpos
   kind, which they do indirectly through `field_is_static`.  Simply
   move getting the bitpos below the field_is_static call.

 - I got a failure in gdb.xml/tdesc-regs.exp.  It turns out that in
   make_gdb_type_enum, we set enum field values using SET_FIELD_BITPOS,
   and later access them through FIELD_ENUMVAL.  Fix that by using
   set_loc_enumval to set the value.

Change-Id: I53d3734916c46457576ba11dd77df4049d2fc1e8
2021-10-07 11:03:54 -04:00
bfd RISC-V: Add support for Zbs instructions 2021-10-07 17:09:25 +08:00
binutils PR28401, invalid section name lookup 2021-10-06 11:24:29 +10:30
config Deprecate a.out support for NetBSD targets. 2021-08-11 13:17:54 +01:00
contrib
cpu Re: opcodes: constify & local meps macros 2021-07-05 21:40:49 +09:30
elfcpp PATCH [4/4] arm: Add Tag_PACRET_use build attribute 2021-08-17 14:49:42 +02:00
etc etc: switch to automake 2021-09-09 23:30:12 -04:00
gas RISC-V: Support aliases for Zbs instructions 2021-10-07 17:09:28 +08:00
gdb gdb: add accessors for field (and call site) location 2021-10-07 11:03:54 -04:00
gdbserver [gdb/build] Add CXX_DIALECT to CXX 2021-10-04 18:51:09 +02:00
gdbsupport [gdb/build] Add CXX_DIALECT to CXX 2021-10-04 18:51:09 +02:00
gnulib gnulib: import various network functions 2021-09-08 17:48:09 -04:00
gold [GOLD] PowerPC64 support for sym+addend GOT entries 2021-09-18 08:20:11 +09:30
gprof configure: regenerate in all projects that use libtool.m4 2021-09-27 20:31:24 +01:00
include RISC-V: Add support for Zbs instructions 2021-10-07 17:09:25 +08:00
intl Deprecate a.out support for NetBSD targets. 2021-08-11 13:17:54 +01:00
ld ld: pru: Fix resource_table output section alignment 2021-09-30 22:15:50 +03:00
libbacktrace Copy in libbacktrace from gcc 2021-09-28 12:21:21 +01:00
libctf libctf, lookup: fix bounds of pptrtab lookup 2021-09-27 20:31:26 +01:00
libdecnumber
libiberty Deprecate a.out support for NetBSD targets. 2021-08-11 13:17:54 +01:00
opcodes RISC-V: Support aliases for Zbs instructions 2021-10-07 17:09:28 +08:00
readline
sim sim: add --info-target for listing supported BFD targets 2021-10-04 02:19:58 -04:00
texinfo
zlib configure: regenerate in all projects that use libtool.m4 2021-09-27 20:31:24 +01:00
.cvsignore
.gitattributes
.gitignore
ar-lib
ChangeLog src-release.sh: add libbacktrace to GDB_SUPPORT_DIRS 2021-09-28 12:21:21 +01:00
compile
config-ml.in
config.guess
config.rpath
config.sub
configure top-level configure: setup target_configdirs based on repository 2021-09-28 12:21:21 +01:00
configure.ac top-level configure: setup target_configdirs based on repository 2021-09-28 12:21:21 +01:00
COPYING
COPYING3
COPYING3.LIB
COPYING.LIB
COPYING.LIBGLOSS
COPYING.NEWLIB
depcomp
djunpack.bat
install-sh
libtool.m4 libtool.m4: fix nm BSD flag detection 2021-09-27 20:31:23 +01:00
lt~obsolete.m4
ltgcc.m4
ltmain.sh
ltoptions.m4
ltsugar.m4
ltversion.m4
MAINTAINERS
Makefile.def gdb: Add a dependency between gdb and libbacktrace 2021-09-28 12:21:21 +01:00
Makefile.in gdb: Add a dependency between gdb and libbacktrace 2021-09-28 12:21:21 +01:00
Makefile.tpl
makefile.vms
missing
mkdep
mkinstalldirs
move-if-change
multilib.am
README
README-maintainer-mode
setup.com
src-release.sh src-release.sh: add libbacktrace to GDB_SUPPORT_DIRS 2021-09-28 12:21:21 +01:00
symlink-tree
test-driver
ylwrap

		   README for GNU development tools

This directory contains various GNU compilers, assemblers, linkers, 
debuggers, etc., plus their support routines, definitions, and documentation.

If you are receiving this as part of a GDB release, see the file gdb/README.
If with a binutils release, see binutils/README;  if with a libg++ release,
see libg++/README, etc.  That'll give you info about this
package -- supported targets, how to use it, how to report bugs, etc.

It is now possible to automatically configure and build a variety of
tools with one command.  To build all of the tools contained herein,
run the ``configure'' script here, e.g.:

	./configure 
	make

To install them (by default in /usr/local/bin, /usr/local/lib, etc),
then do:
	make install

(If the configure script can't determine your type of computer, give it
the name as an argument, for instance ``./configure sun4''.  You can
use the script ``config.sub'' to test whether a name is recognized; if
it is, config.sub translates it to a triplet specifying CPU, vendor,
and OS.)

If you have more than one compiler on your system, it is often best to
explicitly set CC in the environment before running configure, and to
also set CC when running make.  For example (assuming sh/bash/ksh):

	CC=gcc ./configure
	make

A similar example using csh:

	setenv CC gcc
	./configure
	make

Much of the code and documentation enclosed is copyright by
the Free Software Foundation, Inc.  See the file COPYING or
COPYING.LIB in the various directories, for a description of the
GNU General Public License terms under which you can copy the files.

REPORTING BUGS: Again, see gdb/README, binutils/README, etc., for info
on where and how to report problems.