binutils-gdb/gdb/testsuite/gdb.cp/ref-params.exp
Tom de Vries 72fbdf834d [gdb/testsuite] Fix testing build_executable result
When running with target board unix/-feliminate-dwarf2-dups, we run into these
FAILs:
...
FAIL: gdb.cp/rvalue-ref-params.exp: print value of f1 on Child&& in f2
FAIL: gdb.cp/ref-params.exp: print value of f1 on Child in main
FAIL: gdb.cp/ref-params.exp: print value of f2 on Child in main
FAIL: gdb.cp/ref-params.exp: print value of f1 on Child& in f2
FAIL: gdb.cp/ref-params.exp: print mf1(MQ)
FAIL: gdb.cp/ref-params.exp: print mf2(MQ)
FAIL: gdb.cp/ref-params.exp: print f1(MQR)
FAIL: gdb.cp/ref-params.exp: print mf1(MQR)
FAIL: gdb.cp/ref-params.exp: print mf2(MQR)
...

This is due to comparing the result of build_executable to 1, while
build_executable returns either 0 for success, or -1 for failure.

Fix this by comparing with -1 instead.

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2020-03-07  Tom de Vries  <tdevries@suse.de>

	* gdb.cp/ref-params.exp: Compare build_executable result with -1.
	* gdb.cp/rvalue-ref-params.exp: Same.
2020-03-07 22:46:07 +01:00

67 lines
2.1 KiB
Plaintext

# Tests for reference parameters of types and their subtypes in GDB.
# Copyright 2006-2020 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# written by Paul N. Hilfinger (Hilfinger@adacore.com)
#
# test running programs
#
if { [skip_cplus_tests] } { continue }
standard_testfile .cc
if {[build_executable $testfile.exp $testfile $srcfile {debug c++}] == -1} {
return -1
}
gdb_exit
proc gdb_start_again { text } {
global binfile
global srcfile
clean_restart $binfile
runto ${srcfile}:[gdb_get_line_number $text]
}
gdb_start_again "marker1 here"
gdb_test "print Q" ".*id = 42.*" "print value of a Child in main"
gdb_test "print f1(Q)" ".* = 42.*" "print value of f1 on Child in main"
gdb_test "print f2(Q)" ".* = 42.*" "print value of f2 on Child in main"
gdb_start_again "marker1 here"
gdb_test "print f1(QR)" ".* = 42.*" "print value of f1 on (Child&) in main"
gdb_start_again "marker1 here"
gdb_test "print f2(QR)" ".* = 42.*" "print value of f2 on (Child&) in main"
gdb_start_again "marker2 here"
gdb_test "print C" ".*id = 42.*" "print value of Child& in f2"
gdb_test "print f1(C)" ".* = 42.*" "print value of f1 on Child& in f2"
gdb_start_again "marker3 here"
gdb_test "print R" ".*id = 42.*" "print value of Parent& in f1"
gdb_start_again "breakpoint MQ here"
gdb_test "print f1(MQ)" ".* = 53"
gdb_test "print mf1(MQ)" ".* = 106"
gdb_test "print mf2(MQ)" ".* = 106"
gdb_test "print f1(MQR)" ".* = 53"
gdb_test "print mf1(MQR)" ".* = 106"
gdb_test "print mf2(MQR)" ".* = 106"