mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
b0fcf3e344
When applying layouts gdb computes the size of each window (or rather, each sub-layout within a layout) using integer arithmetic. As this rounds down the results, then, when all sub-layouts are sized, there is the possibility that we have some space left over. Currently, this space is just assigned to an arbitrary sub-layout. This can result in some unbalanced results. Consider this set of steps with current master: (gdb) tui enable (gdb) layout regs (gdb) info win Name Lines Columns Focus regs 7 80 src 9 80 (has focus) status 1 80 cmd 8 80 Notice the weird split between the src and regs windows, the original layout specification has these windows given equal weight. The problem is that, with rounding, both the regs and src windows are initially sized to 7, the extra 2 lines are then arbitrarily added to the src window. In this commit, rather than add all the extra space to one single window, I instead hand out the extra space 1 line at a time, looping over all the sub-layouts. We take care to respect the min/max sizes, and so, we now get this result: (gdb) tui enable (gdb) layout regs (gdb) info win Name Lines Columns Focus regs 8 80 src 8 80 (has focus) status 1 80 cmd 8 80 This looks more natural to me. This is obviously a change in behaviour, and so, lots of the existing tests need to be updated to take this into account. None of the changes are huge, it's just a line or two (or column for width) moved between windows.
64 lines
1.8 KiB
Plaintext
64 lines
1.8 KiB
Plaintext
# Copyright 2022 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test the "winwidth" command.
|
|
|
|
tuiterm_env
|
|
|
|
standard_testfile tui-layout.c
|
|
|
|
if {[build_executable "failed to prepare" ${testfile} ${srcfile}] == -1} {
|
|
return -1
|
|
}
|
|
|
|
Term::clean_restart 24 80 $testfile
|
|
if {![Term::enter_tui]} {
|
|
unsupported "TUI not supported"
|
|
return
|
|
}
|
|
|
|
Term::command "tui new-layout h { -horizontal src 1 asm 1 } 1 status 0 cmd 1"
|
|
Term::command "layout h"
|
|
|
|
with_test_prefix "original window sizes" {
|
|
Term::check_box "source box" 0 0 40 15
|
|
Term::check_box "asm box" 39 0 41 15
|
|
Term::command "winwidth src +5"
|
|
}
|
|
|
|
with_test_prefix "after src +5" {
|
|
Term::check_box "source box" 0 0 45 15
|
|
Term::check_box "asm box" 44 0 36 15
|
|
Term::command "winwidth asm -5"
|
|
}
|
|
|
|
with_test_prefix "after asm -5" {
|
|
Term::dump_screen
|
|
Term::check_box "source box" 0 0 50 15
|
|
Term::check_box "asm box" 49 0 31 15
|
|
Term::command "winwidth asm +8"
|
|
}
|
|
|
|
with_test_prefix "after asm +8" {
|
|
Term::check_box "source box" 0 0 42 15
|
|
Term::check_box "asm box" 41 0 39 15
|
|
Term::command "winwidth src -2"
|
|
}
|
|
|
|
with_test_prefix "after src -2" {
|
|
Term::check_box "source box" 0 0 40 15
|
|
Term::check_box "asm box" 39 0 41 15
|
|
}
|