mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
cce0ae568c
The previous patch to add -prompt/-lbl to gdb_test introduced a regression: Before, you could specify an explicit empty message to indicate you didn't want to PASS, like so: gdb_test COMMAND PATTERN "" After said patch, gdb_test no longer distinguishes no-message-specified vs empty-message, so tests that previously would be silent on PASS, now started emitting PASS messages based on COMMAND. This in turn introduced a number of PATH/DUPLICATE violations in the testsuite. This commit fixes all the regressions I could see. This patch uses the new -nopass feature introduced in the previous commit, but tries to avoid it if possible. Most of the patch fixes DUPLICATE issues the usual way, of using with_test_prefix or explicit unique messages. See previous commit's log for more info. In addition to looking for DUPLICATEs, I also looked for cases where we would now end up with an empty message in gdb.sum, due to a gdb_test being passed both no message and empty command. E.g., this in gdb.ada/bp_reset.exp: gdb_run_cmd gdb_test "" "Breakpoint $decimal, foo\\.nested_sub \\(\\).*" was resulting in this in gdb.sum: PASS: gdb.ada/bp_reset.exp: I fixed such cases by passing an explicit message. We may want to make such cases error out. Tested on x86_64 GNU/Linux, native and native-extended-gdbserver. I see zero PATH cases now. I get zero DUPLICATEs with native testing now. I still see some DUPLICATEs with native-extended-gdbserver, but those were preexisting, unrelated to the gdb_test change. Change-Id: I5375f23f073493e0672190a0ec2e847938a580b2
269 lines
10 KiB
Plaintext
269 lines
10 KiB
Plaintext
# Copyright 2008-2022 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This file is part of the GDB testsuite.
|
|
# This test tests the restoration of various kinds of machine state
|
|
# to their original values with a process record log. We will execute
|
|
# the program forward while it changes various types of data, and
|
|
# then execute it backward to see if their values get restored.
|
|
#
|
|
# The types of machine state (data) that are tested are:
|
|
# register variable
|
|
# auto variable
|
|
# function static variable
|
|
# module static variable
|
|
# module global variable
|
|
#
|
|
# TODO:
|
|
# various, possibly including...
|
|
# .bss variable, .data variable, ...
|
|
# shared library variable
|
|
# heap variable (pointer)...
|
|
# overlay variables...
|
|
# Test forward replay
|
|
#
|
|
|
|
# This test suitable only for process record-replay
|
|
if ![supports_process_record] {
|
|
return
|
|
}
|
|
|
|
standard_testfile machinestate.c ms1.c
|
|
set precsave [standard_output_file machinestate.precsave]
|
|
|
|
if { [prepare_for_testing "failed to prepare" $testfile \
|
|
[list $srcfile $srcfile2]] } {
|
|
return -1
|
|
}
|
|
|
|
set newline "\[\r\n\]+"
|
|
|
|
set beginmain [gdb_get_line_number " begin main " $srcfile]
|
|
set endmain [gdb_get_line_number " end main " $srcfile]
|
|
|
|
# Test begins
|
|
|
|
runto_main
|
|
|
|
if [supports_process_record] {
|
|
# Activate process record/replay
|
|
gdb_test_no_output "record" "turn on process record"
|
|
}
|
|
|
|
gdb_test "break $endmain" \
|
|
"Breakpoint $decimal at .*$srcfile, line $endmain\." \
|
|
"breakpoint at end of main"
|
|
|
|
gdb_test "continue" "Breakpoint .* end main .*" "run to end of main"
|
|
|
|
gdb_test "record save $precsave" \
|
|
"Saved core file $precsave with execution log\." \
|
|
"save process recfile"
|
|
|
|
gdb_test "kill" "" "kill process, prepare to debug log file" \
|
|
"Kill the program being debugged\\? \\(y or n\\) " "y"
|
|
|
|
gdb_test "record restore $precsave" \
|
|
"Restored records from core file .*" \
|
|
"reload prec save file"
|
|
|
|
# Proceed to end of main
|
|
|
|
gdb_test "break $endmain" \
|
|
"Breakpoint.* file .*$srcfile, line $endmain.*" \
|
|
"break at end of main"
|
|
|
|
gdb_test_multiple "continue" "go to end of main forward" {
|
|
-re ".*Breakpoint $decimal,.*$srcfile:$endmain.*$gdb_prompt $" {
|
|
pass "go to end of main forward"
|
|
}
|
|
-re "No more reverse-execution history.* end main .*$gdb_prompt $" {
|
|
pass "go to end of main forward"
|
|
}
|
|
}
|
|
|
|
###
|
|
###
|
|
###
|
|
|
|
# Now run backward to each of several points where data is changed.
|
|
#
|
|
|
|
# Module global variable, reverse
|
|
with_test_prefix "module global variable, reverse" {
|
|
set breakloc [gdb_get_line_number \
|
|
"module_global_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "reverse-continue" "$srcfile:$breakloc.*" "reverse to $breakloc"
|
|
|
|
gdb_test "print aglobal" " = 0$newline" "module global reverse-breakpoint"
|
|
gdb_test "step" " module global post-change .*"
|
|
gdb_test "print aglobal" " = 1$newline" "module global forward past bp"
|
|
gdb_test "reverse-step" "$newline$breakloc.*"
|
|
gdb_test "print aglobal" " = 0$newline" "module global reverse-step to bp"
|
|
}
|
|
|
|
# Module static variable, reverse
|
|
with_test_prefix "module static variable, reverse" {
|
|
set breakloc [gdb_get_line_number \
|
|
"module_static_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "reverse-continue" "$srcfile:$breakloc.*" "reverse to $breakloc"
|
|
|
|
gdb_test "print astatic" " = 0$newline" "module static reverse-breakpoint"
|
|
gdb_test "step" " module static post-change .*"
|
|
gdb_test "print astatic" " = 1$newline" "module static forward"
|
|
gdb_test "reverse-step" "$newline$breakloc.*"
|
|
gdb_test "print astatic" " = 0$newline" "module static reverse-step"
|
|
}
|
|
|
|
# Function static variable, reverse
|
|
with_test_prefix "function static variable, reverse" {
|
|
set breakloc [gdb_get_line_number \
|
|
"function_static_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "reverse-continue" "$srcfile:$breakloc.*" "reverse to $breakloc"
|
|
|
|
gdb_test "print a" " = 0$newline" "function static reverse-breakpoint"
|
|
gdb_test "step" " function static post-change .*"
|
|
gdb_test "print a" " = 1$newline" "function static forward"
|
|
gdb_test "reverse-step" "$newline$breakloc.*"
|
|
gdb_test "print a" " = 0$newline" "function static reverse-step"
|
|
}
|
|
|
|
# Auto variable, reverse
|
|
with_test_prefix "auto variable, reverse" {
|
|
set breakloc [gdb_get_line_number \
|
|
"auto_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "reverse-continue" "$srcfile:$breakloc.*" "reverse to $breakloc"
|
|
|
|
gdb_test "print a" " = 0$newline" "auto var reverse-breakpoint"
|
|
gdb_test "step" " auto post-change .*"
|
|
gdb_test "print a" " = 1$newline" "auto var forward"
|
|
gdb_test "reverse-step" "$newline$breakloc.*"
|
|
gdb_test "print a" " = 0$newline" "auto var reverse-step"
|
|
}
|
|
|
|
# Register variable, reverse
|
|
with_test_prefix "register variable, reverse" {
|
|
set breakloc [gdb_get_line_number \
|
|
"register_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "reverse-continue" "$srcfile:$breakloc.*" "reverse to $breakloc"
|
|
|
|
gdb_test "print a" " = 0$newline" "register var reverse-breakpoint"
|
|
gdb_test "step" " register post-change .*"
|
|
gdb_test "print a" " = 1$newline" \
|
|
"register var step post-change, first time"
|
|
gdb_test "reverse-step" "$newline$breakloc.*"
|
|
gdb_test "print a" " = 0$newline" "register var reverse step-to"
|
|
}
|
|
|
|
# Proceed to beginning of main
|
|
|
|
gdb_test "tbreak $beginmain" ".*$srcfile, line $beginmain.*" \
|
|
"tbreak at beginning of main"
|
|
gdb_test "reverse-continue" ".*$srcfile:$beginmain.*" "reverse to main"
|
|
|
|
# Now repeat tests while replaying forward.
|
|
|
|
# Register variable, forward
|
|
with_test_prefix "register variable, forward" {
|
|
set breakloc [gdb_get_line_number \
|
|
"register_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "continue" "$srcfile:$breakloc.*" "forward to $breakloc"
|
|
|
|
gdb_test "print a" " = 0$newline" "register var forward-breakpoint"
|
|
gdb_test "reverse-step" "hide.*"
|
|
gdb_test "step" "$newline$breakloc.*" "step, 1"
|
|
gdb_test "print a" " = 0$newline" "register var forward step-to"
|
|
gdb_test "step" " register post-change .*" "step, 2"
|
|
gdb_test "print a" " = 1$newline" \
|
|
"register var step post-change, second time"
|
|
}
|
|
|
|
# Auto variable, forward
|
|
with_test_prefix "auto variable, forward" {
|
|
set breakloc [gdb_get_line_number \
|
|
"auto_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "continue" "$srcfile:$breakloc.*" "forward to $breakloc"
|
|
|
|
gdb_test "print a" " = 0$newline" "auto var forward-breakpoint"
|
|
gdb_test "reverse-step" "hide.*"
|
|
gdb_test "step" "$newline$breakloc.*" "step, 1"
|
|
gdb_test "print a" " = 0$newline" "auto var forward step-to"
|
|
gdb_test "step" " auto post-change .*" "step, 2"
|
|
gdb_test "print a" " = 1$newline" "auto var step post-change"
|
|
}
|
|
|
|
# Function static variable, forward
|
|
with_test_prefix "function static variable, forward" {
|
|
set breakloc [gdb_get_line_number \
|
|
"function_static_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "continue" "$srcfile:$breakloc.*" "forward to $breakloc"
|
|
|
|
gdb_test "print a" " = 0$newline" "function static forward-breakpoint"
|
|
gdb_test "reverse-step" "hide.*"
|
|
gdb_test "step" "$newline$breakloc.*" "step, 1"
|
|
gdb_test "print a" " = 0$newline" "function static forward step-to"
|
|
gdb_test "step" " function static post-change .*" "step, 2"
|
|
gdb_test "print a" " = 1$newline" "function static step post-change"
|
|
}
|
|
|
|
# Module static variable, forward
|
|
with_test_prefix "module static variable, forward" {
|
|
set breakloc [gdb_get_line_number \
|
|
"module_static_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "continue" "$srcfile:$breakloc.*" "forward to $breakloc"
|
|
|
|
gdb_test "print astatic" " = 0$newline" "module static forward-breakpoint"
|
|
gdb_test "reverse-step" "hide.*"
|
|
gdb_test "step" "$newline$breakloc.*" "step, 1"
|
|
gdb_test "print astatic" " = 0$newline" "module static forward step-to"
|
|
gdb_test "step" " module static post-change .*" "step, 2"
|
|
gdb_test "print astatic" " = 1$newline" "module static step post-change"
|
|
}
|
|
|
|
# Module global variable, forward
|
|
with_test_prefix "module global variable, forward" {
|
|
set breakloc [gdb_get_line_number \
|
|
"module_global_state: set breakpoint here" $srcfile]
|
|
|
|
gdb_test "tbreak $breakloc" "$srcfile, line $breakloc.*"
|
|
gdb_test "continue" "$srcfile:$breakloc.*" "forward to $breakloc"
|
|
|
|
gdb_test "print aglobal" " = 0$newline" "module global forward-breakpoint"
|
|
gdb_test "reverse-step" "hide.*"
|
|
gdb_test "step" "$newline$breakloc.*" "step, 1"
|
|
gdb_test "print aglobal" " = 0$newline" "module global forward step-to"
|
|
gdb_test "step" " module global post-change .*" "step, 2"
|
|
gdb_test "print aglobal" " = 1$newline" "module global step post-change"
|
|
}
|
|
|