mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-03 04:12:10 +08:00
6f1d2f789b
When a GDB built with -D_GLIBCXX_DEBUG=1 reads a binary with a single
character name, we hit this assertion failure:
$ ./gdb -q --data-directory=data-directory -nx ./x
/usr/include/c++/12.1.0/string_view:239: constexpr const std::basic_string_view<_CharT, _Traits>::value_type& std::basic_string_view<_CharT, _Traits>::operator[](size_type) const [with _CharT = char; _Traits = std::char_traits<char>; const_reference = const char&; size_type = long unsigned int]: Assertion '__pos < this->_M_len' failed.
The backtrace:
#3 0x00007ffff6c0f002 in std::__glibcxx_assert_fail (file=<optimized out>, line=<optimized out>, function=<optimized out>, condition=<optimized out>) at /usr/src/debug/gcc/libstdc++-v3/src/c++11/debug.cc:60
#4 0x000055555da8a864 in std::basic_string_view<char, std::char_traits<char> >::operator[] (this=0x7fffffffcc30, __pos=1) at /usr/include/c++/12.1.0/string_view:239
#5 0x00005555609dcb88 in path_join[abi:cxx11](gdb::array_view<std::basic_string_view<char, std::char_traits<char> > const>) (paths=...) at /home/simark/src/binutils-gdb/gdbsupport/pathstuff.cc:203
#6 0x000055555e0443f4 in path_join<char const*, char const*> () at /home/simark/src/binutils-gdb/gdb/../gdbsupport/pathstuff.h:84
#7 0x00005555609dc336 in gdb_realpath_keepfile[abi:cxx11](char const*) (filename=0x6060000a8d40 "/home/simark/build/binutils-gdb-one-target/gdb/./x") at /home/simark/src/binutils-gdb/gdbsupport/pathstuff.cc:122
#8 0x000055555ebd2794 in exec_file_attach (filename=0x7fffffffe0f9 "./x", from_tty=1) at /home/simark/src/binutils-gdb/gdb/exec.c:471
#9 0x000055555f2b3fb0 in catch_command_errors (command=0x55555ebd1ab6 <exec_file_attach(char const*, int)>, arg=0x7fffffffe0f9 "./x", from_tty=1, do_bp_actions=false) at /home/simark/src/binutils-gdb/gdb/main.c:513
#10 0x000055555f2b7e11 in captured_main_1 (context=0x7fffffffdb60) at /home/simark/src/binutils-gdb/gdb/main.c:1209
#11 0x000055555f2b9144 in captured_main (data=0x7fffffffdb60) at /home/simark/src/binutils-gdb/gdb/main.c:1319
#12 0x000055555f2b9226 in gdb_main (args=0x7fffffffdb60) at /home/simark/src/binutils-gdb/gdb/main.c:1344
#13 0x000055555d938c5e in main (argc=5, argv=0x7fffffffdcf8) at /home/simark/src/binutils-gdb/gdb/gdb.c:32
The problem is this line in path_join:
gdb_assert (strlen (path) == 0 || !IS_ABSOLUTE_PATH (path));
... where `path` is "x". IS_ABSOLUTE_PATH eventually calls
HAS_DRIVE_SPEC_1:
#define HAS_DRIVE_SPEC_1(dos_based, f) \
((f)[0] && ((f)[1] == ':') && (dos_based))
This macro accesses indices 0 and 1 of the input string. However, `f`
is a string_view of length 1, so it's incorrect to try to access index
1. We know that the string_view's underlying object is a null-terminated
string, so in practice there's no harm. But as far as the string_view
is concerned, index 1 is considered out of bounds.
This patch makes the easy fix, that is to change the path_join parameter
from a vector of to a vector of `const char *`. Another solution would
be to introduce a non-standard gdb::cstring_view class, which would be a
view over a null-terminated string. With that class, it would be
correct to access index 1, it would yield the NUL character. If there
is interest in having this class (it has been mentioned a few times in
the past) I can do it and use it here.
This was found by running tests such as gdb.ada/arrayidx.exp, which
produce 1-char long filenames, so adding a new test is not necessary.
Change-Id: Ia41a16c7243614636b18754fd98a41860756f7af
166 lines
5.7 KiB
C++
166 lines
5.7 KiB
C++
/* Path manipulation routines for GDB and gdbserver.
|
|
|
|
Copyright (C) 1986-2022 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef COMMON_PATHSTUFF_H
|
|
#define COMMON_PATHSTUFF_H
|
|
|
|
#include "gdbsupport/byte-vector.h"
|
|
#include "gdbsupport/array-view.h"
|
|
|
|
#include <sys/types.h>
|
|
#include <sys/stat.h>
|
|
#include <unistd.h>
|
|
#include <array>
|
|
|
|
/* Path utilities. */
|
|
|
|
/* Return the real path of FILENAME, expanding all the symbolic links.
|
|
|
|
Contrary to "gdb_abspath", this function does not use
|
|
CURRENT_DIRECTORY for path expansion. Instead, it relies on the
|
|
current working directory (CWD) of GDB or gdbserver. */
|
|
|
|
extern gdb::unique_xmalloc_ptr<char> gdb_realpath (const char *filename);
|
|
|
|
/* Return a copy of FILENAME, with its directory prefix canonicalized
|
|
by gdb_realpath. */
|
|
|
|
extern std::string gdb_realpath_keepfile (const char *filename);
|
|
|
|
/* Return PATH in absolute form, performing tilde-expansion if necessary.
|
|
PATH cannot be NULL or the empty string.
|
|
This does not resolve symlinks however, use gdb_realpath for that.
|
|
|
|
Contrary to "gdb_realpath", this function uses CURRENT_DIRECTORY
|
|
for the path expansion. This may lead to scenarios the current
|
|
working directory (CWD) is different than CURRENT_DIRECTORY.
|
|
|
|
If CURRENT_DIRECTORY is NULL, this function returns a copy of
|
|
PATH. */
|
|
|
|
extern std::string gdb_abspath (const char *path);
|
|
|
|
/* If the path in CHILD is a child of the path in PARENT, return a
|
|
pointer to the first component in the CHILD's pathname below the
|
|
PARENT. Otherwise, return NULL. */
|
|
|
|
extern const char *child_path (const char *parent, const char *child);
|
|
|
|
/* Join elements in PATHS into a single path.
|
|
|
|
The first element can be absolute or relative. All the others must be
|
|
relative. */
|
|
|
|
extern std::string path_join (gdb::array_view<const char *> paths);
|
|
|
|
/* Same as the above, but accept paths as distinct parameters. */
|
|
|
|
template<typename ...Args>
|
|
std::string
|
|
path_join (Args... paths)
|
|
{
|
|
/* It doesn't make sense to join less than two paths. */
|
|
gdb_static_assert (sizeof... (Args) >= 2);
|
|
|
|
std::array<const char *, sizeof... (Args)> path_array
|
|
{ paths... };
|
|
|
|
return path_join (gdb::array_view<const char *> (path_array));
|
|
}
|
|
|
|
/* Return whether PATH contains a directory separator character. */
|
|
|
|
extern bool contains_dir_separator (const char *path);
|
|
|
|
/* Get the usual user cache directory for the current platform.
|
|
|
|
On Linux, it follows the XDG Base Directory specification: use
|
|
$XDG_CACHE_HOME/gdb if the XDG_CACHE_HOME environment variable is
|
|
defined, otherwise $HOME/.cache.
|
|
|
|
On macOS, it follows the local convention and uses
|
|
~/Library/Caches/gdb.
|
|
|
|
The return value is absolute and tilde-expanded. Return an empty
|
|
string if neither XDG_CACHE_HOME (on Linux) or HOME are defined. */
|
|
|
|
extern std::string get_standard_cache_dir ();
|
|
|
|
/* Get the usual temporary directory for the current platform.
|
|
|
|
On Windows, this is the TMP or TEMP environment variable.
|
|
|
|
On the rest, this is the TMPDIR environment variable, if defined, else /tmp.
|
|
|
|
Throw an exception on error. */
|
|
|
|
extern std::string get_standard_temp_dir ();
|
|
|
|
/* Get the usual user config directory for the current platform.
|
|
|
|
On Linux, it follows the XDG Base Directory specification: use
|
|
$XDG_CONFIG_HOME/gdb if the XDG_CONFIG_HOME environment variable is
|
|
defined, otherwise $HOME/.config.
|
|
|
|
On macOS, it follows the local convention and uses
|
|
~/Library/Preferences/gdb.
|
|
|
|
The return value is absolute and tilde-expanded. Return an empty
|
|
string if neither XDG_CONFIG_HOME (on Linux) or HOME are defined. */
|
|
|
|
extern std::string get_standard_config_dir ();
|
|
|
|
/* Look for FILENAME in the standard configuration directory as returned by
|
|
GET_STANDARD_CONFIG_DIR and return the path to the file. No check is
|
|
performed that the file actually exists or not.
|
|
|
|
If FILENAME begins with a '.' then the path returned will remove the
|
|
leading '.' character, for example passing '.gdbinit' could return the
|
|
path '/home/username/.config/gdb/gdbinit'. */
|
|
|
|
extern std::string get_standard_config_filename (const char *filename);
|
|
|
|
/* Look for a file called NAME in either the standard config directory or
|
|
in the users home directory. If a suitable file is found then *BUF will
|
|
be filled with the contents of a call to 'stat' on the found file,
|
|
otherwise *BUF is undefined after this call.
|
|
|
|
If NAME starts with a '.' character then, when looking in the standard
|
|
config directory the file searched for has the '.' removed. For
|
|
example, if NAME is '.gdbinit' then on a Linux target GDB might look for
|
|
'~/.config/gdb/gdbinit' and then '~/.gdbinit'. */
|
|
|
|
extern std::string find_gdb_home_config_file (const char *name,
|
|
struct stat *buf);
|
|
|
|
/* Return the file name of the user's shell. Normally this comes from
|
|
the SHELL environment variable. */
|
|
|
|
extern const char *get_shell ();
|
|
|
|
/* Make a filename suitable to pass to mkstemp based on F (e.g.
|
|
/tmp/foo -> /tmp/foo-XXXXXX). */
|
|
|
|
extern gdb::char_vector make_temp_filename (const std::string &f);
|
|
|
|
/* String containing the current directory (what getwd would return). */
|
|
extern char *current_directory;
|
|
|
|
#endif /* COMMON_PATHSTUFF_H */
|