Jan Kratochvil 184cd07257 Fix crash on process name "(sd-pam)" (PR 16594). ... info os processes -fsanitize=address error https://sourceware.org/bugzilla/show_bug.cgi?id=16594 info os processes ================================================================= ==5795== ERROR: AddressSanitizer: heap-use-after-free on address 0x600600214974 at pc 0x757a92 bp 0x7fff95dd9f00 sp 0x7fff95dd9ef0 READ of size 4 at 0x600600214974 thread T0 #0 0x757a91 in get_cores_used_by_process (.../gdb/gdb+0x757a91) At least Fedora 20 has process(es): 6678 ? Ss 0:00 /usr/lib/systemd/systemd --user 6680 ? S 0:00 \_ (sd-pam) and GDB "info os processes" crashes on it as /proc/6680/stat contains: 6680 ((sd-pam)) S 6678 6678 6678 0 -1 1077961024 33 0 0 0 0 0 0 0 20 0 1 0 18568 73768960 120 18446744073709551615 1 1 0 0 0 0 0 4096 0 18446744073709551615 0 0 17 6 0 0 0 0 0 0 0 0 0 0 0 0 0 and GDB fails to find the proper end of the process name "((sd-pam))". Therefore it reads core number off-by-one (it reads 17 instead of 6) and overruns the array. (1) Make the process name parsing more foolproof. (2) Do not trust the parsed number from /proc/PID/stat and verify it against the array size. I noticed that 'ps' gets this right, so I've peeked at its sources, and it just looks for the first ')' starting at the end. dc072aced7:proc/readproc.c Look for stat2proc. Given ps does that, I believe the kernel won't ever be changed in a way that would break it. So it sounds like could do strrchr from the end of stat just as well without worry, which is simpler. gdb/ 2014-02-21 Jan Kratochvil <jan.kratochvil@redhat.com> PR gdb/16594 * common/linux-osdata.c (linux_common_core_of_thread): Find the end of process name. (get_cores_used_by_process): New parameter num_cores, use it. (linux_xfer_osdata_processes): Pass num_cores to it. * linux-tdep.c (linux_info_proc, linux_fill_prpsinfo): Find the end of process name. Message-ID: <20140217212826.GA15080@host2.jankratochvil.net>		2014-02-21 18:39:40 +01:00
..
agent.c
agent.h
ax.def
break-common.h
btrace-common.h
buffer.c
buffer.h
common-utils.c
common-utils.h
common.m4
create-version.sh
filestuff.c
filestuff.h
format.c
format.h
gdb_assert.h
gdb_locale.h
gdb_signals.h
gdb_thread_db.h
gdb_vecs.c
gdb_vecs.h
gdb_wait.h
glibc_thread_db.h
host-defs.h
i386-cpuid.h
i386-gcc-cpuid.h
i386-xstate.h
linux-btrace.c
linux-btrace.h
linux-osdata.c
linux-osdata.h
linux-procfs.c
linux-procfs.h
linux-ptrace.c
linux-ptrace.h
mips-linux-watch.c
mips-linux-watch.h
print-utils.c
print-utils.h
ptid.c
ptid.h
queue.h
rsp-low.c
rsp-low.h
signals.c
vec.c
vec.h
version.h
xml-utils.c
xml-utils.h