mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-02-05 12:53:16 +08:00
a60ead5ded
While testing mixed-lang-stack I realized that valgrind actually complained about a double free in the test. All done ==2503051== ==2503051== HEAP SUMMARY: ==2503051== in use at exit: 0 bytes in 0 blocks ==2503051== total heap usage: 26 allocs, 27 frees, 87,343 bytes allocated ==2503051== ==2503051== All heap blocks were freed -- no leaks are possible ==2503051== ==2503051== For lists of detected and suppressed errors, rerun with: -s ==2503051== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0) Reason for this is that in mixed-lang-stack.cpp in mixed_func_1f an object "derived_type obj" goes on the stack which is then passed-by-value (so copied) to mixed_func_1g. The default copy-ctor will be called but, since derived_type contains a heap allocated string and the copy constructor is not implemented it will only be able to shallow copy the object. Right after each of the functions the object gets freed - on the other hand the d'tor of derived_type actually is implemented and calls free on the heap allocated string which leads to a double free. Instead of obeying the rule of 3/5 I just got rid of all that since it does not serve the test. The string is now just a const char* = ".." object member.
76 lines
1.5 KiB
C++
76 lines
1.5 KiB
C++
/* Copyright 2020-2022 Free Software Foundation, Inc.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include <cstring>
|
|
#include <cstdlib>
|
|
|
|
class base_one
|
|
{
|
|
int num1 = 1;
|
|
int num2 = 2;
|
|
int num3 = 3;
|
|
};
|
|
|
|
class base_two
|
|
{
|
|
public:
|
|
const char *string = "Something in C++";
|
|
float val = 3.5;
|
|
};
|
|
|
|
class derived_type : public base_one, base_two
|
|
{
|
|
public:
|
|
derived_type ()
|
|
: base_one (),
|
|
base_two ()
|
|
{
|
|
/* Nothing. */
|
|
}
|
|
|
|
private:
|
|
int xxx = 9;
|
|
float yyy = 10.5;
|
|
};
|
|
|
|
static void mixed_func_1f ();
|
|
static void mixed_func_1g ();
|
|
|
|
extern "C"
|
|
{
|
|
/* Entry point to be called from Fortran. */
|
|
void
|
|
mixed_func_1e ()
|
|
{
|
|
mixed_func_1f ();
|
|
}
|
|
|
|
/* The entry point back into Fortran. */
|
|
extern void mixed_func_1h_ ();
|
|
}
|
|
|
|
static void
|
|
mixed_func_1g (derived_type obj)
|
|
{
|
|
mixed_func_1h_ ();
|
|
}
|
|
|
|
static void
|
|
mixed_func_1f () {
|
|
derived_type obj;
|
|
|
|
mixed_func_1g (obj);
|
|
}
|