binutils-gdb/bfd
Alan Modra c213164ad2 [PowerPC64] pc-relative TLS relocations
This patch supports using pcrel instructions in TLS code sequences.  A
number of new relocations are needed, gas operand modifiers to
generate those relocations, and new TLS optimisation.  For
optimisation it turns out that the new pcrel GD and LD sequences can
be distinguished from the non-pcrel GD and LD sequences by there being
different relocations on the new sequence.  The final "add ra,rb,13"
on IE sequences similarly needs a new relocation, or as I chose, a
modification of R_PPC64_TLS.  On pcrel IE code, the R_PPC64_TLS points
one byte into the "add" instruction rather than being on the
instruction boundary.

GD:
 pla 3,z@got@tlsgd@pcrel	  # R_PPC64_GOT_TLSGD34
 bl __tls_get_addr@notoc(z@tlsgd) # R_PPC64_TLSGD and R_PPC64_REL24_NOTOC
  edited to IE
   pld 3,z@got@tprel@pcrel
   add 3,3,13
  edited to LE
   paddi 3,13,z@tprel
   nop

LD:
 pla 3,z@got@tlsld@pcrel	  # R_PPC64_GOT_TLSLD34
 bl __tls_get_addr@notoc(z@tlsld) # R_PPC64_TLSLD and R_PPC64_REL24_NOTOC
 ..
 paddi 9,3,z2@dtprel
 pld 10,z3@got@dtprel@pcrel
 add 10,10,3
  edited to LE
   paddi 3,13,0x1000
   nop

IE:
 pld 9,z@got@tprel@pcrel	  # R_PPC64_GOT_TPREL34
 add 3,9,z@tls@pcrel		  # R_PPC64_TLS at insn+1
 ldx 4,9,z@tls@pcrel
 lwax 5,9,z@tls@pcrel
 stdx 5,9,z@tls@pcrel
  edited to LE
  paddi 9,13,z@tprel
  nop
  ld 4,0(9)
  lwa 5,0(9)
  std 5,0(9)

LE:
 paddi 10,13,z@tprel

include/
	* elf/ppc64.h (R_PPC64_TPREL34, R_PPC64_DTPREL34),
	(R_PPC64_GOT_TLSGD34, R_PPC64_GOT_TLSLD34),
	(R_PPC64_GOT_TPREL34, R_PPC64_GOT_DTPREL34): Define.
	(IS_PPC64_TLS_RELOC): Include new tls relocs.
bfd/
	* reloc.c (BFD_RELOC_PPC64_TPREL34, BFD_RELOC_PPC64_DTPREL34),
	(BFD_RELOC_PPC64_GOT_TLSGD34, BFD_RELOC_PPC64_GOT_TLSLD34),
	(BFD_RELOC_PPC64_GOT_TPREL34, BFD_RELOC_PPC64_GOT_DTPREL34),
	(BFD_RELOC_PPC64_TLS_PCREL): New pcrel tls relocs.
	* elf64-ppc.c (ppc64_elf_howto_raw): Add howtos for pcrel tls relocs.
	(ppc64_elf_reloc_type_lookup): Translate pcrel tls relocs.
	(must_be_dyn_reloc, dec_dynrel_count): Add R_PPC64_TPREL64.
	(ppc64_elf_check_relocs): Support pcrel tls relocs.
	(ppc64_elf_tls_optimize, ppc64_elf_relocate_section): Likewise.
	* bfd-in2.h: Regenerate.
	* libbfd.h: Regenerate.
gas/
	* config/tc-ppc.c (ppc_elf_suffix): Map "tls@pcrel", "got@tlsgd@pcrel",
	"got@tlsld@pcrel", "got@tprel@pcrel", and "got@dtprel@pcrel".
	(fixup_size, md_assemble): Handle pcrel tls relocs.
	(ppc_force_relocation, ppc_fix_adjustable): Likewise.
	(md_apply_fix, tc_gen_reloc): Likewise.
ld/
	* testsuite/ld-powerpc/tlsgd.d,
	* testsuite/ld-powerpc/tlsgd.s,
	* testsuite/ld-powerpc/tlsie.d,
	* testsuite/ld-powerpc/tlsie.s,
	* testsuite/ld-powerpc/tlsld.d,
	* testsuite/ld-powerpc/tlsld.s: New tests.
	* testsuite/ld-powerpc/powerpc.exp: Run them.
2019-07-19 18:01:25 +09:30
..
doc PR24427, bfd/doc/chew.c reads uninitialized memory and subtracts from function pointer 2019-04-10 18:30:29 +09:30
hosts
po Regen POTFILES for bpf 2019-05-24 23:15:07 +09:30
.gitignore
acinclude.m4
aclocal.m4
aix5ppc-core.c
aix386-core.c
aout32.c
aout64.c
aout-cris.c
aout-ns32k.c
aout-target.h
aout-tic30.c Obsolete tic30-aout, and linker segmentation faults 2019-05-28 10:55:21 +09:30
aoutx.h
arc-got.h
arc-plt.def
arc-plt.h
archive64.c
archive.c
archures.c bfd: add support for eBPF 2019-05-23 19:33:41 +02:00
bfd-in2.h [PowerPC64] pc-relative TLS relocations 2019-07-19 18:01:25 +09:30
bfd-in.h [LD, AArch64] Move ELF options behind -z 2019-06-06 12:21:14 +01:00
bfd.c
bfd.m4
bfdio.c
bfdwin.c
binary.c
cache.c
cf-i386lynx.c
ChangeLog [PowerPC64] pc-relative TLS relocations 2019-07-19 18:01:25 +09:30
ChangeLog-0001
ChangeLog-0203
ChangeLog-2004
ChangeLog-2005
ChangeLog-2006
ChangeLog-2007
ChangeLog-2008
ChangeLog-2009
ChangeLog-2010
ChangeLog-2011
ChangeLog-2012
ChangeLog-2013
ChangeLog-2014
ChangeLog-2015
ChangeLog-2016
ChangeLog-2017
ChangeLog-2018
ChangeLog-9193
ChangeLog-9495
ChangeLog-9697
ChangeLog-9899
cisco-core.c
coff64-rs6000.c
coff-alpha.c
coff-arm.c
coff-bfd.c
coff-bfd.h
coff-go32.c
coff-i386.c BFD whitespace fixes 2019-04-03 12:50:39 +10:30
coff-ia64.c
coff-mcore.c
coff-mips.c
coff-ppc.c
coff-rs6000.c
coff-sh.c
coff-stgo32.c
coff-tic4x.c
coff-tic30.c
coff-tic54x.c
coff-tic80.c
coff-x86_64.c BFD whitespace fixes 2019-04-03 12:50:39 +10:30
coff-z8k.c
coff-z80.c
coffcode.h Treat the .gnu.debuglink and .gnu.debugaltlink sections as debug sections when reading them in from COFF/PE format files. 2019-05-02 15:11:39 +01:00
coffgen.c BFD whitespace fixes 2019-04-03 12:50:39 +10:30
cofflink.c COFF linker segmentation faults 2019-05-28 17:57:51 +09:30
coffswap.h
compress.c Fix a bug recently introduced to the linker where it would complain about a section being larger than a file, even if the section was artificial. 2019-07-02 14:14:13 +01:00
config.bfd Plugin target handling 2019-06-28 10:18:49 +09:30
config.in
configure Plugin target handling 2019-06-28 10:18:49 +09:30
configure.ac Plugin target handling 2019-06-28 10:18:49 +09:30
configure.com
configure.host
COPYING
corefile.c
cpu-aarch64.c
cpu-alpha.c
cpu-arc.c
cpu-arm.c [binutils, ARM, 1/16] Add support for Armv8.1-M Mainline CLI 2019-04-15 10:54:42 +01:00
cpu-avr.c
cpu-bfin.c
cpu-bpf.c bfd: add support for eBPF 2019-05-23 19:33:41 +02:00
cpu-cr16.c
cpu-cr16c.c
cpu-cris.c
cpu-crx.c
cpu-csky.c
cpu-d10v.c
cpu-d30v.c
cpu-dlx.c
cpu-epiphany.c
cpu-fr30.c
cpu-frv.c
cpu-ft32.c
cpu-h8300.c
cpu-hppa.c
cpu-i386.c
cpu-ia64-opc.c
cpu-ia64.c
cpu-iamcu.c
cpu-ip2k.c
cpu-iq2000.c
cpu-k1om.c
cpu-l1om.c
cpu-lm32.c
cpu-m9s12x.c
cpu-m9s12xg.c
cpu-m32c.c
cpu-m32r.c
cpu-m68hc11.c
cpu-m68hc12.c
cpu-m68k.c
cpu-m10200.c
cpu-m10300.c
cpu-mcore.c
cpu-mep.c
cpu-metag.c
cpu-microblaze.c
cpu-mips.c
cpu-mmix.c
cpu-moxie.c
cpu-msp430.c
cpu-mt.c
cpu-nds32.c
cpu-nfp.c
cpu-nios2.c
cpu-ns32k.c
cpu-or1k.c
cpu-pdp11.c
cpu-pj.c
cpu-plugin.c
cpu-powerpc.c
cpu-pru.c
cpu-riscv.c
cpu-rl78.c
cpu-rs6000.c
cpu-rx.c
cpu-s12z.c
cpu-s390.c
cpu-score.c
cpu-sh.c
cpu-sparc.c
cpu-spu.c
cpu-tic4x.c
cpu-tic6x.c
cpu-tic30.c
cpu-tic54x.c
cpu-tic80.c
cpu-tilegx.c
cpu-tilepro.c
cpu-v850_rh850.c
cpu-v850.c
cpu-vax.c
cpu-visium.c
cpu-wasm32.c
cpu-xc16x.c
cpu-xgate.c
cpu-xstormy16.c
cpu-xtensa.c
cpu-z8k.c
cpu-z80.c
dep-in.sed
development.sh
dwarf1.c
dwarf2.c XCOFF linker segmentation fault 2019-05-28 10:05:02 +09:30
ecoff.c
ecofflink.c
ecoffswap.h
elf32-am33lin.c
elf32-arc.c
elf32-arm.c PR ld/24709 [arm] linker crash and assertion failure with CMSE 2019-07-02 13:09:02 +00:00
elf32-avr.c Fix PR 24571 - Relaxation does not shorten jmp or call to target at pc-relative range boundary 2019-05-21 12:48:06 +05:30
elf32-avr.h
elf32-bfin.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-cr16.c
elf32-cr16c.c
elf32-cris.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-crx.c
elf32-csky.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-d10v.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-d30v.c
elf32-dlx.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-dlx.h
elf32-epiphany.c
elf32-fr30.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-frv.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-ft32.c
elf32-gen.c
elf32-h8300.c
elf32-hppa.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-hppa.h
elf32-i386.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-ip2k.c
elf32-iq2000.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-lm32.c LM32 linker segmentation faults 2019-05-28 14:38:31 +09:30
elf32-m32c.c
elf32-m32r.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-m68hc1x.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-m68hc1x.h
elf32-m68hc11.c
elf32-m68hc12.c
elf32-m68k.c m68k linker segmentation faults 2019-05-28 14:38:08 +09:30
elf32-mcore.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-mep.c
elf32-metag.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-metag.h
elf32-microblaze.c Microblaze linker segmentation fault 2019-05-28 15:56:14 +09:30
elf32-mips.c
elf32-moxie.c
elf32-msp430.c
elf32-mt.c
elf32-nds32.c
elf32-nds32.h
elf32-nios2.c
elf32-nios2.h
elf32-or1k.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-pj.c PicoJava weak undefined symbols 2019-05-06 11:41:28 +09:30
elf32-ppc.c [PowerPC] Rename TLS_TPRELGD to TLS_GDIE 2019-07-18 22:17:30 +09:30
elf32-ppc.h
elf32-pru.c BFD whitespace fixes 2019-04-03 12:50:39 +10:30
elf32-rl78.c
elf32-rx.c BFD whitespace fixes 2019-04-03 12:50:39 +10:30
elf32-rx.h
elf32-s12z.c s12z and h8300 no-print-map-discarded fails 2019-04-19 12:41:58 +09:30
elf32-s390.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-score7.c
elf32-score.c
elf32-score.h
elf32-sh-relocs.h
elf32-sh.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-sparc.c
elf32-spu.c
elf32-spu.h
elf32-tic6x.c
elf32-tic6x.h
elf32-tilegx.c
elf32-tilegx.h
elf32-tilepro.c
elf32-tilepro.h
elf32-v850.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-vax.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-visium.c
elf32-wasm32.c
elf32-xc16x.c
elf32-xgate.c BFD whitespace fixes 2019-04-03 12:50:39 +10:30
elf32-xstormy16.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32-xtensa.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf32.c
elf64-alpha.c Alpha-linux linker segmentation fault 2019-05-28 15:11:54 +09:30
elf64-bpf.c bfd: add support for eBPF 2019-05-23 19:33:41 +02:00
elf64-gen.c
elf64-hppa.c HPPA64 linker segmentation faults 2019-05-28 10:55:41 +09:30
elf64-hppa.h
elf64-ia64-vms.c
elf64-mips.c
elf64-mmix.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf64-nfp.c
elf64-ppc.c [PowerPC64] pc-relative TLS relocations 2019-07-19 18:01:25 +09:30
elf64-ppc.h
elf64-s390.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf64-sparc.c BFD whitespace fixes 2019-04-03 12:50:39 +10:30
elf64-tilegx.c
elf64-tilegx.h
elf64-x86-64.c x86: Suggest -fPIE when not building shared object 2019-04-17 10:25:28 -07:00
elf64.c
elf-attrs.c
elf-bfd.h Stop the BFD library from issuing a warning message when processing allocated sections in debuginfo files that lie outside of any loadable segment. 2019-07-02 15:58:29 +01:00
elf-eh-frame.c
elf-hppa.h
elf-ifunc.c
elf-linker-x86.h x86: Add -z cet-report=[none|warning|error] 2019-04-11 08:21:30 -07:00
elf-linux-core.h
elf-m10200.c BFD whitespace fixes 2019-04-03 12:50:39 +10:30
elf-m10300.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elf-nacl.c
elf-nacl.h
elf-properties.c bfd/elf-properties: avoid shadowing a C library symbol 2019-06-25 12:01:50 +02:00
elf-s390-common.c
elf-s390.h
elf-strtab.c
elf-vxworks.c
elf-vxworks.h
elf.c Stop the BFD library from issuing a warning message when processing allocated sections in debuginfo files that lie outside of any loadable segment. 2019-07-02 15:58:29 +01:00
elfcode.h PR24689 again, string table corruption 2019-06-23 14:24:45 +09:30
elfcore.h
elflink.c Fix __bss_start assertion failure in _bfd_elf_fix_symbol_flags 2019-07-15 16:02:42 +09:30
elfn32-mips.c
elfnn-aarch64.c aarch64: remove unnecessary loc_hash_table traversal 2019-06-17 17:58:53 +01:00
elfnn-ia64.c BFD whitespace fixes 2019-04-03 12:50:39 +10:30
elfnn-riscv.c RISC-V: Enable lui relaxation for CODE and MERGE sections. 2019-06-24 13:50:10 -07:00
elfxx-aarch64.c [BFD, AArch64] Fix PT_GNU_PROPERTY alignment issue 2019-06-06 12:27:41 +01:00
elfxx-aarch64.h
elfxx-ia64.c
elfxx-ia64.h
elfxx-mips.c MIPS/LD: Skip overflow check for %pcrel_hi relocations 2019-05-28 10:49:16 -07:00
elfxx-mips.h [MIPS] Add generation of PLT entries with compact jumps for MIPS R6 2019-05-21 09:22:28 -07:00
elfxx-riscv.c BFD whitespace fixes 2019-04-03 12:50:39 +10:30
elfxx-riscv.h
elfxx-sparc.c Check corrupt VTENTRY entry in bfd_elf_gc_record_vtentry 2019-04-11 06:45:05 -07:00
elfxx-sparc.h
elfxx-target.h
elfxx-tilegx.c
elfxx-tilegx.h
elfxx-x86.c x86: Suggest -fPIE when not building shared object 2019-04-17 10:25:28 -07:00
elfxx-x86.h x86: Also check x86 linker_def for non-shared definition 2019-04-17 09:08:46 -07:00
format.c Plugin target handling 2019-06-28 10:18:49 +09:30
gen-aout.c
genlink.h
go32stub.h
hash.c
host-aout.c
hppabsd-core.c
hpux-core.c
i386aout.c
i386bsd.c
i386lynx.c
i386msdos.c
ihex.c
init.c
irix-core.c
libaout.h
libbfd-in.h
libbfd.c
libbfd.h [PowerPC64] pc-relative TLS relocations 2019-07-19 18:01:25 +09:30
libcoff-in.h
libcoff.h
libecoff.h
libhppa.h
libpei.h
libxcoff.h
linker.c Generic ELF target group signature symbol 2019-05-27 13:56:28 +09:30
lynx-core.c
mach-o-aarch64.c
mach-o-arm.c Ensure that when attempting to process an ARM Mach-O file with unknown relocs, that a suitable error message is displayed. 2019-06-26 17:03:32 +01:00
mach-o-i386.c
mach-o-target.c
mach-o-x86-64.c
mach-o.c Ensure that when attempting to process an ARM Mach-O file with unknown relocs, that a suitable error message is displayed. 2019-06-26 17:03:32 +01:00
mach-o.h
MAINTAINERS
Makefile.am bfd: add support for eBPF 2019-05-23 19:33:41 +02:00
Makefile.in Regenerate with approved autotools version 2019-06-14 10:30:35 +09:30
makefile.vms
mep-relocs.pl
merge.c
mmo.c
netbsd-core.c
netbsd.h
ns32k.h
ns32knetbsd.c
opncls.c
osf-core.c
pc532-mach.c
pdp11.c
pe-arm-wince.c
pe-arm.c
pe-i386.c
pe-mcore.c
pe-ppc.c
pe-sh.c
pe-x86_64.c BFD whitespace fixes 2019-04-03 12:50:39 +10:30
pef-traceback.h
pef.c
pef.h
pei-arm-wince.c
pei-arm.c
pei-i386.c
pei-ia64.c
pei-mcore.c
pei-ppc.c
pei-sh.c
pei-x86_64.c BFD whitespace fixes 2019-04-03 12:50:39 +10:30
peicode.h
peXXigen.c
plugin.c PR24511, nm should not mark symbols in .init_array as "t" 2019-05-04 16:57:33 +09:30
plugin.h
PORTING
ppcboot.c
ptrace-core.c
README
reloc16.c
reloc.c [PowerPC64] pc-relative TLS relocations 2019-07-19 18:01:25 +09:30
rs6000-core.c
sco5-core.c
section.c
simple.c
som.c bfdtest1 segfaults on hppa-hp-hpux10 2019-05-22 18:33:39 +09:30
som.h
srec.c
stab-syms.c
stabs.c
stamp-h.in
syms.c PR24511, nm should not mark symbols in .init_array as "t" 2019-05-04 16:57:33 +09:30
sysdep.h
targets.c Plugin target handling 2019-06-28 10:18:49 +09:30
targmatch.sed
tekhex.c
TODO
trad-core.c
vax1knetbsd.c
vaxnetbsd.c
verilog.c Add new option to objcopy: --verilog-data-width. Use this option to set the size of byte bundles generated in verilog format files. 2019-05-14 10:42:25 +01:00
version.h Automatic date update in version.in 2019-07-19 00:00:39 +00:00
version.m4
vms-alpha.c vms-alpha gas segfault 2019-05-22 18:33:39 +09:30
vms-lib.c
vms-misc.c
vms.h
warning.m4
wasm-module.c
wasm-module.h
xcofflink.c XCOFF linker segmentation fault 2019-05-28 10:05:02 +09:30
xsym.c
xsym.h
xtensa-isa.c
xtensa-modules.c

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

BFD is an object file library.  It permits applications to use the
same routines to process object files regardless of their format.

BFD is used by the GNU debugger, assembler, linker, and the binary
utilities.

The documentation on using BFD is scanty and may be occasionally
incorrect.  Pointers to documentation problems, or an entirely
rewritten manual, would be appreciated.

There is some BFD internals documentation in doc/bfdint.texi which may
help programmers who want to modify BFD.

BFD is normally built as part of another package.  See the build
instructions for that package, probably in a README file in the
appropriate directory.

BFD supports the following configure options:

  --target=TARGET
	The default target for which to build the library.  TARGET is
	a configuration target triplet, such as sparc-sun-solaris.
  --enable-targets=TARGET,TARGET,TARGET...
	Additional targets the library should support.  To include
	support for all known targets, use --enable-targets=all.
  --enable-64-bit-bfd
	Include support for 64 bit targets.  This is automatically
	turned on if you explicitly request a 64 bit target, but not
	for --enable-targets=all.  This requires a compiler with a 64
	bit integer type, such as gcc.
  --enable-shared
	Build BFD as a shared library.
  --with-mmap
	Use mmap when accessing files.  This is faster on some hosts,
	but slower on others.  It may not work on all hosts.

Report bugs with BFD to bug-binutils@gnu.org.

Patches are encouraged.  When sending patches, always send the output
of diff -u or diff -c from the original file to the new file.  Do not
send default diff output.  Do not make the diff from the new file to
the original file.  Remember that any patch must not break other
systems.  Remember that BFD must support cross compilation from any
host to any target, so patches which use ``#ifdef HOST'' are not
acceptable.  Please also read the ``Reporting Bugs'' section of the
gcc manual.

Bug reports without patches will be remembered, but they may never get
fixed until somebody volunteers to fix them.

Copyright (C) 2012-2019 Free Software Foundation, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.