binutils-gdb/gdb/testsuite/boards/gdbserver-base.exp
Simon Marchi e4fe375676 Don't redefine upload/download/file in gdbserver-base
Before patch

  Make native gdbserver boards no longer be "remote" (in DejaGnu terms)
  739b3f1d8f

the local gdbserver boards (except native-extended-gdbserver...) were
considered as remote by DejaGNU.  To avoid DejaGNU trying to use ssh/scp
to download the files to the target (which is actually local), the
gdbserver-base.exp file defined some _download, _upload and _file board
operations to override the default behavior, and instead just use local
operations.

The same patch also changed remote-stdio-gdbserver.exp to make it
inherit from gdbserver-base.exp.  Since then, this board (which is
actually remote) uses the overrides with local file operations.  As a
result, files are never actually copied to the target.

I think we can simply remove the overrides from gdbserver-base.exp.
Because all boards should be properly considered local or remote by
DejaGNU, it should by default use the right method for transferring
files.

gdb/testsuite/ChangeLog:

	PR gdb/22841
	* boards/gdbserver-base.exp (${board}_file, ${board}_download,
	${board}_upload): Remove.
2018-03-08 17:53:57 -05:00

35 lines
1.3 KiB
Plaintext

# Copyright 2011-2018 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# This file has common bits shared between other dejagnu "board files"
# that are used to run the testsuite with gdbserver.
process_multilib_options ""
# The default compiler for this target.
set_board_info compiler "[find_gcc]"
# Test the copy of gdbserver in the build directory.
set_board_info gdb_server_prog "[pwd]/../gdbserver/gdbserver"
# gdbserver does not intercept target file operations and perform them
# on the host.
set_board_info gdb,nofileio 1
# The predefined TSVs in GDBserver.
set_board_info gdb,predefined_tsv "\\\$trace_timestamp"
set GDBFLAGS "${GDBFLAGS} -ex \"set auto-connect-native-target off\""