binutils-gdb/gdb/common
Pedro Alves 56be6ea89c Some gdb_exception{,error,quit} tweaks
- Explicitly include <string> for std::string.

- Use std::make_shared to construct gdb_exception::message instead of
  operator new, avoiding one heap allocation (2 instead of 3).  Add
  'const char *fmt, va_list ap' parameters to
  gdb_exception{,error,quit}'s ctors, and do the std::make_shared in
  the gdb_exception ctor.

- gdb_exception_error's constructor does not need to have an 'enum
  return_reason' parameter, since it is always RETURN_ERROR, by
  definition.

- Similarly, gdb_exception_quit's contructor does not need to have
  'enum return_reason'/'enum errors' parameters.

- In the gdb_exception_{quit,_error} ctors that take a gdb_exception
  as argument, assert that they're being passed a gdb_exception object
  of the right 'reason'.

gdb/ChangeLog:
2019-04-08  Pedro Alves  <palves@redhat.com>

	* common/common-exceptions.c (throw_exception): Don't create
	named object to throw; throw directly.
	(throw_it): Likewise.  Don't initialize gdb_exception::message
	here, with new; pass FMT and AP to the ctor instead.
	* common/common-exceptions.h: Include <string>.
	(gdb_exception::gdb_exception(enum return_reason, enum errors,
	const char *, va_list)): New ctor.  Use std::make_shared.
	(gdb_exception_error::gdb_exception_error(enum return_reason, enum
	errors)): Delete.
	(gdb_exception_error::gdb_exception_error(enum errors, const char
	*, va_list)): New.
	(gdb_exception_error::gdb_exception_error(const gdb_exception &)):
	Add assertion.
	(gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
	errors)): Delete.
	(gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
	(gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
	Add assertion.
2019-04-08 20:13:32 +01:00
..
agent.c
agent.h
array-view.h
ax.def
break-common.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
btrace-common.c
btrace-common.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
buffer.c
buffer.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
byte-vector.h
cleanups.c Remove basic cleanup code 2019-03-06 16:04:31 -07:00
cleanups.h Remove basic cleanup code 2019-03-06 16:04:31 -07:00
common-debug.c
common-debug.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
common-defs.h Introduce ATTRIBUTE_UNUSED_RESULT and use it 2019-03-05 08:48:39 -07:00
common-exceptions.c Some gdb_exception{,error,quit} tweaks 2019-04-08 20:13:32 +01:00
common-exceptions.h Some gdb_exception{,error,quit} tweaks 2019-04-08 20:13:32 +01:00
common-gdbthread.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
common-inferior.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
common-regcache.c
common-regcache.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
common-types.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
common-utils.c
common-utils.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
common.host
common.m4
create-version.sh Update create-version.sh to use common/version.h 2019-01-25 15:28:16 -07:00
def-vector.h
default-init-alloc.h
enum-flags.h
environ.c
environ.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
errors.c
errors.h
fileio.c
fileio.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
filestuff.c Remove last cleanup from linux-namespaces.c 2019-03-06 16:04:31 -07:00
filestuff.h Remove last cleanup from linux-namespaces.c 2019-03-06 16:04:31 -07:00
filtered-iterator.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
format.c
format.h
forward-scope-exit.h Fix clang/libc++ build 2019-01-24 18:01:49 +00:00
function-view.h
gdb_assert.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
gdb_locale.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
gdb_optional.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
gdb_proc_service.h
gdb_ref_ptr.h Add ATTRIBUTE_UNUSED_RESULT to ref_ptr::release 2019-03-05 08:48:40 -07:00
gdb_setjmp.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
gdb_signals.h
gdb_splay_tree.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
gdb_string_view.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
gdb_string_view.tcc
gdb_sys_time.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
gdb_tilde_expand.c
gdb_tilde_expand.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
gdb_unique_ptr.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
gdb_unlinker.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
gdb_vecs.c
gdb_vecs.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
gdb_wait.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
hash_enum.h
host-defs.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
job-control.c
job-control.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
mingw-strerror.c
netstuff.c Fix GDB compilation on MinGW (PR gdb/24292) 2019-03-02 15:13:54 +02:00
netstuff.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
new-op.c Rename gdb exception types 2019-04-08 09:05:40 -06:00
next-iterator.h
observable.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
offset-type.h
pathstuff.c Add a new function child_path. 2019-02-12 13:56:16 -08:00
pathstuff.h Add a new function child_path. 2019-02-12 13:56:16 -08:00
poison.h
posix-strerror.c
preprocessor.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
print-utils.c
print-utils.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
ptid.c Make null_ptid and minus_one_ptid "const" 2019-03-12 10:45:37 -06:00
ptid.h Make null_ptid and minus_one_ptid "const" 2019-03-12 10:45:37 -06:00
queue.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
refcounted-object.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
rsp-low.c
rsp-low.h
run-time-clock.c
run-time-clock.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
safe-iterator.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
scope-exit.h Introduce scope_exit 2019-01-23 19:02:58 +00:00
scoped_fd.h Add ATTRIBUTE_UNUSED_RESULT to scoped_fd 2019-03-05 08:48:40 -07:00
scoped_mmap.c
scoped_mmap.h Add ATTRIBUTE_UNUSED_RESULT to scoped_mmap 2019-03-05 08:48:40 -07:00
scoped_restore.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
selftest.c Rename gdb exception types 2019-04-08 09:05:40 -06:00
selftest.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
signals-state-save-restore.c
signals-state-save-restore.h
signals.c
symbol.h
tdesc.c
tdesc.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
traits.h
underlying.h
valid-expr.h Rename ESC -> ESC_PARENS 2019-01-23 18:58:28 +00:00
vec.c
vec.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
version.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
x86-xstate.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00
xml-utils.c
xml-utils.h Normalize include guards in gdb 2019-02-07 03:27:23 -07:00