mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-24 12:35:55 +08:00
0726fcc61a
Fix a commit f90183d7e3 ("Get GDBserver pid on remote target") bug and
correctly handle the case where the PID of `gdbserver' could not have
been retrieved. If that happens, $server_pid is unset causing:
FAIL: gdb.server/server-kill.exp: p server_pid
ERROR: tcl error sourcing .../gdb/testsuite/gdb.server/server-kill.exp.
ERROR: can't read "server_pid": no such variable
while executing
"if {$server_pid == "" } {
return -1
}"
(file ".../gdb/testsuite/gdb.server/server-kill.exp" line 49)
invoked from within
"source .../gdb/testsuite/gdb.server/server-kill.exp"
("uplevel" body line 1)
invoked from within
"uplevel #0 source .../gdb/testsuite/gdb.server/server-kill.exp"
invoked from within
"catch "uplevel #0 source $test_file_name""
Verify that the variable exists then rather than trying to access it.
gdb/testsuite/
* gdb.server/server-kill.exp: Verify whether `server_pid' exists
rather then trying to access it in determining whether the PID
of `gdbserver' could have been retrieved.
63 lines
1.9 KiB
Plaintext
63 lines
1.9 KiB
Plaintext
# This testcase is part of GDB, the GNU debugger.
|
|
#
|
|
# Copyright 2013-2018 Free Software Foundation, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
load_lib gdbserver-support.exp
|
|
|
|
standard_testfile
|
|
|
|
if {[skip_gdbserver_tests]} {
|
|
return 0
|
|
}
|
|
|
|
if { [prepare_for_testing "failed to prepare" ${testfile}] } {
|
|
return -1
|
|
}
|
|
|
|
# Make sure we're disconnected, in case we're testing with an
|
|
# extended-remote board, therefore already connected.
|
|
gdb_test "disconnect" ".*"
|
|
|
|
gdbserver_run ""
|
|
|
|
# Continue past server_pid assignment.
|
|
gdb_breakpoint ${srcfile}:[gdb_get_line_number "i = 0;"]
|
|
gdb_continue_to_breakpoint "after server_pid assignment"
|
|
|
|
# Get the pid of GDBServer.
|
|
set test "p server_pid"
|
|
gdb_test_multiple $test $test {
|
|
-re " = ($decimal)\r\n$gdb_prompt $" {
|
|
set server_pid $expect_out(1,string)
|
|
pass $test
|
|
}
|
|
}
|
|
|
|
if ![info exists server_pid] {
|
|
return -1
|
|
}
|
|
|
|
remote_exec target "kill -9 $server_pid"
|
|
|
|
# Enable trace status packet which is disabled after the connection
|
|
# if the remote target doesn't support tracepoint at all. Otherwise,
|
|
# no RSP packet is sent out.
|
|
gdb_test_no_output "set remote trace-status-packet on"
|
|
|
|
# Force GDB to talk with GDBserver, so that we can get the
|
|
# "connection closed" error.
|
|
gdb_test "tstatus" {Remote connection closed|Remote communication error\. Target disconnected\.: Connection reset by peer\.}
|