mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
ebf0b03c70
Remove an inconsistency in linker error message processing causing that it depends on the ability to infer the name of the originating source file whether or not the name of the offending function is repeated by clever formatters for each issue reported within the function. Taking the `ld/testsuite/ld-powerpc/tocopt7.s' test case source as an example and the `powerpc-linux' target we have: $ as -gdwarf2 -o tocopt.o -a64 tocopt.s $ ld -o tocopt -melf64ppc tocopt.o tocopt.o: In function `_start': tocopt.s:35:(.text+0x14): toc optimization is not supported for 0x3fa00000 instruction. tocopt.s:49:(.text+0x34): toc optimization is not supported for 0x3fa00000 instruction. $ vs: $ as -o tocopt.o -a64 tocopt.s $ ld -o tocopt -melf64ppc tocopt.o tocopt.o: In function `_start': (.text+0x14): toc optimization is not supported for 0x3fa00000 instruction. tocopt.o: In function `_start': (.text+0x34): toc optimization is not supported for 0x3fa00000 instruction. $ Similarly with the `mips-linux' target and this source: $ cat jal-global-multi-overflow.s .text .set noreorder .space 0x2000 .align 4 .globl foo .ent foo foo: jal bar nor $0, $0 jal bar nor $0, $0 .end foo .space 0x1ff0 .align 4 .globl bar .ent bar bar: jal foo nor $0, $0 jal foo nor $0, $0 .end bar $ as -o jal-global-multi-overflow.o jal-global-multi-overflow.s $ ld -Ttext 0x1fffd000 -e foo -o jal-global-multi-overflow jal-global-multi-overflow.o jal-global-multi-overflow.o: In function `foo': (.text+0x2000): relocation truncated to fit: R_MIPS_26 against `bar' jal-global-multi-overflow.o: In function `foo': (.text+0x2008): relocation truncated to fit: R_MIPS_26 against `bar' jal-global-multi-overflow.o: In function `bar': (.text+0x4000): relocation truncated to fit: R_MIPS_26 against `foo' jal-global-multi-overflow.o: In function `bar': (.text+0x4008): relocation truncated to fit: R_MIPS_26 against `foo' $ Not only this is inconsistent, but it causes output clutter as well with redundant information. The cause for this is a check in `vfinfo' the intent of which is to print the function heading whenever (among others) the name of the source file has changed, which however does not take into account a situation where the name couldn't have been established both now and previously. Adjust the check then for this situation, yielding: $ as -o tocopt.o -a64 tocopt.s $ ld -o tocopt -melf64ppc tocopt.o tocopt.o: In function `_start': (.text+0x14): toc optimization is not supported for 0x3fa00000 instruction. (.text+0x34): toc optimization is not supported for 0x3fa00000 instruction. $ and: $ as -o jal-global-multi-overflow.o jal-global-multi-overflow.s $ ld -Ttext 0x1fffd000 -e foo -o jal-global-multi-overflow jal-global-multi-overflow.o jal-global-multi-overflow.o: In function `foo': (.text+0x2000): relocation truncated to fit: R_MIPS_26 against `bar' (.text+0x2008): relocation truncated to fit: R_MIPS_26 against `bar' jal-global-multi-overflow.o: In function `bar': (.text+0x4000): relocation truncated to fit: R_MIPS_26 against `foo' (.text+0x4008): relocation truncated to fit: R_MIPS_26 against `foo' $ respectively instead. Adjust the test suite accordingly. ld/ * ldmisc.c (vfinfo): Don't print the function name again either if no source file name has been found both now and previously. * testsuite/ld-cris/tls-err-20x.d: Adjust accordingly. * testsuite/ld-mips-elf/mode-change-error-1.d: Likewise. * testsuite/ld-mips-elf/unaligned-branch.d: Likewise. * testsuite/ld-mips-elf/unaligned-branch-mips16.d: Likewise. * testsuite/ld-mips-elf/unaligned-branch-micromips.d: Likewise. * testsuite/ld-mips-elf/unaligned-branch-r6-1.d: Likewise. * testsuite/ld-mips-elf/unaligned-branch-2.d: Likewise. * testsuite/ld-mips-elf/unaligned-branch-r6-2.d: Likewise. * testsuite/ld-mips-elf/unaligned-branch-ignore-2.d: Likewise. * testsuite/ld-mips-elf/unaligned-branch-ignore-mips16.d: Likewise. * testsuite/ld-mips-elf/unaligned-branch-ignore-micromips.d: Likewise. * testsuite/ld-mips-elf/unaligned-branch-ignore-r6-1.d: Likewise. * testsuite/ld-mips-elf/unaligned-jalx-addend-1.d: Likewise. * testsuite/ld-mips-elf/unaligned-jalx-addend-mips16-1.d: Likewise. * testsuite/ld-mips-elf/unaligned-jalx-addend-micromips-1.d: Likewise. * testsuite/ld-mips-elf/unaligned-jalx-addend-3.d: Likewise. * testsuite/ld-mips-elf/unaligned-jump.d: Likewise. * testsuite/ld-mips-elf/unaligned-jump-mips16.d: Likewise. * testsuite/ld-mips-elf/unaligned-jump-micromips.d: Likewise. * testsuite/ld-mips-elf/unaligned-lwpc-1.d: Likewise. * testsuite/ld-mips-elf/unaligned-ldpc-1.d: Likewise. * testsuite/ld-powerpc/tocopt.out: Likewise. * testsuite/ld-powerpc/tocopt7.out: Likewise.
548 lines
12 KiB
C
548 lines
12 KiB
C
/* ldmisc.c
|
||
Copyright (C) 1991-2017 Free Software Foundation, Inc.
|
||
Written by Steve Chamberlain of Cygnus Support.
|
||
|
||
This file is part of the GNU Binutils.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program; if not, write to the Free Software
|
||
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
||
MA 02110-1301, USA. */
|
||
|
||
#include "sysdep.h"
|
||
#include "bfd.h"
|
||
#include "bfdlink.h"
|
||
#include "libiberty.h"
|
||
#include "filenames.h"
|
||
#include "demangle.h"
|
||
#include <stdarg.h>
|
||
#include "ld.h"
|
||
#include "ldmisc.h"
|
||
#include "ldexp.h"
|
||
#include "ldlang.h"
|
||
#include <ldgram.h>
|
||
#include "ldlex.h"
|
||
#include "ldmain.h"
|
||
#include "ldfile.h"
|
||
#include "elf-bfd.h"
|
||
#include "coff-bfd.h"
|
||
|
||
/*
|
||
%% literal %
|
||
%A section name from a section
|
||
%B filename from a bfd
|
||
%C clever filename:linenumber with function
|
||
%D like %C, but no function name
|
||
%E current bfd error or errno
|
||
%F error is fatal
|
||
%G like %D, but only function name
|
||
%H like %C but in addition emit section+offset
|
||
%I filename from a lang_input_statement_type
|
||
%P print program name
|
||
%R info about a relent
|
||
%S print script file and linenumber from etree_type.
|
||
%T symbol name
|
||
%V hex bfd_vma
|
||
%W hex bfd_vma with 0x with no leading zeros taking up 8 spaces
|
||
%X no object output, fail return
|
||
%d integer, like printf
|
||
%ld long, like printf
|
||
%lu unsigned long, like printf
|
||
%p native (host) void* pointer, like printf
|
||
%s arbitrary string, like printf
|
||
%u integer, like printf
|
||
%v hex bfd_vma, no leading zeros
|
||
*/
|
||
|
||
void
|
||
vfinfo (FILE *fp, const char *fmt, va_list arg, bfd_boolean is_warning)
|
||
{
|
||
bfd_boolean fatal = FALSE;
|
||
|
||
while (*fmt != '\0')
|
||
{
|
||
const char *str = fmt;
|
||
while (*fmt != '%' && *fmt != '\0')
|
||
fmt++;
|
||
if (fmt != str)
|
||
if (fwrite (str, 1, fmt - str, fp))
|
||
{
|
||
/* Ignore. */
|
||
}
|
||
|
||
if (*fmt == '%')
|
||
{
|
||
fmt++;
|
||
switch (*fmt++)
|
||
{
|
||
case '%':
|
||
/* literal % */
|
||
putc ('%', fp);
|
||
break;
|
||
|
||
case 'X':
|
||
/* no object output, fail return */
|
||
config.make_executable = FALSE;
|
||
break;
|
||
|
||
case 'V':
|
||
/* hex bfd_vma */
|
||
{
|
||
bfd_vma value = va_arg (arg, bfd_vma);
|
||
fprintf_vma (fp, value);
|
||
}
|
||
break;
|
||
|
||
case 'v':
|
||
/* hex bfd_vma, no leading zeros */
|
||
{
|
||
char buf[100];
|
||
char *p = buf;
|
||
bfd_vma value = va_arg (arg, bfd_vma);
|
||
sprintf_vma (p, value);
|
||
while (*p == '0')
|
||
p++;
|
||
if (!*p)
|
||
p--;
|
||
fputs (p, fp);
|
||
}
|
||
break;
|
||
|
||
case 'W':
|
||
/* hex bfd_vma with 0x with no leading zeroes taking up
|
||
8 spaces. */
|
||
{
|
||
char buf[100];
|
||
bfd_vma value;
|
||
char *p;
|
||
int len;
|
||
|
||
value = va_arg (arg, bfd_vma);
|
||
sprintf_vma (buf, value);
|
||
for (p = buf; *p == '0'; ++p)
|
||
;
|
||
if (*p == '\0')
|
||
--p;
|
||
len = strlen (p);
|
||
while (len < 8)
|
||
{
|
||
putc (' ', fp);
|
||
++len;
|
||
}
|
||
fprintf (fp, "0x%s", p);
|
||
}
|
||
break;
|
||
|
||
case 'T':
|
||
/* Symbol name. */
|
||
{
|
||
const char *name = va_arg (arg, const char *);
|
||
|
||
if (name == NULL || *name == 0)
|
||
{
|
||
fprintf (fp, _("no symbol"));
|
||
break;
|
||
}
|
||
else if (demangling)
|
||
{
|
||
char *demangled;
|
||
|
||
demangled = bfd_demangle (link_info.output_bfd, name,
|
||
DMGL_ANSI | DMGL_PARAMS);
|
||
if (demangled != NULL)
|
||
{
|
||
fprintf (fp, "%s", demangled);
|
||
free (demangled);
|
||
break;
|
||
}
|
||
}
|
||
fprintf (fp, "%s", name);
|
||
}
|
||
break;
|
||
|
||
case 'A':
|
||
/* section name from a section */
|
||
{
|
||
asection *sec = va_arg (arg, asection *);
|
||
bfd *abfd = sec->owner;
|
||
const char *group = NULL;
|
||
struct coff_comdat_info *ci;
|
||
|
||
fprintf (fp, "%s", sec->name);
|
||
if (abfd != NULL
|
||
&& bfd_get_flavour (abfd) == bfd_target_elf_flavour
|
||
&& elf_next_in_group (sec) != NULL
|
||
&& (sec->flags & SEC_GROUP) == 0)
|
||
group = elf_group_name (sec);
|
||
else if (abfd != NULL
|
||
&& bfd_get_flavour (abfd) == bfd_target_coff_flavour
|
||
&& (ci = bfd_coff_get_comdat_section (sec->owner,
|
||
sec)) != NULL)
|
||
group = ci->name;
|
||
if (group != NULL)
|
||
fprintf (fp, "[%s]", group);
|
||
}
|
||
break;
|
||
|
||
case 'B':
|
||
/* filename from a bfd */
|
||
{
|
||
bfd *abfd = va_arg (arg, bfd *);
|
||
|
||
if (abfd == NULL)
|
||
fprintf (fp, "%s generated", program_name);
|
||
else if (abfd->my_archive != NULL
|
||
&& !bfd_is_thin_archive (abfd->my_archive))
|
||
fprintf (fp, "%s(%s)", abfd->my_archive->filename,
|
||
abfd->filename);
|
||
else
|
||
fprintf (fp, "%s", abfd->filename);
|
||
}
|
||
break;
|
||
|
||
case 'F':
|
||
/* Error is fatal. */
|
||
fatal = TRUE;
|
||
break;
|
||
|
||
case 'P':
|
||
/* Print program name. */
|
||
fprintf (fp, "%s", program_name);
|
||
break;
|
||
|
||
case 'E':
|
||
/* current bfd error or errno */
|
||
fprintf (fp, "%s", bfd_errmsg (bfd_get_error ()));
|
||
break;
|
||
|
||
case 'I':
|
||
/* filename from a lang_input_statement_type */
|
||
{
|
||
lang_input_statement_type *i;
|
||
|
||
i = va_arg (arg, lang_input_statement_type *);
|
||
if (i->the_bfd->my_archive != NULL
|
||
&& !bfd_is_thin_archive (i->the_bfd->my_archive))
|
||
fprintf (fp, "(%s)",
|
||
bfd_get_filename (i->the_bfd->my_archive));
|
||
fprintf (fp, "%s", i->local_sym_name);
|
||
if ((i->the_bfd->my_archive == NULL
|
||
|| bfd_is_thin_archive (i->the_bfd->my_archive))
|
||
&& filename_cmp (i->local_sym_name, i->filename) != 0)
|
||
fprintf (fp, " (%s)", i->filename);
|
||
}
|
||
break;
|
||
|
||
case 'S':
|
||
/* Print script file and linenumber. */
|
||
{
|
||
etree_type node;
|
||
etree_type *tp = va_arg (arg, etree_type *);
|
||
|
||
if (tp == NULL)
|
||
{
|
||
tp = &node;
|
||
tp->type.filename = ldlex_filename ();
|
||
tp->type.lineno = lineno;
|
||
}
|
||
if (tp->type.filename != NULL)
|
||
fprintf (fp, "%s:%u", tp->type.filename, tp->type.lineno);
|
||
}
|
||
break;
|
||
|
||
case 'R':
|
||
/* Print all that's interesting about a relent. */
|
||
{
|
||
arelent *relent = va_arg (arg, arelent *);
|
||
|
||
lfinfo (fp, "%s+0x%v (type %s)",
|
||
(*(relent->sym_ptr_ptr))->name,
|
||
relent->addend,
|
||
relent->howto->name);
|
||
}
|
||
break;
|
||
|
||
case 'C':
|
||
case 'D':
|
||
case 'G':
|
||
case 'H':
|
||
/* Clever filename:linenumber with function name if possible.
|
||
The arguments are a BFD, a section, and an offset. */
|
||
{
|
||
static bfd *last_bfd;
|
||
static char *last_file;
|
||
static char *last_function;
|
||
bfd *abfd;
|
||
asection *section;
|
||
bfd_vma offset;
|
||
asymbol **asymbols = NULL;
|
||
const char *filename;
|
||
const char *functionname;
|
||
unsigned int linenumber;
|
||
bfd_boolean discard_last;
|
||
bfd_boolean done;
|
||
|
||
abfd = va_arg (arg, bfd *);
|
||
section = va_arg (arg, asection *);
|
||
offset = va_arg (arg, bfd_vma);
|
||
|
||
if (abfd != NULL)
|
||
{
|
||
if (!bfd_generic_link_read_symbols (abfd))
|
||
einfo (_("%B%F: could not read symbols: %E\n"), abfd);
|
||
|
||
asymbols = bfd_get_outsymbols (abfd);
|
||
}
|
||
|
||
/* The GNU Coding Standard requires that error messages
|
||
be of the form:
|
||
|
||
source-file-name:lineno: message
|
||
|
||
We do not always have a line number available so if
|
||
we cannot find them we print out the section name and
|
||
offset instead. */
|
||
discard_last = TRUE;
|
||
if (abfd != NULL
|
||
&& bfd_find_nearest_line (abfd, section, asymbols, offset,
|
||
&filename, &functionname,
|
||
&linenumber))
|
||
{
|
||
if (functionname != NULL
|
||
&& (fmt[-1] == 'C' || fmt[-1] == 'H'))
|
||
{
|
||
/* Detect the case where we are printing out a
|
||
message for the same function as the last
|
||
call to vinfo ("%C"). In this situation do
|
||
not print out the ABFD filename or the
|
||
function name again. Note - we do still
|
||
print out the source filename, as this will
|
||
allow programs that parse the linker's output
|
||
(eg emacs) to correctly locate multiple
|
||
errors in the same source file. */
|
||
if (last_bfd == NULL
|
||
|| last_function == NULL
|
||
|| last_bfd != abfd
|
||
|| (last_file == NULL) != (filename == NULL)
|
||
|| (filename != NULL
|
||
&& filename_cmp (last_file, filename) != 0)
|
||
|| strcmp (last_function, functionname) != 0)
|
||
{
|
||
lfinfo (fp, _("%B: In function `%T':\n"),
|
||
abfd, functionname);
|
||
|
||
last_bfd = abfd;
|
||
if (last_file != NULL)
|
||
free (last_file);
|
||
last_file = NULL;
|
||
if (filename)
|
||
last_file = xstrdup (filename);
|
||
if (last_function != NULL)
|
||
free (last_function);
|
||
last_function = xstrdup (functionname);
|
||
}
|
||
discard_last = FALSE;
|
||
}
|
||
else
|
||
lfinfo (fp, "%B:", abfd);
|
||
|
||
if (filename != NULL)
|
||
fprintf (fp, "%s:", filename);
|
||
|
||
done = fmt[-1] != 'H';
|
||
if (functionname != NULL && fmt[-1] == 'G')
|
||
lfinfo (fp, "%T", functionname);
|
||
else if (filename != NULL && linenumber != 0)
|
||
fprintf (fp, "%u%s", linenumber, done ? "" : ":");
|
||
else
|
||
done = FALSE;
|
||
}
|
||
else
|
||
{
|
||
lfinfo (fp, "%B:", abfd);
|
||
done = FALSE;
|
||
}
|
||
if (!done)
|
||
lfinfo (fp, "(%A+0x%v)", section, offset);
|
||
|
||
if (discard_last)
|
||
{
|
||
last_bfd = NULL;
|
||
if (last_file != NULL)
|
||
{
|
||
free (last_file);
|
||
last_file = NULL;
|
||
}
|
||
if (last_function != NULL)
|
||
{
|
||
free (last_function);
|
||
last_function = NULL;
|
||
}
|
||
}
|
||
}
|
||
break;
|
||
|
||
case 'p':
|
||
/* native (host) void* pointer, like printf */
|
||
fprintf (fp, "%p", va_arg (arg, void *));
|
||
break;
|
||
|
||
case 's':
|
||
/* arbitrary string, like printf */
|
||
fprintf (fp, "%s", va_arg (arg, char *));
|
||
break;
|
||
|
||
case 'd':
|
||
/* integer, like printf */
|
||
fprintf (fp, "%d", va_arg (arg, int));
|
||
break;
|
||
|
||
case 'u':
|
||
/* unsigned integer, like printf */
|
||
fprintf (fp, "%u", va_arg (arg, unsigned int));
|
||
break;
|
||
|
||
case 'l':
|
||
if (*fmt == 'd')
|
||
{
|
||
fprintf (fp, "%ld", va_arg (arg, long));
|
||
++fmt;
|
||
break;
|
||
}
|
||
else if (*fmt == 'u')
|
||
{
|
||
fprintf (fp, "%lu", va_arg (arg, unsigned long));
|
||
++fmt;
|
||
break;
|
||
}
|
||
/* Fallthru */
|
||
|
||
default:
|
||
fprintf (fp, "%%%c", fmt[-1]);
|
||
break;
|
||
}
|
||
}
|
||
}
|
||
|
||
if (is_warning && config.fatal_warnings)
|
||
config.make_executable = FALSE;
|
||
|
||
if (fatal)
|
||
xexit (1);
|
||
}
|
||
|
||
/* Format info message and print on stdout. */
|
||
|
||
/* (You would think this should be called just "info", but then you
|
||
would be hosed by LynxOS, which defines that name in its libc.) */
|
||
|
||
void
|
||
info_msg (const char *fmt, ...)
|
||
{
|
||
va_list arg;
|
||
|
||
va_start (arg, fmt);
|
||
vfinfo (stdout, fmt, arg, FALSE);
|
||
va_end (arg);
|
||
}
|
||
|
||
/* ('e' for error.) Format info message and print on stderr. */
|
||
|
||
void
|
||
einfo (const char *fmt, ...)
|
||
{
|
||
va_list arg;
|
||
|
||
fflush (stdout);
|
||
va_start (arg, fmt);
|
||
vfinfo (stderr, fmt, arg, TRUE);
|
||
va_end (arg);
|
||
fflush (stderr);
|
||
}
|
||
|
||
void
|
||
info_assert (const char *file, unsigned int line)
|
||
{
|
||
einfo (_("%F%P: internal error %s %d\n"), file, line);
|
||
}
|
||
|
||
/* ('m' for map) Format info message and print on map. */
|
||
|
||
void
|
||
minfo (const char *fmt, ...)
|
||
{
|
||
if (config.map_file != NULL)
|
||
{
|
||
va_list arg;
|
||
|
||
va_start (arg, fmt);
|
||
if (fmt[0] == '%' && fmt[1] == '!' && fmt[2] == 0)
|
||
{
|
||
/* Stash info about --as-needed shared libraries. Print
|
||
later so they don't appear intermingled with archive
|
||
library info. */
|
||
struct asneeded_minfo *m = xmalloc (sizeof *m);
|
||
|
||
m->next = NULL;
|
||
m->soname = va_arg (arg, const char *);
|
||
m->ref = va_arg (arg, bfd *);
|
||
m->name = va_arg (arg, const char *);
|
||
*asneeded_list_tail = m;
|
||
asneeded_list_tail = &m->next;
|
||
}
|
||
else
|
||
vfinfo (config.map_file, fmt, arg, FALSE);
|
||
va_end (arg);
|
||
}
|
||
}
|
||
|
||
void
|
||
lfinfo (FILE *file, const char *fmt, ...)
|
||
{
|
||
va_list arg;
|
||
|
||
va_start (arg, fmt);
|
||
vfinfo (file, fmt, arg, FALSE);
|
||
va_end (arg);
|
||
}
|
||
|
||
/* Functions to print the link map. */
|
||
|
||
void
|
||
print_space (void)
|
||
{
|
||
fprintf (config.map_file, " ");
|
||
}
|
||
|
||
void
|
||
print_nl (void)
|
||
{
|
||
fprintf (config.map_file, "\n");
|
||
}
|
||
|
||
/* A more or less friendly abort message. In ld.h abort is defined to
|
||
call this function. */
|
||
|
||
void
|
||
ld_abort (const char *file, int line, const char *fn)
|
||
{
|
||
if (fn != NULL)
|
||
einfo (_("%P: internal error: aborting at %s:%d in %s\n"),
|
||
file, line, fn);
|
||
else
|
||
einfo (_("%P: internal error: aborting at %s:%d\n"),
|
||
file, line);
|
||
einfo (_("%P%F: please report this bug\n"));
|
||
xexit (1);
|
||
}
|