mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 04:31:49 +08:00
ee2a6fc604
I ran into:
...
Thread 3.1 "watchpoint-fork" hit Breakpoint 3, marker () at \
watchpoint-fork-mt.c:42^M
42 }^M
(gdb) parent2: 1945^M
FAIL: gdb.threads/watchpoint-fork.exp: child: multithreaded: breakpoint (A) \
after the second fork (timeout)
...
The problem is that the FAILing gdb_test expects '(gdb) ' to be the last thing
printed, but the inferior prints something after that.
A similar FAIL is described in the sources in watchpoint-fork-parent.c:
...
printf ("child%d: %d\n", nr, (int) getpid ());
/* Delay to get both the "child%d" and "parent%d" message printed
without a race breaking expect by its endless wait on `$gdb_prompt$':
Breakpoint 3, marker () at watchpoint-fork.c:33
33 }
(gdb) parent2: 14223 */
i = sleep (1);
...
I noticed that while the executables print output, the output is not verified in
the test-case, so it's merely debug output.
Fix this by:
- guarding the prints in the executables (as well as related
sleep and setbuf calls) with #if DEBUG, and
- compiling by default with DEBUG=0.
gdb/testsuite/ChangeLog:
2020-01-29 Tom de Vries <tdevries@suse.de>
* gdb.threads/watchpoint-fork-child.c: Guard prints with #if DEBUG.
* gdb.threads/watchpoint-fork-mt.c: Same.
* gdb.threads/watchpoint-fork-parent.c: Same.
* gdb.threads/watchpoint-fork-st.c: Same.
* gdb.threads/watchpoint-fork.exp: Compile with DEBUG=0.
Change-Id: I63efd4c7771f96b5f5cd87ef2ab36795484ae2be
77 lines
2.1 KiB
C
77 lines
2.1 KiB
C
/* Test case for forgotten hw-watchpoints after fork()-off of a process.
|
|
|
|
Copyright 2012-2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include <string.h>
|
|
#include <errno.h>
|
|
#include <sys/types.h>
|
|
#include <unistd.h>
|
|
#include <assert.h>
|
|
#include <stdio.h>
|
|
#include <sys/wait.h>
|
|
|
|
#include "watchpoint-fork.h"
|
|
|
|
void
|
|
forkoff (int nr)
|
|
{
|
|
pid_t child, pid_got;
|
|
int exit_code = 42 + nr;
|
|
int status, i;
|
|
|
|
child = fork ();
|
|
switch (child)
|
|
{
|
|
case -1:
|
|
assert (0);
|
|
case 0:
|
|
#if DEBUG
|
|
printf ("child%d: %d\n", nr, (int) getpid ());
|
|
/* Delay to get both the "child%d" and "parent%d" message printed without
|
|
a race breaking expect by its endless wait on `$gdb_prompt$':
|
|
Breakpoint 3, marker () at ../../../gdb/testsuite/gdb.threads/watchpoint-fork.c:33
|
|
33 }
|
|
(gdb) parent2: 14223 */
|
|
i = sleep (1);
|
|
assert (i == 0);
|
|
#endif
|
|
|
|
/* We must not get caught here (against a forgotten breakpoint). */
|
|
var++;
|
|
marker ();
|
|
|
|
_exit (exit_code);
|
|
default:
|
|
#if DEBUG
|
|
printf ("parent%d: %d\n", nr, (int) child);
|
|
/* Delay to get both the "child%d" and "parent%d" message printed, see
|
|
above. */
|
|
i = sleep (1);
|
|
assert (i == 0);
|
|
#endif
|
|
|
|
pid_got = wait (&status);
|
|
assert (pid_got == child);
|
|
assert (WIFEXITED (status));
|
|
assert (WEXITSTATUS (status) == exit_code);
|
|
|
|
/* We must get caught here (against a false watchpoint removal). */
|
|
marker ();
|
|
}
|
|
}
|