mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-06 12:09:26 +08:00
963eeee42a
When running test-case gdb.base/morestack.exp without the gold linker
installed, we run into:
...
Running src/gdb/testsuite/gdb.base/morestack.exp ...
gdb compile failed, collect2: fatal error: cannot find 'ld'
compilation terminated.
FAIL: gdb.base/morestack.exp: continue
=== gdb Summary ===
nr of expected passes 1
nr of unexpected failures 1
nr of untested testcases 1
...
The test-case needs the gold linker to run correctly (as explained in commit
b8d38ee425 "testsuite: Fix false FAIL for gdb.base/morestack.exp"), but
only prefers it, and doesn't require it.
Fix this by requiring the gold linker in the test-case. Furthermore, silence
the compilation error by introducing a caching proc have_fuse_ld_gold and
using it in this and other test-cases that use -fuse-ld=gold.
Tested on x86_64-linux.
gdb/testsuite/ChangeLog:
2020-07-13 Tom de Vries <tdevries@suse.de>
* lib/gdb.exp (have_fuse_ld_gold): New caching proc.
* gdb.base/gcore-tls-pie.exp: Use have_fuse_ld_gold.
* gdb.base/gold-gdb-index.exp: Same.
* gdb.base/morestack.exp: Same.
62 lines
1.7 KiB
Plaintext
62 lines
1.7 KiB
Plaintext
# Copyright (C) 2011-2020 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
if [get_compiler_info] {
|
|
return -1
|
|
}
|
|
|
|
if {$gcc_compiled == 0} {
|
|
return -1
|
|
}
|
|
|
|
if { [have_fuse_ld_gold] == 0} {
|
|
return -1
|
|
}
|
|
|
|
standard_testfile
|
|
|
|
# -fuse-ld=gold is used for calling printf code built without -fsplit-stack
|
|
# which could crash otherwise. See GCC documentation of -fsplit-stack.
|
|
set opts "additional_flags=-fsplit-stack"
|
|
if { [prepare_for_testing "failed to prepare" ${testfile} $srcfile \
|
|
[list $opts additional_flags=-fuse-ld=gold]] } {
|
|
return -1
|
|
}
|
|
|
|
if ![runto_main] {
|
|
return -1
|
|
}
|
|
|
|
gdb_breakpoint "marker_hit"
|
|
gdb_breakpoint "marker_miss"
|
|
|
|
set test "continue"
|
|
gdb_test_multiple $test $test {
|
|
-re "marker_hit.*$gdb_prompt $" {
|
|
pass $test
|
|
}
|
|
-re "marker_miss.*$gdb_prompt $" {
|
|
# The testcase failed to violated the frame_id_inner condition by
|
|
# handing inner frame with higher (on the stack-grows-down arches)
|
|
# $sp address than the outer frame.
|
|
xfail $test
|
|
return 0
|
|
}
|
|
}
|
|
|
|
# FAIL was on `bt' producing:
|
|
# Backtrace stopped: previous frame inner to this frame (corrupt stack?)
|
|
gdb_test "up 3000" " in main .*"
|