mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-06 12:09:26 +08:00
bbda248c50
The v850 testsuite code has been testing the $opt variable, but this
was never actually set anywhere globally or v850-specific. Instead,
this was a random variable leaking out of the sh testsuite code. As
far as I can tell, it has always been this way. That means the code
only ever tested the v850 cpu target (which is the default).
This failure can be easily seen in practice by running the v850 code
in isolation and seeing it crash:
$ runtest v850/allinsns.exp
...
Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using ../../../sim/testsuite/config/default.exp as tool-and-target-specific interface file.
WARNING: Assuming target board is the local machine (which is probably wrong).
You may need to set your DEJAGNU environment variable.
Running ../../../sim/testsuite/v850/allinsns.exp ...
ERROR: tcl error sourcing ../../../sim/testsuite/v850/allinsns.exp.
ERROR: tcl error code TCL LOOKUP VARNAME opt
ERROR: can't read "opt": no such variable
while executing
"switch -regexp -- $opt {
Backing up a bit, the reason for this logic in the first place is
because the common sim testsuite code makes an assumption about the
assembler options with cpu_option -- the option and its value are
always separated by an =. This is not the case with v850. So tweak
the core sim logic a bit to support omitting the = so that we can
switch v850 to the standard all_machs setting and avoid opt entirely.
|
||
|---|---|---|
| .. | ||
| aarch64 | ||
| arm | ||
| avr | ||
| bfin | ||
| bpf | ||
| common | ||
| config | ||
| cr16 | ||
| cris | ||
| d10v | ||
| example-synacor | ||
| frv | ||
| ft32 | ||
| h8300 | ||
| iq2000 | ||
| lib | ||
| lm32 | ||
| m32c | ||
| m32r | ||
| m68hc11 | ||
| mcore | ||
| microblaze | ||
| mips | ||
| mn10300 | ||
| moxie | ||
| msp430 | ||
| or1k | ||
| pru | ||
| riscv | ||
| sh | ||
| v850 | ||
| .gitignore | ||
| ChangeLog-2021 | ||
| local.mk | ||