mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 04:31:49 +08:00
cb001c0d28
The object_p (and archive_p, core_file_p) functions are not supposed to have any target specific malloc'd memory attached to the bfd on their return. This should be obvious on a failure return, but it's also true for a successful return. The reason is that even though the object_p recognises the file, that particular target may not be used and thus the bfd won't be closed calling close_and_cleanup for the target that allocated the memory. It turns out that the object_p bfd_target* return value isn't needed. In all cases except ld/plugin.c the target is abfd->xvec and with ld/plugin.c the target isn't used. So this patch returns a cleanup function from object_p instead, called in bfd_check_format_matches to tidy the bfd before trying a different target match. The only cleanup that does anything at this stage is the alpha-vms one. bfd/ * targets.c (bfd_cleanup): New typedef. (struct bfd <_bfd_check_format>): Return a bfd_cleanup. * libbfd-in.h (_bfd_no_cleanup): Define. * format.c (bfd_reinit): Add cleanup parameter, call it. (bfd_check_format_matches): Set cleanup from _bfd_check_format call and pass to bfd_reinit. Delete temp, use abfd->xvec instead. * aout-target.h (callback, object_p): Return bfd_cleanup. * aout-tic30.c (tic30_aout_callback, tic30_aout_object_p): Likewise. * archive.c (bfd_generic_archive_p): Likewise. * binary.c (binary_object_p): Likewise. * coff-alpha.c (alpha_ecoff_object_p): Likewise. * coff-ia64.c (ia64coff_object_p): Likewise. * coff-rs6000.c (_bfd_xcoff_archive_p, rs6000coff_core_p): Likewise. * coff-sh.c (coff_small_object_p): Likewise. * coff-stgo32.c (go32_check_format): Likewise. * coff64-rs6000.c (xcoff64_archive_p, rs6000coff_core_p), (xcoff64_core_p): Likewise. * coffgen.c (coff_real_object_p, coff_object_p): Likewise. * elf-bfd.h (bfd_elf32_object_p, bfd_elf32_core_file_p), (bfd_elf64_object_p, bfd_elf64_core_file_p): Likewise. * elfcode.h (elf_object_p): Likewise. * elfcore.h (elf_core_file_p): Likewise. * i386msdos.c (msdos_object_p): Likewise. * ihex.c (ihex_object_p): Likewise. * libaout.h (some_aout_object_p): Likewise. * libbfd-in.h (bfd_generic_archive_p, _bfd_dummy_target), (_bfd_vms_lib_alpha_archive_p, _bfd_vms_lib_ia64_archive_p): Likewise. * libbfd.c (_bfd_dummy_target): Likewise. * libcoff-in.h (coff_object_p): Likewise. * mach-o-aarch64.c (bfd_mach_o_arm64_object_p), (bfd_mach_o_arm64_core_p): Likewise. * mach-o-arm.c (bfd_mach_o_arm_object_p), (bfd_mach_o_arm_core_p): Likewise. * mach-o-i386.c (bfd_mach_o_i386_object_p), (bfd_mach_o_i386_core_p): Likewise. * mach-o-x86-64.c (bfd_mach_o_x86_64_object_p), (bfd_mach_o_x86_64_core_p): Likewise. * mach-o.c (bfd_mach_o_header_p, bfd_mach_o_gen_object_p), (bfd_mach_o_gen_core_p, bfd_mach_o_fat_archive_p): Likewise. * mach-o.h (bfd_mach_o_object_p, bfd_mach_o_core_p), (bfd_mach_o_fat_archive_p, bfd_mach_o_header_p): Likewise. * mmo.c (mmo_object_p): Likewise. * pef.c (bfd_pef_object_p, bfd_pef_xlib_object_p): Likewise. * peicode.h (coff_real_object_p, pe_ILF_object_p), (pe_bfd_object_p): Likewise. * plugin.c (ld_plugin_object_p, bfd_plugin_object_p): Likewise. * ppcboot.c (ppcboot_object_p): Likewise. * rs6000-core.c (rs6000coff_core_p): Likewise. * som.c (som_object_setup, som_object_p): Likewise. * srec.c (srec_object_p, symbolsrec_object_p): Likewise. * tekhex.c (tekhex_object_p): Likewise. * vms-alpha.c (alpha_vms_object_p): Likewise. * vms-lib.c (_bfd_vms_lib_archive_p, _bfd_vms_lib_alpha_archive_p), (_bfd_vms_lib_ia64_archive_p, _bfd_vms_lib_txt_archive_p): Likewise. * wasm-module.c (wasm_object_p): Likewise. * xsym.c (bfd_sym_object_p): Likewise. * xsym.h (bfd_sym_object_p): Likewise. * aoutx.h (some_aout_object_p): Likewise, and callback parameter return type. * pdp11.c (some_aout_object_p): Likewise. * plugin.c (register_ld_plugin_object_p): Update object_p parameter type. * plugin.h (register_ld_plugin_object_p): Likewise. * bfd-in2.h: Regenerate. * libbfd.h: Regenerate. * libcoff.h: Regenerate. ld/ * plugin.c (plugin_object_p): Return a bfd_cleanup. (plugin_cleanup): New function.
361 lines
9.9 KiB
C
361 lines
9.9 KiB
C
/* ARM Mach-O support for BFD.
|
|
Copyright (C) 2015-2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of BFD, the Binary File Descriptor library.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston,
|
|
MA 02110-1301, USA. */
|
|
|
|
#include "sysdep.h"
|
|
#include "bfd.h"
|
|
#include "libbfd.h"
|
|
#include "libiberty.h"
|
|
#include "mach-o.h"
|
|
#include "mach-o/arm.h"
|
|
|
|
#define bfd_mach_o_object_p bfd_mach_o_arm_object_p
|
|
#define bfd_mach_o_core_p bfd_mach_o_arm_core_p
|
|
#define bfd_mach_o_mkobject bfd_mach_o_arm_mkobject
|
|
|
|
#define bfd_mach_o_canonicalize_one_reloc bfd_mach_o_arm_canonicalize_one_reloc
|
|
#define bfd_mach_o_swap_reloc_out NULL
|
|
#define bfd_mach_o_bfd_reloc_type_lookup bfd_mach_o_arm_bfd_reloc_type_lookup
|
|
#define bfd_mach_o_bfd_reloc_name_lookup bfd_mach_o_arm_bfd_reloc_name_lookup
|
|
|
|
#define bfd_mach_o_print_thread NULL
|
|
#define bfd_mach_o_tgt_seg_table NULL
|
|
#define bfd_mach_o_section_type_valid_for_tgt NULL
|
|
|
|
static bfd_cleanup
|
|
bfd_mach_o_arm_object_p (bfd *abfd)
|
|
{
|
|
return bfd_mach_o_header_p (abfd, 0, 0, BFD_MACH_O_CPU_TYPE_ARM);
|
|
}
|
|
|
|
static bfd_cleanup
|
|
bfd_mach_o_arm_core_p (bfd *abfd)
|
|
{
|
|
return bfd_mach_o_header_p (abfd, 0,
|
|
BFD_MACH_O_MH_CORE, BFD_MACH_O_CPU_TYPE_ARM);
|
|
}
|
|
|
|
static bfd_boolean
|
|
bfd_mach_o_arm_mkobject (bfd *abfd)
|
|
{
|
|
bfd_mach_o_data_struct *mdata;
|
|
|
|
if (!bfd_mach_o_mkobject_init (abfd))
|
|
return FALSE;
|
|
|
|
mdata = bfd_mach_o_get_data (abfd);
|
|
mdata->header.magic = BFD_MACH_O_MH_MAGIC;
|
|
mdata->header.cputype = BFD_MACH_O_CPU_TYPE_ARM;
|
|
mdata->header.cpusubtype = BFD_MACH_O_CPU_SUBTYPE_ARM_ALL;
|
|
mdata->header.byteorder = BFD_ENDIAN_LITTLE;
|
|
mdata->header.version = 1;
|
|
|
|
return TRUE;
|
|
}
|
|
|
|
static reloc_howto_type arm_howto_table[]=
|
|
{
|
|
/* 0 */
|
|
HOWTO (BFD_RELOC_32, 0, 2, 32, FALSE, 0,
|
|
complain_overflow_bitfield,
|
|
NULL, "32",
|
|
FALSE, 0xffffffff, 0xffffffff, FALSE),
|
|
HOWTO (BFD_RELOC_16, 0, 1, 16, FALSE, 0,
|
|
complain_overflow_bitfield,
|
|
NULL, "16",
|
|
FALSE, 0xffff, 0xffff, FALSE),
|
|
HOWTO (BFD_RELOC_8, 0, 0, 8, FALSE, 0,
|
|
complain_overflow_bitfield,
|
|
NULL, "8",
|
|
FALSE, 0xff, 0xff, FALSE),
|
|
HOWTO (BFD_RELOC_32_PCREL, 0, 2, 32, TRUE, 0,
|
|
complain_overflow_bitfield,
|
|
NULL, "DISP32",
|
|
FALSE, 0xffffffff, 0xffffffff, TRUE),
|
|
/* 4 */
|
|
HOWTO (BFD_RELOC_16_PCREL, 0, 1, 16, TRUE, 0,
|
|
complain_overflow_bitfield,
|
|
NULL, "DISP16",
|
|
FALSE, 0xffff, 0xffff, TRUE),
|
|
HOWTO (BFD_RELOC_MACH_O_SECTDIFF, 0, 2, 32, FALSE, 0,
|
|
complain_overflow_bitfield,
|
|
NULL, "SECTDIFF_32",
|
|
FALSE, 0xffffffff, 0xffffffff, FALSE),
|
|
HOWTO (BFD_RELOC_MACH_O_LOCAL_SECTDIFF, 0, 2, 32, FALSE, 0,
|
|
complain_overflow_bitfield,
|
|
NULL, "LSECTDIFF_32",
|
|
FALSE, 0xffffffff, 0xffffffff, FALSE),
|
|
HOWTO (BFD_RELOC_MACH_O_PAIR, 0, 2, 32, FALSE, 0,
|
|
complain_overflow_bitfield,
|
|
NULL, "PAIR_32",
|
|
FALSE, 0xffffffff, 0xffffffff, FALSE),
|
|
/* 8 */
|
|
HOWTO (BFD_RELOC_MACH_O_SECTDIFF, 0, 1, 16, FALSE, 0,
|
|
complain_overflow_bitfield,
|
|
NULL, "SECTDIFF_16",
|
|
FALSE, 0xffff, 0xffff, FALSE),
|
|
HOWTO (BFD_RELOC_MACH_O_LOCAL_SECTDIFF, 0, 1, 16, FALSE, 0,
|
|
complain_overflow_bitfield,
|
|
NULL, "LSECTDIFF_16",
|
|
FALSE, 0xffff, 0xffff, FALSE),
|
|
HOWTO (BFD_RELOC_MACH_O_PAIR, 0, 1, 16, FALSE, 0,
|
|
complain_overflow_bitfield,
|
|
NULL, "PAIR_16",
|
|
FALSE, 0xffff, 0xffff, FALSE),
|
|
HOWTO (BFD_RELOC_ARM_PCREL_CALL, 2, 2, 24, TRUE, 0,
|
|
complain_overflow_signed,
|
|
NULL, "BR24",
|
|
FALSE, 0x00ffffff, 0x00ffffff, TRUE),
|
|
/* 12 */
|
|
HOWTO (BFD_RELOC_ARM_MOVW, 0, 2, 16, FALSE, 0,
|
|
complain_overflow_dont,
|
|
NULL, "MOVW",
|
|
FALSE, 0x000f0fff, 0x000f0fff, FALSE),
|
|
HOWTO (BFD_RELOC_MACH_O_PAIR, 0, 2, 16, FALSE, 0,
|
|
complain_overflow_bitfield,
|
|
NULL, "PAIR_W",
|
|
FALSE, 0x000f0fff, 0x000f0fff, FALSE),
|
|
HOWTO (BFD_RELOC_ARM_MOVT, 0, 2, 16, FALSE, 0,
|
|
complain_overflow_bitfield,
|
|
NULL, "MOVT",
|
|
FALSE, 0x000f0fff, 0x000f0fff, FALSE),
|
|
HOWTO (BFD_RELOC_MACH_O_PAIR, 0, 2, 16, FALSE, 0,
|
|
complain_overflow_bitfield,
|
|
NULL, "PAIR_T",
|
|
FALSE, 0x000f0fff, 0x000f0fff, FALSE),
|
|
/* 16 */
|
|
HOWTO (BFD_RELOC_THUMB_PCREL_BLX, 2, 2, 24, TRUE, 0,
|
|
complain_overflow_signed,
|
|
NULL, "TBR22",
|
|
FALSE, 0x07ff2fff, 0x07ff2fff, TRUE)
|
|
};
|
|
|
|
static bfd_boolean
|
|
bfd_mach_o_arm_canonicalize_one_reloc (bfd * abfd,
|
|
struct mach_o_reloc_info_external * raw,
|
|
arelent * res,
|
|
asymbol ** syms,
|
|
arelent * res_base)
|
|
{
|
|
bfd_mach_o_reloc_info reloc;
|
|
|
|
if (!bfd_mach_o_pre_canonicalize_one_reloc (abfd, raw, &reloc, res, syms))
|
|
{
|
|
fprintf (stderr, "ARm 1\n");
|
|
return FALSE;
|
|
}
|
|
|
|
if (reloc.r_scattered)
|
|
{
|
|
switch (reloc.r_type)
|
|
{
|
|
case BFD_MACH_O_ARM_RELOC_PAIR:
|
|
/* PR 21813: Check for a corrupt PAIR reloc at the start. */
|
|
if (res == res_base)
|
|
{
|
|
_bfd_error_handler (_("\
|
|
malformed mach-o ARM reloc pair: reloc is first reloc"));
|
|
return FALSE;
|
|
}
|
|
if (reloc.r_length == 2)
|
|
{
|
|
res->howto = &arm_howto_table[7];
|
|
res->address = res[-1].address;
|
|
return TRUE;
|
|
}
|
|
else if (reloc.r_length == 1)
|
|
{
|
|
res->howto = &arm_howto_table[10];
|
|
res->address = res[-1].address;
|
|
return TRUE;
|
|
}
|
|
_bfd_error_handler (_("\
|
|
malformed mach-o ARM reloc pair: invalid length: %d"), reloc.r_length);
|
|
return FALSE;
|
|
|
|
case BFD_MACH_O_ARM_RELOC_SECTDIFF:
|
|
if (reloc.r_length == 2)
|
|
{
|
|
res->howto = &arm_howto_table[5];
|
|
return TRUE;
|
|
}
|
|
else if (reloc.r_length == 1)
|
|
{
|
|
res->howto = &arm_howto_table[8];
|
|
return TRUE;
|
|
}
|
|
_bfd_error_handler (_("\
|
|
malformed mach-o ARM sectdiff reloc: invalid length: %d"), reloc.r_length);
|
|
return FALSE;
|
|
|
|
case BFD_MACH_O_ARM_RELOC_LOCAL_SECTDIFF:
|
|
if (reloc.r_length == 2)
|
|
{
|
|
res->howto = &arm_howto_table[6];
|
|
return TRUE;
|
|
}
|
|
else if (reloc.r_length == 1)
|
|
{
|
|
res->howto = &arm_howto_table[9];
|
|
return TRUE;
|
|
}
|
|
_bfd_error_handler (_("\
|
|
malformed mach-o ARM local sectdiff reloc: invalid length: %d"),
|
|
reloc.r_length);
|
|
return FALSE;
|
|
|
|
case BFD_MACH_O_ARM_RELOC_HALF_SECTDIFF:
|
|
switch (reloc.r_length)
|
|
{
|
|
case 2: /* :lower16: for movw arm. */
|
|
res->howto = &arm_howto_table[12];
|
|
return TRUE;
|
|
case 3: /* :upper16: for movt arm. */
|
|
res->howto = &arm_howto_table[14];
|
|
return TRUE;
|
|
}
|
|
_bfd_error_handler (_("\
|
|
malformed mach-o ARM half sectdiff reloc: invalid length: %d"),
|
|
reloc.r_length);
|
|
return FALSE;
|
|
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
else
|
|
{
|
|
switch (reloc.r_type)
|
|
{
|
|
case BFD_MACH_O_ARM_RELOC_VANILLA:
|
|
switch ((reloc.r_length << 1) | reloc.r_pcrel)
|
|
{
|
|
case 0: /* len = 0, pcrel = 0 */
|
|
res->howto = &arm_howto_table[2];
|
|
return TRUE;
|
|
case 2: /* len = 1, pcrel = 0 */
|
|
res->howto = &arm_howto_table[1];
|
|
return TRUE;
|
|
case 3: /* len = 1, pcrel = 1 */
|
|
res->howto = &arm_howto_table[4];
|
|
return TRUE;
|
|
case 4: /* len = 2, pcrel = 0 */
|
|
res->howto = &arm_howto_table[0];
|
|
return TRUE;
|
|
case 5: /* len = 2, pcrel = 1 */
|
|
res->howto = &arm_howto_table[3];
|
|
return TRUE;
|
|
default:
|
|
_bfd_error_handler (_("\
|
|
malformed mach-o ARM vanilla reloc: invalid length: %d (pcrel: %d)"),
|
|
reloc.r_length, reloc.r_pcrel);
|
|
return FALSE;
|
|
}
|
|
break;
|
|
|
|
case BFD_MACH_O_ARM_RELOC_BR24:
|
|
if (reloc.r_length == 2 && reloc.r_pcrel == 1)
|
|
{
|
|
res->howto = &arm_howto_table[11];
|
|
return TRUE;
|
|
}
|
|
break;
|
|
|
|
case BFD_MACH_O_THUMB_RELOC_BR22:
|
|
if (reloc.r_length == 2 && reloc.r_pcrel == 1)
|
|
{
|
|
res->howto = &arm_howto_table[16];
|
|
return TRUE;
|
|
}
|
|
break;
|
|
|
|
case BFD_MACH_O_ARM_RELOC_HALF:
|
|
if (reloc.r_pcrel == 0)
|
|
switch (reloc.r_length)
|
|
{
|
|
case 0: /* :lower16: for movw arm. */
|
|
res->howto = &arm_howto_table[12];
|
|
return TRUE;
|
|
case 1: /* :upper16: for movt arm. */
|
|
res->howto = &arm_howto_table[14];
|
|
return TRUE;
|
|
}
|
|
break;
|
|
|
|
case BFD_MACH_O_ARM_RELOC_PAIR:
|
|
if (res[-1].howto == &arm_howto_table[12]
|
|
&& reloc.r_length == 0)
|
|
{
|
|
/* Pair for :lower16: of movw arm. */
|
|
res->howto = &arm_howto_table[13];
|
|
/* This reloc contains the other half in its r_address field. */
|
|
res[-1].addend += (res->address & 0xffff) << 16;
|
|
res->address = res[-1].address;
|
|
return TRUE;
|
|
}
|
|
else if (res[-1].howto == &arm_howto_table[14]
|
|
&& reloc.r_length == 1)
|
|
{
|
|
/* Pair for :upper16: of movt arm. */
|
|
res->howto = &arm_howto_table[15];
|
|
/* This reloc contains the other half in its r_address field. */
|
|
res[-1].addend += res->address & 0xffff;
|
|
res->address = res[-1].address;
|
|
return TRUE;
|
|
}
|
|
break;
|
|
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
|
|
_bfd_error_handler (_("\
|
|
malformed mach-o ARM reloc: unknown reloc type: %d"), reloc.r_length);
|
|
return FALSE;
|
|
}
|
|
|
|
static reloc_howto_type *
|
|
bfd_mach_o_arm_bfd_reloc_type_lookup (bfd *abfd ATTRIBUTE_UNUSED,
|
|
bfd_reloc_code_real_type code)
|
|
{
|
|
unsigned int i;
|
|
|
|
for (i = 0; i < sizeof (arm_howto_table) / sizeof (*arm_howto_table); i++)
|
|
if (code == arm_howto_table[i].type)
|
|
return &arm_howto_table[i];
|
|
return NULL;
|
|
}
|
|
|
|
static reloc_howto_type *
|
|
bfd_mach_o_arm_bfd_reloc_name_lookup (bfd *abfd ATTRIBUTE_UNUSED,
|
|
const char *name ATTRIBUTE_UNUSED)
|
|
{
|
|
return NULL;
|
|
}
|
|
|
|
#define TARGET_NAME arm_mach_o_vec
|
|
#define TARGET_STRING "mach-o-arm"
|
|
#define TARGET_ARCHITECTURE bfd_arch_arm
|
|
#define TARGET_PAGESIZE 4096
|
|
#define TARGET_BIG_ENDIAN 0
|
|
#define TARGET_ARCHIVE 0
|
|
#define TARGET_PRIORITY 0
|
|
#include "mach-o-target.c"
|