mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
e0c23e11da
There's a bug in the python tui API. If the user tries to delete the window title attribute then this will trigger undefined behaviour in GDB due to a missing nullptr check. gdb/ChangeLog: * python/py-tui.c (gdbpy_tui_set_title): Check that the new value for the title is not nullptr. gdb/testsuite/ChangeLog: * gdb.python/tui-window.exp: Add new tests. * gdb.python/tui-window.py (TestWindow) <__init__>: Store TestWindow object into global the_window. <remote_title>: New method. (delete_window_title): New function.
52 lines
1.6 KiB
Python
52 lines
1.6 KiB
Python
# Copyright (C) 2020-2021 Free Software Foundation, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# A TUI window implemented in Python.
|
|
|
|
import gdb
|
|
|
|
the_window = None
|
|
|
|
class TestWindow:
|
|
def __init__(self, win):
|
|
global the_window
|
|
the_window = self
|
|
self.count = 0
|
|
self.win = win
|
|
win.title = "This Is The Title"
|
|
|
|
def render(self):
|
|
self.win.erase()
|
|
w = self.win.width
|
|
h = self.win.height
|
|
self.win.write("Test: " + str(self.count) + " " + str(w) + "x" + str(h))
|
|
self.count = self.count + 1
|
|
|
|
# Tries to delete the title attribute. GDB will throw an error.
|
|
def remove_title(self):
|
|
del self.win.title
|
|
|
|
gdb.register_window_type("test", TestWindow)
|
|
|
|
# Call REMOVE_TITLE on the global window object.
|
|
def delete_window_title ():
|
|
the_window.remove_title ()
|
|
|
|
# A TUI window "constructor" that always fails.
|
|
def failwin(win):
|
|
raise RuntimeError("Whoops")
|
|
|
|
gdb.register_window_type("fail", failwin)
|