mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-21 04:42:53 +08:00
1f599d0e7b
Always turn hidden and internal symbols which have a dynamic index into
local ones. This is required by the the ELF gABI[1]:
"A hidden symbol contained in a relocatable object must be either
removed or converted to STB_LOCAL binding by the link-editor when the
relocatable object is included in an executable file or shared object."
"An internal symbol contained in a relocatable object must be either
removed or converted to STB_LOCAL binding by the link-editor when the
relocatable object is included in an executable file or shared object."
The ELF linker usually respects this requirement, however in the case
where a dynamic symbol has been preallocated due to a reference of the
default export class aka visibility from the object being linked, and
then merged with a hidden or internal symbol definition from within the
same object, then the original export class is carried over to the
output dynamic symbol table, because while merging the generic ELF
linker only converts affected dynamic symbols to local when they are
defined or referenced by the object being linked and a dynamic object
involved in the link both at a time.
The dynamic symbol produced confuses then the dynamic loader at the run
time -- the hidden or internal export class is ignored and the symbol
follows preemption rules as with the default export class.
In the MIPS target it happens when `mips_elf_record_global_got_symbol'
creates a dynamic symbol when a call relocation is encountered.
Additionally if the undefined symbol referred by such a relocation does
specify the intended export class, then a local dynamic symbol is
created instead, which is harmless and allowed, but useless. Normally
no local dynamic symbols are created, except for a single dummy one at
the beginning.
Correct the problem by removing the extra check for a dynamic symbol
being defined or referenced by the object being linked and a dynamic
object involved in the link both at a time. The test cases included
cover the internal and hidden symbol cases, as well as a protected
symbol for a reference, the handling of which is unchanged by this fix.
Both cases described above are covered, that is where an internal or
hidden dynamic symbol is produced and where a local one is.
NB this change affects CRIS results where some symbols in the static
table produced in a final link are now converted from STV_HIDDEN to
STB_LOCAL. This happens whenever the `elf_backend_hide_symbol' handler
is called, so the affected symbols must have been chosen for entering
into the dynamic symbol table, except in these test cases no such symbol
table is produced. In fully linked binaries the static symbol table is
only used for debugging though, so such a change is fine.
References:
[1] "System V Application Binary Interface - DRAFT - 24 April 2001",
The Santa Cruz Operation, Inc., "Symbol Table",
<http://www.sco.com/developers/gabi/2001-04-24/ch4.symtab.html>
bfd/
PR ld/19908
* elflink.c (elf_link_add_object_symbols): Always turn hidden
and internal symbols which have a dynamic index into local
ones.
ld/
PR ld/19908
* testsuite/ld-cris/tls-e-20.d: Adjust for hidden symbol
handling fix.
* testsuite/ld-cris/tls-e-20a.d: Likewise.
* testsuite/ld-cris/tls-e-21.d: Likewise.
* testsuite/ld-cris/tls-e-23.d: Likewise.
* testsuite/ld-cris/tls-e-80.d: Likewise.
* testsuite/ld-cris/tls-gd-3h.d: Likewise.
* testsuite/ld-cris/tls-leie-19.d: Likewise.
* testsuite/ld-mips-elf/export-class-ref-lib.sd: New test.
* testsuite/ld-mips-elf/export-hidden-ref.sd: New test.
* testsuite/ld-mips-elf/export-internal-ref.sd: New test.
* testsuite/ld-mips-elf/export-protected-ref.sd: New test.
* testsuite/ld-mips-elf/export-class-ref-f0.s: New test source.
* testsuite/ld-mips-elf/export-class-ref-f1.s: New test source.
* testsuite/ld-mips-elf/export-class-ref-f2.s: New test source.
* testsuite/ld-mips-elf/mips-elf.exp: Run the new tests.
59 lines
1.3 KiB
Makefile
59 lines
1.3 KiB
Makefile
#source: start1.s
|
|
#source: tls128.s
|
|
#source: tls-leie-19.s
|
|
#source: tls-le-12.s
|
|
#source: tls-ie-11.s --pic
|
|
#source: tls-hx1x2.s
|
|
#source: tls-x.s
|
|
#source: tls-z.s
|
|
#as: --no-underscore --em=criself
|
|
#ld: -m crislinux
|
|
#objdump: -d -s -h -t -r -p
|
|
|
|
# Check that we have proper NPTL/TLS markings and GOT for an
|
|
# executable with two R_CRIS_32_TPREL and two R_CRIS_32_GOT_TPREL,
|
|
# four different symbols.
|
|
|
|
.*: file format elf32-cris
|
|
|
|
Program Header:
|
|
#...
|
|
TLS off 0x0+b4 vaddr 0x0+820b4 paddr 0x0+820b4 align 2\*\*2
|
|
filesz 0x0+90 memsz 0x0+90 flags r--
|
|
private flags = 0:
|
|
#...
|
|
2 .got .*
|
|
CONTENTS.*
|
|
SYMBOL TABLE:
|
|
#...
|
|
0+84 l \.tdata 0+4 x2
|
|
#...
|
|
0+80 l \.tdata 0+4 x1
|
|
#...
|
|
0+88 g .tdata 0+4 x
|
|
#...
|
|
0+8c g .tdata 0+4 z
|
|
#...
|
|
Contents of section \.text:
|
|
#...
|
|
Contents of section \.got:
|
|
82144 0+ 0+ 0+ f4ffffff .*
|
|
82154 f0ffffff .*
|
|
|
|
Disassembly of section \.text:
|
|
|
|
00080094 <_start>:
|
|
80094: 41b2 moveq 1,\$r11
|
|
#...
|
|
00080098 <tlsfn19>:
|
|
80098: 6fae f8ff ffff move.d 0xfffffff8,\$r10
|
|
#...
|
|
|
|
000800a0 <tlsfn12>:
|
|
800a0: 6fae fcff ffff move.d 0xfffffffc,\$r10
|
|
#...
|
|
|
|
000800a8 <tlsdsofn>:
|
|
800a8: 6fae 1000 0000 move.d 10 <tls128\+0x10>,\$r10
|
|
800ae: 6fbe 0c00 0000 move.d c <tls128\+0xc>,\$r11
|