mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-06 12:09:26 +08:00
4dfef5be68
As follow-up to this discussion: https://sourceware.org/pipermail/gdb-patches/2020-August/171385.html ... make runto_main not pass no-message to runto. This means that if we fail to run to main, for some reason, we'll emit a FAIL. This is the behavior we want the majority of (if not all) the time. Without this, we rely on tests logging a failure if runto_main fails, otherwise. They do so in a very inconsisteny mannet, sometimes using "fail", "unsupported" or "untested". The messages also vary widly. This patch removes all these messages as well. Also, remove a few "fail" where we call runto (and not runto_main). by default (without an explicit no-message argument), runto prints a failure already. In two places, gdb.multi/multi-re-run.exp and gdb.python/py-pp-registration.exp, remove "message" passed to runto. This removes a few PASSes that we don't care about (but FAILs will still be printed if we fail to run to where we want to). This aligns their behavior with the rest of the testsuite. Change-Id: Ib763c98c5f4fb6898886b635210d7c34bd4b9023
66 lines
2.0 KiB
Plaintext
66 lines
2.0 KiB
Plaintext
# Copyright (C) 2019-2021 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test breakpoints work correctly when stack protector is used.
|
|
|
|
# Note on Debian/Ubuntu, stack protector is on by default, and is
|
|
# currently force disabled in gdb_compile due to the XFAIL below.
|
|
|
|
# Ensure the compiler is gcc/clang and is new enough to support stack
|
|
# protection.
|
|
if { !([test_compiler_info "gcc-*"] || [test_compiler_info "clang-*"])
|
|
|| [test_compiler_info {gcc-[0-3]-*}]
|
|
|| [test_compiler_info {gcc-4-0-*}]
|
|
|| [test_compiler_info {clang-[0-4]=*}] } {
|
|
return 0
|
|
}
|
|
|
|
standard_testfile
|
|
|
|
set protector_options { "-fno-stack-protector" "-fstack-protector" \
|
|
"-fstack-protector-all" "-fstack-protector-strong" }
|
|
|
|
proc simple_func_break_test { protection } {
|
|
global testfile
|
|
global srcfile
|
|
global binfile
|
|
|
|
set options debug
|
|
lappend options additional_flags=$protection
|
|
|
|
if {[prepare_for_testing "failed to prepare" $testfile $srcfile $options]} {
|
|
return -1
|
|
}
|
|
|
|
if { ![runto_main] } then {
|
|
return -1
|
|
}
|
|
|
|
# Break on function foo and ensure it stops on the first line of code.
|
|
gdb_breakpoint "foo"
|
|
|
|
if { $protection == "-fstack-protector-all"
|
|
&& [test_compiler_info "gcc-*"] } {
|
|
setup_xfail "gcc/88432" "*-*-linux*"
|
|
}
|
|
gdb_continue_to_breakpoint "foo" ".*break here.*"
|
|
|
|
return 1
|
|
}
|
|
|
|
foreach_with_prefix protection $protector_options {
|
|
simple_func_break_test $protection
|
|
}
|