binutils-gdb/gdb/common/filestuff.h
Tom Tromey b3279b601e Use mkostemp, not mkstemp
I noticed that gdb could leak file descriptors coming from mkstemp.
This patch fixes the problem by importing the gnulib mkostemp instead,
and then changing gdb to pass O_CLOEXEC.

A small gnulib patch was needed.  This has already been accepted
upstream.

gdb/ChangeLog
2018-10-27  Tom Tromey  <tom@tromey.com>

	* unittests/scoped_mmap-selftests.c (test_normal): Use
	gdb_mkostemp_cloexec.
	* unittests/scoped_fd-selftests.c (test_destroy, test_release):
	Use gdb_mkostemp_cloexec.
	* gnulib/aclocal-m4-deps.mk, gnulib/aclocal.m4,
	gnulib/config.in, gnulib/configure,
	gnulib/import/Makefile.am, gnulib/import/Makefile.in,
	gnulib/import/m4/gnulib-cache.m4,
	gnulib/import/m4/gnulib-comp.m4: Update.
	* gnulib/import/m4/mkostemp.m4: New file.
	* gnulib/import/m4/mkstemp.m4: Remove.
	* gnulib/import/mkostemp.c: New file.
	* gnulib/import/mkstemp.m4: Remove.
	* gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Remove
	mkstemp, add mkostemp.  Apply new patch.
	* gnulib/import/stdlib.in.h: Apply patch.
	* gnulib/patches/0002-mkostemp-mkostemps-Fix-compilation-error-in-C-mode-o.patch:
	New file.
	* dwarf-index-write.c (write_psymtabs_to_index): Use
	gdb_mkostemp_cloexec.
	* common/filestuff.h (gdb_mkostemp_cloexec): New function.
2018-10-27 11:58:41 -06:00

147 lines
4.2 KiB
C++

/* Low-level file-handling.
Copyright (C) 2012-2018 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#ifndef FILESTUFF_H
#define FILESTUFF_H
#include <dirent.h>
#include <fcntl.h>
/* Note all the file descriptors which are open when this is called.
These file descriptors will not be closed by close_most_fds. */
extern void notice_open_fds (void);
/* Mark a file descriptor as inheritable across an exec. */
extern void mark_fd_no_cloexec (int fd);
/* Mark a file descriptor as no longer being inheritable across an
exec. This is only meaningful when FD was previously passed to
mark_fd_no_cloexec. */
extern void unmark_fd_no_cloexec (int fd);
/* Close all open file descriptors other than those marked by
'notice_open_fds', and stdin, stdout, and stderr. Errors that
occur while closing are ignored. */
extern void close_most_fds (void);
/* Like 'open', but ensures that the returned file descriptor has the
close-on-exec flag set. */
extern int gdb_open_cloexec (const char *filename, int flags,
/* mode_t */ unsigned long mode);
/* Like mkstemp, but ensures that the file descriptor is
close-on-exec. */
static inline int
gdb_mkostemp_cloexec (char *name_template, int flags = 0)
{
/* gnulib provides a mkostemp replacement if needed. */
return mkostemp (name_template, flags | O_CLOEXEC);
}
/* Convenience wrapper for the above, which takes the filename as an
std::string. */
static inline int
gdb_open_cloexec (const std::string &filename, int flags,
/* mode_t */ unsigned long mode)
{
return gdb_open_cloexec (filename.c_str (), flags, mode);
}
struct gdb_file_deleter
{
void operator() (FILE *file) const
{
fclose (file);
}
};
/* A unique pointer to a FILE. */
typedef std::unique_ptr<FILE, gdb_file_deleter> gdb_file_up;
/* Like 'fopen', but ensures that the returned file descriptor has the
close-on-exec flag set. */
extern gdb_file_up gdb_fopen_cloexec (const char *filename,
const char *opentype);
/* Convenience wrapper for the above, which takes the filename as an
std::string. */
static inline gdb_file_up
gdb_fopen_cloexec (const std::string &filename, const char *opentype)
{
return gdb_fopen_cloexec (filename.c_str (), opentype);
}
/* Like 'socketpair', but ensures that the returned file descriptors
have the close-on-exec flag set. */
extern int gdb_socketpair_cloexec (int domain, int style, int protocol,
int filedes[2]);
/* Like 'socket', but ensures that the returned file descriptor has
the close-on-exec flag set. */
extern int gdb_socket_cloexec (int domain, int style, int protocol);
/* Like 'pipe', but ensures that the returned file descriptors have
the close-on-exec flag set. */
extern int gdb_pipe_cloexec (int filedes[2]);
/* Return a new cleanup that closes FD. */
extern struct cleanup *make_cleanup_close (int fd);
struct gdb_dir_deleter
{
void operator() (DIR *dir) const
{
closedir (dir);
}
};
/* A unique pointer to a DIR. */
typedef std::unique_ptr<DIR, gdb_dir_deleter> gdb_dir_up;
/* Return true if the file NAME exists and is a regular file.
If the result is false then *ERRNO_PTR is set to a useful value assuming
we're expecting a regular file. */
extern bool is_regular_file (const char *name, int *errno_ptr);
/* A cheap (as in low-quality) recursive mkdir. Try to create all the
parents directories up to DIR and DIR itself. Stop if we hit an
error along the way. There is no attempt to remove created
directories in case of failure.
Returns false on failure and sets errno. */
extern bool mkdir_recursive (const char *dir);
#endif /* FILESTUFF_H */