mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
6c2659886f
I'd like to enable the -Wmissing-declarations warning. However, it
warns for every _initialize function, for example:
CXX dcache.o
/home/smarchi/src/binutils-gdb/gdb/dcache.c: In function ‘void _initialize_dcache()’:
/home/smarchi/src/binutils-gdb/gdb/dcache.c:688:1: error: no previous declaration for ‘void _initialize_dcache()’ [-Werror=missing-declarations]
_initialize_dcache (void)
^~~~~~~~~~~~~~~~~~
The only practical way forward I found is to add back the declarations,
which were removed by this commit:
commit 481695ed5f
Author: John Baldwin <jhb@FreeBSD.org>
Date: Sat Sep 9 11:02:37 2017 -0700
Remove unnecessary function prototypes.
I don't think it's a big problem to have the declarations for these
functions, but if anybody has a better solution for this, I'll be happy
to use it.
gdb/ChangeLog:
* aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
* aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
* aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
* aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
* aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
* ada-exp.y (_initialize_ada_exp): Add declaration.
* ada-lang.c (_initialize_ada_language): Add declaration.
* ada-tasks.c (_initialize_tasks): Add declaration.
* agent.c (_initialize_agent): Add declaration.
* aix-thread.c (_initialize_aix_thread): Add declaration.
* alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
* alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
* alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
* alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
* alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
* alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
* amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
* amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
* amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
* amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
* amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
* amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
* amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
* amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
* amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
* amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
* amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
* amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
* amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
* amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
* annotate.c (_initialize_annotate): Add declaration.
* arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
* arc-tdep.c (_initialize_arc_tdep): Add declaration.
* arch-utils.c (_initialize_gdbarch_utils): Add declaration.
* arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
* arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
* arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
* arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
* arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
* arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
* arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
* arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
* arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
* arm-tdep.c (_initialize_arm_tdep): Add declaration.
* arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
* auto-load.c (_initialize_auto_load): Add declaration.
* auxv.c (_initialize_auxv): Add declaration.
* avr-tdep.c (_initialize_avr_tdep): Add declaration.
* ax-gdb.c (_initialize_ax_gdb): Add declaration.
* bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
* bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
* break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
* break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
* break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
* breakpoint.c (_initialize_breakpoint): Add declaration.
* bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
* btrace.c (_initialize_btrace): Add declaration.
* charset.c (_initialize_charset): Add declaration.
* cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
* cli/cli-dump.c (_initialize_cli_dump): Add declaration.
* cli/cli-interp.c (_initialize_cli_interp): Add declaration.
* cli/cli-logging.c (_initialize_cli_logging): Add declaration.
* cli/cli-script.c (_initialize_cli_script): Add declaration.
* cli/cli-style.c (_initialize_cli_style): Add declaration.
* coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
* coffread.c (_initialize_coffread): Add declaration.
* compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
* compile/compile.c (_initialize_compile): Add declaration.
* complaints.c (_initialize_complaints): Add declaration.
* completer.c (_initialize_completer): Add declaration.
* copying.c (_initialize_copying): Add declaration.
* corefile.c (_initialize_core): Add declaration.
* corelow.c (_initialize_corelow): Add declaration.
* cp-abi.c (_initialize_cp_abi): Add declaration.
* cp-namespace.c (_initialize_cp_namespace): Add declaration.
* cp-support.c (_initialize_cp_support): Add declaration.
* cp-valprint.c (_initialize_cp_valprint): Add declaration.
* cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
* cris-tdep.c (_initialize_cris_tdep): Add declaration.
* csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
* csky-tdep.c (_initialize_csky_tdep): Add declaration.
* ctfread.c (_initialize_ctfread): Add declaration.
* d-lang.c (_initialize_d_language): Add declaration.
* darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
* darwin-nat.c (_initialize_darwin_nat): Add declaration.
* dbxread.c (_initialize_dbxread): Add declaration.
* dcache.c (_initialize_dcache): Add declaration.
* disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
* disasm.c (_initialize_disasm): Add declaration.
* dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
* dummy-frame.c (_initialize_dummy_frame): Add declaration.
* dwarf-index-cache.c (_initialize_index_cache): Add declaration.
* dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
* dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
* dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
* dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
* dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
* dwarf2read.c (_initialize_dwarf2_read): Add declaration.
* elfread.c (_initialize_elfread): Add declaration.
* exec.c (_initialize_exec): Add declaration.
* extension.c (_initialize_extension): Add declaration.
* f-lang.c (_initialize_f_language): Add declaration.
* f-valprint.c (_initialize_f_valprint): Add declaration.
* fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
* fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
* filesystem.c (_initialize_filesystem): Add declaration.
* findcmd.c (_initialize_mem_search): Add declaration.
* findvar.c (_initialize_findvar): Add declaration.
* fork-child.c (_initialize_fork_child): Add declaration.
* frame-base.c (_initialize_frame_base): Add declaration.
* frame-unwind.c (_initialize_frame_unwind): Add declaration.
* frame.c (_initialize_frame): Add declaration.
* frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
* frv-tdep.c (_initialize_frv_tdep): Add declaration.
* ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
* gcore.c (_initialize_gcore): Add declaration.
* gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
* gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
* gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
* gdbarch.c (_initialize_gdbarch): Add declaration.
* gdbtypes.c (_initialize_gdbtypes): Add declaration.
* gnu-nat.c (_initialize_gnu_nat): Add declaration.
* gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
* gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
* go-lang.c (_initialize_go_language): Add declaration.
* go32-nat.c (_initialize_go32_nat): Add declaration.
* guile/guile.c (_initialize_guile): Add declaration.
* h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
* hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
* hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
* hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
* hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
* hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
* hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
* hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
* i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
* i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
* i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
* i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
* i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
* i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
* i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
* i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
* i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
* i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
* i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
* i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
* i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
* i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
* i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
* i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
* i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
* i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
* i386-tdep.c (_initialize_i386_tdep): Add declaration.
* i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
* ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
* ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
* ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
* ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
* ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
* infcall.c (_initialize_infcall): Add declaration.
* infcmd.c (_initialize_infcmd): Add declaration.
* inflow.c (_initialize_inflow): Add declaration.
* infrun.c (_initialize_infrun): Add declaration.
* interps.c (_initialize_interpreter): Add declaration.
* iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
* jit.c (_initialize_jit): Add declaration.
* language.c (_initialize_language): Add declaration.
* linux-fork.c (_initialize_linux_fork): Add declaration.
* linux-nat.c (_initialize_linux_nat): Add declaration.
* linux-tdep.c (_initialize_linux_tdep): Add declaration.
* linux-thread-db.c (_initialize_thread_db): Add declaration.
* lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
* m2-lang.c (_initialize_m2_language): Add declaration.
* m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
* m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
* m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
* m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
* m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
* m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
* m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
* m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
* m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
* m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
* machoread.c (_initialize_machoread): Add declaration.
* macrocmd.c (_initialize_macrocmd): Add declaration.
* macroscope.c (_initialize_macroscope): Add declaration.
* maint-test-options.c (_initialize_maint_test_options): Add declaration.
* maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
* maint.c (_initialize_maint_cmds): Add declaration.
* mdebugread.c (_initialize_mdebugread): Add declaration.
* memattr.c (_initialize_mem): Add declaration.
* mep-tdep.c (_initialize_mep_tdep): Add declaration.
* mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
* mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
* mi/mi-interp.c (_initialize_mi_interp): Add declaration.
* mi/mi-main.c (_initialize_mi_main): Add declaration.
* microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
* microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
* mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
* mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
* mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
* mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
* mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
* mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
* mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
* mips-tdep.c (_initialize_mips_tdep): Add declaration.
* mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
* mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
* mipsread.c (_initialize_mipsread): Add declaration.
* mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
* mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
* moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
* msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
* nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
* nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
* nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
* nto-procfs.c (_initialize_procfs): Add declaration.
* objc-lang.c (_initialize_objc_language): Add declaration.
* observable.c (_initialize_observer): Add declaration.
* opencl-lang.c (_initialize_opencl_language): Add declaration.
* or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
* or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
* osabi.c (_initialize_gdb_osabi): Add declaration.
* osdata.c (_initialize_osdata): Add declaration.
* p-valprint.c (_initialize_pascal_valprint): Add declaration.
* parse.c (_initialize_parse): Add declaration.
* ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
* ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
* ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
* ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
* ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
* ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
* ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
* ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
* printcmd.c (_initialize_printcmd): Add declaration.
* probe.c (_initialize_probe): Add declaration.
* proc-api.c (_initialize_proc_api): Add declaration.
* proc-events.c (_initialize_proc_events): Add declaration.
* proc-service.c (_initialize_proc_service): Add declaration.
* procfs.c (_initialize_procfs): Add declaration.
* producer.c (_initialize_producer): Add declaration.
* psymtab.c (_initialize_psymtab): Add declaration.
* python/python.c (_initialize_python): Add declaration.
* ravenscar-thread.c (_initialize_ravenscar): Add declaration.
* record-btrace.c (_initialize_record_btrace): Add declaration.
* record-full.c (_initialize_record_full): Add declaration.
* record.c (_initialize_record): Add declaration.
* regcache-dump.c (_initialize_regcache_dump): Add declaration.
* regcache.c (_initialize_regcache): Add declaration.
* reggroups.c (_initialize_reggroup): Add declaration.
* remote-notif.c (_initialize_notif): Add declaration.
* remote-sim.c (_initialize_remote_sim): Add declaration.
* remote.c (_initialize_remote): Add declaration.
* reverse.c (_initialize_reverse): Add declaration.
* riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
* riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
* riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
* riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
* riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
* rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
* rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
* rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
Add declaration.
* rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
* rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
* run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
* rust-exp.y (_initialize_rust_exp): Add declaration.
* rx-tdep.c (_initialize_rx_tdep): Add declaration.
* s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
* s390-linux-nat.c (_initialize_s390_nat): Add declaration.
* s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
* s390-tdep.c (_initialize_s390_tdep): Add declaration.
* score-tdep.c (_initialize_score_tdep): Add declaration.
* ser-go32.c (_initialize_ser_dos): Add declaration.
* ser-mingw.c (_initialize_ser_windows): Add declaration.
* ser-pipe.c (_initialize_ser_pipe): Add declaration.
* ser-tcp.c (_initialize_ser_tcp): Add declaration.
* ser-uds.c (_initialize_ser_socket): Add declaration.
* ser-unix.c (_initialize_ser_hardwire): Add declaration.
* serial.c (_initialize_serial): Add declaration.
* sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
* sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
* sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
* sh-tdep.c (_initialize_sh_tdep): Add declaration.
* skip.c (_initialize_step_skip): Add declaration.
* sol-thread.c (_initialize_sol_thread): Add declaration.
* solib-aix.c (_initialize_solib_aix): Add declaration.
* solib-darwin.c (_initialize_darwin_solib): Add declaration.
* solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
* solib-frv.c (_initialize_frv_solib): Add declaration.
* solib-svr4.c (_initialize_svr4_solib): Add declaration.
* solib-target.c (_initialize_solib_target): Add declaration.
* solib.c (_initialize_solib): Add declaration.
* source-cache.c (_initialize_source_cache): Add declaration.
* source.c (_initialize_source): Add declaration.
* sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
* sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
* sparc-nat.c (_initialize_sparc_nat): Add declaration.
* sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
* sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
* sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
* sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
* sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
* sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
* sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
* sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
* sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
* sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
* sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
* sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
* sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
* sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
* sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
* sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
* stabsread.c (_initialize_stabsread): Add declaration.
* stack.c (_initialize_stack): Add declaration.
* stap-probe.c (_initialize_stap_probe): Add declaration.
* std-regs.c (_initialize_frame_reg): Add declaration.
* symfile-debug.c (_initialize_symfile_debug): Add declaration.
* symfile-mem.c (_initialize_symfile_mem): Add declaration.
* symfile.c (_initialize_symfile): Add declaration.
* symmisc.c (_initialize_symmisc): Add declaration.
* symtab.c (_initialize_symtab): Add declaration.
* target.c (_initialize_target): Add declaration.
* target-connection.c (_initialize_target_connection): Add
declaration.
* target-dcache.c (_initialize_target_dcache): Add declaration.
* target-descriptions.c (_initialize_target_descriptions): Add declaration.
* thread.c (_initialize_thread): Add declaration.
* tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
* tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
* tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
* tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
* tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
* tracectf.c (_initialize_ctf): Add declaration.
* tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
* tracefile.c (_initialize_tracefile): Add declaration.
* tracepoint.c (_initialize_tracepoint): Add declaration.
* tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
* tui/tui-interp.c (_initialize_tui_interp): Add declaration.
* tui/tui-layout.c (_initialize_tui_layout): Add declaration.
* tui/tui-regs.c (_initialize_tui_regs): Add declaration.
* tui/tui-stack.c (_initialize_tui_stack): Add declaration.
* tui/tui-win.c (_initialize_tui_win): Add declaration.
* tui/tui.c (_initialize_tui): Add declaration.
* typeprint.c (_initialize_typeprint): Add declaration.
* ui-style.c (_initialize_ui_style): Add declaration.
* unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
* unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
* unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
* unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
* unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
* unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
* unittests/filtered_iterator-selftests.c
(_initialize_filtered_iterator_selftests): Add declaration.
* unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
* unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
* unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
* unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
* unittests/main-thread-selftests.c
(_initialize_main_thread_selftests): Add declaration.
* unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
* unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
* unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
* unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
* unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
* unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
* unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
* unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
* unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
* unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
* unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
* unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
* unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
* unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
* unittests/tui-selftests.c (_initialize_tui_selftest): Add
declaration.
* unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
* unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
* unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
* unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
* user-regs.c (_initialize_user_regs): Add declaration.
* utils.c (_initialize_utils): Add declaration.
* v850-tdep.c (_initialize_v850_tdep): Add declaration.
* valops.c (_initialize_valops): Add declaration.
* valprint.c (_initialize_valprint): Add declaration.
* value.c (_initialize_values): Add declaration.
* varobj.c (_initialize_varobj): Add declaration.
* vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
* vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
* vax-tdep.c (_initialize_vax_tdep): Add declaration.
* windows-nat.c (_initialize_windows_nat): Add declaration.
(_initialize_check_for_gdb_ini): Add declaration.
(_initialize_loadable): Add declaration.
* windows-tdep.c (_initialize_windows_tdep): Add declaration.
* x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
* x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
* xcoffread.c (_initialize_xcoffread): Add declaration.
* xml-support.c (_initialize_xml_support): Add declaration.
* xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
* xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
* xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
* xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
Change-Id: I13eec7e0ed2b3c427377a7bdb055cf46da64def9
1107 lines
30 KiB
C
1107 lines
30 KiB
C
/* Work with executable files, for GDB.
|
||
|
||
Copyright (C) 1988-2020 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
#include "frame.h"
|
||
#include "inferior.h"
|
||
#include "target.h"
|
||
#include "gdbcmd.h"
|
||
#include "language.h"
|
||
#include "filenames.h"
|
||
#include "symfile.h"
|
||
#include "objfiles.h"
|
||
#include "completer.h"
|
||
#include "value.h"
|
||
#include "exec.h"
|
||
#include "observable.h"
|
||
#include "arch-utils.h"
|
||
#include "gdbthread.h"
|
||
#include "progspace.h"
|
||
#include "gdb_bfd.h"
|
||
#include "gcore.h"
|
||
#include "source.h"
|
||
|
||
#include <fcntl.h>
|
||
#include "readline/tilde.h"
|
||
#include "gdbcore.h"
|
||
|
||
#include <ctype.h>
|
||
#include <sys/stat.h>
|
||
#include "solist.h"
|
||
#include <algorithm>
|
||
#include "gdbsupport/pathstuff.h"
|
||
|
||
void (*deprecated_file_changed_hook) (const char *);
|
||
|
||
static const target_info exec_target_info = {
|
||
"exec",
|
||
N_("Local exec file"),
|
||
N_("Use an executable file as a target.\n\
|
||
Specify the filename of the executable file.")
|
||
};
|
||
|
||
/* The target vector for executable files. */
|
||
|
||
struct exec_target final : public target_ops
|
||
{
|
||
const target_info &info () const override
|
||
{ return exec_target_info; }
|
||
|
||
strata stratum () const override { return file_stratum; }
|
||
|
||
void close () override;
|
||
enum target_xfer_status xfer_partial (enum target_object object,
|
||
const char *annex,
|
||
gdb_byte *readbuf,
|
||
const gdb_byte *writebuf,
|
||
ULONGEST offset, ULONGEST len,
|
||
ULONGEST *xfered_len) override;
|
||
struct target_section_table *get_section_table () override;
|
||
void files_info () override;
|
||
|
||
bool has_memory () override;
|
||
char *make_corefile_notes (bfd *, int *) override;
|
||
int find_memory_regions (find_memory_region_ftype func, void *data) override;
|
||
};
|
||
|
||
static exec_target exec_ops;
|
||
|
||
/* Whether to open exec and core files read-only or read-write. */
|
||
|
||
bool write_files = false;
|
||
static void
|
||
show_write_files (struct ui_file *file, int from_tty,
|
||
struct cmd_list_element *c, const char *value)
|
||
{
|
||
fprintf_filtered (file, _("Writing into executable and core files is %s.\n"),
|
||
value);
|
||
}
|
||
|
||
|
||
static void
|
||
exec_target_open (const char *args, int from_tty)
|
||
{
|
||
target_preopen (from_tty);
|
||
exec_file_attach (args, from_tty);
|
||
}
|
||
|
||
/* Close and clear exec_bfd. If we end up with no target sections to
|
||
read memory from, this unpushes the exec_ops target. */
|
||
|
||
void
|
||
exec_close (void)
|
||
{
|
||
if (exec_bfd)
|
||
{
|
||
bfd *abfd = exec_bfd;
|
||
|
||
gdb_bfd_unref (abfd);
|
||
|
||
/* Removing target sections may close the exec_ops target.
|
||
Clear exec_bfd before doing so to prevent recursion. */
|
||
exec_bfd = NULL;
|
||
exec_bfd_mtime = 0;
|
||
|
||
remove_target_sections (&exec_bfd);
|
||
|
||
xfree (exec_filename);
|
||
exec_filename = NULL;
|
||
}
|
||
}
|
||
|
||
/* This is the target_close implementation. Clears all target
|
||
sections and closes all executable bfds from all program spaces. */
|
||
|
||
void
|
||
exec_target::close ()
|
||
{
|
||
struct program_space *ss;
|
||
scoped_restore_current_program_space restore_pspace;
|
||
|
||
ALL_PSPACES (ss)
|
||
{
|
||
set_current_program_space (ss);
|
||
clear_section_table (current_target_sections);
|
||
exec_close ();
|
||
}
|
||
}
|
||
|
||
/* See gdbcore.h. */
|
||
|
||
void
|
||
try_open_exec_file (const char *exec_file_host, struct inferior *inf,
|
||
symfile_add_flags add_flags)
|
||
{
|
||
struct gdb_exception prev_err;
|
||
|
||
/* exec_file_attach and symbol_file_add_main may throw an error if the file
|
||
cannot be opened either locally or remotely.
|
||
|
||
This happens for example, when the file is first found in the local
|
||
sysroot (above), and then disappears (a TOCTOU race), or when it doesn't
|
||
exist in the target filesystem, or when the file does exist, but
|
||
is not readable.
|
||
|
||
Even without a symbol file, the remote-based debugging session should
|
||
continue normally instead of ending abruptly. Hence we catch thrown
|
||
errors/exceptions in the following code. */
|
||
try
|
||
{
|
||
/* We must do this step even if exec_file_host is NULL, so that
|
||
exec_file_attach will clear state. */
|
||
exec_file_attach (exec_file_host, add_flags & SYMFILE_VERBOSE);
|
||
}
|
||
catch (gdb_exception_error &err)
|
||
{
|
||
if (err.message != NULL)
|
||
warning ("%s", err.what ());
|
||
|
||
prev_err = std::move (err);
|
||
}
|
||
|
||
if (exec_file_host != NULL)
|
||
{
|
||
try
|
||
{
|
||
symbol_file_add_main (exec_file_host, add_flags);
|
||
}
|
||
catch (const gdb_exception_error &err)
|
||
{
|
||
if (!exception_print_same (prev_err, err))
|
||
warning ("%s", err.what ());
|
||
}
|
||
}
|
||
}
|
||
|
||
/* See gdbcore.h. */
|
||
|
||
void
|
||
exec_file_locate_attach (int pid, int defer_bp_reset, int from_tty)
|
||
{
|
||
char *exec_file_target;
|
||
symfile_add_flags add_flags = 0;
|
||
|
||
/* Do nothing if we already have an executable filename. */
|
||
if (get_exec_file (0) != NULL)
|
||
return;
|
||
|
||
/* Try to determine a filename from the process itself. */
|
||
exec_file_target = target_pid_to_exec_file (pid);
|
||
if (exec_file_target == NULL)
|
||
{
|
||
warning (_("No executable has been specified and target does not "
|
||
"support\n"
|
||
"determining executable automatically. "
|
||
"Try using the \"file\" command."));
|
||
return;
|
||
}
|
||
|
||
gdb::unique_xmalloc_ptr<char> exec_file_host
|
||
= exec_file_find (exec_file_target, NULL);
|
||
|
||
if (defer_bp_reset)
|
||
add_flags |= SYMFILE_DEFER_BP_RESET;
|
||
|
||
if (from_tty)
|
||
add_flags |= SYMFILE_VERBOSE;
|
||
|
||
/* Attempt to open the exec file. */
|
||
try_open_exec_file (exec_file_host.get (), current_inferior (), add_flags);
|
||
}
|
||
|
||
/* Set FILENAME as the new exec file.
|
||
|
||
This function is intended to be behave essentially the same
|
||
as exec_file_command, except that the latter will detect when
|
||
a target is being debugged, and will ask the user whether it
|
||
should be shut down first. (If the answer is "no", then the
|
||
new file is ignored.)
|
||
|
||
This file is used by exec_file_command, to do the work of opening
|
||
and processing the exec file after any prompting has happened.
|
||
|
||
And, it is used by child_attach, when the attach command was
|
||
given a pid but not a exec pathname, and the attach command could
|
||
figure out the pathname from the pid. (In this case, we shouldn't
|
||
ask the user whether the current target should be shut down --
|
||
we're supplying the exec pathname late for good reason.) */
|
||
|
||
void
|
||
exec_file_attach (const char *filename, int from_tty)
|
||
{
|
||
/* First, acquire a reference to the current exec_bfd. We release
|
||
this at the end of the function; but acquiring it now lets the
|
||
BFD cache return it if this call refers to the same file. */
|
||
gdb_bfd_ref_ptr exec_bfd_holder = gdb_bfd_ref_ptr::new_reference (exec_bfd);
|
||
|
||
/* Remove any previous exec file. */
|
||
exec_close ();
|
||
|
||
/* Now open and digest the file the user requested, if any. */
|
||
|
||
if (!filename)
|
||
{
|
||
if (from_tty)
|
||
printf_unfiltered (_("No executable file now.\n"));
|
||
|
||
set_gdbarch_from_file (NULL);
|
||
}
|
||
else
|
||
{
|
||
int load_via_target = 0;
|
||
const char *scratch_pathname, *canonical_pathname;
|
||
int scratch_chan;
|
||
struct target_section *sections = NULL, *sections_end = NULL;
|
||
char **matching;
|
||
|
||
if (is_target_filename (filename))
|
||
{
|
||
if (target_filesystem_is_local ())
|
||
filename += strlen (TARGET_SYSROOT_PREFIX);
|
||
else
|
||
load_via_target = 1;
|
||
}
|
||
|
||
gdb::unique_xmalloc_ptr<char> canonical_storage, scratch_storage;
|
||
if (load_via_target)
|
||
{
|
||
/* gdb_bfd_fopen does not support "target:" filenames. */
|
||
if (write_files)
|
||
warning (_("writing into executable files is "
|
||
"not supported for %s sysroots"),
|
||
TARGET_SYSROOT_PREFIX);
|
||
|
||
scratch_pathname = filename;
|
||
scratch_chan = -1;
|
||
canonical_pathname = scratch_pathname;
|
||
}
|
||
else
|
||
{
|
||
scratch_chan = openp (getenv ("PATH"), OPF_TRY_CWD_FIRST,
|
||
filename, write_files ?
|
||
O_RDWR | O_BINARY : O_RDONLY | O_BINARY,
|
||
&scratch_storage);
|
||
#if defined(__GO32__) || defined(_WIN32) || defined(__CYGWIN__)
|
||
if (scratch_chan < 0)
|
||
{
|
||
char *exename = (char *) alloca (strlen (filename) + 5);
|
||
|
||
strcat (strcpy (exename, filename), ".exe");
|
||
scratch_chan = openp (getenv ("PATH"), OPF_TRY_CWD_FIRST,
|
||
exename, write_files ?
|
||
O_RDWR | O_BINARY
|
||
: O_RDONLY | O_BINARY,
|
||
&scratch_storage);
|
||
}
|
||
#endif
|
||
if (scratch_chan < 0)
|
||
perror_with_name (filename);
|
||
|
||
scratch_pathname = scratch_storage.get ();
|
||
|
||
/* gdb_bfd_open (and its variants) prefers canonicalized
|
||
pathname for better BFD caching. */
|
||
canonical_storage = gdb_realpath (scratch_pathname);
|
||
canonical_pathname = canonical_storage.get ();
|
||
}
|
||
|
||
gdb_bfd_ref_ptr temp;
|
||
if (write_files && !load_via_target)
|
||
temp = gdb_bfd_fopen (canonical_pathname, gnutarget,
|
||
FOPEN_RUB, scratch_chan);
|
||
else
|
||
temp = gdb_bfd_open (canonical_pathname, gnutarget, scratch_chan);
|
||
exec_bfd = temp.release ();
|
||
|
||
if (!exec_bfd)
|
||
{
|
||
error (_("\"%s\": could not open as an executable file: %s."),
|
||
scratch_pathname, bfd_errmsg (bfd_get_error ()));
|
||
}
|
||
|
||
/* gdb_realpath_keepfile resolves symlinks on the local
|
||
filesystem and so cannot be used for "target:" files. */
|
||
gdb_assert (exec_filename == NULL);
|
||
if (load_via_target)
|
||
exec_filename = xstrdup (bfd_get_filename (exec_bfd));
|
||
else
|
||
exec_filename = gdb_realpath_keepfile (scratch_pathname).release ();
|
||
|
||
if (!bfd_check_format_matches (exec_bfd, bfd_object, &matching))
|
||
{
|
||
/* Make sure to close exec_bfd, or else "run" might try to use
|
||
it. */
|
||
exec_close ();
|
||
error (_("\"%s\": not in executable format: %s"),
|
||
scratch_pathname,
|
||
gdb_bfd_errmsg (bfd_get_error (), matching).c_str ());
|
||
}
|
||
|
||
if (build_section_table (exec_bfd, §ions, §ions_end))
|
||
{
|
||
/* Make sure to close exec_bfd, or else "run" might try to use
|
||
it. */
|
||
exec_close ();
|
||
error (_("\"%s\": can't find the file sections: %s"),
|
||
scratch_pathname, bfd_errmsg (bfd_get_error ()));
|
||
}
|
||
|
||
exec_bfd_mtime = bfd_get_mtime (exec_bfd);
|
||
|
||
validate_files ();
|
||
|
||
set_gdbarch_from_file (exec_bfd);
|
||
|
||
/* Add the executable's sections to the current address spaces'
|
||
list of sections. This possibly pushes the exec_ops
|
||
target. */
|
||
add_target_sections (&exec_bfd, sections, sections_end);
|
||
xfree (sections);
|
||
|
||
/* Tell display code (if any) about the changed file name. */
|
||
if (deprecated_exec_file_display_hook)
|
||
(*deprecated_exec_file_display_hook) (filename);
|
||
}
|
||
|
||
bfd_cache_close_all ();
|
||
gdb::observers::executable_changed.notify ();
|
||
}
|
||
|
||
/* Process the first arg in ARGS as the new exec file.
|
||
|
||
Note that we have to explicitly ignore additional args, since we can
|
||
be called from file_command(), which also calls symbol_file_command()
|
||
which can take multiple args.
|
||
|
||
If ARGS is NULL, we just want to close the exec file. */
|
||
|
||
static void
|
||
exec_file_command (const char *args, int from_tty)
|
||
{
|
||
if (from_tty && target_has_execution
|
||
&& !query (_("A program is being debugged already.\n"
|
||
"Are you sure you want to change the file? ")))
|
||
error (_("File not changed."));
|
||
|
||
if (args)
|
||
{
|
||
/* Scan through the args and pick up the first non option arg
|
||
as the filename. */
|
||
|
||
gdb_argv built_argv (args);
|
||
char **argv = built_argv.get ();
|
||
|
||
for (; (*argv != NULL) && (**argv == '-'); argv++)
|
||
{;
|
||
}
|
||
if (*argv == NULL)
|
||
error (_("No executable file name was specified"));
|
||
|
||
gdb::unique_xmalloc_ptr<char> filename (tilde_expand (*argv));
|
||
exec_file_attach (filename.get (), from_tty);
|
||
}
|
||
else
|
||
exec_file_attach (NULL, from_tty);
|
||
}
|
||
|
||
/* Set both the exec file and the symbol file, in one command.
|
||
What a novelty. Why did GDB go through four major releases before this
|
||
command was added? */
|
||
|
||
static void
|
||
file_command (const char *arg, int from_tty)
|
||
{
|
||
/* FIXME, if we lose on reading the symbol file, we should revert
|
||
the exec file, but that's rough. */
|
||
exec_file_command (arg, from_tty);
|
||
symbol_file_command (arg, from_tty);
|
||
if (deprecated_file_changed_hook)
|
||
deprecated_file_changed_hook (arg);
|
||
}
|
||
|
||
|
||
/* Locate all mappable sections of a BFD file.
|
||
table_pp_char is a char * to get it through bfd_map_over_sections;
|
||
we cast it back to its proper type. */
|
||
|
||
static void
|
||
add_to_section_table (bfd *abfd, struct bfd_section *asect,
|
||
void *table_pp_char)
|
||
{
|
||
struct target_section **table_pp = (struct target_section **) table_pp_char;
|
||
flagword aflag;
|
||
|
||
gdb_assert (abfd == asect->owner);
|
||
|
||
/* Check the section flags, but do not discard zero-length sections, since
|
||
some symbols may still be attached to this section. For instance, we
|
||
encountered on sparc-solaris 2.10 a shared library with an empty .bss
|
||
section to which a symbol named "_end" was attached. The address
|
||
of this symbol still needs to be relocated. */
|
||
aflag = bfd_section_flags (asect);
|
||
if (!(aflag & SEC_ALLOC))
|
||
return;
|
||
|
||
(*table_pp)->owner = NULL;
|
||
(*table_pp)->the_bfd_section = asect;
|
||
(*table_pp)->addr = bfd_section_vma (asect);
|
||
(*table_pp)->endaddr = (*table_pp)->addr + bfd_section_size (asect);
|
||
(*table_pp)++;
|
||
}
|
||
|
||
/* See exec.h. */
|
||
|
||
void
|
||
clear_section_table (struct target_section_table *table)
|
||
{
|
||
xfree (table->sections);
|
||
table->sections = table->sections_end = NULL;
|
||
}
|
||
|
||
/* Resize section table TABLE by ADJUSTMENT.
|
||
ADJUSTMENT may be negative, in which case the caller must have already
|
||
removed the sections being deleted.
|
||
Returns the old size. */
|
||
|
||
static int
|
||
resize_section_table (struct target_section_table *table, int adjustment)
|
||
{
|
||
int old_count;
|
||
int new_count;
|
||
|
||
old_count = table->sections_end - table->sections;
|
||
|
||
new_count = adjustment + old_count;
|
||
|
||
if (new_count)
|
||
{
|
||
table->sections = XRESIZEVEC (struct target_section, table->sections,
|
||
new_count);
|
||
table->sections_end = table->sections + new_count;
|
||
}
|
||
else
|
||
clear_section_table (table);
|
||
|
||
return old_count;
|
||
}
|
||
|
||
/* Builds a section table, given args BFD, SECTABLE_PTR, SECEND_PTR.
|
||
Returns 0 if OK, 1 on error. */
|
||
|
||
int
|
||
build_section_table (struct bfd *some_bfd, struct target_section **start,
|
||
struct target_section **end)
|
||
{
|
||
unsigned count;
|
||
|
||
count = bfd_count_sections (some_bfd);
|
||
if (*start)
|
||
xfree (* start);
|
||
*start = XNEWVEC (struct target_section, count);
|
||
*end = *start;
|
||
bfd_map_over_sections (some_bfd, add_to_section_table, (char *) end);
|
||
if (*end > *start + count)
|
||
internal_error (__FILE__, __LINE__,
|
||
_("failed internal consistency check"));
|
||
/* We could realloc the table, but it probably loses for most files. */
|
||
return 0;
|
||
}
|
||
|
||
/* Add the sections array defined by [SECTIONS..SECTIONS_END[ to the
|
||
current set of target sections. */
|
||
|
||
void
|
||
add_target_sections (void *owner,
|
||
struct target_section *sections,
|
||
struct target_section *sections_end)
|
||
{
|
||
int count;
|
||
struct target_section_table *table = current_target_sections;
|
||
|
||
count = sections_end - sections;
|
||
|
||
if (count > 0)
|
||
{
|
||
int space = resize_section_table (table, count);
|
||
int i;
|
||
|
||
for (i = 0; i < count; ++i)
|
||
{
|
||
table->sections[space + i] = sections[i];
|
||
table->sections[space + i].owner = owner;
|
||
}
|
||
|
||
scoped_restore_current_thread restore_thread;
|
||
program_space *curr_pspace = current_program_space;
|
||
|
||
/* If these are the first file sections we can provide memory
|
||
from, push the file_stratum target. Must do this in all
|
||
inferiors sharing the program space. */
|
||
for (inferior *inf : all_inferiors ())
|
||
{
|
||
if (inf->pspace != curr_pspace)
|
||
continue;
|
||
|
||
if (inf->target_is_pushed (&exec_ops))
|
||
continue;
|
||
|
||
switch_to_inferior_no_thread (inf);
|
||
push_target (&exec_ops);
|
||
}
|
||
}
|
||
}
|
||
|
||
/* Add the sections of OBJFILE to the current set of target sections. */
|
||
|
||
void
|
||
add_target_sections_of_objfile (struct objfile *objfile)
|
||
{
|
||
struct target_section_table *table = current_target_sections;
|
||
struct obj_section *osect;
|
||
int space;
|
||
unsigned count = 0;
|
||
struct target_section *ts;
|
||
|
||
if (objfile == NULL)
|
||
return;
|
||
|
||
/* Compute the number of sections to add. */
|
||
ALL_OBJFILE_OSECTIONS (objfile, osect)
|
||
{
|
||
if (bfd_section_size (osect->the_bfd_section) == 0)
|
||
continue;
|
||
count++;
|
||
}
|
||
|
||
if (count == 0)
|
||
return;
|
||
|
||
space = resize_section_table (table, count);
|
||
|
||
ts = table->sections + space;
|
||
|
||
ALL_OBJFILE_OSECTIONS (objfile, osect)
|
||
{
|
||
if (bfd_section_size (osect->the_bfd_section) == 0)
|
||
continue;
|
||
|
||
gdb_assert (ts < table->sections + space + count);
|
||
|
||
ts->addr = obj_section_addr (osect);
|
||
ts->endaddr = obj_section_endaddr (osect);
|
||
ts->the_bfd_section = osect->the_bfd_section;
|
||
ts->owner = (void *) objfile;
|
||
|
||
ts++;
|
||
}
|
||
}
|
||
|
||
/* Remove all target sections owned by OWNER.
|
||
OWNER must be the same value passed to add_target_sections. */
|
||
|
||
void
|
||
remove_target_sections (void *owner)
|
||
{
|
||
struct target_section *src, *dest;
|
||
struct target_section_table *table = current_target_sections;
|
||
|
||
gdb_assert (owner != NULL);
|
||
|
||
dest = table->sections;
|
||
for (src = table->sections; src < table->sections_end; src++)
|
||
if (src->owner != owner)
|
||
{
|
||
/* Keep this section. */
|
||
if (dest < src)
|
||
*dest = *src;
|
||
dest++;
|
||
}
|
||
|
||
/* If we've dropped any sections, resize the section table. */
|
||
if (dest < src)
|
||
{
|
||
int old_count;
|
||
|
||
old_count = resize_section_table (table, dest - src);
|
||
|
||
/* If we don't have any more sections to read memory from,
|
||
remove the file_stratum target from the stack of each
|
||
inferior sharing the program space. */
|
||
if (old_count + (dest - src) == 0)
|
||
{
|
||
scoped_restore_current_thread restore_thread;
|
||
program_space *curr_pspace = current_program_space;
|
||
|
||
for (inferior *inf : all_inferiors ())
|
||
{
|
||
if (inf->pspace != curr_pspace)
|
||
continue;
|
||
|
||
if (inf->pspace->target_sections.sections
|
||
!= inf->pspace->target_sections.sections_end)
|
||
continue;
|
||
|
||
switch_to_inferior_no_thread (inf);
|
||
unpush_target (&exec_ops);
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
/* See exec.h. */
|
||
|
||
void
|
||
exec_on_vfork ()
|
||
{
|
||
if (current_program_space->target_sections.sections
|
||
!= current_program_space->target_sections.sections_end)
|
||
push_target (&exec_ops);
|
||
}
|
||
|
||
|
||
|
||
enum target_xfer_status
|
||
exec_read_partial_read_only (gdb_byte *readbuf, ULONGEST offset,
|
||
ULONGEST len, ULONGEST *xfered_len)
|
||
{
|
||
/* It's unduly pedantic to refuse to look at the executable for
|
||
read-only pieces; so do the equivalent of readonly regions aka
|
||
QTro packet. */
|
||
if (exec_bfd != NULL)
|
||
{
|
||
asection *s;
|
||
bfd_size_type size;
|
||
bfd_vma vma;
|
||
|
||
for (s = exec_bfd->sections; s; s = s->next)
|
||
{
|
||
if ((s->flags & SEC_LOAD) == 0
|
||
|| (s->flags & SEC_READONLY) == 0)
|
||
continue;
|
||
|
||
vma = s->vma;
|
||
size = bfd_section_size (s);
|
||
if (vma <= offset && offset < (vma + size))
|
||
{
|
||
ULONGEST amt;
|
||
|
||
amt = (vma + size) - offset;
|
||
if (amt > len)
|
||
amt = len;
|
||
|
||
amt = bfd_get_section_contents (exec_bfd, s,
|
||
readbuf, offset - vma, amt);
|
||
|
||
if (amt == 0)
|
||
return TARGET_XFER_EOF;
|
||
else
|
||
{
|
||
*xfered_len = amt;
|
||
return TARGET_XFER_OK;
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
/* Indicate failure to find the requested memory block. */
|
||
return TARGET_XFER_E_IO;
|
||
}
|
||
|
||
/* Return all read-only memory ranges found in the target section
|
||
table defined by SECTIONS and SECTIONS_END, starting at (and
|
||
intersected with) MEMADDR for LEN bytes. */
|
||
|
||
static std::vector<mem_range>
|
||
section_table_available_memory (CORE_ADDR memaddr, ULONGEST len,
|
||
struct target_section *sections,
|
||
struct target_section *sections_end)
|
||
{
|
||
std::vector<mem_range> memory;
|
||
|
||
for (target_section *p = sections; p < sections_end; p++)
|
||
{
|
||
if ((bfd_section_flags (p->the_bfd_section) & SEC_READONLY) == 0)
|
||
continue;
|
||
|
||
/* Copy the meta-data, adjusted. */
|
||
if (mem_ranges_overlap (p->addr, p->endaddr - p->addr, memaddr, len))
|
||
{
|
||
ULONGEST lo1, hi1, lo2, hi2;
|
||
|
||
lo1 = memaddr;
|
||
hi1 = memaddr + len;
|
||
|
||
lo2 = p->addr;
|
||
hi2 = p->endaddr;
|
||
|
||
CORE_ADDR start = std::max (lo1, lo2);
|
||
int length = std::min (hi1, hi2) - start;
|
||
|
||
memory.emplace_back (start, length);
|
||
}
|
||
}
|
||
|
||
return memory;
|
||
}
|
||
|
||
enum target_xfer_status
|
||
section_table_read_available_memory (gdb_byte *readbuf, ULONGEST offset,
|
||
ULONGEST len, ULONGEST *xfered_len)
|
||
{
|
||
target_section_table *table = target_get_section_table (&exec_ops);
|
||
std::vector<mem_range> available_memory
|
||
= section_table_available_memory (offset, len,
|
||
table->sections, table->sections_end);
|
||
|
||
normalize_mem_ranges (&available_memory);
|
||
|
||
for (const mem_range &r : available_memory)
|
||
{
|
||
if (mem_ranges_overlap (r.start, r.length, offset, len))
|
||
{
|
||
CORE_ADDR end;
|
||
enum target_xfer_status status;
|
||
|
||
/* Get the intersection window. */
|
||
end = std::min<CORE_ADDR> (offset + len, r.start + r.length);
|
||
|
||
gdb_assert (end - offset <= len);
|
||
|
||
if (offset >= r.start)
|
||
status = exec_read_partial_read_only (readbuf, offset,
|
||
end - offset,
|
||
xfered_len);
|
||
else
|
||
{
|
||
*xfered_len = r.start - offset;
|
||
status = TARGET_XFER_UNAVAILABLE;
|
||
}
|
||
return status;
|
||
}
|
||
}
|
||
|
||
*xfered_len = len;
|
||
return TARGET_XFER_UNAVAILABLE;
|
||
}
|
||
|
||
enum target_xfer_status
|
||
section_table_xfer_memory_partial (gdb_byte *readbuf, const gdb_byte *writebuf,
|
||
ULONGEST offset, ULONGEST len,
|
||
ULONGEST *xfered_len,
|
||
struct target_section *sections,
|
||
struct target_section *sections_end,
|
||
const char *section_name)
|
||
{
|
||
int res;
|
||
struct target_section *p;
|
||
ULONGEST memaddr = offset;
|
||
ULONGEST memend = memaddr + len;
|
||
|
||
if (len == 0)
|
||
internal_error (__FILE__, __LINE__,
|
||
_("failed internal consistency check"));
|
||
|
||
for (p = sections; p < sections_end; p++)
|
||
{
|
||
struct bfd_section *asect = p->the_bfd_section;
|
||
bfd *abfd = asect->owner;
|
||
|
||
if (section_name && strcmp (section_name, asect->name) != 0)
|
||
continue; /* not the section we need. */
|
||
if (memaddr >= p->addr)
|
||
{
|
||
if (memend <= p->endaddr)
|
||
{
|
||
/* Entire transfer is within this section. */
|
||
if (writebuf)
|
||
res = bfd_set_section_contents (abfd, asect,
|
||
writebuf, memaddr - p->addr,
|
||
len);
|
||
else
|
||
res = bfd_get_section_contents (abfd, asect,
|
||
readbuf, memaddr - p->addr,
|
||
len);
|
||
|
||
if (res != 0)
|
||
{
|
||
*xfered_len = len;
|
||
return TARGET_XFER_OK;
|
||
}
|
||
else
|
||
return TARGET_XFER_EOF;
|
||
}
|
||
else if (memaddr >= p->endaddr)
|
||
{
|
||
/* This section ends before the transfer starts. */
|
||
continue;
|
||
}
|
||
else
|
||
{
|
||
/* This section overlaps the transfer. Just do half. */
|
||
len = p->endaddr - memaddr;
|
||
if (writebuf)
|
||
res = bfd_set_section_contents (abfd, asect,
|
||
writebuf, memaddr - p->addr,
|
||
len);
|
||
else
|
||
res = bfd_get_section_contents (abfd, asect,
|
||
readbuf, memaddr - p->addr,
|
||
len);
|
||
if (res != 0)
|
||
{
|
||
*xfered_len = len;
|
||
return TARGET_XFER_OK;
|
||
}
|
||
else
|
||
return TARGET_XFER_EOF;
|
||
}
|
||
}
|
||
}
|
||
|
||
return TARGET_XFER_EOF; /* We can't help. */
|
||
}
|
||
|
||
struct target_section_table *
|
||
exec_target::get_section_table ()
|
||
{
|
||
return current_target_sections;
|
||
}
|
||
|
||
enum target_xfer_status
|
||
exec_target::xfer_partial (enum target_object object,
|
||
const char *annex, gdb_byte *readbuf,
|
||
const gdb_byte *writebuf,
|
||
ULONGEST offset, ULONGEST len, ULONGEST *xfered_len)
|
||
{
|
||
struct target_section_table *table = get_section_table ();
|
||
|
||
if (object == TARGET_OBJECT_MEMORY)
|
||
return section_table_xfer_memory_partial (readbuf, writebuf,
|
||
offset, len, xfered_len,
|
||
table->sections,
|
||
table->sections_end,
|
||
NULL);
|
||
else
|
||
return TARGET_XFER_E_IO;
|
||
}
|
||
|
||
|
||
void
|
||
print_section_info (struct target_section_table *t, bfd *abfd)
|
||
{
|
||
struct gdbarch *gdbarch = gdbarch_from_bfd (abfd);
|
||
struct target_section *p;
|
||
/* FIXME: 16 is not wide enough when gdbarch_addr_bit > 64. */
|
||
int wid = gdbarch_addr_bit (gdbarch) <= 32 ? 8 : 16;
|
||
|
||
printf_filtered ("\t`%s', ", bfd_get_filename (abfd));
|
||
wrap_here (" ");
|
||
printf_filtered (_("file type %s.\n"), bfd_get_target (abfd));
|
||
if (abfd == exec_bfd)
|
||
{
|
||
/* gcc-3.4 does not like the initialization in
|
||
<p == t->sections_end>. */
|
||
bfd_vma displacement = 0;
|
||
bfd_vma entry_point;
|
||
|
||
for (p = t->sections; p < t->sections_end; p++)
|
||
{
|
||
struct bfd_section *psect = p->the_bfd_section;
|
||
|
||
if ((bfd_section_flags (psect) & (SEC_ALLOC | SEC_LOAD))
|
||
!= (SEC_ALLOC | SEC_LOAD))
|
||
continue;
|
||
|
||
if (bfd_section_vma (psect) <= abfd->start_address
|
||
&& abfd->start_address < (bfd_section_vma (psect)
|
||
+ bfd_section_size (psect)))
|
||
{
|
||
displacement = p->addr - bfd_section_vma (psect);
|
||
break;
|
||
}
|
||
}
|
||
if (p == t->sections_end)
|
||
warning (_("Cannot find section for the entry point of %s."),
|
||
bfd_get_filename (abfd));
|
||
|
||
entry_point = gdbarch_addr_bits_remove (gdbarch,
|
||
bfd_get_start_address (abfd)
|
||
+ displacement);
|
||
printf_filtered (_("\tEntry point: %s\n"),
|
||
paddress (gdbarch, entry_point));
|
||
}
|
||
for (p = t->sections; p < t->sections_end; p++)
|
||
{
|
||
struct bfd_section *psect = p->the_bfd_section;
|
||
bfd *pbfd = psect->owner;
|
||
|
||
printf_filtered ("\t%s", hex_string_custom (p->addr, wid));
|
||
printf_filtered (" - %s", hex_string_custom (p->endaddr, wid));
|
||
|
||
/* FIXME: A format of "08l" is not wide enough for file offsets
|
||
larger than 4GB. OTOH, making it "016l" isn't desirable either
|
||
since most output will then be much wider than necessary. It
|
||
may make sense to test the size of the file and choose the
|
||
format string accordingly. */
|
||
/* FIXME: i18n: Need to rewrite this sentence. */
|
||
if (info_verbose)
|
||
printf_filtered (" @ %s",
|
||
hex_string_custom (psect->filepos, 8));
|
||
printf_filtered (" is %s", bfd_section_name (psect));
|
||
if (pbfd != abfd)
|
||
printf_filtered (" in %s", bfd_get_filename (pbfd));
|
||
printf_filtered ("\n");
|
||
}
|
||
}
|
||
|
||
void
|
||
exec_target::files_info ()
|
||
{
|
||
if (exec_bfd)
|
||
print_section_info (current_target_sections, exec_bfd);
|
||
else
|
||
puts_filtered (_("\t<no file loaded>\n"));
|
||
}
|
||
|
||
static void
|
||
set_section_command (const char *args, int from_tty)
|
||
{
|
||
struct target_section *p;
|
||
const char *secname;
|
||
unsigned seclen;
|
||
unsigned long secaddr;
|
||
char secprint[100];
|
||
long offset;
|
||
struct target_section_table *table;
|
||
|
||
if (args == 0)
|
||
error (_("Must specify section name and its virtual address"));
|
||
|
||
/* Parse out section name. */
|
||
for (secname = args; !isspace (*args); args++);
|
||
seclen = args - secname;
|
||
|
||
/* Parse out new virtual address. */
|
||
secaddr = parse_and_eval_address (args);
|
||
|
||
table = current_target_sections;
|
||
for (p = table->sections; p < table->sections_end; p++)
|
||
{
|
||
if (!strncmp (secname, bfd_section_name (p->the_bfd_section), seclen)
|
||
&& bfd_section_name (p->the_bfd_section)[seclen] == '\0')
|
||
{
|
||
offset = secaddr - p->addr;
|
||
p->addr += offset;
|
||
p->endaddr += offset;
|
||
if (from_tty)
|
||
exec_ops.files_info ();
|
||
return;
|
||
}
|
||
}
|
||
if (seclen >= sizeof (secprint))
|
||
seclen = sizeof (secprint) - 1;
|
||
strncpy (secprint, secname, seclen);
|
||
secprint[seclen] = '\0';
|
||
error (_("Section %s not found"), secprint);
|
||
}
|
||
|
||
/* If we can find a section in FILENAME with BFD index INDEX, adjust
|
||
it to ADDRESS. */
|
||
|
||
void
|
||
exec_set_section_address (const char *filename, int index, CORE_ADDR address)
|
||
{
|
||
struct target_section *p;
|
||
struct target_section_table *table;
|
||
|
||
table = current_target_sections;
|
||
for (p = table->sections; p < table->sections_end; p++)
|
||
{
|
||
if (filename_cmp (filename, p->the_bfd_section->owner->filename) == 0
|
||
&& index == p->the_bfd_section->index)
|
||
{
|
||
p->endaddr += address - p->addr;
|
||
p->addr = address;
|
||
}
|
||
}
|
||
}
|
||
|
||
bool
|
||
exec_target::has_memory ()
|
||
{
|
||
/* We can provide memory if we have any file/target sections to read
|
||
from. */
|
||
return (current_target_sections->sections
|
||
!= current_target_sections->sections_end);
|
||
}
|
||
|
||
char *
|
||
exec_target::make_corefile_notes (bfd *obfd, int *note_size)
|
||
{
|
||
error (_("Can't create a corefile"));
|
||
}
|
||
|
||
int
|
||
exec_target::find_memory_regions (find_memory_region_ftype func, void *data)
|
||
{
|
||
return objfile_find_memory_regions (this, func, data);
|
||
}
|
||
|
||
void _initialize_exec ();
|
||
void
|
||
_initialize_exec ()
|
||
{
|
||
struct cmd_list_element *c;
|
||
|
||
if (!dbx_commands)
|
||
{
|
||
c = add_cmd ("file", class_files, file_command, _("\
|
||
Use FILE as program to be debugged.\n\
|
||
It is read for its symbols, for getting the contents of pure memory,\n\
|
||
and it is the program executed when you use the `run' command.\n\
|
||
If FILE cannot be found as specified, your execution directory path\n\
|
||
($PATH) is searched for a command of that name.\n\
|
||
No arg means to have no executable file and no symbols."), &cmdlist);
|
||
set_cmd_completer (c, filename_completer);
|
||
}
|
||
|
||
c = add_cmd ("exec-file", class_files, exec_file_command, _("\
|
||
Use FILE as program for getting contents of pure memory.\n\
|
||
If FILE cannot be found as specified, your execution directory path\n\
|
||
is searched for a command of that name.\n\
|
||
No arg means have no executable file."), &cmdlist);
|
||
set_cmd_completer (c, filename_completer);
|
||
|
||
add_com ("section", class_files, set_section_command, _("\
|
||
Change the base address of section SECTION of the exec file to ADDR.\n\
|
||
This can be used if the exec file does not contain section addresses,\n\
|
||
(such as in the a.out format), or when the addresses specified in the\n\
|
||
file itself are wrong. Each section must be changed separately. The\n\
|
||
``info files'' command lists all the sections and their addresses."));
|
||
|
||
add_setshow_boolean_cmd ("write", class_support, &write_files, _("\
|
||
Set writing into executable and core files."), _("\
|
||
Show writing into executable and core files."), NULL,
|
||
NULL,
|
||
show_write_files,
|
||
&setlist, &showlist);
|
||
|
||
add_target (exec_target_info, exec_target_open, filename_completer);
|
||
}
|