mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-27 04:52:05 +08:00
dda83cd783
Many spots incorrectly use only spaces for indentation (for example, there are a lot of spots in ada-lang.c). I've always found it awkward when I needed to edit one of these spots: do I keep the original wrong indentation, or do I fix it? What if the lines around it are also wrong, do I fix them too? I probably don't want to fix them in the same patch, to avoid adding noise to my patch. So I propose to fix as much as possible once and for all (hopefully). One typical counter argument for this is that it makes code archeology more difficult, because git-blame will show this commit as the last change for these lines. My counter counter argument is: when git-blaming, you often need to do "blame the file at the parent commit" anyway, to go past some other refactor that touched the line you are interested in, but is not the change you are looking for. So you already need a somewhat efficient way to do this. Using some interactive tool, rather than plain git-blame, makes this trivial. For example, I use "tig blame <file>", where going back past the commit that changed the currently selected line is one keystroke. It looks like Magit in Emacs does it too (though I've never used it). Web viewers of Github and Gitlab do it too. My point is that it won't really make archeology more difficult. The other typical counter argument is that it will cause conflicts with existing patches. That's true... but it's a one time cost, and those are not conflicts that are difficult to resolve. I have also tried "git rebase --ignore-whitespace", it seems to work well. Although that will re-introduce the faulty indentation, so one needs to take care of fixing the indentation in the patch after that (which is easy). gdb/ChangeLog: * aarch64-linux-tdep.c: Fix indentation. * aarch64-ravenscar-thread.c: Fix indentation. * aarch64-tdep.c: Fix indentation. * aarch64-tdep.h: Fix indentation. * ada-lang.c: Fix indentation. * ada-lang.h: Fix indentation. * ada-tasks.c: Fix indentation. * ada-typeprint.c: Fix indentation. * ada-valprint.c: Fix indentation. * ada-varobj.c: Fix indentation. * addrmap.c: Fix indentation. * addrmap.h: Fix indentation. * agent.c: Fix indentation. * aix-thread.c: Fix indentation. * alpha-bsd-nat.c: Fix indentation. * alpha-linux-tdep.c: Fix indentation. * alpha-mdebug-tdep.c: Fix indentation. * alpha-nbsd-tdep.c: Fix indentation. * alpha-obsd-tdep.c: Fix indentation. * alpha-tdep.c: Fix indentation. * amd64-bsd-nat.c: Fix indentation. * amd64-darwin-tdep.c: Fix indentation. * amd64-linux-nat.c: Fix indentation. * amd64-linux-tdep.c: Fix indentation. * amd64-nat.c: Fix indentation. * amd64-obsd-tdep.c: Fix indentation. * amd64-tdep.c: Fix indentation. * amd64-windows-tdep.c: Fix indentation. * annotate.c: Fix indentation. * arc-tdep.c: Fix indentation. * arch-utils.c: Fix indentation. * arch/arm-get-next-pcs.c: Fix indentation. * arch/arm.c: Fix indentation. * arm-linux-nat.c: Fix indentation. * arm-linux-tdep.c: Fix indentation. * arm-nbsd-tdep.c: Fix indentation. * arm-pikeos-tdep.c: Fix indentation. * arm-tdep.c: Fix indentation. * arm-tdep.h: Fix indentation. * arm-wince-tdep.c: Fix indentation. * auto-load.c: Fix indentation. * auxv.c: Fix indentation. * avr-tdep.c: Fix indentation. * ax-gdb.c: Fix indentation. * ax-general.c: Fix indentation. * bfin-linux-tdep.c: Fix indentation. * block.c: Fix indentation. * block.h: Fix indentation. * blockframe.c: Fix indentation. * bpf-tdep.c: Fix indentation. * break-catch-sig.c: Fix indentation. * break-catch-syscall.c: Fix indentation. * break-catch-throw.c: Fix indentation. * breakpoint.c: Fix indentation. * breakpoint.h: Fix indentation. * bsd-uthread.c: Fix indentation. * btrace.c: Fix indentation. * build-id.c: Fix indentation. * buildsym-legacy.h: Fix indentation. * buildsym.c: Fix indentation. * c-typeprint.c: Fix indentation. * c-valprint.c: Fix indentation. * c-varobj.c: Fix indentation. * charset.c: Fix indentation. * cli/cli-cmds.c: Fix indentation. * cli/cli-decode.c: Fix indentation. * cli/cli-decode.h: Fix indentation. * cli/cli-script.c: Fix indentation. * cli/cli-setshow.c: Fix indentation. * coff-pe-read.c: Fix indentation. * coffread.c: Fix indentation. * compile/compile-cplus-types.c: Fix indentation. * compile/compile-object-load.c: Fix indentation. * compile/compile-object-run.c: Fix indentation. * completer.c: Fix indentation. * corefile.c: Fix indentation. * corelow.c: Fix indentation. * cp-abi.h: Fix indentation. * cp-namespace.c: Fix indentation. * cp-support.c: Fix indentation. * cp-valprint.c: Fix indentation. * cris-linux-tdep.c: Fix indentation. * cris-tdep.c: Fix indentation. * darwin-nat-info.c: Fix indentation. * darwin-nat.c: Fix indentation. * darwin-nat.h: Fix indentation. * dbxread.c: Fix indentation. * dcache.c: Fix indentation. * disasm.c: Fix indentation. * dtrace-probe.c: Fix indentation. * dwarf2/abbrev.c: Fix indentation. * dwarf2/attribute.c: Fix indentation. * dwarf2/expr.c: Fix indentation. * dwarf2/frame.c: Fix indentation. * dwarf2/index-cache.c: Fix indentation. * dwarf2/index-write.c: Fix indentation. * dwarf2/line-header.c: Fix indentation. * dwarf2/loc.c: Fix indentation. * dwarf2/macro.c: Fix indentation. * dwarf2/read.c: Fix indentation. * dwarf2/read.h: Fix indentation. * elfread.c: Fix indentation. * eval.c: Fix indentation. * event-top.c: Fix indentation. * exec.c: Fix indentation. * exec.h: Fix indentation. * expprint.c: Fix indentation. * f-lang.c: Fix indentation. * f-typeprint.c: Fix indentation. * f-valprint.c: Fix indentation. * fbsd-nat.c: Fix indentation. * fbsd-tdep.c: Fix indentation. * findvar.c: Fix indentation. * fork-child.c: Fix indentation. * frame-unwind.c: Fix indentation. * frame-unwind.h: Fix indentation. * frame.c: Fix indentation. * frv-linux-tdep.c: Fix indentation. * frv-tdep.c: Fix indentation. * frv-tdep.h: Fix indentation. * ft32-tdep.c: Fix indentation. * gcore.c: Fix indentation. * gdb_bfd.c: Fix indentation. * gdbarch.sh: Fix indentation. * gdbarch.c: Re-generate * gdbarch.h: Re-generate. * gdbcore.h: Fix indentation. * gdbthread.h: Fix indentation. * gdbtypes.c: Fix indentation. * gdbtypes.h: Fix indentation. * glibc-tdep.c: Fix indentation. * gnu-nat.c: Fix indentation. * gnu-nat.h: Fix indentation. * gnu-v2-abi.c: Fix indentation. * gnu-v3-abi.c: Fix indentation. * go32-nat.c: Fix indentation. * guile/guile-internal.h: Fix indentation. * guile/scm-cmd.c: Fix indentation. * guile/scm-frame.c: Fix indentation. * guile/scm-iterator.c: Fix indentation. * guile/scm-math.c: Fix indentation. * guile/scm-ports.c: Fix indentation. * guile/scm-pretty-print.c: Fix indentation. * guile/scm-value.c: Fix indentation. * h8300-tdep.c: Fix indentation. * hppa-linux-nat.c: Fix indentation. * hppa-linux-tdep.c: Fix indentation. * hppa-nbsd-nat.c: Fix indentation. * hppa-nbsd-tdep.c: Fix indentation. * hppa-obsd-nat.c: Fix indentation. * hppa-tdep.c: Fix indentation. * hppa-tdep.h: Fix indentation. * i386-bsd-nat.c: Fix indentation. * i386-darwin-nat.c: Fix indentation. * i386-darwin-tdep.c: Fix indentation. * i386-dicos-tdep.c: Fix indentation. * i386-gnu-nat.c: Fix indentation. * i386-linux-nat.c: Fix indentation. * i386-linux-tdep.c: Fix indentation. * i386-nto-tdep.c: Fix indentation. * i386-obsd-tdep.c: Fix indentation. * i386-sol2-nat.c: Fix indentation. * i386-tdep.c: Fix indentation. * i386-tdep.h: Fix indentation. * i386-windows-tdep.c: Fix indentation. * i387-tdep.c: Fix indentation. * i387-tdep.h: Fix indentation. * ia64-libunwind-tdep.c: Fix indentation. * ia64-libunwind-tdep.h: Fix indentation. * ia64-linux-nat.c: Fix indentation. * ia64-linux-tdep.c: Fix indentation. * ia64-tdep.c: Fix indentation. * ia64-tdep.h: Fix indentation. * ia64-vms-tdep.c: Fix indentation. * infcall.c: Fix indentation. * infcmd.c: Fix indentation. * inferior.c: Fix indentation. * infrun.c: Fix indentation. * iq2000-tdep.c: Fix indentation. * language.c: Fix indentation. * linespec.c: Fix indentation. * linux-fork.c: Fix indentation. * linux-nat.c: Fix indentation. * linux-tdep.c: Fix indentation. * linux-thread-db.c: Fix indentation. * lm32-tdep.c: Fix indentation. * m2-lang.c: Fix indentation. * m2-typeprint.c: Fix indentation. * m2-valprint.c: Fix indentation. * m32c-tdep.c: Fix indentation. * m32r-linux-tdep.c: Fix indentation. * m32r-tdep.c: Fix indentation. * m68hc11-tdep.c: Fix indentation. * m68k-bsd-nat.c: Fix indentation. * m68k-linux-nat.c: Fix indentation. * m68k-linux-tdep.c: Fix indentation. * m68k-tdep.c: Fix indentation. * machoread.c: Fix indentation. * macrocmd.c: Fix indentation. * macroexp.c: Fix indentation. * macroscope.c: Fix indentation. * macrotab.c: Fix indentation. * macrotab.h: Fix indentation. * main.c: Fix indentation. * mdebugread.c: Fix indentation. * mep-tdep.c: Fix indentation. * mi/mi-cmd-catch.c: Fix indentation. * mi/mi-cmd-disas.c: Fix indentation. * mi/mi-cmd-env.c: Fix indentation. * mi/mi-cmd-stack.c: Fix indentation. * mi/mi-cmd-var.c: Fix indentation. * mi/mi-cmds.c: Fix indentation. * mi/mi-main.c: Fix indentation. * mi/mi-parse.c: Fix indentation. * microblaze-tdep.c: Fix indentation. * minidebug.c: Fix indentation. * minsyms.c: Fix indentation. * mips-linux-nat.c: Fix indentation. * mips-linux-tdep.c: Fix indentation. * mips-nbsd-tdep.c: Fix indentation. * mips-tdep.c: Fix indentation. * mn10300-linux-tdep.c: Fix indentation. * mn10300-tdep.c: Fix indentation. * moxie-tdep.c: Fix indentation. * msp430-tdep.c: Fix indentation. * namespace.h: Fix indentation. * nat/fork-inferior.c: Fix indentation. * nat/gdb_ptrace.h: Fix indentation. * nat/linux-namespaces.c: Fix indentation. * nat/linux-osdata.c: Fix indentation. * nat/netbsd-nat.c: Fix indentation. * nat/x86-dregs.c: Fix indentation. * nbsd-nat.c: Fix indentation. * nbsd-tdep.c: Fix indentation. * nios2-linux-tdep.c: Fix indentation. * nios2-tdep.c: Fix indentation. * nto-procfs.c: Fix indentation. * nto-tdep.c: Fix indentation. * objfiles.c: Fix indentation. * objfiles.h: Fix indentation. * opencl-lang.c: Fix indentation. * or1k-tdep.c: Fix indentation. * osabi.c: Fix indentation. * osabi.h: Fix indentation. * osdata.c: Fix indentation. * p-lang.c: Fix indentation. * p-typeprint.c: Fix indentation. * p-valprint.c: Fix indentation. * parse.c: Fix indentation. * ppc-linux-nat.c: Fix indentation. * ppc-linux-tdep.c: Fix indentation. * ppc-nbsd-nat.c: Fix indentation. * ppc-nbsd-tdep.c: Fix indentation. * ppc-obsd-nat.c: Fix indentation. * ppc-ravenscar-thread.c: Fix indentation. * ppc-sysv-tdep.c: Fix indentation. * ppc64-tdep.c: Fix indentation. * printcmd.c: Fix indentation. * proc-api.c: Fix indentation. * producer.c: Fix indentation. * producer.h: Fix indentation. * prologue-value.c: Fix indentation. * prologue-value.h: Fix indentation. * psymtab.c: Fix indentation. * python/py-arch.c: Fix indentation. * python/py-bpevent.c: Fix indentation. * python/py-event.c: Fix indentation. * python/py-event.h: Fix indentation. * python/py-finishbreakpoint.c: Fix indentation. * python/py-frame.c: Fix indentation. * python/py-framefilter.c: Fix indentation. * python/py-inferior.c: Fix indentation. * python/py-infthread.c: Fix indentation. * python/py-objfile.c: Fix indentation. * python/py-prettyprint.c: Fix indentation. * python/py-registers.c: Fix indentation. * python/py-signalevent.c: Fix indentation. * python/py-stopevent.c: Fix indentation. * python/py-stopevent.h: Fix indentation. * python/py-threadevent.c: Fix indentation. * python/py-tui.c: Fix indentation. * python/py-unwind.c: Fix indentation. * python/py-value.c: Fix indentation. * python/py-xmethods.c: Fix indentation. * python/python-internal.h: Fix indentation. * python/python.c: Fix indentation. * ravenscar-thread.c: Fix indentation. * record-btrace.c: Fix indentation. * record-full.c: Fix indentation. * record.c: Fix indentation. * reggroups.c: Fix indentation. * regset.h: Fix indentation. * remote-fileio.c: Fix indentation. * remote.c: Fix indentation. * reverse.c: Fix indentation. * riscv-linux-tdep.c: Fix indentation. * riscv-ravenscar-thread.c: Fix indentation. * riscv-tdep.c: Fix indentation. * rl78-tdep.c: Fix indentation. * rs6000-aix-tdep.c: Fix indentation. * rs6000-lynx178-tdep.c: Fix indentation. * rs6000-nat.c: Fix indentation. * rs6000-tdep.c: Fix indentation. * rust-lang.c: Fix indentation. * rx-tdep.c: Fix indentation. * s12z-tdep.c: Fix indentation. * s390-linux-tdep.c: Fix indentation. * score-tdep.c: Fix indentation. * ser-base.c: Fix indentation. * ser-mingw.c: Fix indentation. * ser-uds.c: Fix indentation. * ser-unix.c: Fix indentation. * serial.c: Fix indentation. * sh-linux-tdep.c: Fix indentation. * sh-nbsd-tdep.c: Fix indentation. * sh-tdep.c: Fix indentation. * skip.c: Fix indentation. * sol-thread.c: Fix indentation. * solib-aix.c: Fix indentation. * solib-darwin.c: Fix indentation. * solib-frv.c: Fix indentation. * solib-svr4.c: Fix indentation. * solib.c: Fix indentation. * source.c: Fix indentation. * sparc-linux-tdep.c: Fix indentation. * sparc-nbsd-tdep.c: Fix indentation. * sparc-obsd-tdep.c: Fix indentation. * sparc-ravenscar-thread.c: Fix indentation. * sparc-tdep.c: Fix indentation. * sparc64-linux-tdep.c: Fix indentation. * sparc64-nbsd-tdep.c: Fix indentation. * sparc64-obsd-tdep.c: Fix indentation. * sparc64-tdep.c: Fix indentation. * stabsread.c: Fix indentation. * stack.c: Fix indentation. * stap-probe.c: Fix indentation. * stubs/ia64vms-stub.c: Fix indentation. * stubs/m32r-stub.c: Fix indentation. * stubs/m68k-stub.c: Fix indentation. * stubs/sh-stub.c: Fix indentation. * stubs/sparc-stub.c: Fix indentation. * symfile-mem.c: Fix indentation. * symfile.c: Fix indentation. * symfile.h: Fix indentation. * symmisc.c: Fix indentation. * symtab.c: Fix indentation. * symtab.h: Fix indentation. * target-float.c: Fix indentation. * target.c: Fix indentation. * target.h: Fix indentation. * tic6x-tdep.c: Fix indentation. * tilegx-linux-tdep.c: Fix indentation. * tilegx-tdep.c: Fix indentation. * top.c: Fix indentation. * tracefile-tfile.c: Fix indentation. * tracepoint.c: Fix indentation. * tui/tui-disasm.c: Fix indentation. * tui/tui-io.c: Fix indentation. * tui/tui-regs.c: Fix indentation. * tui/tui-stack.c: Fix indentation. * tui/tui-win.c: Fix indentation. * tui/tui-winsource.c: Fix indentation. * tui/tui.c: Fix indentation. * typeprint.c: Fix indentation. * ui-out.h: Fix indentation. * unittests/copy_bitwise-selftests.c: Fix indentation. * unittests/memory-map-selftests.c: Fix indentation. * utils.c: Fix indentation. * v850-tdep.c: Fix indentation. * valarith.c: Fix indentation. * valops.c: Fix indentation. * valprint.c: Fix indentation. * valprint.h: Fix indentation. * value.c: Fix indentation. * value.h: Fix indentation. * varobj.c: Fix indentation. * vax-tdep.c: Fix indentation. * windows-nat.c: Fix indentation. * windows-tdep.c: Fix indentation. * xcoffread.c: Fix indentation. * xml-syscall.c: Fix indentation. * xml-tdesc.c: Fix indentation. * xstormy16-tdep.c: Fix indentation. * xtensa-config.c: Fix indentation. * xtensa-linux-nat.c: Fix indentation. * xtensa-linux-tdep.c: Fix indentation. * xtensa-tdep.c: Fix indentation. gdbserver/ChangeLog: * ax.cc: Fix indentation. * dll.cc: Fix indentation. * inferiors.h: Fix indentation. * linux-low.cc: Fix indentation. * linux-nios2-low.cc: Fix indentation. * linux-ppc-ipa.cc: Fix indentation. * linux-ppc-low.cc: Fix indentation. * linux-x86-low.cc: Fix indentation. * linux-xtensa-low.cc: Fix indentation. * regcache.cc: Fix indentation. * server.cc: Fix indentation. * tracepoint.cc: Fix indentation. gdbsupport/ChangeLog: * common-exceptions.h: Fix indentation. * event-loop.cc: Fix indentation. * fileio.cc: Fix indentation. * filestuff.cc: Fix indentation. * gdb-dlfcn.cc: Fix indentation. * gdb_string_view.h: Fix indentation. * job-control.cc: Fix indentation. * signals.cc: Fix indentation. Change-Id: I4bad7ae6be0fbe14168b8ebafb98ffe14964a695
593 lines
17 KiB
C
593 lines
17 KiB
C
/* Generate a core file for the inferior process.
|
|
|
|
Copyright (C) 2001-2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "elf-bfd.h"
|
|
#include "infcall.h"
|
|
#include "inferior.h"
|
|
#include "gdbcore.h"
|
|
#include "objfiles.h"
|
|
#include "solib.h"
|
|
#include "symfile.h"
|
|
#include "arch-utils.h"
|
|
#include "completer.h"
|
|
#include "gcore.h"
|
|
#include "cli/cli-decode.h"
|
|
#include <fcntl.h>
|
|
#include "regcache.h"
|
|
#include "regset.h"
|
|
#include "gdb_bfd.h"
|
|
#include "readline/tilde.h"
|
|
#include <algorithm>
|
|
#include "gdbsupport/gdb_unlinker.h"
|
|
#include "gdbsupport/byte-vector.h"
|
|
#include "gdbsupport/scope-exit.h"
|
|
|
|
/* The largest amount of memory to read from the target at once. We
|
|
must throttle it to limit the amount of memory used by GDB during
|
|
generate-core-file for programs with large resident data. */
|
|
#define MAX_COPY_BYTES (1024 * 1024)
|
|
|
|
static const char *default_gcore_target (void);
|
|
static enum bfd_architecture default_gcore_arch (void);
|
|
static int gcore_memory_sections (bfd *);
|
|
|
|
/* create_gcore_bfd -- helper for gcore_command (exported).
|
|
Open a new bfd core file for output, and return the handle. */
|
|
|
|
gdb_bfd_ref_ptr
|
|
create_gcore_bfd (const char *filename)
|
|
{
|
|
gdb_bfd_ref_ptr obfd (gdb_bfd_openw (filename, default_gcore_target ()));
|
|
|
|
if (obfd == NULL)
|
|
error (_("Failed to open '%s' for output."), filename);
|
|
bfd_set_format (obfd.get (), bfd_core);
|
|
bfd_set_arch_mach (obfd.get (), default_gcore_arch (), 0);
|
|
return obfd;
|
|
}
|
|
|
|
/* write_gcore_file_1 -- do the actual work of write_gcore_file. */
|
|
|
|
static void
|
|
write_gcore_file_1 (bfd *obfd)
|
|
{
|
|
gdb::unique_xmalloc_ptr<char> note_data;
|
|
int note_size = 0;
|
|
asection *note_sec = NULL;
|
|
|
|
/* An external target method must build the notes section. */
|
|
/* FIXME: uweigand/2011-10-06: All architectures that support core file
|
|
generation should be converted to gdbarch_make_corefile_notes; at that
|
|
point, the target vector method can be removed. */
|
|
if (!gdbarch_make_corefile_notes_p (target_gdbarch ()))
|
|
note_data = target_make_corefile_notes (obfd, ¬e_size);
|
|
else
|
|
note_data = gdbarch_make_corefile_notes (target_gdbarch (), obfd,
|
|
¬e_size);
|
|
|
|
if (note_data == NULL || note_size == 0)
|
|
error (_("Target does not support core file generation."));
|
|
|
|
/* Create the note section. */
|
|
note_sec = bfd_make_section_anyway_with_flags (obfd, "note0",
|
|
SEC_HAS_CONTENTS
|
|
| SEC_READONLY
|
|
| SEC_ALLOC);
|
|
if (note_sec == NULL)
|
|
error (_("Failed to create 'note' section for corefile: %s"),
|
|
bfd_errmsg (bfd_get_error ()));
|
|
|
|
bfd_set_section_vma (note_sec, 0);
|
|
bfd_set_section_alignment (note_sec, 0);
|
|
bfd_set_section_size (note_sec, note_size);
|
|
|
|
/* Now create the memory/load sections. */
|
|
if (gcore_memory_sections (obfd) == 0)
|
|
error (_("gcore: failed to get corefile memory sections from target."));
|
|
|
|
/* Write out the contents of the note section. */
|
|
if (!bfd_set_section_contents (obfd, note_sec, note_data.get (), 0,
|
|
note_size))
|
|
warning (_("writing note section (%s)"), bfd_errmsg (bfd_get_error ()));
|
|
}
|
|
|
|
/* write_gcore_file -- helper for gcore_command (exported).
|
|
Compose and write the corefile data to the core file. */
|
|
|
|
void
|
|
write_gcore_file (bfd *obfd)
|
|
{
|
|
target_prepare_to_generate_core ();
|
|
SCOPE_EXIT { target_done_generating_core (); };
|
|
write_gcore_file_1 (obfd);
|
|
}
|
|
|
|
/* gcore_command -- implements the 'gcore' command.
|
|
Generate a core file from the inferior process. */
|
|
|
|
static void
|
|
gcore_command (const char *args, int from_tty)
|
|
{
|
|
gdb::unique_xmalloc_ptr<char> corefilename;
|
|
|
|
/* No use generating a corefile without a target process. */
|
|
if (!target_has_execution ())
|
|
noprocess ();
|
|
|
|
if (args && *args)
|
|
corefilename.reset (tilde_expand (args));
|
|
else
|
|
{
|
|
/* Default corefile name is "core.PID". */
|
|
corefilename.reset (xstrprintf ("core.%d", inferior_ptid.pid ()));
|
|
}
|
|
|
|
if (info_verbose)
|
|
fprintf_filtered (gdb_stdout,
|
|
"Opening corefile '%s' for output.\n",
|
|
corefilename.get ());
|
|
|
|
if (target_supports_dumpcore ())
|
|
target_dumpcore (corefilename.get ());
|
|
else
|
|
{
|
|
/* Open the output file. */
|
|
gdb_bfd_ref_ptr obfd (create_gcore_bfd (corefilename.get ()));
|
|
|
|
/* Arrange to unlink the file on failure. */
|
|
gdb::unlinker unlink_file (corefilename.get ());
|
|
|
|
/* Call worker function. */
|
|
write_gcore_file (obfd.get ());
|
|
|
|
/* Succeeded. */
|
|
unlink_file.keep ();
|
|
}
|
|
|
|
fprintf_filtered (gdb_stdout, "Saved corefile %s\n", corefilename.get ());
|
|
}
|
|
|
|
static enum bfd_architecture
|
|
default_gcore_arch (void)
|
|
{
|
|
const struct bfd_arch_info *bfdarch = gdbarch_bfd_arch_info (target_gdbarch ());
|
|
|
|
if (bfdarch != NULL)
|
|
return bfdarch->arch;
|
|
if (current_program_space->exec_bfd () == NULL)
|
|
error (_("Can't find bfd architecture for corefile (need execfile)."));
|
|
|
|
return bfd_get_arch (current_program_space->exec_bfd ());
|
|
}
|
|
|
|
static const char *
|
|
default_gcore_target (void)
|
|
{
|
|
/* The gdbarch may define a target to use for core files. */
|
|
if (gdbarch_gcore_bfd_target_p (target_gdbarch ()))
|
|
return gdbarch_gcore_bfd_target (target_gdbarch ());
|
|
|
|
/* Otherwise, try to fall back to the exec target. This will probably
|
|
not work for non-ELF targets. */
|
|
if (current_program_space->exec_bfd () == NULL)
|
|
return NULL;
|
|
else
|
|
return bfd_get_target (current_program_space->exec_bfd ());
|
|
}
|
|
|
|
/* Derive a reasonable stack segment by unwinding the target stack,
|
|
and store its limits in *BOTTOM and *TOP. Return non-zero if
|
|
successful. */
|
|
|
|
static int
|
|
derive_stack_segment (bfd_vma *bottom, bfd_vma *top)
|
|
{
|
|
struct frame_info *fi, *tmp_fi;
|
|
|
|
gdb_assert (bottom);
|
|
gdb_assert (top);
|
|
|
|
/* Can't succeed without stack and registers. */
|
|
if (!target_has_stack () || !target_has_registers ())
|
|
return 0;
|
|
|
|
/* Can't succeed without current frame. */
|
|
fi = get_current_frame ();
|
|
if (fi == NULL)
|
|
return 0;
|
|
|
|
/* Save frame pointer of TOS frame. */
|
|
*top = get_frame_base (fi);
|
|
/* If current stack pointer is more "inner", use that instead. */
|
|
if (gdbarch_inner_than (get_frame_arch (fi), get_frame_sp (fi), *top))
|
|
*top = get_frame_sp (fi);
|
|
|
|
/* Find prev-most frame. */
|
|
while ((tmp_fi = get_prev_frame (fi)) != NULL)
|
|
fi = tmp_fi;
|
|
|
|
/* Save frame pointer of prev-most frame. */
|
|
*bottom = get_frame_base (fi);
|
|
|
|
/* Now canonicalize their order, so that BOTTOM is a lower address
|
|
(as opposed to a lower stack frame). */
|
|
if (*bottom > *top)
|
|
{
|
|
bfd_vma tmp_vma;
|
|
|
|
tmp_vma = *top;
|
|
*top = *bottom;
|
|
*bottom = tmp_vma;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
/* call_target_sbrk --
|
|
helper function for derive_heap_segment. */
|
|
|
|
static bfd_vma
|
|
call_target_sbrk (int sbrk_arg)
|
|
{
|
|
struct objfile *sbrk_objf;
|
|
struct gdbarch *gdbarch;
|
|
bfd_vma top_of_heap;
|
|
struct value *target_sbrk_arg;
|
|
struct value *sbrk_fn, *ret;
|
|
bfd_vma tmp;
|
|
|
|
if (lookup_minimal_symbol ("sbrk", NULL, NULL).minsym != NULL)
|
|
{
|
|
sbrk_fn = find_function_in_inferior ("sbrk", &sbrk_objf);
|
|
if (sbrk_fn == NULL)
|
|
return (bfd_vma) 0;
|
|
}
|
|
else if (lookup_minimal_symbol ("_sbrk", NULL, NULL).minsym != NULL)
|
|
{
|
|
sbrk_fn = find_function_in_inferior ("_sbrk", &sbrk_objf);
|
|
if (sbrk_fn == NULL)
|
|
return (bfd_vma) 0;
|
|
}
|
|
else
|
|
return (bfd_vma) 0;
|
|
|
|
gdbarch = sbrk_objf->arch ();
|
|
target_sbrk_arg = value_from_longest (builtin_type (gdbarch)->builtin_int,
|
|
sbrk_arg);
|
|
gdb_assert (target_sbrk_arg);
|
|
ret = call_function_by_hand (sbrk_fn, NULL, target_sbrk_arg);
|
|
if (ret == NULL)
|
|
return (bfd_vma) 0;
|
|
|
|
tmp = value_as_long (ret);
|
|
if ((LONGEST) tmp <= 0 || (LONGEST) tmp == 0xffffffff)
|
|
return (bfd_vma) 0;
|
|
|
|
top_of_heap = tmp;
|
|
return top_of_heap;
|
|
}
|
|
|
|
/* Derive a reasonable heap segment for ABFD by looking at sbrk and
|
|
the static data sections. Store its limits in *BOTTOM and *TOP.
|
|
Return non-zero if successful. */
|
|
|
|
static int
|
|
derive_heap_segment (bfd *abfd, bfd_vma *bottom, bfd_vma *top)
|
|
{
|
|
bfd_vma top_of_data_memory = 0;
|
|
bfd_vma top_of_heap = 0;
|
|
bfd_size_type sec_size;
|
|
bfd_vma sec_vaddr;
|
|
asection *sec;
|
|
|
|
gdb_assert (bottom);
|
|
gdb_assert (top);
|
|
|
|
/* This function depends on being able to call a function in the
|
|
inferior. */
|
|
if (!target_has_execution ())
|
|
return 0;
|
|
|
|
/* The following code assumes that the link map is arranged as
|
|
follows (low to high addresses):
|
|
|
|
---------------------------------
|
|
| text sections |
|
|
---------------------------------
|
|
| data sections (including bss) |
|
|
---------------------------------
|
|
| heap |
|
|
--------------------------------- */
|
|
|
|
for (sec = abfd->sections; sec; sec = sec->next)
|
|
{
|
|
if (bfd_section_flags (sec) & SEC_DATA
|
|
|| strcmp (".bss", bfd_section_name (sec)) == 0)
|
|
{
|
|
sec_vaddr = bfd_section_vma (sec);
|
|
sec_size = bfd_section_size (sec);
|
|
if (sec_vaddr + sec_size > top_of_data_memory)
|
|
top_of_data_memory = sec_vaddr + sec_size;
|
|
}
|
|
}
|
|
|
|
top_of_heap = call_target_sbrk (0);
|
|
if (top_of_heap == (bfd_vma) 0)
|
|
return 0;
|
|
|
|
/* Return results. */
|
|
if (top_of_heap > top_of_data_memory)
|
|
{
|
|
*bottom = top_of_data_memory;
|
|
*top = top_of_heap;
|
|
return 1;
|
|
}
|
|
|
|
/* No additional heap space needs to be saved. */
|
|
return 0;
|
|
}
|
|
|
|
static void
|
|
make_output_phdrs (bfd *obfd, asection *osec)
|
|
{
|
|
int p_flags = 0;
|
|
int p_type = 0;
|
|
|
|
/* FIXME: these constants may only be applicable for ELF. */
|
|
if (startswith (bfd_section_name (osec), "load"))
|
|
p_type = PT_LOAD;
|
|
else if (startswith (bfd_section_name (osec), "note"))
|
|
p_type = PT_NOTE;
|
|
else
|
|
p_type = PT_NULL;
|
|
|
|
p_flags |= PF_R; /* Segment is readable. */
|
|
if (!(bfd_section_flags (osec) & SEC_READONLY))
|
|
p_flags |= PF_W; /* Segment is writable. */
|
|
if (bfd_section_flags (osec) & SEC_CODE)
|
|
p_flags |= PF_X; /* Segment is executable. */
|
|
|
|
bfd_record_phdr (obfd, p_type, 1, p_flags, 0, 0, 0, 0, 1, &osec);
|
|
}
|
|
|
|
/* find_memory_region_ftype implementation. DATA is 'bfd *' for the core file
|
|
GDB is creating. */
|
|
|
|
static int
|
|
gcore_create_callback (CORE_ADDR vaddr, unsigned long size, int read,
|
|
int write, int exec, int modified, void *data)
|
|
{
|
|
bfd *obfd = (bfd *) data;
|
|
asection *osec;
|
|
flagword flags = SEC_ALLOC | SEC_HAS_CONTENTS | SEC_LOAD;
|
|
|
|
/* If the memory segment has no permissions set, ignore it, otherwise
|
|
when we later try to access it for read/write, we'll get an error
|
|
or jam the kernel. */
|
|
if (read == 0 && write == 0 && exec == 0 && modified == 0)
|
|
{
|
|
if (info_verbose)
|
|
{
|
|
fprintf_filtered (gdb_stdout, "Ignore segment, %s bytes at %s\n",
|
|
plongest (size), paddress (target_gdbarch (), vaddr));
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
if (write == 0 && modified == 0 && !solib_keep_data_in_core (vaddr, size))
|
|
{
|
|
/* See if this region of memory lies inside a known file on disk.
|
|
If so, we can avoid copying its contents by clearing SEC_LOAD. */
|
|
struct obj_section *objsec;
|
|
|
|
for (objfile *objfile : current_program_space->objfiles ())
|
|
ALL_OBJFILE_OSECTIONS (objfile, objsec)
|
|
{
|
|
bfd *abfd = objfile->obfd;
|
|
asection *asec = objsec->the_bfd_section;
|
|
bfd_vma align = (bfd_vma) 1 << bfd_section_alignment (asec);
|
|
bfd_vma start = obj_section_addr (objsec) & -align;
|
|
bfd_vma end = (obj_section_endaddr (objsec) + align - 1) & -align;
|
|
|
|
/* Match if either the entire memory region lies inside the
|
|
section (i.e. a mapping covering some pages of a large
|
|
segment) or the entire section lies inside the memory region
|
|
(i.e. a mapping covering multiple small sections).
|
|
|
|
This BFD was synthesized from reading target memory,
|
|
we don't want to omit that. */
|
|
if (objfile->separate_debug_objfile_backlink == NULL
|
|
&& ((vaddr >= start && vaddr + size <= end)
|
|
|| (start >= vaddr && end <= vaddr + size))
|
|
&& !(bfd_get_file_flags (abfd) & BFD_IN_MEMORY))
|
|
{
|
|
flags &= ~(SEC_LOAD | SEC_HAS_CONTENTS);
|
|
goto keep; /* Break out of two nested for loops. */
|
|
}
|
|
}
|
|
|
|
keep:;
|
|
}
|
|
|
|
if (write == 0)
|
|
flags |= SEC_READONLY;
|
|
|
|
if (exec)
|
|
flags |= SEC_CODE;
|
|
else
|
|
flags |= SEC_DATA;
|
|
|
|
osec = bfd_make_section_anyway_with_flags (obfd, "load", flags);
|
|
if (osec == NULL)
|
|
{
|
|
warning (_("Couldn't make gcore segment: %s"),
|
|
bfd_errmsg (bfd_get_error ()));
|
|
return 1;
|
|
}
|
|
|
|
if (info_verbose)
|
|
{
|
|
fprintf_filtered (gdb_stdout, "Save segment, %s bytes at %s\n",
|
|
plongest (size), paddress (target_gdbarch (), vaddr));
|
|
}
|
|
|
|
bfd_set_section_size (osec, size);
|
|
bfd_set_section_vma (osec, vaddr);
|
|
bfd_set_section_lma (osec, 0);
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
objfile_find_memory_regions (struct target_ops *self,
|
|
find_memory_region_ftype func, void *obfd)
|
|
{
|
|
/* Use objfile data to create memory sections. */
|
|
struct obj_section *objsec;
|
|
bfd_vma temp_bottom, temp_top;
|
|
|
|
/* Call callback function for each objfile section. */
|
|
for (objfile *objfile : current_program_space->objfiles ())
|
|
ALL_OBJFILE_OSECTIONS (objfile, objsec)
|
|
{
|
|
asection *isec = objsec->the_bfd_section;
|
|
flagword flags = bfd_section_flags (isec);
|
|
|
|
/* Separate debug info files are irrelevant for gcore. */
|
|
if (objfile->separate_debug_objfile_backlink != NULL)
|
|
continue;
|
|
|
|
if ((flags & SEC_ALLOC) || (flags & SEC_LOAD))
|
|
{
|
|
int size = bfd_section_size (isec);
|
|
int ret;
|
|
|
|
ret = (*func) (obj_section_addr (objsec), size,
|
|
1, /* All sections will be readable. */
|
|
(flags & SEC_READONLY) == 0, /* Writable. */
|
|
(flags & SEC_CODE) != 0, /* Executable. */
|
|
1, /* MODIFIED is unknown, pass it as true. */
|
|
obfd);
|
|
if (ret != 0)
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
/* Make a stack segment. */
|
|
if (derive_stack_segment (&temp_bottom, &temp_top))
|
|
(*func) (temp_bottom, temp_top - temp_bottom,
|
|
1, /* Stack section will be readable. */
|
|
1, /* Stack section will be writable. */
|
|
0, /* Stack section will not be executable. */
|
|
1, /* Stack section will be modified. */
|
|
obfd);
|
|
|
|
/* Make a heap segment. */
|
|
if (derive_heap_segment (current_program_space->exec_bfd (), &temp_bottom,
|
|
&temp_top))
|
|
(*func) (temp_bottom, temp_top - temp_bottom,
|
|
1, /* Heap section will be readable. */
|
|
1, /* Heap section will be writable. */
|
|
0, /* Heap section will not be executable. */
|
|
1, /* Heap section will be modified. */
|
|
obfd);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void
|
|
gcore_copy_callback (bfd *obfd, asection *osec)
|
|
{
|
|
bfd_size_type size, total_size = bfd_section_size (osec);
|
|
file_ptr offset = 0;
|
|
|
|
/* Read-only sections are marked; we don't have to copy their contents. */
|
|
if ((bfd_section_flags (osec) & SEC_LOAD) == 0)
|
|
return;
|
|
|
|
/* Only interested in "load" sections. */
|
|
if (!startswith (bfd_section_name (osec), "load"))
|
|
return;
|
|
|
|
size = std::min (total_size, (bfd_size_type) MAX_COPY_BYTES);
|
|
gdb::byte_vector memhunk (size);
|
|
|
|
while (total_size > 0)
|
|
{
|
|
if (size > total_size)
|
|
size = total_size;
|
|
|
|
if (target_read_memory (bfd_section_vma (osec) + offset,
|
|
memhunk.data (), size) != 0)
|
|
{
|
|
warning (_("Memory read failed for corefile "
|
|
"section, %s bytes at %s."),
|
|
plongest (size),
|
|
paddress (target_gdbarch (), bfd_section_vma (osec)));
|
|
break;
|
|
}
|
|
if (!bfd_set_section_contents (obfd, osec, memhunk.data (),
|
|
offset, size))
|
|
{
|
|
warning (_("Failed to write corefile contents (%s)."),
|
|
bfd_errmsg (bfd_get_error ()));
|
|
break;
|
|
}
|
|
|
|
total_size -= size;
|
|
offset += size;
|
|
}
|
|
}
|
|
|
|
static int
|
|
gcore_memory_sections (bfd *obfd)
|
|
{
|
|
/* Try gdbarch method first, then fall back to target method. */
|
|
if (!gdbarch_find_memory_regions_p (target_gdbarch ())
|
|
|| gdbarch_find_memory_regions (target_gdbarch (),
|
|
gcore_create_callback, obfd) != 0)
|
|
{
|
|
if (target_find_memory_regions (gcore_create_callback, obfd) != 0)
|
|
return 0; /* FIXME: error return/msg? */
|
|
}
|
|
|
|
/* Record phdrs for section-to-segment mapping. */
|
|
for (asection *sect : gdb_bfd_sections (obfd))
|
|
make_output_phdrs (obfd, sect);
|
|
|
|
/* Copy memory region contents. */
|
|
for (asection *sect : gdb_bfd_sections (obfd))
|
|
gcore_copy_callback (obfd, sect);
|
|
|
|
return 1;
|
|
}
|
|
|
|
void _initialize_gcore ();
|
|
void
|
|
_initialize_gcore ()
|
|
{
|
|
add_com ("generate-core-file", class_files, gcore_command, _("\
|
|
Save a core file with the current state of the debugged process.\n\
|
|
Usage: generate-core-file [FILENAME]\n\
|
|
Argument is optional filename. Default filename is 'core.PROCESS_ID'."));
|
|
|
|
add_com_alias ("gcore", "generate-core-file", class_files, 1);
|
|
}
|