mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-21 04:42:53 +08:00
c628b528e0
While remote.c works with "char *" buffers most of the time, other remote targets have binary-ish-er protocols, and choose to use "unsigned char" throughout, like e.g., remote-mips.c or remote-m32r-sdi.c. That results in -Wpointer-sign warnings in those targets, unless we add casts in calls to serial_write. Since serial_write is only concerned about sending raw host bytes out, and serial_ops->write_prim already works with "void *"/"size_t", a similar interface to the "write" or "send" system calls, I find it natural to change serial_write's prototype accordingly, avoiding the need for casts. Tested on x86_64 Fedora 17, and also by building x86_64-mingw32 and DJGPP/go32 -hosted gdbs. gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * ser-base.c (ser_base_write): Change prototype -- take 'void *' buffer and size_t size. Adjust. * ser-base.h (ser_base_write): Adjust. * ser-go32.c (cnts): Change type to size_t. (dos_write): Change prototype -- take 'void *' buffer and size_t size. Adjust. (dos_info): Print elements of 'cnts' as unsigned long. * serial.c (serial_write): Likewise. * serial.h (serial_write): Adjust. (struct serial_ops) <write>: Change prototype -- take 'void *' buffer and size_t size. Adjust.
54 lines
2.1 KiB
C
54 lines
2.1 KiB
C
/* Generic serial interface functions.
|
|
|
|
Copyright (C) 2005-2013 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef SER_BASE_H
|
|
#define SER_BASE_H
|
|
|
|
struct serial;
|
|
struct ui_file;
|
|
|
|
extern int generic_readchar (struct serial *scb, int timeout,
|
|
int (*do_readchar) (struct serial *scb,
|
|
int timeout));
|
|
extern int ser_base_flush_output (struct serial *scb);
|
|
extern int ser_base_flush_input (struct serial *scb);
|
|
extern int ser_base_send_break (struct serial *scb);
|
|
extern void ser_base_raw (struct serial *scb);
|
|
extern serial_ttystate ser_base_get_tty_state (struct serial *scb);
|
|
extern serial_ttystate ser_base_copy_tty_state (struct serial *scb,
|
|
serial_ttystate ttystate);
|
|
extern int ser_base_set_tty_state (struct serial *scb,
|
|
serial_ttystate ttystate);
|
|
extern void ser_base_print_tty_state (struct serial *scb,
|
|
serial_ttystate ttystate,
|
|
struct ui_file *stream);
|
|
extern int ser_base_noflush_set_tty_state (struct serial *scb,
|
|
serial_ttystate new_ttystate,
|
|
serial_ttystate old_ttystate);
|
|
extern int ser_base_setbaudrate (struct serial *scb, int rate);
|
|
extern int ser_base_setstopbits (struct serial *scb, int rate);
|
|
extern int ser_base_drain_output (struct serial *scb);
|
|
|
|
extern int ser_base_write (struct serial *scb, const void *buf, size_t count);
|
|
|
|
extern void ser_base_async (struct serial *scb, int async_p);
|
|
extern int ser_base_readchar (struct serial *scb, int timeout);
|
|
|
|
#endif
|