binutils-gdb/gdb/frame-info.h
Simon Marchi f71e3f86e8 gdb: add special handling for frame level 0 in frame_info_ptr
I noticed this problem while preparing the initial submission for the
ROCm GDB port.  One particularity of this patch set is that it does not
support unwinding frames, that requires support of some DWARF extensions
that will come later.  It was still possible to run to a breakpoint and
print frame #0, though.

When rebasing on top of the frame_info_ptr work, GDB started tripping on
a prepare_reinflate call, making it not possible anymore to event print
the frame when stopping on a breakpoint.  One thing to know about frame
0 is that its id is lazily computed when something requests it through
get_frame_id.  See:

  23912acd40/gdb/frame.c (L2070-2080)

So, up to that prepare_reinflate call, frame 0's id was not computed,
and prepare_reinflate, calling get_frame_id, forces it to be computed.
Computing the frame id generally requires unwinding the previous frame,
which with my ROCm GDB patch fails.  An exception is thrown and the
printing of the frame is simply abandonned.

Regardless of this ROCm GDB problem (which is admittedly temporary, it
will be possible to unwind with subsequent patches), we want to avoid
prepare_reinflate to force the computing of the frame id, for the same
reasons we lazily compute it in the first place.

In addition, frame 0's id is subject to change across a frame cache
reset.  This is why save_selected_frame and restore_selected_frame have
special handling for frame 0:

  23912acd40/gdb/frame.c (L1841-1863)

For this last reason, we also need to handle frame 0 specially in
prepare_reinflate / reinflate.  Because the frame id of frame 0 can
change across a frame cache reset, we must not rely on the frame id from
that frame to reinflate it.  We should instead just re-fetch the current
frame at that point.

This patch adds a frame_info_ptr::m_cached_level field, set in
frame_info_ptr::prepare_reinflate, so we can tell if a frame is frame 0.
There are cases where a frame_info_ptr object wraps a sentinel frame,
for which frame_relative_level returns -1, so I have chosen the value -2
to represent "invalid frame level", for when the frame_info_ptr object
is empty.

In frame_info_ptr::prepare_reinflate, only cache the frame id if the
frame level is not 0.  It's fine to cache the frame id for the sentinel
frame, it will be properly handled by frame_find_by_id later.

In frame_info_ptr::reinflate, if the frame level is 0, call
get_current_frame to get the target's current frame.  Otherwise, use
frame_find_by_id just as before.

This patch should not have user-visible changes with upstream GDB.  But
it will avoid forcing the computation of frame 0's when calling
prepare_reinflate.  And, well, it fixes the upcoming ROCm GDB patch
series.

Change-Id: I176ed7ee9317ddbb190acee8366e087e08e4d266
Reviewed-By: Bruno Larsen <blarsen@redhat.com>
2022-11-10 11:33:16 -05:00

208 lines
5.2 KiB
C++

/* Frame info pointer
Copyright (C) 2022 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#ifndef GDB_FRAME_INFO_H
#define GDB_FRAME_INFO_H
#include "gdbsupport/intrusive_list.h"
#include "frame-id.h"
struct frame_info;
/* A wrapper for "frame_info *". frame_info objects are invalidated
whenever reinit_frame_cache is called. This class arranges to
invalidate the pointer when appropriate. This is done to help
detect a GDB bug that was relatively common.
A small amount of code must still operate on raw pointers, so a
"get" method is provided. However, you should normally not use
this in new code. */
class frame_info_ptr : public intrusive_list_node<frame_info_ptr>
{
public:
/* Create a frame_info_ptr from a raw pointer. */
explicit frame_info_ptr (struct frame_info *ptr)
: m_ptr (ptr)
{
frame_list.push_back (*this);
}
/* Create a null frame_info_ptr. */
frame_info_ptr ()
{
frame_list.push_back (*this);
}
frame_info_ptr (std::nullptr_t)
{
frame_list.push_back (*this);
}
frame_info_ptr (const frame_info_ptr &other)
: m_ptr (other.m_ptr),
m_cached_id (other.m_cached_id),
m_cached_level (other.m_cached_level)
{
frame_list.push_back (*this);
}
frame_info_ptr (frame_info_ptr &&other)
: m_ptr (other.m_ptr),
m_cached_id (other.m_cached_id),
m_cached_level (other.m_cached_level)
{
other.m_ptr = nullptr;
other.m_cached_id = null_frame_id;
other.m_cached_level = invalid_level;
frame_list.push_back (*this);
}
~frame_info_ptr ()
{
frame_list.erase (frame_list.iterator_to (*this));
}
frame_info_ptr &operator= (const frame_info_ptr &other)
{
m_ptr = other.m_ptr;
m_cached_id = other.m_cached_id;
m_cached_level = other.m_cached_level;
return *this;
}
frame_info_ptr &operator= (std::nullptr_t)
{
m_ptr = nullptr;
m_cached_id = null_frame_id;
m_cached_level = invalid_level;
return *this;
}
frame_info_ptr &operator= (frame_info_ptr &&other)
{
m_ptr = other.m_ptr;
m_cached_id = other.m_cached_id;
m_cached_level = other.m_cached_level;
other.m_ptr = nullptr;
other.m_cached_id = null_frame_id;
other.m_cached_level = invalid_level;
return *this;
}
frame_info *operator-> () const
{
return m_ptr;
}
/* Fetch the underlying pointer. Note that new code should
generally not use this -- avoid it if at all possible. */
frame_info *get () const
{
return m_ptr;
}
/* This exists for compatibility with pre-existing code that checked
a "frame_info *" using "!". */
bool operator! () const
{
return m_ptr == nullptr;
}
/* This exists for compatibility with pre-existing code that checked
a "frame_info *" like "if (ptr)". */
explicit operator bool () const
{
return m_ptr != nullptr;
}
/* Invalidate this pointer. */
void invalidate ()
{
m_ptr = nullptr;
}
/* Cache the frame_id that the pointer will use to reinflate. */
void prepare_reinflate ();
/* Use the cached frame_id to reinflate the pointer. */
void reinflate ();
private:
/* We sometimes need to construct frame_info_ptr objects around the
sentinel_frame, which has level -1. Therefore, make the invalid frame
level value -2. */
static constexpr int invalid_level = -2;
/* The underlying pointer. */
frame_info *m_ptr = nullptr;
/* The frame_id of the underlying pointer. */
frame_id m_cached_id = null_frame_id;
/* The frame level of the underlying pointer. */
int m_cached_level = invalid_level;
/* All frame_info_ptr objects are kept on an intrusive list.
This keeps their construction and destruction costs
reasonably small. */
static intrusive_list<frame_info_ptr> frame_list;
/* A friend so it can invalidate the pointers. */
friend void reinit_frame_cache ();
};
static inline bool
operator== (const frame_info *self, const frame_info_ptr &other)
{
return self == other.get ();
}
static inline bool
operator== (const frame_info_ptr &self, const frame_info_ptr &other)
{
return self.get () == other.get ();
}
static inline bool
operator== (const frame_info_ptr &self, const frame_info *other)
{
return self.get () == other;
}
static inline bool
operator!= (const frame_info *self, const frame_info_ptr &other)
{
return self != other.get ();
}
static inline bool
operator!= (const frame_info_ptr &self, const frame_info_ptr &other)
{
return self.get () != other.get ();
}
static inline bool
operator!= (const frame_info_ptr &self, const frame_info *other)
{
return self.get () != other;
}
#endif /* GDB_FRAME_INFO_H */