binutils-gdb/gdbserver
Andrew Burgess 1048062a3f gdbserver: pass osabi to GDB in more target descriptions
Problem Description
-------------------

On a Windows machine I built gdbserver, configured for the target
'x86_64-w64-mingw32', then on a GNU/Linux machine I built GDB with
support for all target (--enable-targets=all).

On the Windows machine I start gdbserver with a small test binary:

  $ gdbserver 192.168.129.25:54321 C:\some\directory\executable.exe

On the GNU/Linux machine I start GDB without the test binary, and
connect to gdbserver.

As I have not given GDB the test binary, my expectation is that GDB
would connect to gdbserver and then download the file over the remote
protocol, but instead I was presented with this message:

  (gdb) target remote 192.168.129.25:54321
  Remote debugging using 192.168.129.25:54321
  warning: C:\some\directory\executable.exe: No such file or directory.
  0x00007ffa3e1e1741 in ?? ()
  (gdb)

What I found is that if I told GDB where to find the binary, like
this:

  (gdb) file target:C:/some/directory/executable.exe
  A program is being debugged already.
  Are you sure you want to change the file? (y or n) y
  Reading C:/some/directory/executable.exe from remote target...
  warning: File transfers from remote targets can be slow. Use "set sysroot" to access files locally instead.
  Reading C:/some/directory/executable.exe from remote target...
  Reading symbols from target:C:/some/directory/executable.exe...
  (gdb)

then GDB would download the executable.

The Actual Issue
----------------

I tracked the problem down to exec_file_find (solib.c).  The remote
target was passing an absolute Windows filename (beginning with "C:/"
in this case), but in exec_file_find GDB was failing the
IS_TARGET_ABSOLUTE_PATH call, and so was treating the filename as
relative.

The IS_TARGET_ABSOLUTE_PATH call was failing because GDB thought that
the file system kind was "unix", and as the filename didn't start with
a "/" it assumed the filename was not absolute.

But I'm connecting to a Windows target and 'target-file-system-kind'
was set to "auto", so GDB should be figuring out that the target
file-system is "dos-based".

Looking in effective_target_file_system_kind (filesystem.c), we find
that the logic of "auto" is delegated to the current gdbarch.  However
in windows-tdep.c we see:

  set_gdbarch_has_dos_based_file_system (gdbarch, 1);

So if we are using a Windows gdbarch we should have "dos-based"
filesystems.  What this means is that after connecting to the remote
target GDB has selected the wrong gdbarch.

What's happening is that the target description sent back by the
remote target only includes the x86-64 registers.  There's no
information about which OS we're on.  As a consequence, GDB picks the
first x86-64 gdbarch which can handle the provided register set, which
happens to be a GNU/Linux gdbarch.

And indeed, there doesn't appear to be anywhere in gdbserver that sets
the osabi on the target descriptions. Some target descriptions do have
their osabi set when the description is created, e.g. in:

  gdb/arch/amd64.c	- Sets GNU/Linux osabi when appropriate.
  gdb/arch/i386.c	- Likewise.
  gdb/arch/tic6x.c	- Always set GNU/Linux osabi.

There are also some cases in gdb/features/*.c where the tdesc is set,
but these locations are only called from GDB, not from gdbserver.

This means that many target descriptions are created without an osabi,
gdbserver does nothing to fix this, and the description is returned to
GDB without an osabi included.  This leaves GDB having to guess what
the target osabi is, and in some cases, GDB can get this wrong.

Proposed Solution
-----------------

I propose to change init_target_desc so that it requires an gdb_osabi
to be passed in, this will then be used to set the target_desc osabi
field.

I believe that within gdbserver init_target_desc is called for every
target_desc, so this should mean that every target_desc has an
opportunity to set the osabi to something sane.

I did consider passing the osabi into the code which creates the
target_desc objects, but that would require updating far more code, as
each target has its own code for creating target descriptions.
The approach taken here requires minimal changes and forces every
user of init_target_desc to think about what the correct osabi is.

In some cases, e.g. amd64, where the osabi is already set when the
target_desc is created, the init_target_desc call will override the
current value, however, we should always be replacing it with the same
actual value.  i.e. if the target_desc is created with the osabi set
to GNU/Linux, then this should only happen when gdbserver is built for
GNU/Linux, in which case the init_target_desc should also be setting
the osabi to GNU/Linux.

The Tricky Bits
---------------

Some targets, like amd64, use a features based approach for creating
target_desc objects, there's a function in arch/amd64.c which creates
a target_desc, adds features too it, and returns the new target_desc.
This target_desc is then passed to an init_target_desc call within
gdbserver.  This is the easy case to handle.

Then there are other targets which instead have a fixed set of xml
files, each of which is converted into a .dat file, which is then used
to generate a .cc file, which is compiled into gdbserver.  The
generated .cc file creates the target_desc object and calls
init_target_desc on it.  In this case though the target description
that is sent to GDB isn't generated from the target_desc object, but
is instead the contents of the fixed xml file.  For this case the
osabi which we pass to init_target_desc should match the osabi that
exists in the fixed xml file.

Luckily, in the previous commit I copied the osabi information from
the fixed xml files into the .dat files.  So in this commit I have
extended regdat.sh to read the osabi from the .dat file and use it in
the generated init_target_desc call.

The problem with some of these .dat base targets is that their fixed
xml files don't currently contain any osabi information, and the file
names don't indicate that they are Linux only (despite them currently
only being used from gdbserver for Linux targets), so I don't
currently feel confident adding any osabi information to these files.
An example would be features/rs6000/powerpc-64.xml.  For now I've just
ignored these cases.  The init_target_desc will use GDB_OSABI_UNKNOWN
which is the default.  This means that for these targets nothing
changes from the current behaviour.  But many other targets do now
pass the osabi back.  Targets that do pass the osabi back are
improved with this commit.

Conclusion
----------

Now when I connect to the Windows remote the target description
returned includes the osabi name.  With this extra information GDB
selects the correct gdbarch object, which means that GDB understands
the target has a "dos-based" file-system.  With that correct GDB
understands that the filename it was given is absolute, and so fetches
the file from the remote as we'd like.

Reviewed-By: Kevin Buettner <kevinb@redhat.com>
2024-11-12 12:51:36 +00:00
..
.dir-locals.el
.gitattributes
.gitignore
acinclude.m4
aclocal.m4
ax-result-types.def
ax.cc
ax.h
ChangeLog-2002-2021
config.in btrace, python: Enable ptwrite filter registration. 2024-08-14 11:20:57 +02:00
configure btrace, python: Enable ptwrite filter registration. 2024-08-14 11:20:57 +02:00
configure.ac
configure.srv gdb: AArch64: Support MTE on baremetal 2024-08-01 10:01:39 +01:00
debug.cc
debug.h
dll.cc
dll.h
fork-child.cc
gdb_proc_service.h
gdbreplay.cc gdbreplay: Add --debug-logging option 2024-10-21 16:38:18 +02:00
gdbthread.h gdbserver: remove pid_of(thread) 2024-11-08 09:16:23 -05:00
hostio.cc gdbserver: add gdbserver support for vFile::stat packet 2024-07-18 13:24:20 +01:00
hostio.h
i387-fp.cc gdb, gdbserver, python, testsuite: Remove MPX. 2024-09-25 11:06:57 +00:00
i387-fp.h gdb/gdbserver: share some code relating to target description creation 2024-06-14 09:08:45 +01:00
inferiors.cc gdbserver: remove ptid_of(thread) 2024-11-08 09:16:23 -05:00
inferiors.h gdbserver: remove pidof(process) 2024-11-08 09:16:23 -05:00
linux-aarch32-low.cc
linux-aarch32-low.h gdbserver: remove declaration of init_registers_arm_with_neon 2024-10-11 13:22:31 +01:00
linux-aarch32-tdesc.cc gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
linux-aarch32-tdesc.h
linux-aarch64-ipa.cc
linux-aarch64-low.cc gdbserver: remove pid_of(thread) 2024-11-08 09:16:23 -05:00
linux-aarch64-tdesc.cc gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
linux-aarch64-tdesc.h
linux-amd64-ipa.cc gdb/gdbserver: share x86/linux tdesc caching 2024-06-14 09:08:45 +01:00
linux-arc-low.cc gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
linux-arm-low.cc gdbserver: remove pid_of(thread) 2024-11-08 09:16:23 -05:00
linux-arm-tdesc.cc gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
linux-arm-tdesc.h
linux-csky-low.cc gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
linux-i386-ipa.cc gdb/gdbserver: share x86/linux tdesc caching 2024-06-14 09:08:45 +01:00
linux-ia64-low.cc
linux-loongarch-low.cc gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
linux-low.cc gdbserver: remove pidof(process) 2024-11-08 09:16:23 -05:00
linux-low.h gdb: move have_ptrace_getregset declaration into gdb/nat directory 2024-06-14 09:08:45 +01:00
linux-m68k-low.cc
linux-mips-low.cc gdbserver: remove lwpid_of(thread) 2024-11-08 09:16:23 -05:00
linux-nios2-low.cc
linux-or1k-low.cc
linux-ppc-ipa.cc
linux-ppc-low.cc gdbserver: remove lwpid_of(thread) 2024-11-08 09:16:23 -05:00
linux-ppc-tdesc-init.h
linux-riscv-low.cc gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
linux-s390-ipa.cc
linux-s390-low.cc gdbserver: remove pid_of(thread) 2024-11-08 09:16:23 -05:00
linux-s390-tdesc.h
linux-sh-low.cc
linux-sparc-low.cc
linux-tic6x-low.cc Revert "gdbserver: pass osabi to GDB in target description" 2024-10-11 09:31:51 +01:00
linux-x86-low.cc gdbserver: remove lwpid_of(thread) 2024-11-08 09:16:23 -05:00
linux-x86-tdesc.cc gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
linux-xtensa-low.cc
Makefile.in gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
mem-break.cc gdbserver: remove ptid_of(thread) 2024-11-08 09:16:23 -05:00
mem-break.h
netbsd-aarch64-low.cc gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
netbsd-amd64-low.cc gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
netbsd-i386-low.cc gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
netbsd-low.cc gdbserver: remove ptid_of(thread) 2024-11-08 09:16:23 -05:00
netbsd-low.h
notif.cc
notif.h
proc-service.cc
proc-service.list
README gdbreplay: Add --debug-logging option 2024-10-21 16:38:18 +02:00
regcache.cc [gdb/tdep] Use raw_supply_part_zeroed for AArch64 2024-11-12 11:37:50 +01:00
regcache.h [gdb/tdep] Use raw_supply_part_zeroed for AArch64 2024-11-12 11:37:50 +01:00
remote-utils.cc gdbserver: remove pidof(process) 2024-11-08 09:16:23 -05:00
remote-utils.h
server.cc gdbserver: remove pid_of(thread) 2024-11-08 09:16:23 -05:00
server.h Add "error_message+" feature to qSupported 2024-06-12 14:13:35 +02:00
symbol.cc
target.cc
target.h
tdesc.cc gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
tdesc.h gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
thread-db.cc gdbserver: remove pidof(process) 2024-11-08 09:16:23 -05:00
tracepoint.cc gdbserver: remove current_ptid macro 2024-11-08 09:16:23 -05:00
tracepoint.h
utils.cc gdb, gdbserver, gdbsupport: use [[noreturn]] instead of ATTRIBUTE_NORETURN 2024-07-16 18:30:45 -04:00
utils.h
win32-i386-low.cc gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
win32-low.cc gdbserver: remove current_thread_ptid 2024-11-08 09:16:23 -05:00
win32-low.h gdbserver: pass osabi to GDB in more target descriptions 2024-11-12 12:51:36 +00:00
x86-low.cc
x86-low.h
x86-tdesc.h
xtensa-xtregs.cc

		   README for GDBserver & GDBreplay
		    by Stu Grossman and Fred Fish

Introduction:

This is GDBserver, a remote server for Un*x-like systems.  It can be used to
control the execution of a program on a target system from a GDB on a different
host.  GDB and GDBserver communicate using the standard remote serial protocol.
They communicate via either a serial line or a TCP connection.

For more information about GDBserver, see the GDB manual:

    https://sourceware.org/gdb/current/onlinedocs/gdb/Remote-Protocol.html

Usage (server (target) side):

First, you need to have a copy of the program you want to debug put onto
the target system.  The program can be stripped to save space if needed, as
GDBserver doesn't care about symbols.  All symbol handling is taken care of by
the GDB running on the host system.

To use the server, you log on to the target system, and run the `gdbserver'
program.  You must tell it (a) how to communicate with GDB, (b) the name of
your program, and (c) its arguments.  The general syntax is:

	target> gdbserver COMM PROGRAM [ARGS ...]

For example, using a serial port, you might say:

	target> gdbserver /dev/com1 emacs foo.txt

This tells GDBserver to debug emacs with an argument of foo.txt, and to
communicate with GDB via /dev/com1.  GDBserver now waits patiently for the
host GDB to communicate with it.

To use a TCP connection, you could say:

	target> gdbserver host:2345 emacs foo.txt

This says pretty much the same thing as the last example, except that we are
going to communicate with the host GDB via TCP.  The `host:2345' argument means
that we are expecting to see a TCP connection to local TCP port 2345.
(Currently, the `host' part is ignored.)  You can choose any number you want for
the port number as long as it does not conflict with any existing TCP ports on
the target system.  This same port number must be used in the host GDB's
`target remote' command, which will be described shortly. Note that if you chose
a port number that conflicts with another service, GDBserver will print an error
message and exit.

On some targets, GDBserver can also attach to running programs.  This is
accomplished via the --attach argument.  The syntax is:

	target> gdbserver --attach COMM PID

PID is the process ID of a currently running process.  It isn't necessary
to point GDBserver at a binary for the running process.

Usage (host side):

You need an unstripped copy of the target program on your host system, since
GDB needs to examine it's symbol tables and such.  Start up GDB as you normally
would, with the target program as the first argument.  (You may need to use the
--baud option if the serial line is running at anything except 9600 baud.)
Ie: `gdb TARGET-PROG', or `gdb --baud BAUD TARGET-PROG'.  After that, the only
new command you need to know about is `target remote'.  It's argument is either
a device name (usually a serial device, like `/dev/ttyb'), or a HOST:PORT
descriptor.  For example:

	(gdb) target remote /dev/ttyb

communicates with the server via serial line /dev/ttyb, and:

	(gdb) target remote the-target:2345

communicates via a TCP connection to port 2345 on host `the-target', where
you previously started up GDBserver with the same port number.  Note that for
TCP connections, you must start up GDBserver prior to using the `target remote'
command, otherwise you may get an error that looks something like
`Connection refused'.

Building GDBserver:

See the `configure.srv` file for the list of host triplets you can build
GDBserver for.

Building GDBserver for your host is very straightforward.  If you build
GDB natively on a host which GDBserver supports, it will be built
automatically when you build GDB.  You can also build just GDBserver:

	% mkdir obj
	% cd obj
	% path-to-toplevel-sources/configure --disable-gdb
	% make all-gdbserver

(If you have a combined binutils+gdb tree, you may want to also
disable other directories when configuring, e.g., binutils, gas, gold,
gprof, and ld.)

If you prefer to cross-compile to your target, then you can also build
GDBserver that way.  For example:

	% export CC=your-cross-compiler
	% path-to-topevel-sources/configure --disable-gdb
	% make all-gdbserver

Using GDBreplay:

A special hacked down version of GDBserver can be used to replay remote
debug log files created by GDB.  Before using the GDB "target" command to
initiate a remote debug session, use "set remotelogfile <filename>" to tell
GDB that you want to make a recording of the serial or tcp session.  Note
that when replaying the session, GDB communicates with GDBreplay via tcp,
regardless of whether the original session was via a serial link or tcp.

Once you are done with the remote debug session, start GDBreplay and
tell it the name of the log file and the host and port number that GDB
should connect to (typically the same as the host running GDB):

	$ gdbreplay logfile host:port

Then start GDB (preferably in a different screen or window) and use the
"target" command to connect to GDBreplay:

	(gdb) target remote host:port

Repeat the same sequence of user commands to GDB that you gave in the
original debug session.  GDB should not be able to tell that it is talking
to GDBreplay rather than a real target, all other things being equal.

As GDBreplay communicates with GDB, it outputs only the commands
it expects from GDB. The --debug-logging option turns printing the
remotelogfile to stderr on. GDBreplay then echos the command lines
to stderr, as well as the contents of the packets it sends and receives.