binutils-gdb/gdb/f-valprint.c
Simon Marchi 50888e42dc gdb: change functions returning value contents to use gdb::array_view
The bug fixed by this [1] patch was caused by an out-of-bounds access to
a value's content.  The code gets the value's content (just a pointer)
and then indexes it with a non-sensical index.

This made me think of changing functions that return value contents to
return array_views instead of a plain pointer.  This has the advantage
that when GDB is built with _GLIBCXX_DEBUG, accesses to the array_view
are checked, making bugs more apparent / easier to find.

This patch changes the return types of these functions, and updates
callers to call .data() on the result, meaning it's not changing
anything in practice.  Additional work will be needed (which can be done
little by little) to make callers propagate the use of array_view and
reap the benefits.

[1] https://sourceware.org/pipermail/gdb-patches/2021-September/182306.html

Change-Id: I5151f888f169e1c36abe2cbc57620110673816f3
2021-10-25 14:51:44 -04:00

481 lines
14 KiB
C
Raw Blame History

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

/* Support for printing Fortran values for GDB, the GNU debugger.
Copyright (C) 1993-2021 Free Software Foundation, Inc.
Contributed by Motorola. Adapted from the C definitions by Farooq Butt
(fmbutt@engage.sps.mot.com), additionally worked over by Stan Shebs.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "symtab.h"
#include "gdbtypes.h"
#include "expression.h"
#include "value.h"
#include "valprint.h"
#include "language.h"
#include "f-lang.h"
#include "frame.h"
#include "gdbcore.h"
#include "command.h"
#include "block.h"
#include "dictionary.h"
#include "cli/cli-style.h"
#include "gdbarch.h"
#include "f-array-walker.h"
static void f77_get_dynamic_length_of_aggregate (struct type *);
LONGEST
f77_get_lowerbound (struct type *type)
{
if (type->bounds ()->low.kind () == PROP_UNDEFINED)
error (_("Lower bound may not be '*' in F77"));
return type->bounds ()->low.const_val ();
}
LONGEST
f77_get_upperbound (struct type *type)
{
if (type->bounds ()->high.kind () == PROP_UNDEFINED)
{
/* We have an assumed size array on our hands. Assume that
upper_bound == lower_bound so that we show at least 1 element.
If the user wants to see more elements, let him manually ask for 'em
and we'll subscript the array and show him. */
return f77_get_lowerbound (type);
}
return type->bounds ()->high.const_val ();
}
/* Obtain F77 adjustable array dimensions. */
static void
f77_get_dynamic_length_of_aggregate (struct type *type)
{
int upper_bound = -1;
int lower_bound = 1;
/* Recursively go all the way down into a possibly multi-dimensional
F77 array and get the bounds. For simple arrays, this is pretty
easy but when the bounds are dynamic, we must be very careful
to add up all the lengths correctly. Not doing this right
will lead to horrendous-looking arrays in parameter lists.
This function also works for strings which behave very
similarly to arrays. */
if (TYPE_TARGET_TYPE (type)->code () == TYPE_CODE_ARRAY
|| TYPE_TARGET_TYPE (type)->code () == TYPE_CODE_STRING)
f77_get_dynamic_length_of_aggregate (TYPE_TARGET_TYPE (type));
/* Recursion ends here, start setting up lengths. */
lower_bound = f77_get_lowerbound (type);
upper_bound = f77_get_upperbound (type);
/* Patch in a valid length value. */
TYPE_LENGTH (type) =
(upper_bound - lower_bound + 1)
* TYPE_LENGTH (check_typedef (TYPE_TARGET_TYPE (type)));
}
/* A class used by FORTRAN_PRINT_ARRAY as a specialisation of the array
walking template. This specialisation prints Fortran arrays. */
class fortran_array_printer_impl : public fortran_array_walker_base_impl
{
public:
/* Constructor. TYPE is the array type being printed, ADDRESS is the
address in target memory for the object of TYPE being printed. VAL is
the GDB value (of TYPE) being printed. STREAM is where to print to,
RECOURSE is passed through (and prevents infinite recursion), and
OPTIONS are the printing control options. */
explicit fortran_array_printer_impl (struct type *type,
CORE_ADDR address,
struct value *val,
struct ui_file *stream,
int recurse,
const struct value_print_options *options)
: m_elts (0),
m_val (val),
m_stream (stream),
m_recurse (recurse),
m_options (options)
{ /* Nothing. */ }
/* Called while iterating over the array bounds. When SHOULD_CONTINUE is
false then we must return false, as we have reached the end of the
array bounds for this dimension. However, we also return false if we
have printed too many elements (after printing '...'). In all other
cases, return true. */
bool continue_walking (bool should_continue)
{
bool cont = should_continue && (m_elts < m_options->print_max);
if (!cont && should_continue)
fputs_filtered ("...", m_stream);
return cont;
}
/* Called when we start iterating over a dimension. If it's not the
inner most dimension then print an opening '(' character. */
void start_dimension (bool inner_p)
{
fputs_filtered ("(", m_stream);
}
/* Called when we finish processing a batch of items within a dimension
of the array. Depending on whether this is the inner most dimension
or not we print different things, but this is all about adding
separators between elements, and dimensions of the array. */
void finish_dimension (bool inner_p, bool last_p)
{
fputs_filtered (")", m_stream);
if (!last_p)
fputs_filtered (" ", m_stream);
}
/* Called to process an element of ELT_TYPE at offset ELT_OFF from the
start of the parent object. */
void process_element (struct type *elt_type, LONGEST elt_off, bool last_p)
{
/* Extract the element value from the parent value. */
struct value *e_val
= value_from_component (m_val, elt_type, elt_off);
common_val_print (e_val, m_stream, m_recurse, m_options, current_language);
if (!last_p)
fputs_filtered (", ", m_stream);
++m_elts;
}
private:
/* The number of elements printed so far. */
int m_elts;
/* The value from which we are printing elements. */
struct value *m_val;
/* The stream we should print too. */
struct ui_file *m_stream;
/* The recursion counter, passed through when we print each element. */
int m_recurse;
/* The print control options. Gives us the maximum number of elements to
print, and is passed through to each element that we print. */
const struct value_print_options *m_options = nullptr;
};
/* This function gets called to print a Fortran array. */
static void
fortran_print_array (struct type *type, CORE_ADDR address,
struct ui_file *stream, int recurse,
const struct value *val,
const struct value_print_options *options)
{
fortran_array_walker<fortran_array_printer_impl> p
(type, address, (struct value *) val, stream, recurse, options);
p.walk ();
}
/* Decorations for Fortran. */
static const struct generic_val_print_decorations f_decorations =
{
"(",
",",
")",
".TRUE.",
".FALSE.",
"void",
"{",
"}"
};
/* See f-lang.h. */
void
f_language::value_print_inner (struct value *val, struct ui_file *stream,
int recurse,
const struct value_print_options *options) const
{
struct type *type = check_typedef (value_type (val));
struct gdbarch *gdbarch = type->arch ();
int printed_field = 0; /* Number of fields printed. */
struct type *elttype;
CORE_ADDR addr;
int index;
const gdb_byte *valaddr = value_contents_for_printing (val).data ();
const CORE_ADDR address = value_address (val);
switch (type->code ())
{
case TYPE_CODE_STRING:
f77_get_dynamic_length_of_aggregate (type);
printstr (stream, builtin_type (gdbarch)->builtin_char, valaddr,
TYPE_LENGTH (type), NULL, 0, options);
break;
case TYPE_CODE_ARRAY:
if (TYPE_TARGET_TYPE (type)->code () != TYPE_CODE_CHAR)
fortran_print_array (type, address, stream, recurse, val, options);
else
{
struct type *ch_type = TYPE_TARGET_TYPE (type);
f77_get_dynamic_length_of_aggregate (type);
printstr (stream, ch_type, valaddr,
TYPE_LENGTH (type) / TYPE_LENGTH (ch_type), NULL, 0,
options);
}
break;
case TYPE_CODE_PTR:
if (options->format && options->format != 's')
{
value_print_scalar_formatted (val, options, 0, stream);
break;
}
else
{
int want_space = 0;
addr = unpack_pointer (type, valaddr);
elttype = check_typedef (TYPE_TARGET_TYPE (type));
if (elttype->code () == TYPE_CODE_FUNC)
{
/* Try to print what function it points to. */
print_function_pointer_address (options, gdbarch, addr, stream);
return;
}
if (options->symbol_print)
want_space = print_address_demangle (options, gdbarch, addr,
stream, demangle);
else if (options->addressprint && options->format != 's')
{
fputs_filtered (paddress (gdbarch, addr), stream);
want_space = 1;
}
/* For a pointer to char or unsigned char, also print the string
pointed to, unless pointer is null. */
if (TYPE_LENGTH (elttype) == 1
&& elttype->code () == TYPE_CODE_INT
&& (options->format == 0 || options->format == 's')
&& addr != 0)
{
if (want_space)
fputs_filtered (" ", stream);
val_print_string (TYPE_TARGET_TYPE (type), NULL, addr, -1,
stream, options);
}
return;
}
break;
case TYPE_CODE_STRUCT:
case TYPE_CODE_UNION:
/* Starting from the Fortran 90 standard, Fortran supports derived
types. */
fprintf_filtered (stream, "( ");
for (index = 0; index < type->num_fields (); index++)
{
struct value *field = value_field (val, index);
struct type *field_type = check_typedef (type->field (index).type ());
if (field_type->code () != TYPE_CODE_FUNC)
{
const char *field_name;
if (printed_field > 0)
fputs_filtered (", ", stream);
field_name = type->field (index).name ();
if (field_name != NULL)
{
fputs_styled (field_name, variable_name_style.style (),
stream);
fputs_filtered (" = ", stream);
}
common_val_print (field, stream, recurse + 1,
options, current_language);
++printed_field;
}
}
fprintf_filtered (stream, " )");
break;
case TYPE_CODE_BOOL:
if (options->format || options->output_format)
{
struct value_print_options opts = *options;
opts.format = (options->format ? options->format
: options->output_format);
value_print_scalar_formatted (val, &opts, 0, stream);
}
else
{
LONGEST longval = value_as_long (val);
/* The Fortran standard doesn't specify how logical types are
represented. Different compilers use different non zero
values to represent logical true. */
if (longval == 0)
fputs_filtered (f_decorations.false_name, stream);
else
fputs_filtered (f_decorations.true_name, stream);
}
break;
case TYPE_CODE_INT:
case TYPE_CODE_REF:
case TYPE_CODE_FUNC:
case TYPE_CODE_FLAGS:
case TYPE_CODE_FLT:
case TYPE_CODE_VOID:
case TYPE_CODE_ERROR:
case TYPE_CODE_RANGE:
case TYPE_CODE_UNDEF:
case TYPE_CODE_COMPLEX:
case TYPE_CODE_CHAR:
default:
generic_value_print (val, stream, recurse, options, &f_decorations);
break;
}
}
static void
info_common_command_for_block (const struct block *block, const char *comname,
int *any_printed)
{
struct block_iterator iter;
struct symbol *sym;
struct value_print_options opts;
get_user_print_options (&opts);
ALL_BLOCK_SYMBOLS (block, iter, sym)
if (SYMBOL_DOMAIN (sym) == COMMON_BLOCK_DOMAIN)
{
const struct common_block *common = SYMBOL_VALUE_COMMON_BLOCK (sym);
size_t index;
gdb_assert (SYMBOL_CLASS (sym) == LOC_COMMON_BLOCK);
if (comname && (!sym->linkage_name ()
|| strcmp (comname, sym->linkage_name ()) != 0))
continue;
if (*any_printed)
putchar_filtered ('\n');
else
*any_printed = 1;
if (sym->print_name ())
printf_filtered (_("Contents of F77 COMMON block '%s':\n"),
sym->print_name ());
else
printf_filtered (_("Contents of blank COMMON block:\n"));
for (index = 0; index < common->n_entries; index++)
{
struct value *val = NULL;
printf_filtered ("%s = ",
common->contents[index]->print_name ());
try
{
val = value_of_variable (common->contents[index], block);
value_print (val, gdb_stdout, &opts);
}
catch (const gdb_exception_error &except)
{
fprintf_styled (gdb_stdout, metadata_style.style (),
"<error reading variable: %s>",
except.what ());
}
putchar_filtered ('\n');
}
}
}
/* This function is used to print out the values in a given COMMON
block. It will always use the most local common block of the
given name. */
static void
info_common_command (const char *comname, int from_tty)
{
struct frame_info *fi;
const struct block *block;
int values_printed = 0;
/* We have been told to display the contents of F77 COMMON
block supposedly visible in this function. Let us
first make sure that it is visible and if so, let
us display its contents. */
fi = get_selected_frame (_("No frame selected"));
/* The following is generally ripped off from stack.c's routine
print_frame_info(). */
block = get_frame_block (fi, 0);
if (block == NULL)
{
printf_filtered (_("No symbol table info available.\n"));
return;
}
while (block)
{
info_common_command_for_block (block, comname, &values_printed);
/* After handling the function's top-level block, stop. Don't
continue to its superblock, the block of per-file symbols. */
if (BLOCK_FUNCTION (block))
break;
block = BLOCK_SUPERBLOCK (block);
}
if (!values_printed)
{
if (comname)
printf_filtered (_("No common block '%s'.\n"), comname);
else
printf_filtered (_("No common blocks.\n"));
}
}
void _initialize_f_valprint ();
void
_initialize_f_valprint ()
{
add_info ("common", info_common_command,
_("Print out the values contained in a Fortran COMMON block."));
}