binutils-gdb/gdb/testsuite/gdb.fortran/block-data.exp
Bernhard Heckel a5fd13a915 Dwarf: Don't add nameless modules to partial symbol table
A name for BLOCK DATA in Fortran is optional.  If no name has been
assigned, GDB crashes during read-in of DWARF when BLOCK DATA is
represented via DW_TAG_module.  BLOCK DATA is used for one-time
initialization of non-pointer variables in named common blocks.

As of now there is no issue when gfortran is used as DW_TAG_module is
not emitted.  However, with Intel ifort the nameless DW_TAG_module is
present and has the following form:

 ...
  <1><dd>: Abbrev Number: 7 (DW_TAG_module)
     <de>   DW_AT_decl_line   : 46
     <df>   DW_AT_decl_file   : 1
     <e0>   DW_AT_description : (indirect string, offset: 0x110): block
 data
     <e4>   DW_AT_high_pc     : 0x402bb7
     <ec>   DW_AT_low_pc      : 0x402bb7
 ...

The missing name leads to a crash in add_partial_symbol, during length
calculation.

gdb/ChangeLog:
2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>

	* dwarf2read.c (add_partial_symbol): Skip nameless modules.

gdb/testsuite/Changelog:
2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>

	* gdb.fortran/block-data.f: New.
	* gdb.fortran/block-data.exp: New.
2019-06-11 19:20:09 +01:00

64 lines
2.1 KiB
Plaintext

# Copyright 2016-2019 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Test anonymous block-data statements.
# A name for BLOCK DATA in Fortran is optional. BLOCK DATA is used
# for one-time initialization of non-pointer variables in named common
# blocks. GDB used to crash with 'Intel ifort'-generated code, which
# outputs nameless DW_TAG_module, unlike with gfortran which just
# doesn't emit DW_TAG_module in this case.
if { [skip_fortran_tests] } { return -1 }
standard_testfile .f
load_lib "fortran.exp"
if {[prepare_for_testing $testfile.exp $testfile $srcfile {debug f90}]} {
return -1
}
if ![runto MAIN__] then {
untested "couldn't run to breakpoint MAIN__"
return -1
}
with_test_prefix "default values" {
gdb_test "print doub1" "= 1\.11\\d+"
gdb_test "print doub2" "= 2\.22\\d+"
gdb_test "print char1" "= 'abcdef'"
gdb_test "print char2" "= 'ghijkl'"
}
gdb_breakpoint [gdb_get_line_number "! BP_BEFORE_SUB"]
gdb_continue_to_breakpoint "! BP_BEFORE_SUB" ".*! BP_BEFORE_SUB.*"
with_test_prefix "before sub" {
gdb_test "print doub1" "= 11\.11\\d+"
gdb_test "print doub2" "= 22\.22\\d+"
gdb_test "print char1" "= 'ABCDEF'"
gdb_test "print char2" "= 'GHIJKL'"
}
gdb_breakpoint [gdb_get_line_number "! BP_SUB"]
gdb_continue_to_breakpoint "! BP_SUB" ".*! BP_SUB.*"
with_test_prefix "in sub" {
gdb_test "print doub1" "= 11\.11\\d+"
gdb_test "print doub2" "= 22\.22\\d+"
gdb_test "print char1" "= 'ABCDEF'"
gdb_test "print char2" "= 'GHIJKL'"
}