binutils-gdb/ld
Andrew Burgess ace667e59a ld: Restore file offset after a plugin fails to claim a file
When using the plugin interface to claim an input file the claim method
from (possible) many plugins can be called on an input file.  If these
claim methods read content from the input file then the file offset
stored in the underlying file descriptor will change.

As we share a file descriptor between the plugin interface (created with
dup in ld/plugin.c:plugin_object_p) and the input bfd object, then any
changes to the file offset in the file descriptor will effect the bfd
object.  Also, as the changes to the file offset did not originate from
calls through the bfd interface, but instead came from the plugin
directly, then the bfd will not be aware that the file offset has
changed.  This is a problem as the bfd library caches the file offset.
If the plugin decides not to claim an input file then, currently, we
leave the bfd in a state where the actual file offset is out of sync
with the cached file offset.

This problem came to light after a recent commit
7d0b9ebc1e (Don't include libbfd.h outside
of bfd, part 6) however, I don't believe that commit actual introduces
the bug, it just exposed the existing issue.

This commit solves the problem by backing up and restoring the file
offset for the file descriptor of the input file.  The restore is only
done if the plugin does not claim the input file, as it is in this case
that the bfd library might be used again to try and identify the
unclaimed file.

ld/ChangeLog:

	* plugin.c (plugin_call_claim_file): Restore the file offset after
	an unsuccessful attempt to claim a file.
	* testplug.c (bytes_to_read_before_claim): New global.
	(record_read_length): New function, sets new global
	bytes_to_read_before_claim.
	(parse_option): Handle 'read:<NUMBER>' option.
	(onclaim_file): Read file content before checking for claim.
	* testsuite/ld-plugin/plugin-30.d: New file.
	* testsuite/ld-plugin/plugin.exp: Add new test.
2016-07-19 09:58:01 +01:00
..
emulparams [ARC] Fix/improve small data support. 2016-07-14 10:08:57 +02:00
emultempl Don't include libbfd.h outside of bfd, part 1 2016-07-16 13:25:11 +09:30
po
scripttempl FT32 linker script cleanup 2016-07-06 18:58:10 -07:00
testsuite ld: Restore file offset after a plugin fails to claim a file 2016-07-19 09:58:01 +01:00
.gitignore
aclocal.m4
ChangeLog ld: Restore file offset after a plugin fails to claim a file 2016-07-19 09:58:01 +01:00
ChangeLog-0001
ChangeLog-0203
ChangeLog-2004
ChangeLog-2005
ChangeLog-2006
ChangeLog-2007
ChangeLog-2008
ChangeLog-2009
ChangeLog-2010
ChangeLog-2011
ChangeLog-2012
ChangeLog-2013
ChangeLog-2014
ChangeLog-2015
ChangeLog-9197
ChangeLog-9899
config.in ld: Add a linker configure option --enable-relro 2016-06-22 05:37:38 -07:00
configure ld: Add a linker configure option --enable-relro 2016-06-22 05:37:38 -07:00
configure.ac ld: Add a linker configure option --enable-relro 2016-06-22 05:37:38 -07:00
configure.host
configure.tgt ld: Add a linker configure option --enable-relro 2016-06-22 05:37:38 -07:00
deffile.h
deffilep.y
dep-in.sed
elf-hints-local.h
fdl.texi
gen-doc.texi
genscrba.sh
genscripts.sh
h8-doc.texi
ld.h Add support for creating ELF import libraries 2016-07-15 17:50:48 +01:00
ld.texinfo Add support for creating ELF import libraries 2016-07-15 17:50:48 +01:00
ldbuildid.c
ldbuildid.h
ldcref.c
ldctor.c
ldctor.h
ldemul.c
ldemul.h
ldexp.c Add support for creating ELF import libraries 2016-07-15 17:50:48 +01:00
ldexp.h
ldfile.c
ldfile.h
ldgram.y
ldint.texinfo
ldlang.c Don't include libbfd.h outside of bfd, part 4 2016-07-16 13:29:35 +09:30
ldlang.h
ldlex-wrapper.c
ldlex.h Add support for creating ELF import libraries 2016-07-15 17:50:48 +01:00
ldlex.l ld: track linker-definedness of symbols 2016-07-05 11:36:08 +02:00
ldmain.c
ldmain.h
ldmisc.c
ldmisc.h
ldver.c
ldver.h
ldwrite.c
ldwrite.h
lexsup.c Add support for creating ELF import libraries 2016-07-15 17:50:48 +01:00
MAINTAINERS
Makefile.am Don't include libbfd.h outside of bfd, part 1 2016-07-16 13:25:11 +09:30
Makefile.in Don't include libbfd.h outside of bfd, part 1 2016-07-16 13:25:11 +09:30
mri.c
mri.h
NEWS Add support for creating ELF import libraries 2016-07-15 17:50:48 +01:00
pe-dll.c
pe-dll.h
pep-dll.c
pep-dll.h
plugin.c ld: Restore file offset after a plugin fails to claim a file 2016-07-19 09:58:01 +01:00
plugin.h
README
stamp-h.in
sysdep.h
testplug2.c
testplug3.c
testplug4.c
testplug.c ld: Restore file offset after a plugin fails to claim a file 2016-07-19 09:58:01 +01:00
TODO

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

		README for LD

This is the GNU linker.  It is distributed with other "binary
utilities" which should be in ../binutils.  See ../binutils/README for
more general notes, including where to send bug reports.

There are many features of the linker:

* The linker uses a Binary File Descriptor library (../bfd)
  that it uses to read and write object files.  This helps
  insulate the linker itself from the format of object files.

* The linker supports a number of different object file
  formats.  It can even handle multiple formats at once:
  Read two input formats and write a third.

* The linker can be configured for cross-linking.

* The linker supports a control language.

* There is a user manual (ld.texinfo), as well as the
  beginnings of an internals manual (ldint.texinfo).

Installation
============

See ../binutils/README.

If you want to make a cross-linker, you may want to specify
a different search path of -lfoo libraries than the default.
You can do this by setting the LIB_PATH variable in ./Makefile
or using the --with-lib-path configure switch.

To build just the linker, make the target all-ld from the top level
directory (one directory above this one).

Porting to a new target
=======================

See the ldint.texinfo manual.

Reporting bugs etc
===========================

See ../binutils/README.

Known problems
==============

The Solaris linker normally exports all dynamic symbols from an
executable.  The GNU linker does not do this by default.  This is
because the GNU linker tries to present the same interface for all
similar targets (in this case, all native ELF targets).  This does not
matter for normal programs, but it can make a difference for programs
which try to dlopen an executable, such as PERL or Tcl.  You can make
the GNU linker export all dynamic symbols with the -E or
--export-dynamic command line option.

HP/UX 9.01 has a shell bug that causes the linker scripts to be
generated incorrectly.  The symptom of this appears to be "fatal error
- scanner input buffer overflow" error messages.  There are various
workarounds to this:
  * Build and install bash, and build with "make SHELL=bash".
  * Update to a version of HP/UX with a working shell (e.g., 9.05).
  * Replace "(. ${srcdir}/scripttempl/${SCRIPT_NAME}.sc)" in
    genscripts.sh with "sh ${srcdir}..." (no parens) and make sure the
    emulparams script used exports any shell variables it sets.

Copyright (C) 2012-2016 Free Software Foundation, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.