mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2025-01-24 12:35:55 +08:00
4176f14d9c
I noticed some spots that were checking HAVE_UNISTD_H. There is no
need to do this, as <unistd.h> is unconditionally included in many
places in gdb. This sort of cleanup was done once before, in 2013:
2013-07-01 Pedro Alves <palves@redhat.com>
* defs.h: Don't check HAVE_UNISTD_H before including <unistd.h>.
(STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO): Delete.
* tracepoint.c: Don't check HAVE_UNISTD_H before including
<unistd.h>.
HAVE_UNISTD_H seems to come from gnulib, so there are still mentions
of it in the source.
gdb/ChangeLog
2018-10-01 Tom Tromey <tom@tromey.com>
* unittests/scoped_mmap-selftests.c: Don't check HAVE_UNISTD_H.
* unittests/scoped_fd-selftests.c: Don't check HAVE_UNISTD_H.
* common/scoped_fd.h: Don't check HAVE_UNISTD_H.
84 lines
1.8 KiB
C
84 lines
1.8 KiB
C
/* Self tests for scoped_fd for GDB, the GNU debugger.
|
|
|
|
Copyright (C) 2018 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
|
|
#include "common/scoped_fd.h"
|
|
#include "config.h"
|
|
#include "selftest.h"
|
|
|
|
namespace selftests {
|
|
namespace scoped_fd {
|
|
|
|
/* Test that the file descriptor is closed. */
|
|
static void
|
|
test_destroy ()
|
|
{
|
|
char filename[] = "scoped_fd-selftest-XXXXXX";
|
|
int fd = mkstemp (filename);
|
|
SELF_CHECK (fd >= 0);
|
|
|
|
unlink (filename);
|
|
errno = 0;
|
|
{
|
|
::scoped_fd sfd (fd);
|
|
|
|
SELF_CHECK (sfd.get () == fd);
|
|
}
|
|
|
|
SELF_CHECK (close (fd) == -1 && errno == EBADF);
|
|
}
|
|
|
|
/* Test that the file descriptor can be released. */
|
|
static void
|
|
test_release ()
|
|
{
|
|
char filename[] = "scoped_fd-selftest-XXXXXX";
|
|
int fd = mkstemp (filename);
|
|
SELF_CHECK (fd >= 0);
|
|
|
|
unlink (filename);
|
|
errno = 0;
|
|
{
|
|
::scoped_fd sfd (fd);
|
|
|
|
SELF_CHECK (sfd.release () == fd);
|
|
}
|
|
|
|
SELF_CHECK (close (fd) == 0 || errno != EBADF);
|
|
}
|
|
|
|
/* Run selftests. */
|
|
static void
|
|
run_tests ()
|
|
{
|
|
test_destroy ();
|
|
test_release ();
|
|
}
|
|
|
|
} /* namespace scoped_fd */
|
|
} /* namespace selftests */
|
|
|
|
void
|
|
_initialize_scoped_fd_selftests ()
|
|
{
|
|
selftests::register_test ("scoped_fd",
|
|
selftests::scoped_fd::run_tests);
|
|
}
|