binutils-gdb/gas
Andrew Burgess 6837a663c5 opcodes/aarch64: split off creation of comment text in disassembler
The function aarch64_print_operand (aarch64-opc.c) is responsible for
converting an instruction operand into the textual representation of
that operand.

In some cases, a comment is included in the operand representation,
though this (currently) only happens for the last operand of the
instruction.

In a future commit I would like to enable the new libopcodes styling
for AArch64, this will allow objdump and GDB[1] to syntax highlight
the disassembler output, however, having operands and comments
combined in a single string like this makes such styling harder.

In this commit, I propose to extend aarch64_print_operand to take a
second buffer.  Any comments for the instruction are written into this
extra buffer.  The two callers of aarch64_print_operand are then
updated to pass an extra buffer, and print any resulting comment.

In this commit no styling is added, that will come later.  However, I
have adjusted the output slightly.  Before this commit some comments
would be separated from the instruction operands with a tab character,
while in other cases the comment was separated with two single spaces.

After this commit I use a single tab character in all cases.  This
means a few test cases needed updated.  If people would prefer me to
move everyone to use the two spaces, then just let me know.  Or maybe
there was a good reason why we used a mix of styles, I could probably
figure out a way to maintain the old output exactly if that is
critical.

Other than that, there should be no user visible changes after this
commit.

[1] GDB patches have not been merged yet, but have been posted to the
GDB mailing list:
https://sourceware.org/pipermail/gdb-patches/2022-June/190142.html
2022-06-29 12:03:22 +01:00
..
config opcodes/aarch64: split off creation of comment text in disassembler 2022-06-29 12:03:22 +01:00
doc drop XC16x bits 2022-06-27 11:11:46 +02:00
po drop XC16x bits 2022-06-27 11:11:46 +02:00
testsuite opcodes/aarch64: split off creation of comment text in disassembler 2022-06-29 12:03:22 +01:00
.gitignore
acinclude.m4
aclocal.m4
app.c gas: retain whitespace between strings 2022-03-23 08:41:54 +01:00
as.c as: Reject unknown -gXXX option 2022-04-19 10:35:41 -07:00
as.h gas dwarf2dbg.c tidy 2022-06-14 09:56:45 +09:30
asintl.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
atof-generic.c Re: ubsan: signed integer overflow in atof_generic 2022-06-02 18:42:01 +09:30
bignum.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
bit_fix.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
cgen.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
cgen.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
ChangeLog oops - forgot changelog entry for the previous delta. 2022-05-18 16:26:21 +01:00
ChangeLog-0001
ChangeLog-0203
ChangeLog-2004
ChangeLog-2005
ChangeLog-2006
ChangeLog-2007
ChangeLog-2008
ChangeLog-2009
ChangeLog-2010
ChangeLog-2011
ChangeLog-2012
ChangeLog-2013
ChangeLog-2014
ChangeLog-2015
ChangeLog-2016
ChangeLog-2017
ChangeLog-2018
ChangeLog-2019
ChangeLog-2020
ChangeLog-9295
ChangeLog-9697
ChangeLog-9899
compress-debug.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
compress-debug.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
cond.c gas: don't ignore .linefile inside false conditionals 2022-05-18 09:37:00 +02:00
config.in
configure drop XC16x bits 2022-06-27 11:11:46 +02:00
configure.ac drop XC16x bits 2022-06-27 11:11:46 +02:00
configure.com Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
configure.tgt Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
CONTRIBUTORS Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
COPYING
debug.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
dep-in.sed
depend.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
dw2gencfi.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
dw2gencfi.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
dwarf2dbg.c gas dwarf2dbg.c tidy 2022-06-14 09:56:45 +09:30
dwarf2dbg.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
ecoff.c gas: drop .appfile and .appline 2022-04-12 09:04:15 +02:00
ecoff.h gas: drop .appfile and .appline 2022-04-12 09:04:15 +02:00
ehopt.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
emul-target.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
emul.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
expr.c Add support for COFF secidx relocations 2022-04-07 14:47:17 +01:00
expr.h Add support for COFF secidx relocations 2022-04-07 14:47:17 +01:00
flonum-copy.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
flonum-konst.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
flonum-mult.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
flonum.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
frags.c ubsan: undefined shift in frag_align_code 2022-06-02 16:10:30 +09:30
frags.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
gdbinit.in
hash.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
hash.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
input-file.c use of uninitialised value in input_file_open 2022-06-16 16:27:35 +09:30
input-file.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
input-scrub.c asan: double free sb_kill 2022-06-08 16:22:15 +09:30
itbl-lex-wrapper.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
itbl-lex.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
itbl-lex.l Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
itbl-ops.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
itbl-ops.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
itbl-parse.y Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
listing.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
listing.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
literal.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
macro.c gas: tweak .irp and alike file/line handling for M68K/MRI 2022-05-18 09:35:29 +02:00
macro.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
MAINTAINERS Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
Makefile.am drop XC16x bits 2022-06-27 11:11:46 +02:00
Makefile.in drop XC16x bits 2022-06-27 11:11:46 +02:00
makefile.vms Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
messages.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
NEWS x86: mention dropped L1OM/K1OM support in ld/ as well 2022-03-24 15:27:28 +01:00
obj.h gas: drop .appfile and .appline 2022-04-12 09:04:15 +02:00
output-file.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
output-file.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
read.c gas read_a_source_file #APP processing 2022-06-02 15:54:18 +09:30
read.h gas: fold do_repeat{,_with_expander}() 2022-05-18 09:37:34 +02:00
README Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
remap.c gas dwarf2dbg.c tidy 2022-06-14 09:56:45 +09:30
sb.c sb_scrub_and_add_sb not draining input string buffer 2022-06-02 15:54:14 +09:30
sb.h gas: further adjust file/line handling for .macro 2022-04-12 09:03:43 +02:00
stabs.c gas dwarf2dbg.c tidy 2022-06-14 09:56:45 +09:30
subsegs.c Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
subsegs.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
symbols.c Replace bfd_hostptr_t with uintptr_t 2022-05-27 22:08:59 +09:30
symbols.h gas local label and dollar label handling 2022-02-16 22:05:24 +10:30
tc.h Update year range in copyright notice of binutils files 2022-01-02 12:04:28 +10:30
write.c Replace bfd_hostptr_t with uintptr_t 2022-05-27 22:08:59 +09:30
write.h ppc: extend opindex to 16 bits 2022-05-25 12:13:44 +09:30

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

		README for GAS

A number of things have changed since version 1 and the wonderful
world of gas looks very different.  There's still a lot of irrelevant
garbage lying around that will be cleaned up in time.  Documentation
is scarce, as are logs of the changes made since the last gas release.
My apologies, and I'll try to get something useful.

Unpacking and Installation - Summary
====================================

See ../binutils/README.

To build just the assembler, make the target all-gas.

Documentation
=============

The GAS release includes texinfo source for its manual, which can be processed
into `info' or `dvi' forms.

The DVI form is suitable for printing or displaying; the commands for doing
this vary from system to system.  On many systems, `lpr -d' will print a DVI
file.  On others, you may need to run a program such as `dvips' to convert the
DVI file into a form your system can print.

If you wish to build the DVI file, you will need to have TeX installed on your
system.  You can rebuild it by typing:

	cd gas/doc
	make as.dvi

The Info form is viewable with the GNU Emacs `info' subsystem, or the
stand-alone `info' program, available as part of the GNU Texinfo distribution.
To build the info files, you will need the `makeinfo' program.  Type:

	cd gas/doc
	make info

Specifying names for hosts and targets
======================================

   The specifications used for hosts and targets in the `configure'
script are based on a three-part naming scheme, but some short
predefined aliases are also supported.  The full naming scheme encodes
three pieces of information in the following pattern:

     ARCHITECTURE-VENDOR-OS

   For example, you can use the alias `sun4' as a HOST argument or in a
`--target=TARGET' option.  The equivalent full name is
`sparc-sun-sunos4'.

   The `configure' script accompanying GAS does not provide any query
facility to list all supported host and target names or aliases.
`configure' calls the Bourne shell script `config.sub' to map
abbreviations to full names; you can read the script, if you wish, or
you can use it to test your guesses on abbreviations--for example:

     % sh config.sub i386v
     i386-unknown-sysv
     % sh config.sub i786v
     Invalid configuration `i786v': machine `i786v' not recognized


`configure' options
===================

   Here is a summary of the `configure' options and arguments that are
most often useful for building GAS.  `configure' also has several other
options not listed here.

     configure [--help]
               [--prefix=DIR]
               [--srcdir=PATH]
               [--host=HOST]
               [--target=TARGET]
               [--with-OPTION]
               [--enable-OPTION]

You may introduce options with a single `-' rather than `--' if you
prefer; but you may abbreviate option names if you use `--'.

`--help'
     Print a summary of the options to `configure', and exit.

`-prefix=DIR'
     Configure the source to install programs and files under directory
     `DIR'.

`--srcdir=PATH'
     Look for the package's source code in directory DIR.  Usually
     `configure' can determine that directory automatically.

`--host=HOST'
     Configure GAS to run on the specified HOST.  Normally the
     configure script can figure this out automatically.

     There is no convenient way to generate a list of all available
     hosts.

`--target=TARGET'
     Configure GAS for cross-assembling programs for the specified
     TARGET.  Without this option, GAS is configured to assemble .o files
     that run on the same machine (HOST) as GAS itself.

     There is no convenient way to generate a list of all available
     targets.

`--enable-OPTION'
     These flags tell the program or library being configured to
     configure itself differently from the default for the specified
     host/target combination.  See below for a list of `--enable'
     options recognized in the gas distribution.

`configure' accepts other options, for compatibility with configuring
other GNU tools recursively; but these are the only options that affect
GAS or its supporting libraries.

The `--enable' options recognized by software in the gas distribution are:

`--enable-targets=...'
     This causes one or more specified configurations to be added to those for
     which BFD support is compiled.  Currently gas cannot use any format other
     than its compiled-in default, so this option is not very useful.

`--enable-bfd-assembler'
     This causes the assembler to use the new code being merged into it to use
     BFD data structures internally, and use BFD for writing object files.
     For most targets, this isn't supported yet.  For most targets where it has
     been done, it's already the default.  So generally you won't need to use
     this option.

Compiler Support Hacks
======================

On a few targets, the assembler has been modified to support a feature
that is potentially useful when assembling compiler output, but which
may confuse assembly language programmers.  If assembler encounters a
.word pseudo-op of the form symbol1-symbol2 (the difference of two
symbols), and the difference of those two symbols will not fit in 16
bits, the assembler will create a branch around a long jump to
symbol1, and insert this into the output directly before the next
label: The .word will (instead of containing garbage, or giving an
error message) contain (the address of the long jump)-symbol2.  This
allows the assembler to assemble jump tables that jump to locations
very far away into code that works properly.  If the next label is
more than 32K away from the .word, you lose (silently); RMS claims
this will never happen.  If the -K option is given, you will get a
warning message when this happens.


REPORTING BUGS IN GAS
=====================

Bugs in gas should be reported to:

   https://sourceware.org/bugzilla/

See ../binutils/README for what we need in a bug report.

Copyright (C) 2012-2022 Free Software Foundation, Inc.

Copying and distribution of this file, with or without modification,
are permitted in any medium without royalty provided the copyright
notice and this notice are preserved.