mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 04:31:49 +08:00
9bcb1f1630
I left making inferior::detaching a bool to a separate patch, because doing that makes a make_cleanup_restore_integer call in infrun.c:prepare_for_detach no longer compile (passing a 'bool *' when an 'int *' is expected). Since we want to get rid of cleanups anyway, I looked at converting that to a scoped_restore. However, prepare_for_detach wants to discard the cleanup on success, and scoped_restore doesn't have an equivalent for that. So I added one -- I called it "release()" because it seems like a natural fit in the way standard components call similarly-spirited methods, and, it's also what the proposal for a generic scope guard calls it too, AFAICS: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4189.pdf I've added some scoped_guard unit tests, while at it. gdb/ChangeLog: 2017-04-19 Pedro Alves <palves@redhat.com> * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add unittests/scoped_restore-selftests.c. (SUBDIR_UNITTESTS_OBS): Add scoped_restore-selftests.o. * common/scoped_restore.h (scoped_restore_base): Make "class". (scoped_restore_base::release): New public method. (scoped_restore_base::scoped_restore_base): New protected ctor. (scoped_restore_base::m_saved_var): New protected field. (scoped_restore_tmpl::scoped_restore_tmpl(T*)): Initialize the scoped_restore_base base class instead of m_saved_var directly. (scoped_restore_tmpl::scoped_restore_tmpl(T*, T2)): Likewise. (scoped_restore_tmpl::scoped_restore_tmpl(const scoped_restore_tmpl<T>&)): Likewise. (scoped_restore_tmpl::~scoped_restore_tmpl): Use the saved_var method. (scoped_restore_tmpl::saved_var): New method. (scoped_restore_tmpl::m_saved_var): Delete. * inferior.h (inferior::detaching): Now a bool. * infrun.c (prepare_for_detach): Use a scoped_restore instead of a cleanup. * unittests/scoped_restore-selftests.c: New file.
119 lines
3.5 KiB
C++
119 lines
3.5 KiB
C++
/* scoped_restore, a simple class for saving and restoring a value
|
|
|
|
Copyright (C) 2016-2017 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef SCOPED_RESTORE_H
|
|
#define SCOPED_RESTORE_H
|
|
|
|
/* Base class for scoped_restore_tmpl. */
|
|
class scoped_restore_base
|
|
{
|
|
public:
|
|
/* This informs the (scoped_restore_tmpl<T>) dtor that you no longer
|
|
want the original value restored. */
|
|
void release () const
|
|
{ m_saved_var = NULL; }
|
|
|
|
protected:
|
|
scoped_restore_base (void *saved_var)
|
|
: m_saved_var (saved_var)
|
|
{}
|
|
|
|
/* The type-erased saved variable. This is here so that clients can
|
|
call release() on a "scoped_restore" local, which is a typedef to
|
|
a scoped_restore_base. See below. */
|
|
mutable void *m_saved_var;
|
|
};
|
|
|
|
/* A convenience typedef. Users of make_scoped_restore declare the
|
|
local RAII object as having this type. */
|
|
typedef const scoped_restore_base &scoped_restore;
|
|
|
|
/* An RAII-based object that saves a variable's value, and then
|
|
restores it again when this object is destroyed. */
|
|
template<typename T>
|
|
class scoped_restore_tmpl : public scoped_restore_base
|
|
{
|
|
public:
|
|
|
|
/* Create a new scoped_restore object that saves the current value
|
|
of *VAR. *VAR will be restored when this scoped_restore object
|
|
is destroyed. */
|
|
scoped_restore_tmpl (T *var)
|
|
: scoped_restore_base (var),
|
|
m_saved_value (*var)
|
|
{
|
|
}
|
|
|
|
/* Create a new scoped_restore object that saves the current value
|
|
of *VAR, and sets *VAR to VALUE. *VAR will be restored when this
|
|
scoped_restore object is destroyed. This is templated on T2 to
|
|
allow passing VALUEs of types convertible to T.
|
|
E.g.: T='base'; T2='derived'. */
|
|
template <typename T2>
|
|
scoped_restore_tmpl (T *var, T2 value)
|
|
: scoped_restore_base (var),
|
|
m_saved_value (*var)
|
|
{
|
|
*var = value;
|
|
}
|
|
|
|
scoped_restore_tmpl (const scoped_restore_tmpl<T> &other)
|
|
: scoped_restore_base {other.m_saved_var},
|
|
m_saved_value (other.m_saved_value)
|
|
{
|
|
other.m_saved_var = NULL;
|
|
}
|
|
|
|
~scoped_restore_tmpl ()
|
|
{
|
|
if (saved_var () != NULL)
|
|
*saved_var () = m_saved_value;
|
|
}
|
|
|
|
private:
|
|
/* Return a pointer to the saved variable with its type
|
|
restored. */
|
|
T *saved_var ()
|
|
{ return static_cast<T *> (m_saved_var); }
|
|
|
|
/* No need for this. It is intentionally not defined anywhere. */
|
|
scoped_restore_tmpl &operator= (const scoped_restore_tmpl &);
|
|
|
|
/* The saved value. */
|
|
const T m_saved_value;
|
|
};
|
|
|
|
/* Make a scoped_restore. This is useful because it lets template
|
|
argument deduction work. */
|
|
template<typename T>
|
|
scoped_restore_tmpl<T> make_scoped_restore (T *var)
|
|
{
|
|
return scoped_restore_tmpl<T> (var);
|
|
}
|
|
|
|
/* Make a scoped_restore. This is useful because it lets template
|
|
argument deduction work. */
|
|
template<typename T, typename T2>
|
|
scoped_restore_tmpl<T> make_scoped_restore (T *var, T2 value)
|
|
{
|
|
return scoped_restore_tmpl<T> (var, value);
|
|
}
|
|
|
|
#endif /* SCOPED_RESTORE_H */
|