mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-21 04:42:53 +08:00
3f94e58859
The sources for the test-cases gdb.arch/i386-mpx*.exp contain have_mpx functions that test whether the processor supports mpx instructions. OTOH, the test-cases are compiled using -mmpx -fcheck-pointer-bounds, which instrument all functions with mpx instructions. So, the function that is supposed to test whether mpx instruction are supported contains mpx instructions, which is a bit odd. We could fix this by: - factoring out the have_mpx function into a single source file, and - compiling it without "-mmpx -fcheck-pointer-bounds". But having the mpx support test as part of the test-cases seems like an unnecessary complication that makes the test-cases more difficult to analyze, reason about and modify. So we go one step further and factor out the mpx support test in into a gdb_caching_proc. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2021-01-12 Tom de Vries <tdevries@suse.de> * gdb.arch/i386-mpx-call.c (have_mpx): Remove. (main): Remove call to have_mpx. * gdb.arch/i386-mpx-call.exp: Use have_mpx. * gdb.arch/i386-mpx-map.c (have_mpx): Remove. (main): Remote call to have_mpx. * gdb.arch/i386-mpx-map.exp: Use have_mpx. * gdb.arch/i386-mpx-sigsegv.c (have_mpx): Remove. (main): Remove call to have_mpx. * gdb.arch/i386-mpx-sigsegv.exp: Use have_mpx. * gdb.arch/i386-mpx-simple_segv.c (have_mpx): Remove. (main): Remove call to have_mpx. * gdb.arch/i386-mpx-simple_segv.exp: Use have_mpx. * gdb.arch/i386-mpx.c (have_mpx): Remove. (main): Remote call to have_mpx. * gdb.arch/i386-mpx.exp: Use have_mpx. * lib/gdb.exp (have_mpx): New proc.
140 lines
3.8 KiB
Plaintext
140 lines
3.8 KiB
Plaintext
# Copyright (C) 2015-2021 Free Software Foundation, Inc.
|
|
#
|
|
# Contributed by Intel Corp. <walfred.tedeschi@intel.com>
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Testing handle setup together with boundary violation signals.
|
|
#
|
|
# Some states are not allowed as reported on the manual, as noprint
|
|
# implies nostop, but nostop might print.
|
|
#
|
|
# Caveat: Setting the handle to nopass, ends up in a endless loop.
|
|
|
|
if { ![istarget i?86-*-*] && ![istarget x86_64-*-* ] } {
|
|
verbose "Skipping x86 MPX tests."
|
|
return
|
|
}
|
|
|
|
standard_testfile
|
|
|
|
if { ![supports_mpx_check_pointer_bounds] } {
|
|
return -1
|
|
}
|
|
|
|
if { ![have_mpx] } {
|
|
unsupported "processor does not support MPX"
|
|
return -1
|
|
}
|
|
|
|
set comp_flags "-mmpx -fcheck-pointer-bounds -I${srcdir}/../nat/"
|
|
|
|
if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
|
|
[list debug nowarnings additional_flags=${comp_flags}]] } {
|
|
return -1
|
|
}
|
|
|
|
if ![runto_main] {
|
|
untested "could not run to main"
|
|
return -1
|
|
}
|
|
|
|
set violation [multi_line "Program received signal SIGSEGV, Segmentation fault" \
|
|
"Upper bound violation while accessing address $hex" \
|
|
"Bounds: \\\[lower = $hex, upper = $hex\\\]"]
|
|
|
|
set segv_with_exit "Program received signal SIGSEGV,\
|
|
Segmentation fault.*$inferior_exited_re.*"
|
|
|
|
|
|
# Test handler for segmentation fault for:
|
|
# print pass stop
|
|
#
|
|
set parameters "print pass stop"
|
|
with_test_prefix "$parameters" {
|
|
if ![runto_main] {
|
|
fail "could not run to main"
|
|
return -1
|
|
}
|
|
|
|
gdb_test "handle SIGSEGV $parameters"\
|
|
".*SIGSEGV.*Yes.*Yes.*Yes.*Segmentation fault.*"\
|
|
"set parameters"
|
|
|
|
gdb_test "continue" ".*$violation.*" "display"
|
|
|
|
gdb_test "where" ".*#0 $hex in upper.*"\
|
|
"should be in upper"
|
|
}
|
|
|
|
# Test handler for segmentation fault for:
|
|
# print pass nostop
|
|
#
|
|
set parameters "print pass nostop"
|
|
with_test_prefix "$parameters" {
|
|
if ![runto_main] {
|
|
fail "could not run to main"
|
|
return -1
|
|
}
|
|
|
|
gdb_test "handle SIGSEGV $parameters"\
|
|
".*SIGSEGV.*No.*Yes.*Yes.*Segmentation fault.*"\
|
|
"set parameters"
|
|
|
|
gdb_test "continue" ".*$segv_with_exit.*" "display"
|
|
|
|
gdb_test "where" "No stack." "no inferior"
|
|
}
|
|
|
|
# Test handler for segmentation fault for:
|
|
# print nopass stop
|
|
#
|
|
set parameters "print nopass stop"
|
|
with_test_prefix "$parameters" {
|
|
if ![runto_main] {
|
|
fail "could not run to main"
|
|
return -1
|
|
}
|
|
|
|
gdb_test "handle SIGSEGV $parameters"\
|
|
".*SIGSEGV.*Yes.*Yes.*No.*Segmentation fault.*"\
|
|
"set parameters"
|
|
|
|
gdb_test "continue" ".*$violation.*" "display"
|
|
|
|
gdb_test "where" ".*#0 $hex in upper.*"\
|
|
"should be in upper"
|
|
}
|
|
|
|
# Test handler for segmentation fault for:
|
|
# print nopass stop
|
|
#
|
|
set parameters "noprint pass nostop"
|
|
with_test_prefix "$parameters" {
|
|
if ![runto_main] {
|
|
fail "could not run to main"
|
|
return -1
|
|
}
|
|
|
|
gdb_test "handle SIGSEGV $parameters"\
|
|
".*SIGSEGV.*No.*No.*Yes.*Segmentation fault.*"\
|
|
"set parameters"
|
|
|
|
gdb_test "continue" "Continuing\..*$inferior_exited_re.*"\
|
|
"Display"
|
|
|
|
gdb_test "where" "No stack." "no inferior"
|
|
}
|
|
|