mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-09 04:21:49 +08:00
8cb6e17571
Looking at the ARM disassembler output, every comment seems to start
with a ';' character, so I assumed this was the correct character to
start an assembler comment.
I then spotted a couple of places where there was no ';', but instead,
just a '@' character. I thought that this was a case of a missing
';', and proposed a patch to add the missing ';' characters.
Turns out I was wrong, '@' is actually the ARM assembler comment
character, while ';' is the statement separator. Thus this:
nop ;@ comment
is two statements, the first is the 'nop' instruction, while the
second contains no instructions, just the '@ comment' comment text.
This:
nop @ comment
is a single 'nop' instruction followed by a comment. And finally,
this:
nop ; comment
is two statements, the first contains the 'nop' instruction, while the
second contains the instruction 'comment', which obviously isn't
actually an instruction at all.
Why this matters is that, in the next commit, I would like to add
libopcodes syntax styling support for ARM.
The question then is how should the disassembler style the three cases
above?
As '@' is the actual comment start character then clearly the '@' and
anything after it can be styled as a comment. But what about ';' in
the second example? Style as text? Style as a comment?
And the third example is even harder, what about the 'comment' text?
Style as an instruction mnemonic? Style as text? Style as a comment?
I think the only sensible answer is to move the disassembler to use
'@' consistently as its comment character, and remove all the uses of
';'.
Then, in the next commit, it's obvious what to do.
There's obviously a *lot* of tests that get updated by this commit,
the only actual code changes are in opcodes/arm-dis.c.
32 lines
858 B
Makefile
32 lines
858 B
Makefile
|
|
.*
|
|
|
|
|
|
Disassembly of section \.plt:
|
|
|
|
00008000 <.*>:
|
|
8000: e52de004 push {lr} @ \(str lr, \[sp, #-4\]!\)
|
|
8004: e59fe004 ldr lr, \[pc, #4\] @ 8010 <.*>
|
|
8008: e08fe00e add lr, pc, lr
|
|
800c: e5bef008 ldr pc, \[lr, #8\]!
|
|
8010: 00000ffc \.word 0x00000ffc
|
|
00008014 <bar@plt>:
|
|
8014: 4778 bx pc
|
|
8016: e7fd b.n .+ <.+>
|
|
8018: e28fc600 add ip, pc, #0, 12
|
|
801c: e28cca00 add ip, ip, #0, 20
|
|
8020: e5bcfff8 ldr pc, \[ip, #4088\]! @ 0xff8
|
|
|
|
Disassembly of section \.text:
|
|
|
|
00008ff0 <foo>:
|
|
8ff0: 46c0 nop @ \(mov r8, r8\)
|
|
8ff2: f240 0000 movw r0, #0
|
|
8ff6: f240 0000 movw r0, #0
|
|
8ffa: f240 0000 movw r0, #0
|
|
8ffe: f000 b803 b\.w 9008 <foo\+0x18>
|
|
9002: 0000 movs r0, r0
|
|
9004: 0000 movs r0, r0
|
|
9006: 0000 movs r0, r0
|
|
9008: f7ff b804 b\.w 8014 <bar@plt>
|