mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-21 04:42:53 +08:00
224c3ddb89
Most allocation functions (if not all) return a void* pointing to the allocated memory. In C++, we need to add an explicit cast when assigning the result to a pointer to another type (which is the case more often than not). The content of this patch is taken from Pedro's branch, from commit "(mostly) auto-generated patch to insert casts needed for C++". I validated that the changes make sense and manually reflowed the code to make it respect the coding style. I also found multiple places where I could use XNEW/XNEWVEC/XRESIZEVEC/etc. Thanks a lot to whoever did that automated script to insert casts, doing it completely by hand would have taken a ridiculous amount of time. Only files built on x86 with --enable-targets=all are modified. This means that all other -nat.c files are untouched and will have to be dealt with later by using appropiate compilers. Or maybe we can try to build them with a regular g++ just to know where to add casts, I don't know. I built-tested this with --enable-targets=all and reg-tested. Here's the changelog entry, which was not too bad to make despite the size, thanks to David Malcom's script. I fixed some bits by hand, but there might be some wrong parts left (hopefully not). gdb/ChangeLog: * aarch64-linux-tdep.c (aarch64_stap_parse_special_token): Add cast to allocation result assignment. * ada-exp.y (write_object_renaming): Likewise. (write_ambiguous_var): Likewise. (ada_nget_field_index): Likewise. (write_var_or_type): Likewise. * ada-lang.c (ada_decode_symbol): Likewise. (ada_value_assign): Likewise. (value_pointer): Likewise. (cache_symbol): Likewise. (add_nonlocal_symbols): Likewise. (ada_name_for_lookup): Likewise. (symbol_completion_add): Likewise. (ada_to_fixed_type_1): Likewise. (ada_get_next_arg): Likewise. (defns_collected): Likewise. * ada-lex.l (processId): Likewise. (processString): Likewise. * ada-tasks.c (read_known_tasks_array): Likewise. (read_known_tasks_list): Likewise. * ada-typeprint.c (decoded_type_name): Likewise. * addrmap.c (addrmap_mutable_create_fixed): Likewise. * amd64-tdep.c (amd64_push_arguments): Likewise. (amd64_displaced_step_copy_insn): Likewise. (amd64_classify_insn_at): Likewise. (amd64_relocate_instruction): Likewise. * amd64obsd-tdep.c (amd64obsd_sigtramp_p): Likewise. * arch-utils.c (simple_displaced_step_copy_insn): Likewise. (initialize_current_architecture): Likewise. * arm-linux-tdep.c (arm_stap_parse_special_token): Likewise. * arm-symbian-tdep.c (arm_symbian_osabi_sniffer): Likewise. * arm-tdep.c (arm_exidx_new_objfile): Likewise. (arm_push_dummy_call): Likewise. (extend_buffer_earlier): Likewise. (arm_adjust_breakpoint_address): Likewise. (arm_skip_stub): Likewise. * auto-load.c (filename_is_in_pattern): Likewise. (maybe_add_script_file): Likewise. (maybe_add_script_text): Likewise. (auto_load_objfile_script_1): Likewise. * auxv.c (ld_so_xfer_auxv): Likewise. * ax-general.c (new_agent_expr): Likewise. (grow_expr): Likewise. (ax_reg_mask): Likewise. * bcache.c (bcache_full): Likewise. * breakpoint.c (program_breakpoint_here_p): Likewise. * btrace.c (parse_xml_raw): Likewise. * build-id.c (build_id_to_debug_bfd): Likewise. * buildsym.c (end_symtab_with_blockvector): Likewise. * c-exp.y (string_exp): Likewise. (qualified_name): Likewise. (write_destructor_name): Likewise. (operator_stoken): Likewise. (parse_number): Likewise. (scan_macro_expansion): Likewise. (yylex): Likewise. (c_print_token): Likewise. * c-lang.c (c_get_string): Likewise. (emit_numeric_character): Likewise. * charset.c (wchar_iterate): Likewise. * cli/cli-cmds.c (complete_command): Likewise. (make_command): Likewise. * cli/cli-dump.c (restore_section_callback): Likewise. (restore_binary_file): Likewise. * cli/cli-interp.c (cli_interpreter_exec): Likewise. * cli/cli-script.c (execute_control_command): Likewise. * cli/cli-setshow.c (do_set_command): Likewise. * coff-pe-read.c (add_pe_forwarded_sym): Likewise. (read_pe_exported_syms): Likewise. * coffread.c (coff_read_struct_type): Likewise. (coff_read_enum_type): Likewise. * common/btrace-common.c (btrace_data_append): Likewise. * common/buffer.c (buffer_grow): Likewise. * common/filestuff.c (gdb_fopen_cloexec): Likewise. * common/format.c (parse_format_string): Likewise. * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append): Likewise. * common/xml-utils.c (xml_escape_text): Likewise. * compile/compile-object-load.c (copy_sections): Likewise. (compile_object_load): Likewise. * compile/compile-object-run.c (compile_object_run): Likewise. * completer.c (filename_completer): Likewise. * corefile.c (read_memory_typed_address): Likewise. (write_memory_unsigned_integer): Likewise. (write_memory_signed_integer): Likewise. (complete_set_gnutarget): Likewise. * corelow.c (get_core_register_section): Likewise. * cp-name-parser.y (d_grab): Likewise. (allocate_info): Likewise. (cp_new_demangle_parse_info): Likewise. * cp-namespace.c (cp_scan_for_anonymous_namespaces): Likewise. (cp_lookup_symbol_in_namespace): Likewise. (lookup_namespace_scope): Likewise. (find_symbol_in_baseclass): Likewise. (cp_lookup_nested_symbol): Likewise. (cp_lookup_transparent_type_loop): Likewise. * cp-support.c (copy_string_to_obstack): Likewise. (make_symbol_overload_list): Likewise. (make_symbol_overload_list_namespace): Likewise. (make_symbol_overload_list_adl_namespace): Likewise. (first_component_command): Likewise. * cp-valprint.c (cp_print_value): Likewise. * ctf.c (ctf_xfer_partial): Likewise. * d-exp.y (StringExp): Likewise. * d-namespace.c (d_lookup_symbol_in_module): Likewise. (lookup_module_scope): Likewise. (find_symbol_in_baseclass): Likewise. (d_lookup_nested_symbol): Likewise. * dbxread.c (find_stab_function_addr): Likewise. (read_dbx_symtab): Likewise. (dbx_end_psymtab): Likewise. (cp_set_block_scope): Likewise. * dcache.c (dcache_alloc): Likewise. * demangle.c (_initialize_demangler): Likewise. * dicos-tdep.c (dicos_load_module_p): Likewise. * dictionary.c (dict_create_hashed_expandable): Likewise. (dict_create_linear_expandable): Likewise. (expand_hashtable): Likewise. (add_symbol_linear_expandable): Likewise. * dwarf2-frame.c (add_cie): Likewise. (add_fde): Likewise. (dwarf2_build_frame_info): Likewise. * dwarf2expr.c (dwarf_expr_grow_stack): Likewise. (dwarf_expr_fetch_address): Likewise. (add_piece): Likewise. (execute_stack_op): Likewise. * dwarf2loc.c (chain_candidate): Likewise. (dwarf_entry_parameter_to_value): Likewise. (read_pieced_value): Likewise. (write_pieced_value): Likewise. * dwarf2read.c (dwarf2_read_section): Likewise. (add_type_unit): Likewise. (read_comp_units_from_section): Likewise. (fixup_go_packaging): Likewise. (dwarf2_compute_name): Likewise. (dwarf2_physname): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (read_func_scope): Likewise. (read_call_site_scope): Likewise. (dwarf2_attach_fields_to_type): Likewise. (process_structure_scope): Likewise. (mark_common_block_symbol_computed): Likewise. (read_common_block): Likewise. (abbrev_table_read_table): Likewise. (guess_partial_die_structure_name): Likewise. (fixup_partial_die): Likewise. (add_file_name): Likewise. (dwarf2_const_value_data): Likewise. (dwarf2_const_value_attr): Likewise. (build_error_marker_type): Likewise. (guess_full_die_structure_name): Likewise. (anonymous_struct_prefix): Likewise. (typename_concat): Likewise. (dwarf2_canonicalize_name): Likewise. (dwarf2_name): Likewise. (write_constant_as_bytes): Likewise. (dwarf2_fetch_constant_bytes): Likewise. (copy_string): Likewise. (parse_macro_definition): Likewise. * elfread.c (elf_symfile_segments): Likewise. (elf_rel_plt_read): Likewise. (elf_gnu_ifunc_resolve_by_cache): Likewise. (elf_gnu_ifunc_resolve_by_got): Likewise. (elf_read_minimal_symbols): Likewise. (elf_gnu_ifunc_record_cache): Likewise. * event-top.c (top_level_prompt): Likewise. (command_line_handler): Likewise. * exec.c (resize_section_table): Likewise. * expprint.c (print_subexp_standard): Likewise. * fbsd-tdep.c (fbsd_collect_regset_section_cb): Likewise. * findcmd.c (parse_find_args): Likewise. * findvar.c (address_from_register): Likewise. * frame.c (get_prev_frame_always): Likewise. * gdb_bfd.c (gdb_bfd_ref): Likewise. (get_section_descriptor): Likewise. * gdb_obstack.c (obconcat): Likewise. (obstack_strdup): Likewise. * gdbtypes.c (lookup_function_type_with_arguments): Likewise. (create_set_type): Likewise. (lookup_unsigned_typename): Likewise. (lookup_signed_typename): Likewise. (resolve_dynamic_union): Likewise. (resolve_dynamic_struct): Likewise. (add_dyn_prop): Likewise. (copy_dynamic_prop_list): Likewise. (arch_flags_type): Likewise. (append_composite_type_field_raw): Likewise. * gdbtypes.h (INIT_FUNC_SPECIFIC): Likewise. * gnu-v3-abi.c (gnuv3_rtti_type): Likewise. * go-exp.y (string_exp): Likewise. * go-lang.c (go_demangle): Likewise. * guile/guile.c (compute_scheme_string): Likewise. * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise. (gdbscm_canonicalize_command_name): Likewise. * guile/scm-ports.c (ioscm_init_stdio_buffers): Likewise. (ioscm_init_memory_port): Likewise. (ioscm_reinit_memory_port): Likewise. * guile/scm-utils.c (gdbscm_gc_xstrdup): Likewise. (gdbscm_gc_dup_argv): Likewise. * h8300-tdep.c (h8300_push_dummy_call): Likewise. * hppa-tdep.c (internalize_unwinds): Likewise. (read_unwind_info): Likewise. * i386-cygwin-tdep.c (core_process_module_section): Likewise. (windows_core_xfer_shared_libraries): Likewise. * i386-tdep.c (i386_displaced_step_copy_insn): Likewise. (i386_stap_parse_special_token_triplet): Likewise. (i386_stap_parse_special_token_three_arg_disp): Likewise. * i386obsd-tdep.c (i386obsd_sigtramp_p): Likewise. * inf-child.c (inf_child_fileio_readlink): Likewise. * inf-ptrace.c (inf_ptrace_fetch_register): Likewise. (inf_ptrace_store_register): Likewise. * infrun.c (follow_exec): Likewise. (displaced_step_prepare_throw): Likewise. (save_stop_context): Likewise. (save_infcall_suspend_state): Likewise. * jit.c (jit_read_descriptor): Likewise. (jit_read_code_entry): Likewise. (jit_symtab_line_mapping_add_impl): Likewise. (finalize_symtab): Likewise. (jit_unwind_reg_get_impl): Likewise. * jv-exp.y (QualifiedName): Likewise. * jv-lang.c (get_java_utf8_name): Likewise. (type_from_class): Likewise. (java_demangle_type_signature): Likewise. (java_class_name_from_physname): Likewise. * jv-typeprint.c (java_type_print_base): Likewise. * jv-valprint.c (java_value_print): Likewise. * language.c (add_language): Likewise. * linespec.c (add_sal_to_sals_basic): Likewise. (add_sal_to_sals): Likewise. (decode_objc): Likewise. (find_linespec_symbols): Likewise. * linux-fork.c (fork_save_infrun_state): Likewise. * linux-nat.c (linux_nat_detach): Likewise. (linux_nat_fileio_readlink): Likewise. * linux-record.c (record_linux_sockaddr): Likewise. (record_linux_msghdr): Likewise. (Do): Likewise. * linux-tdep.c (linux_core_info_proc_mappings): Likewise. (linux_collect_regset_section_cb): Likewise. (linux_get_siginfo_data): Likewise. * linux-thread-db.c (try_thread_db_load_from_pdir_1): Likewise. (try_thread_db_load_from_dir): Likewise. (thread_db_load_search): Likewise. (info_auto_load_libthread_db): Likewise. * m32c-tdep.c (m32c_m16c_address_to_pointer): Likewise. (m32c_m16c_pointer_to_address): Likewise. * m68hc11-tdep.c (m68hc11_pseudo_register_write): Likewise. * m68k-tdep.c (m68k_get_longjmp_target): Likewise. * machoread.c (macho_check_dsym): Likewise. * macroexp.c (resize_buffer): Likewise. (gather_arguments): Likewise. (maybe_expand): Likewise. * macrotab.c (new_macro_key): Likewise. (new_source_file): Likewise. (new_macro_definition): Likewise. * mdebugread.c (parse_symbol): Likewise. (parse_type): Likewise. (parse_partial_symbols): Likewise. (psymtab_to_symtab_1): Likewise. * mem-break.c (default_memory_insert_breakpoint): Likewise. * mi/mi-cmd-break.c (mi_argv_to_format): Likewise. * mi/mi-main.c (mi_cmd_data_read_memory): Likewise. (mi_cmd_data_read_memory_bytes): Likewise. (mi_cmd_data_write_memory_bytes): Likewise. (mi_cmd_trace_frame_collected): Likewise. * mi/mi-parse.c (mi_parse_argv): Likewise. (mi_parse): Likewise. * minidebug.c (lzma_open): Likewise. (lzma_pread): Likewise. * mips-tdep.c (mips_read_fp_register_single): Likewise. (mips_print_fp_register): Likewise. * mipsnbsd-tdep.c (mipsnbsd_get_longjmp_target): Likewise. * mipsread.c (read_alphacoff_dynamic_symtab): Likewise. * mt-tdep.c (mt_register_name): Likewise. (mt_registers_info): Likewise. (mt_push_dummy_call): Likewise. * namespace.c (add_using_directive): Likewise. * nat/linux-btrace.c (perf_event_read): Likewise. (linux_enable_bts): Likewise. * nat/linux-osdata.c (linux_common_core_of_thread): Likewise. * nat/linux-ptrace.c (linux_ptrace_test_ret_to_nx): Likewise. * nto-tdep.c (nto_find_and_open_solib): Likewise. (nto_parse_redirection): Likewise. * objc-lang.c (objc_demangle): Likewise. (find_methods): Likewise. * objfiles.c (get_objfile_bfd_data): Likewise. (set_objfile_main_name): Likewise. (allocate_objfile): Likewise. (objfile_relocate): Likewise. (update_section_map): Likewise. * osabi.c (generic_elf_osabi_sniff_abi_tag_sections): Likewise. * p-exp.y (exp): Likewise. (yylex): Likewise. * p-valprint.c (pascal_object_print_value): Likewise. * parse.c (initialize_expout): Likewise. (mark_completion_tag): Likewise. (copy_name): Likewise. (parse_float): Likewise. (type_stack_reserve): Likewise. * ppc-linux-tdep.c (ppc_stap_parse_special_token): Likewise. (ppu2spu_prev_register): Likewise. * ppc-ravenscar-thread.c (supply_register_at_address): Likewise. * printcmd.c (printf_wide_c_string): Likewise. (printf_pointer): Likewise. * probe.c (parse_probes): Likewise. * python/py-cmd.c (gdbpy_parse_command_name): Likewise. (cmdpy_init): Likewise. * python/py-gdb-readline.c (gdbpy_readline_wrapper): Likewise. * python/py-symtab.c (set_sal): Likewise. * python/py-unwind.c (pyuw_sniffer): Likewise. * python/python.c (python_interactive_command): Likewise. (compute_python_string): Likewise. * ravenscar-thread.c (get_running_thread_id): Likewise. * record-full.c (record_full_exec_insn): Likewise. (record_full_core_open_1): Likewise. * regcache.c (regcache_raw_read_signed): Likewise. (regcache_raw_read_unsigned): Likewise. (regcache_cooked_read_signed): Likewise. (regcache_cooked_read_unsigned): Likewise. * remote-fileio.c (remote_fileio_func_open): Likewise. (remote_fileio_func_rename): Likewise. (remote_fileio_func_unlink): Likewise. (remote_fileio_func_stat): Likewise. (remote_fileio_func_system): Likewise. * remote-mips.c (mips_xfer_memory): Likewise. (mips_load_srec): Likewise. (pmon_end_download): Likewise. * remote.c (new_remote_state): Likewise. (map_regcache_remote_table): Likewise. (remote_register_number_and_offset): Likewise. (init_remote_state): Likewise. (get_memory_packet_size): Likewise. (remote_pass_signals): Likewise. (remote_program_signals): Likewise. (remote_start_remote): Likewise. (remote_check_symbols): Likewise. (remote_query_supported): Likewise. (extended_remote_attach): Likewise. (process_g_packet): Likewise. (store_registers_using_G): Likewise. (putpkt_binary): Likewise. (read_frame): Likewise. (compare_sections_command): Likewise. (remote_hostio_pread): Likewise. (remote_hostio_readlink): Likewise. (remote_file_put): Likewise. (remote_file_get): Likewise. (remote_pid_to_exec_file): Likewise. (_initialize_remote): Likewise. * rs6000-aix-tdep.c (rs6000_aix_ld_info_to_xml): Likewise. (rs6000_aix_core_xfer_shared_libraries_aix): Likewise. * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise. (bfd_uses_spe_extensions): Likewise. * s390-linux-tdep.c (s390_displaced_step_copy_insn): Likewise. * score-tdep.c (score7_malloc_and_get_memblock): Likewise. * solib-dsbt.c (decode_loadmap): Likewise. (fetch_loadmap): Likewise. (scan_dyntag): Likewise. (enable_break): Likewise. (dsbt_relocate_main_executable): Likewise. * solib-frv.c (fetch_loadmap): Likewise. (enable_break2): Likewise. (frv_relocate_main_executable): Likewise. * solib-spu.c (spu_relocate_main_executable): Likewise. (spu_bfd_open): Likewise. * solib-svr4.c (lm_info_read): Likewise. (read_program_header): Likewise. (find_program_interpreter): Likewise. (scan_dyntag): Likewise. (elf_locate_base): Likewise. (open_symbol_file_object): Likewise. (read_program_headers_from_bfd): Likewise. (svr4_relocate_main_executable): Likewise. * solib-target.c (solib_target_relocate_section_addresses): Likewise. * solib.c (solib_find_1): Likewise. (exec_file_find): Likewise. (solib_find): Likewise. * source.c (openp): Likewise. (print_source_lines_base): Likewise. (forward_search_command): Likewise. * sparc-ravenscar-thread.c (supply_register_at_address): Likewise. * spu-tdep.c (spu2ppu_prev_register): Likewise. (spu_get_overlay_table): Likewise. * stabsread.c (patch_block_stabs): Likewise. (define_symbol): Likewise. (again:): Likewise. (read_member_functions): Likewise. (read_one_struct_field): Likewise. (read_enum_type): Likewise. (common_block_start): Likewise. * stack.c (read_frame_arg): Likewise. (backtrace_command): Likewise. * stap-probe.c (stap_parse_register_operand): Likewise. * symfile.c (syms_from_objfile_1): Likewise. (find_separate_debug_file): Likewise. (load_command): Likewise. (load_progress): Likewise. (load_section_callback): Likewise. (reread_symbols): Likewise. (add_filename_language): Likewise. (allocate_compunit_symtab): Likewise. (read_target_long_array): Likewise. (simple_read_overlay_table): Likewise. * symtab.c (symbol_set_names): Likewise. (resize_symbol_cache): Likewise. (rbreak_command): Likewise. (completion_list_add_name): Likewise. (completion_list_objc_symbol): Likewise. (add_filename_to_list): Likewise. * target-descriptions.c (maint_print_c_tdesc_cmd): Likewise. * target-memory.c (target_write_memory_blocks): Likewise. * target.c (target_read_string): Likewise. (read_whatever_is_readable): Likewise. (target_read_alloc_1): Likewise. (simple_search_memory): Likewise. (target_fileio_read_alloc_1): Likewise. * tilegx-tdep.c (tilegx_push_dummy_call): Likewise. * top.c (command_line_input): Likewise. * tracefile-tfile.c (tfile_fetch_registers): Likewise. * tracefile.c (tracefile_fetch_registers): Likewise. * tracepoint.c (add_memrange): Likewise. (init_collection_list): Likewise. (add_aexpr): Likewise. (trace_dump_actions): Likewise. (parse_trace_status): Likewise. (parse_tracepoint_definition): Likewise. (parse_tsv_definition): Likewise. (parse_static_tracepoint_marker_definition): Likewise. * tui/tui-file.c (tui_sfileopen): Likewise. (tui_file_adjust_strbuf): Likewise. * tui/tui-io.c (tui_expand_tabs): Likewise. * tui/tui-source.c (tui_set_source_content): Likewise. * typeprint.c (find_global_typedef): Likewise. * ui-file.c (do_ui_file_xstrdup): Likewise. (ui_file_obsavestring): Likewise. (mem_file_write): Likewise. * utils.c (make_hex_string): Likewise. (get_regcomp_error): Likewise. (puts_filtered_tabular): Likewise. (gdb_realpath_keepfile): Likewise. (ldirname): Likewise. (gdb_bfd_errmsg): Likewise. (substitute_path_component): Likewise. * valops.c (search_struct_method): Likewise. (find_oload_champ_namespace_loop): Likewise. * valprint.c (print_decimal_chars): Likewise. (read_string): Likewise. (generic_emit_char): Likewise. * varobj.c (varobj_delete): Likewise. (varobj_value_get_print_value): Likewise. * vaxobsd-tdep.c (vaxobsd_sigtramp_sniffer): Likewise. * windows-tdep.c (display_one_tib): Likewise. * xcoffread.c (read_xcoff_symtab): Likewise. (process_xcoff_symbol): Likewise. (swap_sym): Likewise. (scan_xcoff_symtab): Likewise. (xcoff_initial_scan): Likewise. * xml-support.c (gdb_xml_end_element): Likewise. (xml_process_xincludes): Likewise. (xml_fetch_content_from_file): Likewise. * xml-syscall.c (xml_list_of_syscalls): Likewise. * xstormy16-tdep.c (xstormy16_push_dummy_call): Likewise. gdb/gdbserver/ChangeLog: * ax.c (gdb_parse_agent_expr): Add cast to allocation result assignment. (gdb_unparse_agent_expr): Likewise. * hostio.c (require_data): Likewise. (handle_pread): Likewise. * linux-low.c (disable_regset): Likewise. (fetch_register): Likewise. (store_register): Likewise. (get_dynamic): Likewise. (linux_qxfer_libraries_svr4): Likewise. * mem-break.c (delete_fast_tracepoint_jump): Likewise. (set_fast_tracepoint_jump): Likewise. (uninsert_fast_tracepoint_jumps_at): Likewise. (reinsert_fast_tracepoint_jumps_at): Likewise. (validate_inserted_breakpoint): Likewise. (clone_agent_expr): Likewise. * regcache.c (init_register_cache): Likewise. * remote-utils.c (putpkt_binary_1): Likewise. (decode_M_packet): Likewise. (decode_X_packet): Likewise. (look_up_one_symbol): Likewise. (relocate_instruction): Likewise. (monitor_output): Likewise. * server.c (handle_search_memory): Likewise. (handle_qxfer_exec_file): Likewise. (handle_qxfer_libraries): Likewise. (handle_qxfer): Likewise. (handle_query): Likewise. (handle_v_cont): Likewise. (handle_v_run): Likewise. (captured_main): Likewise. * target.c (write_inferior_memory): Likewise. * thread-db.c (try_thread_db_load_from_dir): Likewise. * tracepoint.c (init_trace_buffer): Likewise. (add_tracepoint_action): Likewise. (add_traceframe): Likewise. (add_traceframe_block): Likewise. (cmd_qtdpsrc): Likewise. (cmd_qtdv): Likewise. (cmd_qtstatus): Likewise. (response_source): Likewise. (response_tsv): Likewise. (cmd_qtnotes): Likewise. (gdb_collect): Likewise. (initialize_tracepoint): Likewise.
736 lines
20 KiB
C
736 lines
20 KiB
C
/* Caching code for GDB, the GNU debugger.
|
|
|
|
Copyright (C) 1992-2015 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "dcache.h"
|
|
#include "gdbcmd.h"
|
|
#include "gdbcore.h"
|
|
#include "target-dcache.h"
|
|
#include "inferior.h"
|
|
#include "splay-tree.h"
|
|
|
|
/* Commands with a prefix of `{set,show} dcache'. */
|
|
static struct cmd_list_element *dcache_set_list = NULL;
|
|
static struct cmd_list_element *dcache_show_list = NULL;
|
|
|
|
/* The data cache could lead to incorrect results because it doesn't
|
|
know about volatile variables, thus making it impossible to debug
|
|
functions which use memory mapped I/O devices. Set the nocache
|
|
memory region attribute in those cases.
|
|
|
|
In general the dcache speeds up performance. Some speed improvement
|
|
comes from the actual caching mechanism, but the major gain is in
|
|
the reduction of the remote protocol overhead; instead of reading
|
|
or writing a large area of memory in 4 byte requests, the cache
|
|
bundles up the requests into LINE_SIZE chunks, reducing overhead
|
|
significantly. This is most useful when accessing a large amount
|
|
of data, such as when performing a backtrace.
|
|
|
|
The cache is a splay tree along with a linked list for replacement.
|
|
Each block caches a LINE_SIZE area of memory. Within each line we
|
|
remember the address of the line (which must be a multiple of
|
|
LINE_SIZE) and the actual data block.
|
|
|
|
Lines are only allocated as needed, so DCACHE_SIZE really specifies the
|
|
*maximum* number of lines in the cache.
|
|
|
|
At present, the cache is write-through rather than writeback: as soon
|
|
as data is written to the cache, it is also immediately written to
|
|
the target. Therefore, cache lines are never "dirty". Whether a given
|
|
line is valid or not depends on where it is stored in the dcache_struct;
|
|
there is no per-block valid flag. */
|
|
|
|
/* NOTE: Interaction of dcache and memory region attributes
|
|
|
|
As there is no requirement that memory region attributes be aligned
|
|
to or be a multiple of the dcache page size, dcache_read_line() and
|
|
dcache_write_line() must break up the page by memory region. If a
|
|
chunk does not have the cache attribute set, an invalid memory type
|
|
is set, etc., then the chunk is skipped. Those chunks are handled
|
|
in target_xfer_memory() (or target_xfer_memory_partial()).
|
|
|
|
This doesn't occur very often. The most common occurance is when
|
|
the last bit of the .text segment and the first bit of the .data
|
|
segment fall within the same dcache page with a ro/cacheable memory
|
|
region defined for the .text segment and a rw/non-cacheable memory
|
|
region defined for the .data segment. */
|
|
|
|
/* The maximum number of lines stored. The total size of the cache is
|
|
equal to DCACHE_SIZE times LINE_SIZE. */
|
|
#define DCACHE_DEFAULT_SIZE 4096
|
|
static unsigned dcache_size = DCACHE_DEFAULT_SIZE;
|
|
|
|
/* The default size of a cache line. Smaller values reduce the time taken to
|
|
read a single byte and make the cache more granular, but increase
|
|
overhead and reduce the effectiveness of the cache as a prefetcher. */
|
|
#define DCACHE_DEFAULT_LINE_SIZE 64
|
|
static unsigned dcache_line_size = DCACHE_DEFAULT_LINE_SIZE;
|
|
|
|
/* Each cache block holds LINE_SIZE bytes of data
|
|
starting at a multiple-of-LINE_SIZE address. */
|
|
|
|
#define LINE_SIZE_MASK(dcache) ((dcache->line_size - 1))
|
|
#define XFORM(dcache, x) ((x) & LINE_SIZE_MASK (dcache))
|
|
#define MASK(dcache, x) ((x) & ~LINE_SIZE_MASK (dcache))
|
|
|
|
struct dcache_block
|
|
{
|
|
/* For least-recently-allocated and free lists. */
|
|
struct dcache_block *prev;
|
|
struct dcache_block *next;
|
|
|
|
CORE_ADDR addr; /* address of data */
|
|
int refs; /* # hits */
|
|
gdb_byte data[1]; /* line_size bytes at given address */
|
|
};
|
|
|
|
struct dcache_struct
|
|
{
|
|
splay_tree tree;
|
|
struct dcache_block *oldest; /* least-recently-allocated list. */
|
|
|
|
/* The free list is maintained identically to OLDEST to simplify
|
|
the code: we only need one set of accessors. */
|
|
struct dcache_block *freelist;
|
|
|
|
/* The number of in-use lines in the cache. */
|
|
int size;
|
|
CORE_ADDR line_size; /* current line_size. */
|
|
|
|
/* The ptid of last inferior to use cache or null_ptid. */
|
|
ptid_t ptid;
|
|
};
|
|
|
|
typedef void (block_func) (struct dcache_block *block, void *param);
|
|
|
|
static struct dcache_block *dcache_hit (DCACHE *dcache, CORE_ADDR addr);
|
|
|
|
static int dcache_read_line (DCACHE *dcache, struct dcache_block *db);
|
|
|
|
static struct dcache_block *dcache_alloc (DCACHE *dcache, CORE_ADDR addr);
|
|
|
|
static void dcache_info (char *exp, int tty);
|
|
|
|
void _initialize_dcache (void);
|
|
|
|
static int dcache_enabled_p = 0; /* OBSOLETE */
|
|
|
|
static void
|
|
show_dcache_enabled_p (struct ui_file *file, int from_tty,
|
|
struct cmd_list_element *c, const char *value)
|
|
{
|
|
fprintf_filtered (file, _("Deprecated remotecache flag is %s.\n"), value);
|
|
}
|
|
|
|
/* Add BLOCK to circular block list BLIST, behind the block at *BLIST.
|
|
*BLIST is not updated (unless it was previously NULL of course).
|
|
This is for the least-recently-allocated list's sake:
|
|
BLIST points to the oldest block.
|
|
??? This makes for poor cache usage of the free list,
|
|
but is it measurable? */
|
|
|
|
static void
|
|
append_block (struct dcache_block **blist, struct dcache_block *block)
|
|
{
|
|
if (*blist)
|
|
{
|
|
block->next = *blist;
|
|
block->prev = (*blist)->prev;
|
|
block->prev->next = block;
|
|
(*blist)->prev = block;
|
|
/* We don't update *BLIST here to maintain the invariant that for the
|
|
least-recently-allocated list *BLIST points to the oldest block. */
|
|
}
|
|
else
|
|
{
|
|
block->next = block;
|
|
block->prev = block;
|
|
*blist = block;
|
|
}
|
|
}
|
|
|
|
/* Remove BLOCK from circular block list BLIST. */
|
|
|
|
static void
|
|
remove_block (struct dcache_block **blist, struct dcache_block *block)
|
|
{
|
|
if (block->next == block)
|
|
{
|
|
*blist = NULL;
|
|
}
|
|
else
|
|
{
|
|
block->next->prev = block->prev;
|
|
block->prev->next = block->next;
|
|
/* If we removed the block *BLIST points to, shift it to the next block
|
|
to maintain the invariant that for the least-recently-allocated list
|
|
*BLIST points to the oldest block. */
|
|
if (*blist == block)
|
|
*blist = block->next;
|
|
}
|
|
}
|
|
|
|
/* Iterate over all elements in BLIST, calling FUNC.
|
|
PARAM is passed to FUNC.
|
|
FUNC may remove the block it's passed, but only that block. */
|
|
|
|
static void
|
|
for_each_block (struct dcache_block **blist, block_func *func, void *param)
|
|
{
|
|
struct dcache_block *db;
|
|
|
|
if (*blist == NULL)
|
|
return;
|
|
|
|
db = *blist;
|
|
do
|
|
{
|
|
struct dcache_block *next = db->next;
|
|
|
|
func (db, param);
|
|
db = next;
|
|
}
|
|
while (*blist && db != *blist);
|
|
}
|
|
|
|
/* BLOCK_FUNC routine for dcache_free. */
|
|
|
|
static void
|
|
free_block (struct dcache_block *block, void *param)
|
|
{
|
|
xfree (block);
|
|
}
|
|
|
|
/* Free a data cache. */
|
|
|
|
void
|
|
dcache_free (DCACHE *dcache)
|
|
{
|
|
splay_tree_delete (dcache->tree);
|
|
for_each_block (&dcache->oldest, free_block, NULL);
|
|
for_each_block (&dcache->freelist, free_block, NULL);
|
|
xfree (dcache);
|
|
}
|
|
|
|
|
|
/* BLOCK_FUNC function for dcache_invalidate.
|
|
This doesn't remove the block from the oldest list on purpose.
|
|
dcache_invalidate will do it later. */
|
|
|
|
static void
|
|
invalidate_block (struct dcache_block *block, void *param)
|
|
{
|
|
DCACHE *dcache = (DCACHE *) param;
|
|
|
|
splay_tree_remove (dcache->tree, (splay_tree_key) block->addr);
|
|
append_block (&dcache->freelist, block);
|
|
}
|
|
|
|
/* Free all the data cache blocks, thus discarding all cached data. */
|
|
|
|
void
|
|
dcache_invalidate (DCACHE *dcache)
|
|
{
|
|
for_each_block (&dcache->oldest, invalidate_block, dcache);
|
|
|
|
dcache->oldest = NULL;
|
|
dcache->size = 0;
|
|
dcache->ptid = null_ptid;
|
|
|
|
if (dcache->line_size != dcache_line_size)
|
|
{
|
|
/* We've been asked to use a different line size.
|
|
All of our freelist blocks are now the wrong size, so free them. */
|
|
|
|
for_each_block (&dcache->freelist, free_block, dcache);
|
|
dcache->freelist = NULL;
|
|
dcache->line_size = dcache_line_size;
|
|
}
|
|
}
|
|
|
|
/* Invalidate the line associated with ADDR. */
|
|
|
|
static void
|
|
dcache_invalidate_line (DCACHE *dcache, CORE_ADDR addr)
|
|
{
|
|
struct dcache_block *db = dcache_hit (dcache, addr);
|
|
|
|
if (db)
|
|
{
|
|
splay_tree_remove (dcache->tree, (splay_tree_key) db->addr);
|
|
remove_block (&dcache->oldest, db);
|
|
append_block (&dcache->freelist, db);
|
|
--dcache->size;
|
|
}
|
|
}
|
|
|
|
/* If addr is present in the dcache, return the address of the block
|
|
containing it. Otherwise return NULL. */
|
|
|
|
static struct dcache_block *
|
|
dcache_hit (DCACHE *dcache, CORE_ADDR addr)
|
|
{
|
|
struct dcache_block *db;
|
|
|
|
splay_tree_node node = splay_tree_lookup (dcache->tree,
|
|
(splay_tree_key) MASK (dcache, addr));
|
|
|
|
if (!node)
|
|
return NULL;
|
|
|
|
db = (struct dcache_block *) node->value;
|
|
db->refs++;
|
|
return db;
|
|
}
|
|
|
|
/* Fill a cache line from target memory.
|
|
The result is 1 for success, 0 if the (entire) cache line
|
|
wasn't readable. */
|
|
|
|
static int
|
|
dcache_read_line (DCACHE *dcache, struct dcache_block *db)
|
|
{
|
|
CORE_ADDR memaddr;
|
|
gdb_byte *myaddr;
|
|
int len;
|
|
int res;
|
|
int reg_len;
|
|
struct mem_region *region;
|
|
|
|
len = dcache->line_size;
|
|
memaddr = db->addr;
|
|
myaddr = db->data;
|
|
|
|
while (len > 0)
|
|
{
|
|
/* Don't overrun if this block is right at the end of the region. */
|
|
region = lookup_mem_region (memaddr);
|
|
if (region->hi == 0 || memaddr + len < region->hi)
|
|
reg_len = len;
|
|
else
|
|
reg_len = region->hi - memaddr;
|
|
|
|
/* Skip non-readable regions. The cache attribute can be ignored,
|
|
since we may be loading this for a stack access. */
|
|
if (region->attrib.mode == MEM_WO)
|
|
{
|
|
memaddr += reg_len;
|
|
myaddr += reg_len;
|
|
len -= reg_len;
|
|
continue;
|
|
}
|
|
|
|
res = target_read_raw_memory (memaddr, myaddr, reg_len);
|
|
if (res != 0)
|
|
return 0;
|
|
|
|
memaddr += reg_len;
|
|
myaddr += reg_len;
|
|
len -= reg_len;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
/* Get a free cache block, put or keep it on the valid list,
|
|
and return its address. */
|
|
|
|
static struct dcache_block *
|
|
dcache_alloc (DCACHE *dcache, CORE_ADDR addr)
|
|
{
|
|
struct dcache_block *db;
|
|
|
|
if (dcache->size >= dcache_size)
|
|
{
|
|
/* Evict the least recently allocated line. */
|
|
db = dcache->oldest;
|
|
remove_block (&dcache->oldest, db);
|
|
|
|
splay_tree_remove (dcache->tree, (splay_tree_key) db->addr);
|
|
}
|
|
else
|
|
{
|
|
db = dcache->freelist;
|
|
if (db)
|
|
remove_block (&dcache->freelist, db);
|
|
else
|
|
db = ((struct dcache_block *)
|
|
xmalloc (offsetof (struct dcache_block, data)
|
|
+ dcache->line_size));
|
|
|
|
dcache->size++;
|
|
}
|
|
|
|
db->addr = MASK (dcache, addr);
|
|
db->refs = 0;
|
|
|
|
/* Put DB at the end of the list, it's the newest. */
|
|
append_block (&dcache->oldest, db);
|
|
|
|
splay_tree_insert (dcache->tree, (splay_tree_key) db->addr,
|
|
(splay_tree_value) db);
|
|
|
|
return db;
|
|
}
|
|
|
|
/* Using the data cache DCACHE, store in *PTR the contents of the byte at
|
|
address ADDR in the remote machine.
|
|
|
|
Returns 1 for success, 0 for error. */
|
|
|
|
static int
|
|
dcache_peek_byte (DCACHE *dcache, CORE_ADDR addr, gdb_byte *ptr)
|
|
{
|
|
struct dcache_block *db = dcache_hit (dcache, addr);
|
|
|
|
if (!db)
|
|
{
|
|
db = dcache_alloc (dcache, addr);
|
|
|
|
if (!dcache_read_line (dcache, db))
|
|
return 0;
|
|
}
|
|
|
|
*ptr = db->data[XFORM (dcache, addr)];
|
|
return 1;
|
|
}
|
|
|
|
/* Write the byte at PTR into ADDR in the data cache.
|
|
|
|
The caller should have written the data through to target memory
|
|
already.
|
|
|
|
If ADDR is not in cache, this function does nothing; writing to an
|
|
area of memory which wasn't present in the cache doesn't cause it
|
|
to be loaded in. */
|
|
|
|
static void
|
|
dcache_poke_byte (DCACHE *dcache, CORE_ADDR addr, const gdb_byte *ptr)
|
|
{
|
|
struct dcache_block *db = dcache_hit (dcache, addr);
|
|
|
|
if (db)
|
|
db->data[XFORM (dcache, addr)] = *ptr;
|
|
}
|
|
|
|
static int
|
|
dcache_splay_tree_compare (splay_tree_key a, splay_tree_key b)
|
|
{
|
|
if (a > b)
|
|
return 1;
|
|
else if (a == b)
|
|
return 0;
|
|
else
|
|
return -1;
|
|
}
|
|
|
|
/* Allocate and initialize a data cache. */
|
|
|
|
DCACHE *
|
|
dcache_init (void)
|
|
{
|
|
DCACHE *dcache = XNEW (DCACHE);
|
|
|
|
dcache->tree = splay_tree_new (dcache_splay_tree_compare,
|
|
NULL,
|
|
NULL);
|
|
|
|
dcache->oldest = NULL;
|
|
dcache->freelist = NULL;
|
|
dcache->size = 0;
|
|
dcache->line_size = dcache_line_size;
|
|
dcache->ptid = null_ptid;
|
|
|
|
return dcache;
|
|
}
|
|
|
|
|
|
/* Read LEN bytes from dcache memory at MEMADDR, transferring to
|
|
debugger address MYADDR. If the data is presently cached, this
|
|
fills the cache. Arguments/return are like the target_xfer_partial
|
|
interface. */
|
|
|
|
enum target_xfer_status
|
|
dcache_read_memory_partial (struct target_ops *ops, DCACHE *dcache,
|
|
CORE_ADDR memaddr, gdb_byte *myaddr,
|
|
ULONGEST len, ULONGEST *xfered_len)
|
|
{
|
|
ULONGEST i;
|
|
|
|
/* If this is a different inferior from what we've recorded,
|
|
flush the cache. */
|
|
|
|
if (! ptid_equal (inferior_ptid, dcache->ptid))
|
|
{
|
|
dcache_invalidate (dcache);
|
|
dcache->ptid = inferior_ptid;
|
|
}
|
|
|
|
for (i = 0; i < len; i++)
|
|
{
|
|
if (!dcache_peek_byte (dcache, memaddr + i, myaddr + i))
|
|
{
|
|
/* That failed. Discard its cache line so we don't have a
|
|
partially read line. */
|
|
dcache_invalidate_line (dcache, memaddr + i);
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (i == 0)
|
|
{
|
|
/* Even though reading the whole line failed, we may be able to
|
|
read a piece starting where the caller wanted. */
|
|
return raw_memory_xfer_partial (ops, myaddr, NULL, memaddr, len,
|
|
xfered_len);
|
|
}
|
|
else
|
|
{
|
|
*xfered_len = i;
|
|
return TARGET_XFER_OK;
|
|
}
|
|
}
|
|
|
|
/* FIXME: There would be some benefit to making the cache write-back and
|
|
moving the writeback operation to a higher layer, as it could occur
|
|
after a sequence of smaller writes have been completed (as when a stack
|
|
frame is constructed for an inferior function call). Note that only
|
|
moving it up one level to target_xfer_memory[_partial]() is not
|
|
sufficient since we want to coalesce memory transfers that are
|
|
"logically" connected but not actually a single call to one of the
|
|
memory transfer functions. */
|
|
|
|
/* Just update any cache lines which are already present. This is
|
|
called by the target_xfer_partial machinery when writing raw
|
|
memory. */
|
|
|
|
void
|
|
dcache_update (DCACHE *dcache, enum target_xfer_status status,
|
|
CORE_ADDR memaddr, const gdb_byte *myaddr,
|
|
ULONGEST len)
|
|
{
|
|
ULONGEST i;
|
|
|
|
for (i = 0; i < len; i++)
|
|
if (status == TARGET_XFER_OK)
|
|
dcache_poke_byte (dcache, memaddr + i, myaddr + i);
|
|
else
|
|
{
|
|
/* Discard the whole cache line so we don't have a partially
|
|
valid line. */
|
|
dcache_invalidate_line (dcache, memaddr + i);
|
|
}
|
|
}
|
|
|
|
/* Print DCACHE line INDEX. */
|
|
|
|
static void
|
|
dcache_print_line (DCACHE *dcache, int index)
|
|
{
|
|
splay_tree_node n;
|
|
struct dcache_block *db;
|
|
int i, j;
|
|
|
|
if (dcache == NULL)
|
|
{
|
|
printf_filtered (_("No data cache available.\n"));
|
|
return;
|
|
}
|
|
|
|
n = splay_tree_min (dcache->tree);
|
|
|
|
for (i = index; i > 0; --i)
|
|
{
|
|
if (!n)
|
|
break;
|
|
n = splay_tree_successor (dcache->tree, n->key);
|
|
}
|
|
|
|
if (!n)
|
|
{
|
|
printf_filtered (_("No such cache line exists.\n"));
|
|
return;
|
|
}
|
|
|
|
db = (struct dcache_block *) n->value;
|
|
|
|
printf_filtered (_("Line %d: address %s [%d hits]\n"),
|
|
index, paddress (target_gdbarch (), db->addr), db->refs);
|
|
|
|
for (j = 0; j < dcache->line_size; j++)
|
|
{
|
|
printf_filtered ("%02x ", db->data[j]);
|
|
|
|
/* Print a newline every 16 bytes (48 characters). */
|
|
if ((j % 16 == 15) && (j != dcache->line_size - 1))
|
|
printf_filtered ("\n");
|
|
}
|
|
printf_filtered ("\n");
|
|
}
|
|
|
|
/* Parse EXP and show the info about DCACHE. */
|
|
|
|
static void
|
|
dcache_info_1 (DCACHE *dcache, char *exp)
|
|
{
|
|
splay_tree_node n;
|
|
int i, refcount;
|
|
|
|
if (exp)
|
|
{
|
|
char *linestart;
|
|
|
|
i = strtol (exp, &linestart, 10);
|
|
if (linestart == exp || i < 0)
|
|
{
|
|
printf_filtered (_("Usage: info dcache [linenumber]\n"));
|
|
return;
|
|
}
|
|
|
|
dcache_print_line (dcache, i);
|
|
return;
|
|
}
|
|
|
|
printf_filtered (_("Dcache %u lines of %u bytes each.\n"),
|
|
dcache_size,
|
|
dcache ? (unsigned) dcache->line_size
|
|
: dcache_line_size);
|
|
|
|
if (dcache == NULL || ptid_equal (dcache->ptid, null_ptid))
|
|
{
|
|
printf_filtered (_("No data cache available.\n"));
|
|
return;
|
|
}
|
|
|
|
printf_filtered (_("Contains data for %s\n"),
|
|
target_pid_to_str (dcache->ptid));
|
|
|
|
refcount = 0;
|
|
|
|
n = splay_tree_min (dcache->tree);
|
|
i = 0;
|
|
|
|
while (n)
|
|
{
|
|
struct dcache_block *db = (struct dcache_block *) n->value;
|
|
|
|
printf_filtered (_("Line %d: address %s [%d hits]\n"),
|
|
i, paddress (target_gdbarch (), db->addr), db->refs);
|
|
i++;
|
|
refcount += db->refs;
|
|
|
|
n = splay_tree_successor (dcache->tree, n->key);
|
|
}
|
|
|
|
printf_filtered (_("Cache state: %d active lines, %d hits\n"), i, refcount);
|
|
}
|
|
|
|
static void
|
|
dcache_info (char *exp, int tty)
|
|
{
|
|
dcache_info_1 (target_dcache_get (), exp);
|
|
}
|
|
|
|
static void
|
|
set_dcache_size (char *args, int from_tty,
|
|
struct cmd_list_element *c)
|
|
{
|
|
if (dcache_size == 0)
|
|
{
|
|
dcache_size = DCACHE_DEFAULT_SIZE;
|
|
error (_("Dcache size must be greater than 0."));
|
|
}
|
|
target_dcache_invalidate ();
|
|
}
|
|
|
|
static void
|
|
set_dcache_line_size (char *args, int from_tty,
|
|
struct cmd_list_element *c)
|
|
{
|
|
if (dcache_line_size < 2
|
|
|| (dcache_line_size & (dcache_line_size - 1)) != 0)
|
|
{
|
|
unsigned d = dcache_line_size;
|
|
dcache_line_size = DCACHE_DEFAULT_LINE_SIZE;
|
|
error (_("Invalid dcache line size: %u (must be power of 2)."), d);
|
|
}
|
|
target_dcache_invalidate ();
|
|
}
|
|
|
|
static void
|
|
set_dcache_command (char *arg, int from_tty)
|
|
{
|
|
printf_unfiltered (
|
|
"\"set dcache\" must be followed by the name of a subcommand.\n");
|
|
help_list (dcache_set_list, "set dcache ", all_commands, gdb_stdout);
|
|
}
|
|
|
|
static void
|
|
show_dcache_command (char *args, int from_tty)
|
|
{
|
|
cmd_show_list (dcache_show_list, from_tty, "");
|
|
}
|
|
|
|
void
|
|
_initialize_dcache (void)
|
|
{
|
|
add_setshow_boolean_cmd ("remotecache", class_support,
|
|
&dcache_enabled_p, _("\
|
|
Set cache use for remote targets."), _("\
|
|
Show cache use for remote targets."), _("\
|
|
This used to enable the data cache for remote targets. The cache\n\
|
|
functionality is now controlled by the memory region system and the\n\
|
|
\"stack-cache\" flag; \"remotecache\" now does nothing and\n\
|
|
exists only for compatibility reasons."),
|
|
NULL,
|
|
show_dcache_enabled_p,
|
|
&setlist, &showlist);
|
|
|
|
add_info ("dcache", dcache_info,
|
|
_("\
|
|
Print information on the dcache performance.\n\
|
|
With no arguments, this command prints the cache configuration and a\n\
|
|
summary of each line in the cache. Use \"info dcache <lineno> to dump\"\n\
|
|
the contents of a given line."));
|
|
|
|
add_prefix_cmd ("dcache", class_obscure, set_dcache_command, _("\
|
|
Use this command to set number of lines in dcache and line-size."),
|
|
&dcache_set_list, "set dcache ", /*allow_unknown*/0, &setlist);
|
|
add_prefix_cmd ("dcache", class_obscure, show_dcache_command, _("\
|
|
Show dcachesettings."),
|
|
&dcache_show_list, "show dcache ", /*allow_unknown*/0, &showlist);
|
|
|
|
add_setshow_zuinteger_cmd ("line-size", class_obscure,
|
|
&dcache_line_size, _("\
|
|
Set dcache line size in bytes (must be power of 2)."), _("\
|
|
Show dcache line size."),
|
|
NULL,
|
|
set_dcache_line_size,
|
|
NULL,
|
|
&dcache_set_list, &dcache_show_list);
|
|
add_setshow_zuinteger_cmd ("size", class_obscure,
|
|
&dcache_size, _("\
|
|
Set number of dcache lines."), _("\
|
|
Show number of dcache lines."),
|
|
NULL,
|
|
set_dcache_size,
|
|
NULL,
|
|
&dcache_set_list, &dcache_show_list);
|
|
}
|