Simon Marchi 2a50938ab7 gdb: make extract_integer take an array_view ...

I think it would make sense for extract_integer, extract_signed_integer
and extract_unsigned_integer to take an array_view.  This way, when we
extract an integer, we can validate that we don't overflow the buffer
passed by the caller (e.g. ask to extract a 4-byte integer but pass a
2-byte buffer).

 - Change extract_integer to take an array_view
 - Add overloads of extract_signed_integer and extract_unsigned_integer
   that take array_views.  Keep the existing versions so we don't
   need to change all callers, but make them call the array_view
   versions.

This shortens some places like:

  result = extract_unsigned_integer (value_contents (result_val).data (),
				     TYPE_LENGTH (value_type (result_val)),
				     byte_order);

into

  result = extract_unsigned_integer (value_contents (result_val), byte_order);

value_contents returns an array view that is of length
`TYPE_LENGTH (value_type (result_val))` already, so the length is
implicitly communicated through the array view.

Change-Id: Ic1c1f98c88d5c17a8486393af316f982604d6c95

2021-12-03 16:41:38 -05:00

..

basic_string_view

…

optional

…

array-view-selftests.c

gdbsupport: add array_view copy function

2021-12-03 16:37:36 -05:00

child-path-selftests.c

…

cli-utils-selftests.c

…

command-def-selftests.c

…

common-utils-selftests.c

gdb: introduce target_waitkind_str, use it in target_waitstatus::to_string

2021-11-22 13:57:49 -05:00

copy_bitwise-selftests.c

…

enum-flags-selftests.c

…

environ-selftests.c

…

filtered_iterator-selftests.c

…

format_pieces-selftests.c

…

function-view-selftests.c

…

gdb_tilde_expand-selftests.c

…

gmp-utils-selftests.c

gdb: make extract_integer take an array_view

2021-12-03 16:41:38 -05:00

intrusive_list-selftests.c

…

lookup_name_info-selftests.c

…

main-thread-selftests.c

…

memory-map-selftests.c

…

memrange-selftests.c

…

mkdir-recursive-selftests.c

…

observable-selftests.c

…

offset-type-selftests.c

…

optional-selftests.c

…

parallel-for-selftests.c

…

parse-connection-spec-selftests.c

…

ptid-selftests.c

…

rsp-low-selftests.c

…

scoped_fd-selftests.c

…

scoped_ignore_signal-selftests.c

…

scoped_mmap-selftests.c

…

scoped_restore-selftests.c

…

search-memory-selftests.c

…

string_view-selftests.c

…

style-selftests.c

…

tracepoint-selftests.c

…

tui-selftests.c

…

unpack-selftests.c

…

utils-selftests.c

…

vec-utils-selftests.c

…

xml-utils-selftests.c

…