mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 04:31:49 +08:00
e7c9de2678
Currently, if you try to use the array version of
gdb::unique_xmalloc_ptr (i.e., std::unique_ptr) in order to have
access to operator[], like:
gdb::unique_xmalloc_ptr<char[]> buf ((char *) xmalloc (10));
return buf[0];
then the build fails, like:
/usr/include/c++/5.3.1/bits/unique_ptr.h: In instantiation of ‘std::unique_ptr<_Tp [], _Dp>::~unique_ptr() [with _Tp = char; _Dp = gdb::xfree_deleter<char []>]’:
main.c:30:61: required from here
/usr/include/c++/5.3.1/bits/unique_ptr.h:484:17: error: no match for call to ‘(std::unique_ptr<char [], gdb::xfree_deleter<char []> >::deleter_type {aka gdb::xfree_deleter<char []>}) (char*&)’
get_deleter()(__ptr);
^
In file included from src/gdb/common/common-defs.h:92:0,
from src/gdb/defs.h:28,
from src/gdb/main.c:20:
src/gdb/common/gdb_unique_ptr.h:34:8: note: candidate: void gdb::xfree_deleter<T>::operator()(T*) const [with T = char []]
void operator() (T *ptr) const { xfree (ptr); }
^
src/gdb/common/gdb_unique_ptr.h:34:8: note: no known conversion for argument 1 from ‘char*’ to ‘char (*)[]’
Makefile:1911: recipe for target 'main.o' failed
make: *** [main.o] Error 1
The problem is that we're missing an xfree_deleter specialization for
arrays.
gdb/ChangeLog:
2017-08-10 Pedro Alves <palves@redhat.com>
* common/gdb_unique_ptr.h (xfree_deleter<T[]>): Define.
53 lines
1.4 KiB
C++
53 lines
1.4 KiB
C++
/* std::unique_ptr specializations for GDB.
|
|
|
|
Copyright (C) 2016-2017 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef GDB_UNIQUE_PTR_H
|
|
#define GDB_UNIQUE_PTR_H 1
|
|
|
|
#include <memory>
|
|
|
|
namespace gdb
|
|
{
|
|
/* Define gdb::unique_xmalloc_ptr, a std::unique_ptr that manages
|
|
xmalloc'ed memory. */
|
|
|
|
/* The deleter for std::unique_xmalloc_ptr. Uses xfree. */
|
|
template <typename T>
|
|
struct xfree_deleter
|
|
{
|
|
void operator() (T *ptr) const { xfree (ptr); }
|
|
};
|
|
|
|
/* Same, for arrays. */
|
|
template <typename T>
|
|
struct xfree_deleter<T[]>
|
|
{
|
|
void operator() (T *ptr) const { xfree (ptr); }
|
|
};
|
|
|
|
/* Import the standard unique_ptr to our namespace with a custom
|
|
deleter. */
|
|
|
|
template<typename T> using unique_xmalloc_ptr
|
|
= std::unique_ptr<T, xfree_deleter<T>>;
|
|
|
|
} /* namespace gdb */
|
|
|
|
#endif /* GDB_UNIQUE_PTR_H */
|