mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 04:31:49 +08:00
0fa7617d84
I recently learned that move constructors generally should be marked "noexcept". This ensures that standard containers will move objects when possible, rather than copy them. This patch fixes the cases I could find. Note that implicitly-defined or defaulted move constructors will automatically do what you'd expect; that is, they are noexcept if all the members have noexcept move constructors. While doing this, I noticed a couple of odd cases where the move constructor seemed to assume that the object being constructed could have state requiring destruction. I've fixed these as well. See completion_result and scoped_mmap. gdb/ChangeLog 2020-04-20 Tom Tromey <tromey@adacore.com> * python/python.c (struct gdbpy_event): Mark move constructor as noexcept. * python/py-tui.c (class gdbpy_tui_window_maker): Mark move constructor as noexcept. * completer.h (struct completion_result): Mark move constructor as noexcept. * completer.c (completion_result::completion_result): Use initialization style. Don't call reset_match_list. gdbsupport/ChangeLog 2020-04-20 Tom Tromey <tromey@adacore.com> * scoped_mmap.h (scoped_mmap): Mark move constructor as noexcept. Use initialization style. Don't call destroy. * scoped_fd.h (class scoped_fd): Mark move constructor as noexcept. * gdb_ref_ptr.h (class ref_ptr): Mark move constructor as noexcept.
92 lines
2.2 KiB
C++
92 lines
2.2 KiB
C++
/* scoped_mmap, automatically unmap files
|
|
|
|
Copyright (C) 2018-2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef COMMON_SCOPED_MMAP_H
|
|
#define COMMON_SCOPED_MMAP_H
|
|
|
|
#ifdef HAVE_SYS_MMAN_H
|
|
|
|
#include <sys/mman.h>
|
|
|
|
/* A smart-pointer-like class to mmap() and automatically munmap() a memory
|
|
mapping. */
|
|
|
|
class scoped_mmap
|
|
{
|
|
public:
|
|
scoped_mmap () noexcept : m_mem (MAP_FAILED), m_length (0) {}
|
|
scoped_mmap (void *addr, size_t length, int prot, int flags, int fd,
|
|
off_t offset) noexcept : m_length (length)
|
|
{
|
|
m_mem = mmap (addr, m_length, prot, flags, fd, offset);
|
|
}
|
|
|
|
~scoped_mmap ()
|
|
{
|
|
destroy ();
|
|
}
|
|
|
|
scoped_mmap (scoped_mmap &&rhs) noexcept
|
|
: m_mem (rhs.m_mem),
|
|
m_length (rhs.m_length)
|
|
{
|
|
rhs.m_mem = MAP_FAILED;
|
|
rhs.m_length = 0;
|
|
}
|
|
|
|
DISABLE_COPY_AND_ASSIGN (scoped_mmap);
|
|
|
|
ATTRIBUTE_UNUSED_RESULT void *release () noexcept
|
|
{
|
|
void *mem = m_mem;
|
|
m_mem = MAP_FAILED;
|
|
m_length = 0;
|
|
return mem;
|
|
}
|
|
|
|
void reset (void *addr, size_t length, int prot, int flags, int fd,
|
|
off_t offset) noexcept
|
|
{
|
|
destroy ();
|
|
|
|
m_length = length;
|
|
m_mem = mmap (addr, m_length, prot, flags, fd, offset);
|
|
}
|
|
|
|
size_t size () const noexcept { return m_length; }
|
|
void *get () const noexcept { return m_mem; }
|
|
|
|
private:
|
|
void destroy ()
|
|
{
|
|
if (m_mem != MAP_FAILED)
|
|
munmap (m_mem, m_length);
|
|
}
|
|
|
|
void *m_mem;
|
|
size_t m_length;
|
|
};
|
|
|
|
/* Map FILENAME in memory. Throw an error if anything goes wrong. */
|
|
scoped_mmap mmap_file (const char *filename);
|
|
|
|
#endif /* HAVE_SYS_MMAN_H */
|
|
|
|
#endif /* COMMON_SCOPED_MMAP_H */
|