mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-11-27 03:51:15 +08:00
dda83cd783
Many spots incorrectly use only spaces for indentation (for example, there are a lot of spots in ada-lang.c). I've always found it awkward when I needed to edit one of these spots: do I keep the original wrong indentation, or do I fix it? What if the lines around it are also wrong, do I fix them too? I probably don't want to fix them in the same patch, to avoid adding noise to my patch. So I propose to fix as much as possible once and for all (hopefully). One typical counter argument for this is that it makes code archeology more difficult, because git-blame will show this commit as the last change for these lines. My counter counter argument is: when git-blaming, you often need to do "blame the file at the parent commit" anyway, to go past some other refactor that touched the line you are interested in, but is not the change you are looking for. So you already need a somewhat efficient way to do this. Using some interactive tool, rather than plain git-blame, makes this trivial. For example, I use "tig blame <file>", where going back past the commit that changed the currently selected line is one keystroke. It looks like Magit in Emacs does it too (though I've never used it). Web viewers of Github and Gitlab do it too. My point is that it won't really make archeology more difficult. The other typical counter argument is that it will cause conflicts with existing patches. That's true... but it's a one time cost, and those are not conflicts that are difficult to resolve. I have also tried "git rebase --ignore-whitespace", it seems to work well. Although that will re-introduce the faulty indentation, so one needs to take care of fixing the indentation in the patch after that (which is easy). gdb/ChangeLog: * aarch64-linux-tdep.c: Fix indentation. * aarch64-ravenscar-thread.c: Fix indentation. * aarch64-tdep.c: Fix indentation. * aarch64-tdep.h: Fix indentation. * ada-lang.c: Fix indentation. * ada-lang.h: Fix indentation. * ada-tasks.c: Fix indentation. * ada-typeprint.c: Fix indentation. * ada-valprint.c: Fix indentation. * ada-varobj.c: Fix indentation. * addrmap.c: Fix indentation. * addrmap.h: Fix indentation. * agent.c: Fix indentation. * aix-thread.c: Fix indentation. * alpha-bsd-nat.c: Fix indentation. * alpha-linux-tdep.c: Fix indentation. * alpha-mdebug-tdep.c: Fix indentation. * alpha-nbsd-tdep.c: Fix indentation. * alpha-obsd-tdep.c: Fix indentation. * alpha-tdep.c: Fix indentation. * amd64-bsd-nat.c: Fix indentation. * amd64-darwin-tdep.c: Fix indentation. * amd64-linux-nat.c: Fix indentation. * amd64-linux-tdep.c: Fix indentation. * amd64-nat.c: Fix indentation. * amd64-obsd-tdep.c: Fix indentation. * amd64-tdep.c: Fix indentation. * amd64-windows-tdep.c: Fix indentation. * annotate.c: Fix indentation. * arc-tdep.c: Fix indentation. * arch-utils.c: Fix indentation. * arch/arm-get-next-pcs.c: Fix indentation. * arch/arm.c: Fix indentation. * arm-linux-nat.c: Fix indentation. * arm-linux-tdep.c: Fix indentation. * arm-nbsd-tdep.c: Fix indentation. * arm-pikeos-tdep.c: Fix indentation. * arm-tdep.c: Fix indentation. * arm-tdep.h: Fix indentation. * arm-wince-tdep.c: Fix indentation. * auto-load.c: Fix indentation. * auxv.c: Fix indentation. * avr-tdep.c: Fix indentation. * ax-gdb.c: Fix indentation. * ax-general.c: Fix indentation. * bfin-linux-tdep.c: Fix indentation. * block.c: Fix indentation. * block.h: Fix indentation. * blockframe.c: Fix indentation. * bpf-tdep.c: Fix indentation. * break-catch-sig.c: Fix indentation. * break-catch-syscall.c: Fix indentation. * break-catch-throw.c: Fix indentation. * breakpoint.c: Fix indentation. * breakpoint.h: Fix indentation. * bsd-uthread.c: Fix indentation. * btrace.c: Fix indentation. * build-id.c: Fix indentation. * buildsym-legacy.h: Fix indentation. * buildsym.c: Fix indentation. * c-typeprint.c: Fix indentation. * c-valprint.c: Fix indentation. * c-varobj.c: Fix indentation. * charset.c: Fix indentation. * cli/cli-cmds.c: Fix indentation. * cli/cli-decode.c: Fix indentation. * cli/cli-decode.h: Fix indentation. * cli/cli-script.c: Fix indentation. * cli/cli-setshow.c: Fix indentation. * coff-pe-read.c: Fix indentation. * coffread.c: Fix indentation. * compile/compile-cplus-types.c: Fix indentation. * compile/compile-object-load.c: Fix indentation. * compile/compile-object-run.c: Fix indentation. * completer.c: Fix indentation. * corefile.c: Fix indentation. * corelow.c: Fix indentation. * cp-abi.h: Fix indentation. * cp-namespace.c: Fix indentation. * cp-support.c: Fix indentation. * cp-valprint.c: Fix indentation. * cris-linux-tdep.c: Fix indentation. * cris-tdep.c: Fix indentation. * darwin-nat-info.c: Fix indentation. * darwin-nat.c: Fix indentation. * darwin-nat.h: Fix indentation. * dbxread.c: Fix indentation. * dcache.c: Fix indentation. * disasm.c: Fix indentation. * dtrace-probe.c: Fix indentation. * dwarf2/abbrev.c: Fix indentation. * dwarf2/attribute.c: Fix indentation. * dwarf2/expr.c: Fix indentation. * dwarf2/frame.c: Fix indentation. * dwarf2/index-cache.c: Fix indentation. * dwarf2/index-write.c: Fix indentation. * dwarf2/line-header.c: Fix indentation. * dwarf2/loc.c: Fix indentation. * dwarf2/macro.c: Fix indentation. * dwarf2/read.c: Fix indentation. * dwarf2/read.h: Fix indentation. * elfread.c: Fix indentation. * eval.c: Fix indentation. * event-top.c: Fix indentation. * exec.c: Fix indentation. * exec.h: Fix indentation. * expprint.c: Fix indentation. * f-lang.c: Fix indentation. * f-typeprint.c: Fix indentation. * f-valprint.c: Fix indentation. * fbsd-nat.c: Fix indentation. * fbsd-tdep.c: Fix indentation. * findvar.c: Fix indentation. * fork-child.c: Fix indentation. * frame-unwind.c: Fix indentation. * frame-unwind.h: Fix indentation. * frame.c: Fix indentation. * frv-linux-tdep.c: Fix indentation. * frv-tdep.c: Fix indentation. * frv-tdep.h: Fix indentation. * ft32-tdep.c: Fix indentation. * gcore.c: Fix indentation. * gdb_bfd.c: Fix indentation. * gdbarch.sh: Fix indentation. * gdbarch.c: Re-generate * gdbarch.h: Re-generate. * gdbcore.h: Fix indentation. * gdbthread.h: Fix indentation. * gdbtypes.c: Fix indentation. * gdbtypes.h: Fix indentation. * glibc-tdep.c: Fix indentation. * gnu-nat.c: Fix indentation. * gnu-nat.h: Fix indentation. * gnu-v2-abi.c: Fix indentation. * gnu-v3-abi.c: Fix indentation. * go32-nat.c: Fix indentation. * guile/guile-internal.h: Fix indentation. * guile/scm-cmd.c: Fix indentation. * guile/scm-frame.c: Fix indentation. * guile/scm-iterator.c: Fix indentation. * guile/scm-math.c: Fix indentation. * guile/scm-ports.c: Fix indentation. * guile/scm-pretty-print.c: Fix indentation. * guile/scm-value.c: Fix indentation. * h8300-tdep.c: Fix indentation. * hppa-linux-nat.c: Fix indentation. * hppa-linux-tdep.c: Fix indentation. * hppa-nbsd-nat.c: Fix indentation. * hppa-nbsd-tdep.c: Fix indentation. * hppa-obsd-nat.c: Fix indentation. * hppa-tdep.c: Fix indentation. * hppa-tdep.h: Fix indentation. * i386-bsd-nat.c: Fix indentation. * i386-darwin-nat.c: Fix indentation. * i386-darwin-tdep.c: Fix indentation. * i386-dicos-tdep.c: Fix indentation. * i386-gnu-nat.c: Fix indentation. * i386-linux-nat.c: Fix indentation. * i386-linux-tdep.c: Fix indentation. * i386-nto-tdep.c: Fix indentation. * i386-obsd-tdep.c: Fix indentation. * i386-sol2-nat.c: Fix indentation. * i386-tdep.c: Fix indentation. * i386-tdep.h: Fix indentation. * i386-windows-tdep.c: Fix indentation. * i387-tdep.c: Fix indentation. * i387-tdep.h: Fix indentation. * ia64-libunwind-tdep.c: Fix indentation. * ia64-libunwind-tdep.h: Fix indentation. * ia64-linux-nat.c: Fix indentation. * ia64-linux-tdep.c: Fix indentation. * ia64-tdep.c: Fix indentation. * ia64-tdep.h: Fix indentation. * ia64-vms-tdep.c: Fix indentation. * infcall.c: Fix indentation. * infcmd.c: Fix indentation. * inferior.c: Fix indentation. * infrun.c: Fix indentation. * iq2000-tdep.c: Fix indentation. * language.c: Fix indentation. * linespec.c: Fix indentation. * linux-fork.c: Fix indentation. * linux-nat.c: Fix indentation. * linux-tdep.c: Fix indentation. * linux-thread-db.c: Fix indentation. * lm32-tdep.c: Fix indentation. * m2-lang.c: Fix indentation. * m2-typeprint.c: Fix indentation. * m2-valprint.c: Fix indentation. * m32c-tdep.c: Fix indentation. * m32r-linux-tdep.c: Fix indentation. * m32r-tdep.c: Fix indentation. * m68hc11-tdep.c: Fix indentation. * m68k-bsd-nat.c: Fix indentation. * m68k-linux-nat.c: Fix indentation. * m68k-linux-tdep.c: Fix indentation. * m68k-tdep.c: Fix indentation. * machoread.c: Fix indentation. * macrocmd.c: Fix indentation. * macroexp.c: Fix indentation. * macroscope.c: Fix indentation. * macrotab.c: Fix indentation. * macrotab.h: Fix indentation. * main.c: Fix indentation. * mdebugread.c: Fix indentation. * mep-tdep.c: Fix indentation. * mi/mi-cmd-catch.c: Fix indentation. * mi/mi-cmd-disas.c: Fix indentation. * mi/mi-cmd-env.c: Fix indentation. * mi/mi-cmd-stack.c: Fix indentation. * mi/mi-cmd-var.c: Fix indentation. * mi/mi-cmds.c: Fix indentation. * mi/mi-main.c: Fix indentation. * mi/mi-parse.c: Fix indentation. * microblaze-tdep.c: Fix indentation. * minidebug.c: Fix indentation. * minsyms.c: Fix indentation. * mips-linux-nat.c: Fix indentation. * mips-linux-tdep.c: Fix indentation. * mips-nbsd-tdep.c: Fix indentation. * mips-tdep.c: Fix indentation. * mn10300-linux-tdep.c: Fix indentation. * mn10300-tdep.c: Fix indentation. * moxie-tdep.c: Fix indentation. * msp430-tdep.c: Fix indentation. * namespace.h: Fix indentation. * nat/fork-inferior.c: Fix indentation. * nat/gdb_ptrace.h: Fix indentation. * nat/linux-namespaces.c: Fix indentation. * nat/linux-osdata.c: Fix indentation. * nat/netbsd-nat.c: Fix indentation. * nat/x86-dregs.c: Fix indentation. * nbsd-nat.c: Fix indentation. * nbsd-tdep.c: Fix indentation. * nios2-linux-tdep.c: Fix indentation. * nios2-tdep.c: Fix indentation. * nto-procfs.c: Fix indentation. * nto-tdep.c: Fix indentation. * objfiles.c: Fix indentation. * objfiles.h: Fix indentation. * opencl-lang.c: Fix indentation. * or1k-tdep.c: Fix indentation. * osabi.c: Fix indentation. * osabi.h: Fix indentation. * osdata.c: Fix indentation. * p-lang.c: Fix indentation. * p-typeprint.c: Fix indentation. * p-valprint.c: Fix indentation. * parse.c: Fix indentation. * ppc-linux-nat.c: Fix indentation. * ppc-linux-tdep.c: Fix indentation. * ppc-nbsd-nat.c: Fix indentation. * ppc-nbsd-tdep.c: Fix indentation. * ppc-obsd-nat.c: Fix indentation. * ppc-ravenscar-thread.c: Fix indentation. * ppc-sysv-tdep.c: Fix indentation. * ppc64-tdep.c: Fix indentation. * printcmd.c: Fix indentation. * proc-api.c: Fix indentation. * producer.c: Fix indentation. * producer.h: Fix indentation. * prologue-value.c: Fix indentation. * prologue-value.h: Fix indentation. * psymtab.c: Fix indentation. * python/py-arch.c: Fix indentation. * python/py-bpevent.c: Fix indentation. * python/py-event.c: Fix indentation. * python/py-event.h: Fix indentation. * python/py-finishbreakpoint.c: Fix indentation. * python/py-frame.c: Fix indentation. * python/py-framefilter.c: Fix indentation. * python/py-inferior.c: Fix indentation. * python/py-infthread.c: Fix indentation. * python/py-objfile.c: Fix indentation. * python/py-prettyprint.c: Fix indentation. * python/py-registers.c: Fix indentation. * python/py-signalevent.c: Fix indentation. * python/py-stopevent.c: Fix indentation. * python/py-stopevent.h: Fix indentation. * python/py-threadevent.c: Fix indentation. * python/py-tui.c: Fix indentation. * python/py-unwind.c: Fix indentation. * python/py-value.c: Fix indentation. * python/py-xmethods.c: Fix indentation. * python/python-internal.h: Fix indentation. * python/python.c: Fix indentation. * ravenscar-thread.c: Fix indentation. * record-btrace.c: Fix indentation. * record-full.c: Fix indentation. * record.c: Fix indentation. * reggroups.c: Fix indentation. * regset.h: Fix indentation. * remote-fileio.c: Fix indentation. * remote.c: Fix indentation. * reverse.c: Fix indentation. * riscv-linux-tdep.c: Fix indentation. * riscv-ravenscar-thread.c: Fix indentation. * riscv-tdep.c: Fix indentation. * rl78-tdep.c: Fix indentation. * rs6000-aix-tdep.c: Fix indentation. * rs6000-lynx178-tdep.c: Fix indentation. * rs6000-nat.c: Fix indentation. * rs6000-tdep.c: Fix indentation. * rust-lang.c: Fix indentation. * rx-tdep.c: Fix indentation. * s12z-tdep.c: Fix indentation. * s390-linux-tdep.c: Fix indentation. * score-tdep.c: Fix indentation. * ser-base.c: Fix indentation. * ser-mingw.c: Fix indentation. * ser-uds.c: Fix indentation. * ser-unix.c: Fix indentation. * serial.c: Fix indentation. * sh-linux-tdep.c: Fix indentation. * sh-nbsd-tdep.c: Fix indentation. * sh-tdep.c: Fix indentation. * skip.c: Fix indentation. * sol-thread.c: Fix indentation. * solib-aix.c: Fix indentation. * solib-darwin.c: Fix indentation. * solib-frv.c: Fix indentation. * solib-svr4.c: Fix indentation. * solib.c: Fix indentation. * source.c: Fix indentation. * sparc-linux-tdep.c: Fix indentation. * sparc-nbsd-tdep.c: Fix indentation. * sparc-obsd-tdep.c: Fix indentation. * sparc-ravenscar-thread.c: Fix indentation. * sparc-tdep.c: Fix indentation. * sparc64-linux-tdep.c: Fix indentation. * sparc64-nbsd-tdep.c: Fix indentation. * sparc64-obsd-tdep.c: Fix indentation. * sparc64-tdep.c: Fix indentation. * stabsread.c: Fix indentation. * stack.c: Fix indentation. * stap-probe.c: Fix indentation. * stubs/ia64vms-stub.c: Fix indentation. * stubs/m32r-stub.c: Fix indentation. * stubs/m68k-stub.c: Fix indentation. * stubs/sh-stub.c: Fix indentation. * stubs/sparc-stub.c: Fix indentation. * symfile-mem.c: Fix indentation. * symfile.c: Fix indentation. * symfile.h: Fix indentation. * symmisc.c: Fix indentation. * symtab.c: Fix indentation. * symtab.h: Fix indentation. * target-float.c: Fix indentation. * target.c: Fix indentation. * target.h: Fix indentation. * tic6x-tdep.c: Fix indentation. * tilegx-linux-tdep.c: Fix indentation. * tilegx-tdep.c: Fix indentation. * top.c: Fix indentation. * tracefile-tfile.c: Fix indentation. * tracepoint.c: Fix indentation. * tui/tui-disasm.c: Fix indentation. * tui/tui-io.c: Fix indentation. * tui/tui-regs.c: Fix indentation. * tui/tui-stack.c: Fix indentation. * tui/tui-win.c: Fix indentation. * tui/tui-winsource.c: Fix indentation. * tui/tui.c: Fix indentation. * typeprint.c: Fix indentation. * ui-out.h: Fix indentation. * unittests/copy_bitwise-selftests.c: Fix indentation. * unittests/memory-map-selftests.c: Fix indentation. * utils.c: Fix indentation. * v850-tdep.c: Fix indentation. * valarith.c: Fix indentation. * valops.c: Fix indentation. * valprint.c: Fix indentation. * valprint.h: Fix indentation. * value.c: Fix indentation. * value.h: Fix indentation. * varobj.c: Fix indentation. * vax-tdep.c: Fix indentation. * windows-nat.c: Fix indentation. * windows-tdep.c: Fix indentation. * xcoffread.c: Fix indentation. * xml-syscall.c: Fix indentation. * xml-tdesc.c: Fix indentation. * xstormy16-tdep.c: Fix indentation. * xtensa-config.c: Fix indentation. * xtensa-linux-nat.c: Fix indentation. * xtensa-linux-tdep.c: Fix indentation. * xtensa-tdep.c: Fix indentation. gdbserver/ChangeLog: * ax.cc: Fix indentation. * dll.cc: Fix indentation. * inferiors.h: Fix indentation. * linux-low.cc: Fix indentation. * linux-nios2-low.cc: Fix indentation. * linux-ppc-ipa.cc: Fix indentation. * linux-ppc-low.cc: Fix indentation. * linux-x86-low.cc: Fix indentation. * linux-xtensa-low.cc: Fix indentation. * regcache.cc: Fix indentation. * server.cc: Fix indentation. * tracepoint.cc: Fix indentation. gdbsupport/ChangeLog: * common-exceptions.h: Fix indentation. * event-loop.cc: Fix indentation. * fileio.cc: Fix indentation. * filestuff.cc: Fix indentation. * gdb-dlfcn.cc: Fix indentation. * gdb_string_view.h: Fix indentation. * job-control.cc: Fix indentation. * signals.cc: Fix indentation. Change-Id: I4bad7ae6be0fbe14168b8ebafb98ffe14964a695
442 lines
14 KiB
C
442 lines
14 KiB
C
/* Native-dependent code for GNU/Linux x86-64.
|
||
|
||
Copyright (C) 2001-2020 Free Software Foundation, Inc.
|
||
Contributed by Jiri Smid, SuSE Labs.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
#include "inferior.h"
|
||
#include "regcache.h"
|
||
#include "elf/common.h"
|
||
#include <sys/uio.h>
|
||
#include "nat/gdb_ptrace.h"
|
||
#include <asm/prctl.h>
|
||
#include <sys/reg.h>
|
||
#include "gregset.h"
|
||
#include "gdb_proc_service.h"
|
||
|
||
#include "amd64-nat.h"
|
||
#include "amd64-tdep.h"
|
||
#include "amd64-linux-tdep.h"
|
||
#include "i386-linux-tdep.h"
|
||
#include "gdbsupport/x86-xstate.h"
|
||
|
||
#include "x86-linux-nat.h"
|
||
#include "nat/linux-ptrace.h"
|
||
#include "nat/amd64-linux-siginfo.h"
|
||
|
||
/* This definition comes from prctl.h. Kernels older than 2.5.64
|
||
do not have it. */
|
||
#ifndef PTRACE_ARCH_PRCTL
|
||
#define PTRACE_ARCH_PRCTL 30
|
||
#endif
|
||
|
||
struct amd64_linux_nat_target final : public x86_linux_nat_target
|
||
{
|
||
/* Add our register access methods. */
|
||
void fetch_registers (struct regcache *, int) override;
|
||
void store_registers (struct regcache *, int) override;
|
||
|
||
bool low_siginfo_fixup (siginfo_t *ptrace, gdb_byte *inf, int direction)
|
||
override;
|
||
};
|
||
|
||
static amd64_linux_nat_target the_amd64_linux_nat_target;
|
||
|
||
/* Mapping between the general-purpose registers in GNU/Linux x86-64
|
||
`struct user' format and GDB's register cache layout for GNU/Linux
|
||
i386.
|
||
|
||
Note that most GNU/Linux x86-64 registers are 64-bit, while the
|
||
GNU/Linux i386 registers are all 32-bit, but since we're
|
||
little-endian we get away with that. */
|
||
|
||
/* From <sys/reg.h> on GNU/Linux i386. */
|
||
static int amd64_linux_gregset32_reg_offset[] =
|
||
{
|
||
RAX * 8, RCX * 8, /* %eax, %ecx */
|
||
RDX * 8, RBX * 8, /* %edx, %ebx */
|
||
RSP * 8, RBP * 8, /* %esp, %ebp */
|
||
RSI * 8, RDI * 8, /* %esi, %edi */
|
||
RIP * 8, EFLAGS * 8, /* %eip, %eflags */
|
||
CS * 8, SS * 8, /* %cs, %ss */
|
||
DS * 8, ES * 8, /* %ds, %es */
|
||
FS * 8, GS * 8, /* %fs, %gs */
|
||
-1, -1, -1, -1, -1, -1, -1, -1,
|
||
-1, -1, -1, -1, -1, -1, -1, -1,
|
||
-1, -1, -1, -1, -1, -1, -1, -1, -1,
|
||
-1, -1, -1, -1, -1, -1, -1, -1,
|
||
-1, -1, -1, -1, /* MPX registers BND0 ... BND3. */
|
||
-1, -1, /* MPX registers BNDCFGU, BNDSTATUS. */
|
||
-1, -1, -1, -1, -1, -1, -1, -1, /* k0 ... k7 (AVX512) */
|
||
-1, -1, -1, -1, -1, -1, -1, -1, /* zmm0 ... zmm7 (AVX512) */
|
||
-1, /* PKEYS register PKRU */
|
||
ORIG_RAX * 8 /* "orig_eax" */
|
||
};
|
||
|
||
|
||
/* Transfering the general-purpose registers between GDB, inferiors
|
||
and core files. */
|
||
|
||
/* See amd64_collect_native_gregset. This linux specific version handles
|
||
issues with negative EAX values not being restored correctly upon syscall
|
||
return when debugging 32-bit targets. It has no effect on 64-bit
|
||
targets. */
|
||
|
||
static void
|
||
amd64_linux_collect_native_gregset (const struct regcache *regcache,
|
||
void *gregs, int regnum)
|
||
{
|
||
amd64_collect_native_gregset (regcache, gregs, regnum);
|
||
|
||
struct gdbarch *gdbarch = regcache->arch ();
|
||
if (gdbarch_bfd_arch_info (gdbarch)->bits_per_word == 32)
|
||
{
|
||
/* Sign extend EAX value to avoid potential syscall restart
|
||
problems.
|
||
|
||
On Linux, when a syscall is interrupted by a signal, the
|
||
(kernel function implementing the) syscall may return
|
||
-ERESTARTSYS when a signal occurs. Doing so indicates that
|
||
the syscall is restartable. Then, depending on settings
|
||
associated with the signal handler, and after the signal
|
||
handler is called, the kernel can then either return -EINTR
|
||
or it can cause the syscall to be restarted. We are
|
||
concerned with the latter case here.
|
||
|
||
On (32-bit) i386, the status (-ERESTARTSYS) is placed in the
|
||
EAX register. When debugging a 32-bit process from a 64-bit
|
||
(amd64) GDB, the debugger fetches 64-bit registers even
|
||
though the process being debugged is only 32-bit. The
|
||
register cache is only 32 bits wide though; GDB discards the
|
||
high 32 bits when placing 64-bit values in the 32-bit
|
||
regcache. Normally, this is not a problem since the 32-bit
|
||
process should only care about the lower 32-bit portions of
|
||
these registers. That said, it can happen that the 64-bit
|
||
value being restored will be different from the 64-bit value
|
||
that was originally retrieved from the kernel. The one place
|
||
(that we know of) where it does matter is in the kernel's
|
||
syscall restart code. The kernel's code for restarting a
|
||
syscall after a signal expects to see a negative value
|
||
(specifically -ERESTARTSYS) in the 64-bit RAX register in
|
||
order to correctly cause a syscall to be restarted.
|
||
|
||
The call to amd64_collect_native_gregset, above, is setting
|
||
the high 32 bits of RAX (and other registers too) to 0. For
|
||
syscall restart, we need to sign extend EAX so that RAX will
|
||
appear as a negative value when EAX is set to -ERESTARTSYS.
|
||
This in turn will cause the signal handling code in the
|
||
kernel to recognize -ERESTARTSYS which will in turn cause the
|
||
syscall to be restarted.
|
||
|
||
The test case gdb.base/interrupt.exp tests for this problem.
|
||
Without this sign extension code in place, it'll show
|
||
a number of failures when testing against unix/-m32. */
|
||
|
||
if (regnum == -1 || regnum == I386_EAX_REGNUM)
|
||
{
|
||
void *ptr = ((gdb_byte *) gregs
|
||
+ amd64_linux_gregset32_reg_offset[I386_EAX_REGNUM]);
|
||
|
||
*(int64_t *) ptr = *(int32_t *) ptr;
|
||
}
|
||
}
|
||
}
|
||
|
||
/* Fill GDB's register cache with the general-purpose register values
|
||
in *GREGSETP. */
|
||
|
||
void
|
||
supply_gregset (struct regcache *regcache, const elf_gregset_t *gregsetp)
|
||
{
|
||
amd64_supply_native_gregset (regcache, gregsetp, -1);
|
||
}
|
||
|
||
/* Fill register REGNUM (if it is a general-purpose register) in
|
||
*GREGSETP with the value in GDB's register cache. If REGNUM is -1,
|
||
do this for all registers. */
|
||
|
||
void
|
||
fill_gregset (const struct regcache *regcache,
|
||
elf_gregset_t *gregsetp, int regnum)
|
||
{
|
||
amd64_linux_collect_native_gregset (regcache, gregsetp, regnum);
|
||
}
|
||
|
||
/* Transfering floating-point registers between GDB, inferiors and cores. */
|
||
|
||
/* Fill GDB's register cache with the floating-point and SSE register
|
||
values in *FPREGSETP. */
|
||
|
||
void
|
||
supply_fpregset (struct regcache *regcache, const elf_fpregset_t *fpregsetp)
|
||
{
|
||
amd64_supply_fxsave (regcache, -1, fpregsetp);
|
||
}
|
||
|
||
/* Fill register REGNUM (if it is a floating-point or SSE register) in
|
||
*FPREGSETP with the value in GDB's register cache. If REGNUM is
|
||
-1, do this for all registers. */
|
||
|
||
void
|
||
fill_fpregset (const struct regcache *regcache,
|
||
elf_fpregset_t *fpregsetp, int regnum)
|
||
{
|
||
amd64_collect_fxsave (regcache, regnum, fpregsetp);
|
||
}
|
||
|
||
|
||
/* Transferring arbitrary registers between GDB and inferior. */
|
||
|
||
/* Fetch register REGNUM from the child process. If REGNUM is -1, do
|
||
this for all registers (including the floating point and SSE
|
||
registers). */
|
||
|
||
void
|
||
amd64_linux_nat_target::fetch_registers (struct regcache *regcache, int regnum)
|
||
{
|
||
struct gdbarch *gdbarch = regcache->arch ();
|
||
int tid;
|
||
|
||
/* GNU/Linux LWP ID's are process ID's. */
|
||
tid = regcache->ptid ().lwp ();
|
||
if (tid == 0)
|
||
tid = regcache->ptid ().pid (); /* Not a threaded program. */
|
||
|
||
if (regnum == -1 || amd64_native_gregset_supplies_p (gdbarch, regnum))
|
||
{
|
||
elf_gregset_t regs;
|
||
|
||
if (ptrace (PTRACE_GETREGS, tid, 0, (long) ®s) < 0)
|
||
perror_with_name (_("Couldn't get registers"));
|
||
|
||
amd64_supply_native_gregset (regcache, ®s, -1);
|
||
if (regnum != -1)
|
||
return;
|
||
}
|
||
|
||
if (regnum == -1 || !amd64_native_gregset_supplies_p (gdbarch, regnum))
|
||
{
|
||
elf_fpregset_t fpregs;
|
||
|
||
if (have_ptrace_getregset == TRIBOOL_TRUE)
|
||
{
|
||
char xstateregs[X86_XSTATE_MAX_SIZE];
|
||
struct iovec iov;
|
||
|
||
/* Pre-4.14 kernels have a bug (fixed by commit 0852b374173b
|
||
"x86/fpu: Add FPU state copying quirk to handle XRSTOR failure on
|
||
Intel Skylake CPUs") that sometimes causes the mxcsr location in
|
||
xstateregs not to be copied by PTRACE_GETREGSET. Make sure that
|
||
the location is at least initialized with a defined value. */
|
||
memset (xstateregs, 0, sizeof (xstateregs));
|
||
iov.iov_base = xstateregs;
|
||
iov.iov_len = sizeof (xstateregs);
|
||
if (ptrace (PTRACE_GETREGSET, tid,
|
||
(unsigned int) NT_X86_XSTATE, (long) &iov) < 0)
|
||
perror_with_name (_("Couldn't get extended state status"));
|
||
|
||
amd64_supply_xsave (regcache, -1, xstateregs);
|
||
}
|
||
else
|
||
{
|
||
if (ptrace (PTRACE_GETFPREGS, tid, 0, (long) &fpregs) < 0)
|
||
perror_with_name (_("Couldn't get floating point status"));
|
||
|
||
amd64_supply_fxsave (regcache, -1, &fpregs);
|
||
}
|
||
}
|
||
}
|
||
|
||
/* Store register REGNUM back into the child process. If REGNUM is
|
||
-1, do this for all registers (including the floating-point and SSE
|
||
registers). */
|
||
|
||
void
|
||
amd64_linux_nat_target::store_registers (struct regcache *regcache, int regnum)
|
||
{
|
||
struct gdbarch *gdbarch = regcache->arch ();
|
||
int tid;
|
||
|
||
/* GNU/Linux LWP ID's are process ID's. */
|
||
tid = regcache->ptid ().lwp ();
|
||
if (tid == 0)
|
||
tid = regcache->ptid ().pid (); /* Not a threaded program. */
|
||
|
||
if (regnum == -1 || amd64_native_gregset_supplies_p (gdbarch, regnum))
|
||
{
|
||
elf_gregset_t regs;
|
||
|
||
if (ptrace (PTRACE_GETREGS, tid, 0, (long) ®s) < 0)
|
||
perror_with_name (_("Couldn't get registers"));
|
||
|
||
amd64_linux_collect_native_gregset (regcache, ®s, regnum);
|
||
|
||
if (ptrace (PTRACE_SETREGS, tid, 0, (long) ®s) < 0)
|
||
perror_with_name (_("Couldn't write registers"));
|
||
|
||
if (regnum != -1)
|
||
return;
|
||
}
|
||
|
||
if (regnum == -1 || !amd64_native_gregset_supplies_p (gdbarch, regnum))
|
||
{
|
||
elf_fpregset_t fpregs;
|
||
|
||
if (have_ptrace_getregset == TRIBOOL_TRUE)
|
||
{
|
||
char xstateregs[X86_XSTATE_MAX_SIZE];
|
||
struct iovec iov;
|
||
|
||
iov.iov_base = xstateregs;
|
||
iov.iov_len = sizeof (xstateregs);
|
||
if (ptrace (PTRACE_GETREGSET, tid,
|
||
(unsigned int) NT_X86_XSTATE, (long) &iov) < 0)
|
||
perror_with_name (_("Couldn't get extended state status"));
|
||
|
||
amd64_collect_xsave (regcache, regnum, xstateregs, 0);
|
||
|
||
if (ptrace (PTRACE_SETREGSET, tid,
|
||
(unsigned int) NT_X86_XSTATE, (long) &iov) < 0)
|
||
perror_with_name (_("Couldn't write extended state status"));
|
||
}
|
||
else
|
||
{
|
||
if (ptrace (PTRACE_GETFPREGS, tid, 0, (long) &fpregs) < 0)
|
||
perror_with_name (_("Couldn't get floating point status"));
|
||
|
||
amd64_collect_fxsave (regcache, regnum, &fpregs);
|
||
|
||
if (ptrace (PTRACE_SETFPREGS, tid, 0, (long) &fpregs) < 0)
|
||
perror_with_name (_("Couldn't write floating point status"));
|
||
}
|
||
}
|
||
}
|
||
|
||
|
||
/* This function is called by libthread_db as part of its handling of
|
||
a request for a thread's local storage address. */
|
||
|
||
ps_err_e
|
||
ps_get_thread_area (struct ps_prochandle *ph,
|
||
lwpid_t lwpid, int idx, void **base)
|
||
{
|
||
if (gdbarch_bfd_arch_info (ph->thread->inf->gdbarch)->bits_per_word == 32)
|
||
{
|
||
unsigned int base_addr;
|
||
ps_err_e result;
|
||
|
||
result = x86_linux_get_thread_area (lwpid, (void *) (long) idx,
|
||
&base_addr);
|
||
if (result == PS_OK)
|
||
{
|
||
/* Extend the value to 64 bits. Here it's assumed that
|
||
a "long" and a "void *" are the same. */
|
||
(*base) = (void *) (long) base_addr;
|
||
}
|
||
return result;
|
||
}
|
||
else
|
||
{
|
||
|
||
/* FIXME: ezannoni-2003-07-09 see comment above about include
|
||
file order. We could be getting bogus values for these two. */
|
||
gdb_assert (FS < ELF_NGREG);
|
||
gdb_assert (GS < ELF_NGREG);
|
||
switch (idx)
|
||
{
|
||
case FS:
|
||
{
|
||
unsigned long fs;
|
||
errno = 0;
|
||
fs = ptrace (PTRACE_PEEKUSER, lwpid,
|
||
offsetof (struct user_regs_struct, fs_base), 0);
|
||
if (errno == 0)
|
||
{
|
||
*base = (void *) fs;
|
||
return PS_OK;
|
||
}
|
||
}
|
||
|
||
break;
|
||
|
||
case GS:
|
||
{
|
||
unsigned long gs;
|
||
errno = 0;
|
||
gs = ptrace (PTRACE_PEEKUSER, lwpid,
|
||
offsetof (struct user_regs_struct, gs_base), 0);
|
||
if (errno == 0)
|
||
{
|
||
*base = (void *) gs;
|
||
return PS_OK;
|
||
}
|
||
}
|
||
break;
|
||
|
||
default: /* Should not happen. */
|
||
return PS_BADADDR;
|
||
}
|
||
}
|
||
return PS_ERR; /* ptrace failed. */
|
||
}
|
||
|
||
|
||
/* Convert a ptrace/host siginfo object, into/from the siginfo in the
|
||
layout of the inferiors' architecture. Returns true if any
|
||
conversion was done; false otherwise. If DIRECTION is 1, then copy
|
||
from INF to PTRACE. If DIRECTION is 0, copy from PTRACE to
|
||
INF. */
|
||
|
||
bool
|
||
amd64_linux_nat_target::low_siginfo_fixup (siginfo_t *ptrace,
|
||
gdb_byte *inf,
|
||
int direction)
|
||
{
|
||
struct gdbarch *gdbarch = get_frame_arch (get_current_frame ());
|
||
|
||
/* Is the inferior 32-bit? If so, then do fixup the siginfo
|
||
object. */
|
||
if (gdbarch_bfd_arch_info (gdbarch)->bits_per_word == 32)
|
||
return amd64_linux_siginfo_fixup_common (ptrace, inf, direction,
|
||
FIXUP_32);
|
||
/* No fixup for native x32 GDB. */
|
||
else if (gdbarch_addr_bit (gdbarch) == 32 && sizeof (void *) == 8)
|
||
return amd64_linux_siginfo_fixup_common (ptrace, inf, direction,
|
||
FIXUP_X32);
|
||
else
|
||
return false;
|
||
}
|
||
|
||
void _initialize_amd64_linux_nat ();
|
||
void
|
||
_initialize_amd64_linux_nat ()
|
||
{
|
||
amd64_native_gregset32_reg_offset = amd64_linux_gregset32_reg_offset;
|
||
amd64_native_gregset32_num_regs = I386_LINUX_NUM_REGS;
|
||
amd64_native_gregset64_reg_offset = amd64_linux_gregset_reg_offset;
|
||
amd64_native_gregset64_num_regs = AMD64_LINUX_NUM_REGS;
|
||
|
||
gdb_assert (ARRAY_SIZE (amd64_linux_gregset32_reg_offset)
|
||
== amd64_native_gregset32_num_regs);
|
||
|
||
linux_target = &the_amd64_linux_nat_target;
|
||
|
||
/* Add the target. */
|
||
add_inf_child_target (linux_target);
|
||
}
|