mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-15 04:31:49 +08:00
9a3c826307
Note: I needed to split this patch in two, otherwise it's too big for the mailing list. This patch adds explicit casts to situations where a void pointer is assigned to a pointer to the "real" type. Building in C++ mode requires those assignments to use an explicit cast. This includes, for example: - callback arguments (cleanups, comparison functions, ...) - data attached to some object (objfile, program space, etc) in the form of a void pointer - "user data" passed to some function This patch comes from the commit "(mostly) auto-generated patch to insert casts needed for C++", taken from Pedro's C++ branch. Only files built on x86 with --enable-targets=all are modified, so the native files for other arches will need to be dealt with separately. I built-tested this with --enable-targets=all and reg-tested. To my surprise, a test case (selftest.exp) had to be adjusted. Here's the ChangeLog entry. Again, this was relatively quick to make despite the length, thanks to David Malcom's script, although I don't believe it's very useful information in that particular case... gdb/ChangeLog: * aarch64-tdep.c (aarch64_make_prologue_cache): Add cast(s). (aarch64_make_stub_cache): Likewise. (value_of_aarch64_user_reg): Likewise. * ada-lang.c (ada_inferior_data_cleanup): Likewise. (get_ada_inferior_data): Likewise. (get_ada_pspace_data): Likewise. (ada_pspace_data_cleanup): Likewise. (ada_complete_symbol_matcher): Likewise. (ada_exc_search_name_matches): Likewise. * ada-tasks.c (get_ada_tasks_pspace_data): Likewise. (get_ada_tasks_inferior_data): Likewise. * addrmap.c (addrmap_mutable_foreach_worker): Likewise. (splay_obstack_alloc): Likewise. (splay_obstack_free): Likewise. * alpha-linux-tdep.c (alpha_linux_supply_gregset): Likewise. (alpha_linux_collect_gregset): Likewise. (alpha_linux_supply_fpregset): Likewise. (alpha_linux_collect_fpregset): Likewise. * alpha-mdebug-tdep.c (alpha_mdebug_frame_unwind_cache): Likewise. * alpha-tdep.c (alpha_lds): Likewise. (alpha_sts): Likewise. (alpha_sigtramp_frame_unwind_cache): Likewise. (alpha_heuristic_frame_unwind_cache): Likewise. (alpha_supply_int_regs): Likewise. (alpha_fill_int_regs): Likewise. (alpha_supply_fp_regs): Likewise. (alpha_fill_fp_regs): Likewise. * alphanbsd-tdep.c (alphanbsd_supply_fpregset): Likewise. (alphanbsd_aout_supply_gregset): Likewise. (alphanbsd_supply_gregset): Likewise. * amd64-linux-tdep.c (amd64_linux_init_abi): Likewise. (amd64_x32_linux_init_abi): Likewise. * amd64-nat.c (amd64_supply_native_gregset): Likewise. (amd64_collect_native_gregset): Likewise. * amd64-tdep.c (amd64_frame_cache): Likewise. (amd64_sigtramp_frame_cache): Likewise. (amd64_epilogue_frame_cache): Likewise. (amd64_supply_fxsave): Likewise. (amd64_supply_xsave): Likewise. (amd64_collect_fxsave): Likewise. (amd64_collect_xsave): Likewise. * amd64-windows-tdep.c (amd64_windows_frame_cache): Likewise. * amd64obsd-tdep.c (amd64obsd_trapframe_cache): Likewise. * arm-linux-tdep.c (arm_linux_supply_gregset): Likewise. (arm_linux_collect_gregset): Likewise. (arm_linux_supply_nwfpe): Likewise. (arm_linux_collect_nwfpe): Likewise. (arm_linux_supply_vfp): Likewise. (arm_linux_collect_vfp): Likewise. * arm-tdep.c (arm_find_mapping_symbol): Likewise. (arm_prologue_unwind_stop_reason): Likewise. (arm_prologue_this_id): Likewise. (arm_prologue_prev_register): Likewise. (arm_exidx_data_free): Likewise. (arm_find_exidx_entry): Likewise. (arm_stub_this_id): Likewise. (arm_m_exception_this_id): Likewise. (arm_m_exception_prev_register): Likewise. (arm_normal_frame_base): Likewise. (gdb_print_insn_arm): Likewise. (arm_objfile_data_free): Likewise. (arm_record_special_symbol): Likewise. (value_of_arm_user_reg): Likewise. * armbsd-tdep.c (armbsd_supply_fpregset): Likewise. (armbsd_supply_gregset): Likewise. * auto-load.c (auto_load_pspace_data_cleanup): Likewise. (get_auto_load_pspace_data): Likewise. (hash_loaded_script_entry): Likewise. (eq_loaded_script_entry): Likewise. (clear_section_scripts): Likewise. (collect_matching_scripts): Likewise. * auxv.c (auxv_inferior_data_cleanup): Likewise. (get_auxv_inferior_data): Likewise. * avr-tdep.c (avr_frame_unwind_cache): Likewise. * ax-general.c (do_free_agent_expr_cleanup): Likewise. * bfd-target.c (target_bfd_xfer_partial): Likewise. (target_bfd_xclose): Likewise. (target_bfd_get_section_table): Likewise. * bfin-tdep.c (bfin_frame_cache): Likewise. * block.c (find_block_in_blockvector): Likewise. (call_site_for_pc): Likewise. (block_find_non_opaque_type_preferred): Likewise. * break-catch-sig.c (signal_catchpoint_insert_location): Likewise. (signal_catchpoint_remove_location): Likewise. (signal_catchpoint_breakpoint_hit): Likewise. (signal_catchpoint_print_one): Likewise. (signal_catchpoint_print_mention): Likewise. (signal_catchpoint_print_recreate): Likewise. * break-catch-syscall.c (get_catch_syscall_inferior_data): Likewise. * breakpoint.c (do_cleanup_counted_command_line): Likewise. (bp_location_compare_addrs): Likewise. (get_first_locp_gte_addr): Likewise. (check_tracepoint_command): Likewise. (do_map_commands_command): Likewise. (get_breakpoint_objfile_data): Likewise. (free_breakpoint_probes): Likewise. (do_captured_breakpoint_query): Likewise. (compare_breakpoints): Likewise. (bp_location_compare): Likewise. (bpstat_remove_breakpoint_callback): Likewise. (do_delete_breakpoint_cleanup): Likewise. * bsd-uthread.c (bsd_uthread_set_supply_uthread): Likewise. (bsd_uthread_set_collect_uthread): Likewise. (bsd_uthread_activate): Likewise. (bsd_uthread_fetch_registers): Likewise. (bsd_uthread_store_registers): Likewise. * btrace.c (check_xml_btrace_version): Likewise. (parse_xml_btrace_block): Likewise. (parse_xml_btrace_pt_config_cpu): Likewise. (parse_xml_btrace_pt_raw): Likewise. (parse_xml_btrace_pt): Likewise. (parse_xml_btrace_conf_bts): Likewise. (parse_xml_btrace_conf_pt): Likewise. (do_btrace_data_cleanup): Likewise. * c-typeprint.c (find_typedef_for_canonicalize): Likewise. * charset.c (cleanup_iconv): Likewise. (do_cleanup_iterator): Likewise. * cli-out.c (cli_uiout_dtor): Likewise. (cli_table_begin): Likewise. (cli_table_body): Likewise. (cli_table_end): Likewise. (cli_table_header): Likewise. (cli_begin): Likewise. (cli_end): Likewise. (cli_field_int): Likewise. (cli_field_skip): Likewise. (cli_field_string): Likewise. (cli_field_fmt): Likewise. (cli_spaces): Likewise. (cli_text): Likewise. (cli_message): Likewise. (cli_wrap_hint): Likewise. (cli_flush): Likewise. (cli_redirect): Likewise. (out_field_fmt): Likewise. (field_separator): Likewise. (cli_out_set_stream): Likewise. * cli/cli-cmds.c (compare_symtabs): Likewise. * cli/cli-dump.c (call_dump_func): Likewise. (restore_section_callback): Likewise. * cli/cli-script.c (clear_hook_in_cleanup): Likewise. (do_restore_user_call_depth): Likewise. (do_free_command_lines_cleanup): Likewise. * coff-pe-read.c (get_section_vmas): Likewise. (pe_as16): Likewise. (pe_as32): Likewise. * coffread.c (coff_symfile_read): Likewise. * common/agent.c (agent_look_up_symbols): Likewise. * common/filestuff.c (do_close_cleanup): Likewise. * common/format.c (free_format_pieces_cleanup): Likewise. * common/vec.c (vec_o_reserve): Likewise. * compile/compile-c-support.c (print_one_macro): Likewise. * compile/compile-c-symbols.c (hash_symbol_error): Likewise. (eq_symbol_error): Likewise. (del_symbol_error): Likewise. (error_symbol_once): Likewise. (gcc_convert_symbol): Likewise. (gcc_symbol_address): Likewise. (hash_symname): Likewise. (eq_symname): Likewise. * compile/compile-c-types.c (hash_type_map_instance): Likewise. (eq_type_map_instance): Likewise. (insert_type): Likewise. (convert_type): Likewise. * compile/compile-object-load.c (munmap_listp_free_cleanup): Likewise. (setup_sections): Likewise. (link_hash_table_free): Likewise. (copy_sections): Likewise. * compile/compile-object-run.c (do_module_cleanup): Likewise. * compile/compile.c (compile_print_value): Likewise. (do_rmdir): Likewise. (cleanup_compile_instance): Likewise. (cleanup_unlink_file): Likewise. * completer.c (free_completion_tracker): Likewise. * corelow.c (add_to_spuid_list): Likewise. * cp-namespace.c (reset_directive_searched): Likewise. * cp-support.c (reset_directive_searched): Likewise. * cris-tdep.c (cris_sigtramp_frame_unwind_cache): Likewise. (cris_frame_unwind_cache): Likewise. * d-lang.c (builtin_d_type): Likewise. * d-namespace.c (reset_directive_searched): Likewise. * dbxread.c (dbx_free_symfile_info): Likewise. (do_free_bincl_list_cleanup): Likewise. * disasm.c (hash_dis_line_entry): Likewise. (eq_dis_line_entry): Likewise. (dis_asm_print_address): Likewise. (fprintf_disasm): Likewise. (do_ui_file_delete): Likewise. * doublest.c (convert_floatformat_to_doublest): Likewise. * dummy-frame.c (pop_dummy_frame_bpt): Likewise. (dummy_frame_prev_register): Likewise. (dummy_frame_this_id): Likewise. * dwarf2-frame-tailcall.c (cache_hash): Likewise. (cache_eq): Likewise. (cache_find): Likewise. (tailcall_frame_this_id): Likewise. (dwarf2_tailcall_prev_register_first): Likewise. (tailcall_frame_prev_register): Likewise. (tailcall_frame_dealloc_cache): Likewise. (tailcall_frame_prev_arch): Likewise. * dwarf2-frame.c (dwarf2_frame_state_free): Likewise. (dwarf2_frame_set_init_reg): Likewise. (dwarf2_frame_init_reg): Likewise. (dwarf2_frame_set_signal_frame_p): Likewise. (dwarf2_frame_signal_frame_p): Likewise. (dwarf2_frame_set_adjust_regnum): Likewise. (dwarf2_frame_adjust_regnum): Likewise. (clear_pointer_cleanup): Likewise. (dwarf2_frame_cache): Likewise. (find_cie): Likewise. (dwarf2_frame_find_fde): Likewise. * dwarf2expr.c (dwarf_expr_address_type): Likewise. (free_dwarf_expr_context_cleanup): Likewise. * dwarf2loc.c (locexpr_find_frame_base_location): Likewise. (locexpr_get_frame_base): Likewise. (loclist_find_frame_base_location): Likewise. (loclist_get_frame_base): Likewise. (dwarf_expr_dwarf_call): Likewise. (dwarf_expr_get_base_type): Likewise. (dwarf_expr_push_dwarf_reg_entry_value): Likewise. (dwarf_expr_get_obj_addr): Likewise. (entry_data_value_coerce_ref): Likewise. (entry_data_value_copy_closure): Likewise. (entry_data_value_free_closure): Likewise. (get_frame_address_in_block_wrapper): Likewise. (dwarf2_evaluate_property): Likewise. (dwarf2_compile_property_to_c): Likewise. (needs_frame_read_addr_from_reg): Likewise. (needs_frame_get_reg_value): Likewise. (needs_frame_frame_base): Likewise. (needs_frame_frame_cfa): Likewise. (needs_frame_tls_address): Likewise. (needs_frame_dwarf_call): Likewise. (needs_dwarf_reg_entry_value): Likewise. (get_ax_pc): Likewise. (locexpr_read_variable): Likewise. (locexpr_read_variable_at_entry): Likewise. (locexpr_read_needs_frame): Likewise. (locexpr_describe_location): Likewise. (locexpr_tracepoint_var_ref): Likewise. (locexpr_generate_c_location): Likewise. (loclist_read_variable): Likewise. (loclist_read_variable_at_entry): Likewise. (loclist_describe_location): Likewise. (loclist_tracepoint_var_ref): Likewise. (loclist_generate_c_location): Likewise. * dwarf2read.c (line_header_hash_voidp): Likewise. (line_header_eq_voidp): Likewise. (dwarf2_has_info): Likewise. (dwarf2_get_section_info): Likewise. (locate_dwz_sections): Likewise. (hash_file_name_entry): Likewise. (eq_file_name_entry): Likewise. (delete_file_name_entry): Likewise. (dw2_setup): Likewise. (dw2_get_file_names_reader): Likewise. (dw2_find_pc_sect_compunit_symtab): Likewise. (hash_signatured_type): Likewise. (eq_signatured_type): Likewise. (add_signatured_type_cu_to_table): Likewise. (create_debug_types_hash_table): Likewise. (lookup_dwo_signatured_type): Likewise. (lookup_dwp_signatured_type): Likewise. (lookup_signatured_type): Likewise. (hash_type_unit_group): Likewise. (eq_type_unit_group): Likewise. (get_type_unit_group): Likewise. (process_psymtab_comp_unit_reader): Likewise. (sort_tu_by_abbrev_offset): Likewise. (process_skeletonless_type_unit): Likewise. (psymtabs_addrmap_cleanup): Likewise. (dwarf2_read_symtab): Likewise. (psymtab_to_symtab_1): Likewise. (die_hash): Likewise. (die_eq): Likewise. (load_full_comp_unit_reader): Likewise. (reset_die_in_process): Likewise. (free_cu_line_header): Likewise. (handle_DW_AT_stmt_list): Likewise. (hash_dwo_file): Likewise. (eq_dwo_file): Likewise. (hash_dwo_unit): Likewise. (eq_dwo_unit): Likewise. (create_dwo_cu_reader): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (lookup_dwo_unit_in_dwp): Likewise. (dwarf2_locate_dwo_sections): Likewise. (dwarf2_locate_common_dwp_sections): Likewise. (dwarf2_locate_v2_dwp_sections): Likewise. (hash_dwp_loaded_cutus): Likewise. (eq_dwp_loaded_cutus): Likewise. (lookup_dwo_cutu): Likewise. (abbrev_table_free_cleanup): Likewise. (dwarf2_free_abbrev_table): Likewise. (find_partial_die_in_comp_unit): Likewise. (free_line_header_voidp): Likewise. (follow_die_offset): Likewise. (follow_die_sig_1): Likewise. (free_heap_comp_unit): Likewise. (free_stack_comp_unit): Likewise. (dwarf2_free_objfile): Likewise. (per_cu_offset_and_type_hash): Likewise. (per_cu_offset_and_type_eq): Likewise. (get_die_type_at_offset): Likewise. (partial_die_hash): Likewise. (partial_die_eq): Likewise. (dwarf2_per_objfile_free): Likewise. (hash_strtab_entry): Likewise. (eq_strtab_entry): Likewise. (add_string): Likewise. (hash_symtab_entry): Likewise. (eq_symtab_entry): Likewise. (delete_symtab_entry): Likewise. (cleanup_mapped_symtab): Likewise. (add_indices_to_cpool): Likewise. (hash_psymtab_cu_index): Likewise. (eq_psymtab_cu_index): Likewise. (add_address_entry_worker): Likewise. (unlink_if_set): Likewise. (write_one_signatured_type): Likewise. (save_gdb_index_command): Likewise. * elfread.c (elf_symtab_read): Likewise. (elf_gnu_ifunc_cache_hash): Likewise. (elf_gnu_ifunc_cache_eq): Likewise. (elf_gnu_ifunc_record_cache): Likewise. (elf_gnu_ifunc_resolve_by_cache): Likewise. (elf_get_probes): Likewise. (probe_key_free): Likewise. * f-lang.c (builtin_f_type): Likewise. * frame-base.c (frame_base_append_sniffer): Likewise. (frame_base_set_default): Likewise. (frame_base_find_by_frame): Likewise. * frame-unwind.c (frame_unwind_prepend_unwinder): Likewise. (frame_unwind_append_unwinder): Likewise. (frame_unwind_find_by_frame): Likewise. * frame.c (frame_addr_hash): Likewise. (frame_addr_hash_eq): Likewise. (frame_stash_find): Likewise. (do_frame_register_read): Likewise. (unwind_to_current_frame): Likewise. (frame_cleanup_after_sniffer): Likewise. * frv-linux-tdep.c (frv_linux_sigtramp_frame_cache): Likewise. * frv-tdep.c (frv_frame_unwind_cache): Likewise. * ft32-tdep.c (ft32_frame_cache): Likewise. * gcore.c (do_bfd_delete_cleanup): Likewise. (gcore_create_callback): Likewise. * gdb_bfd.c (hash_bfd): Likewise. (eq_bfd): Likewise. (gdb_bfd_open): Likewise. (free_one_bfd_section): Likewise. (gdb_bfd_ref): Likewise. (gdb_bfd_unref): Likewise. (get_section_descriptor): Likewise. (gdb_bfd_map_section): Likewise. (gdb_bfd_crc): Likewise. (gdb_bfd_mark_parent): Likewise. (gdb_bfd_record_inclusion): Likewise. (gdb_bfd_requires_relocations): Likewise. (print_one_bfd): Likewise. * gdbtypes.c (type_pair_hash): Likewise. (type_pair_eq): Likewise. (builtin_type): Likewise. (objfile_type): Likewise. * gnu-v3-abi.c (vtable_ptrdiff_type): Likewise. (vtable_address_point_offset): Likewise. (gnuv3_get_vtable): Likewise. (hash_value_and_voffset): Likewise. (eq_value_and_voffset): Likewise. (compare_value_and_voffset): Likewise. (compute_vtable_size): Likewise. (gnuv3_get_typeid_type): Likewise. * go-lang.c (builtin_go_type): Likewise. * guile/scm-block.c (bkscm_hash_block_smob): Likewise. (bkscm_eq_block_smob): Likewise. (bkscm_objfile_block_map): Likewise. (bkscm_del_objfile_blocks): Likewise. * guile/scm-breakpoint.c (bpscm_build_bp_list): Likewise. * guile/scm-disasm.c (gdbscm_disasm_read_memory_worker): Likewise. (gdbscm_disasm_print_address): Likewise. * guile/scm-frame.c (frscm_hash_frame_smob): Likewise. (frscm_eq_frame_smob): Likewise. (frscm_inferior_frame_map): Likewise. (frscm_del_inferior_frames): Likewise. * guile/scm-gsmob.c (gdbscm_add_objfile_ref): Likewise. * guile/scm-objfile.c (ofscm_handle_objfile_deleted): Likewise. (ofscm_objfile_smob_from_objfile): Likewise. * guile/scm-ports.c (ioscm_write): Likewise. (ioscm_file_port_delete): Likewise. (ioscm_file_port_rewind): Likewise. (ioscm_file_port_put): Likewise. (ioscm_file_port_write): Likewise. * guile/scm-progspace.c (psscm_handle_pspace_deleted): Likewise. (psscm_pspace_smob_from_pspace): Likewise. * guile/scm-safe-call.c (scscm_recording_pre_unwind_handler): Likewise. (scscm_recording_unwind_handler): Likewise. (gdbscm_with_catch): Likewise. (scscm_call_0_body): Likewise. (scscm_call_1_body): Likewise. (scscm_call_2_body): Likewise. (scscm_call_3_body): Likewise. (scscm_call_4_body): Likewise. (scscm_apply_1_body): Likewise. (scscm_eval_scheme_string): Likewise. (gdbscm_safe_eval_string): Likewise. (scscm_source_scheme_script): Likewise. (gdbscm_safe_source_script): Likewise. * guile/scm-string.c (gdbscm_call_scm_to_stringn): Likewise. (gdbscm_call_scm_from_stringn): Likewise. * guile/scm-symbol.c (syscm_hash_symbol_smob): Likewise. (syscm_eq_symbol_smob): Likewise. (syscm_get_symbol_map): Likewise. (syscm_del_objfile_symbols): Likewise. * guile/scm-symtab.c (stscm_hash_symtab_smob): Likewise. (stscm_eq_symtab_smob): Likewise. (stscm_objfile_symtab_map): Likewise. (stscm_del_objfile_symtabs): Likewise. * guile/scm-type.c (tyscm_hash_type_smob): Likewise. (tyscm_eq_type_smob): Likewise. (tyscm_type_map): Likewise. (tyscm_copy_type_recursive): Likewise. (save_objfile_types): Likewise. * guile/scm-utils.c (extract_arg): Likewise. * h8300-tdep.c (h8300_frame_cache): Likewise. * hppa-linux-tdep.c (hppa_linux_sigtramp_frame_unwind_cache): Likewise. * hppa-tdep.c (compare_unwind_entries): Likewise. (find_unwind_entry): Likewise. (hppa_frame_cache): Likewise. (hppa_stub_frame_unwind_cache): Likewise. * hppanbsd-tdep.c (hppanbsd_supply_gregset): Likewise. * hppaobsd-tdep.c (hppaobsd_supply_gregset): Likewise. (hppaobsd_supply_fpregset): Likewise. * i386-cygwin-tdep.c (core_process_module_section): Likewise. * i386-linux-tdep.c (i386_linux_init_abi): Likewise. * i386-tdep.c (i386_frame_cache): Likewise. (i386_epilogue_frame_cache): Likewise. (i386_sigtramp_frame_cache): Likewise. (i386_supply_gregset): Likewise. (i386_collect_gregset): Likewise. (i386_gdbarch_init): Likewise. * i386obsd-tdep.c (i386obsd_aout_supply_regset): Likewise. (i386obsd_trapframe_cache): Likewise. * i387-tdep.c (i387_supply_fsave): Likewise. (i387_collect_fsave): Likewise. (i387_supply_fxsave): Likewise. (i387_collect_fxsave): Likewise. (i387_supply_xsave): Likewise. (i387_collect_xsave): Likewise. * ia64-tdep.c (ia64_frame_cache): Likewise. (ia64_sigtramp_frame_cache): Likewise. * infcmd.c (attach_command_continuation): Likewise. (attach_command_continuation_free_args): Likewise. * inferior.c (restore_inferior): Likewise. (delete_thread_of_inferior): Likewise. * inflow.c (inflow_inferior_data_cleanup): Likewise. (get_inflow_inferior_data): Likewise. (inflow_inferior_exit): Likewise. * infrun.c (displaced_step_clear_cleanup): Likewise. (restore_current_uiout_cleanup): Likewise. (release_stop_context_cleanup): Likewise. (do_restore_infcall_suspend_state_cleanup): Likewise. (do_restore_infcall_control_state_cleanup): Likewise. (restore_inferior_ptid): Likewise. * inline-frame.c (block_starting_point_at): Likewise. * iq2000-tdep.c (iq2000_frame_cache): Likewise. * jit.c (get_jit_objfile_data): Likewise. (get_jit_program_space_data): Likewise. (jit_object_close_impl): Likewise. (jit_find_objf_with_entry_addr): Likewise. (jit_breakpoint_deleted): Likewise. (jit_unwind_reg_set_impl): Likewise. (jit_unwind_reg_get_impl): Likewise. (jit_dealloc_cache): Likewise. (jit_frame_sniffer): Likewise. (jit_frame_prev_register): Likewise. (jit_prepend_unwinder): Likewise. (jit_inferior_exit_hook): Likewise. (free_objfile_data): Likewise. * jv-lang.c (jv_per_objfile_free): Likewise. (get_dynamics_objfile): Likewise. (get_java_class_symtab): Likewise. (builtin_java_type): Likewise. * language.c (language_string_char_type): Likewise. (language_bool_type): Likewise. (language_lookup_primitive_type): Likewise. (language_lookup_primitive_type_as_symbol): Likewise. * linespec.c (hash_address_entry): Likewise. (eq_address_entry): Likewise. (iterate_inline_only): Likewise. (iterate_name_matcher): Likewise. (decode_line_2_compare_items): Likewise. (collect_one_symbol): Likewise. (compare_symbols): Likewise. (compare_msymbols): Likewise. (add_symtabs_to_list): Likewise. (collect_symbols): Likewise. (compare_msyms): Likewise. (add_minsym): Likewise. (cleanup_linespec_result): Likewise. * linux-fork.c (inferior_call_waitpid_cleanup): Likewise. * linux-nat.c (delete_lwp_cleanup): Likewise. (count_events_callback): Likewise. (select_event_lwp_callback): Likewise. (resume_stopped_resumed_lwps): Likewise. * linux-tdep.c (get_linux_gdbarch_data): Likewise. (invalidate_linux_cache_inf): Likewise. (get_linux_inferior_data): Likewise. (linux_find_memory_regions_thunk): Likewise. (linux_make_mappings_callback): Likewise. (linux_corefile_thread_callback): Likewise. (find_mapping_size): Likewise. * linux-thread-db.c (find_new_threads_callback): Likewise. * lm32-tdep.c (lm32_frame_cache): Likewise. * m2-lang.c (builtin_m2_type): Likewise. * m32c-tdep.c (m32c_analyze_frame_prologue): Likewise. * m32r-linux-tdep.c (m32r_linux_sigtramp_frame_cache): Likewise. (m32r_linux_supply_gregset): Likewise. (m32r_linux_collect_gregset): Likewise. * m32r-tdep.c (m32r_frame_unwind_cache): Likewise. * m68hc11-tdep.c (m68hc11_frame_unwind_cache): Likewise. * m68k-tdep.c (m68k_frame_cache): Likewise. * m68kbsd-tdep.c (m68kbsd_supply_fpregset): Likewise. (m68kbsd_supply_gregset): Likewise. * m68klinux-tdep.c (m68k_linux_sigtramp_frame_cache): Likewise. * m88k-tdep.c (m88k_frame_cache): Likewise. (m88k_supply_gregset): Likewise. gdb/gdbserver/ChangeLog: * dll.c (match_dll): Add cast(s). (unloaded_dll): Likewise. * linux-low.c (second_thread_of_pid_p): Likewise. (delete_lwp_callback): Likewise. (count_events_callback): Likewise. (select_event_lwp_callback): Likewise. (linux_set_resume_request): Likewise. * server.c (accumulate_file_name_length): Likewise. (emit_dll_description): Likewise. (handle_qxfer_threads_worker): Likewise. (visit_actioned_threads): Likewise. * thread-db.c (any_thread_of): Likewise. * tracepoint.c (same_process_p): Likewise. (match_blocktype): Likewise. (build_traceframe_info_xml): Likewise. gdb/testsuite/ChangeLog: * gdb.gdb/selftest.exp (do_steps_and_nexts): Adjust expected source line.
610 lines
16 KiB
C
610 lines
16 KiB
C
/* Functions for manipulating expressions designed to be executed on the agent
|
||
Copyright (C) 1998-2015 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
/* Despite what the above comment says about this file being part of
|
||
GDB, we would like to keep these functions free of GDB
|
||
dependencies, since we want to be able to use them in contexts
|
||
outside of GDB (test suites, the stub, etc.) */
|
||
|
||
#include "defs.h"
|
||
#include "ax.h"
|
||
|
||
#include "value.h"
|
||
#include "user-regs.h"
|
||
|
||
static void grow_expr (struct agent_expr *x, int n);
|
||
|
||
static void append_const (struct agent_expr *x, LONGEST val, int n);
|
||
|
||
static LONGEST read_const (struct agent_expr *x, int o, int n);
|
||
|
||
static void generic_ext (struct agent_expr *x, enum agent_op op, int n);
|
||
|
||
/* Functions for building expressions. */
|
||
|
||
/* Allocate a new, empty agent expression. */
|
||
struct agent_expr *
|
||
new_agent_expr (struct gdbarch *gdbarch, CORE_ADDR scope)
|
||
{
|
||
struct agent_expr *x = XNEW (struct agent_expr);
|
||
|
||
x->len = 0;
|
||
x->size = 1; /* Change this to a larger value once
|
||
reallocation code is tested. */
|
||
x->buf = (unsigned char *) xmalloc (x->size);
|
||
|
||
x->gdbarch = gdbarch;
|
||
x->scope = scope;
|
||
|
||
/* Bit vector for registers used. */
|
||
x->reg_mask_len = 1;
|
||
x->reg_mask = XCNEWVEC (unsigned char, x->reg_mask_len);
|
||
|
||
x->tracing = 0;
|
||
x->trace_string = 0;
|
||
|
||
return x;
|
||
}
|
||
|
||
/* Free a agent expression. */
|
||
void
|
||
free_agent_expr (struct agent_expr *x)
|
||
{
|
||
xfree (x->buf);
|
||
xfree (x->reg_mask);
|
||
xfree (x);
|
||
}
|
||
|
||
static void
|
||
do_free_agent_expr_cleanup (void *x)
|
||
{
|
||
free_agent_expr ((struct agent_expr *) x);
|
||
}
|
||
|
||
struct cleanup *
|
||
make_cleanup_free_agent_expr (struct agent_expr *x)
|
||
{
|
||
return make_cleanup (do_free_agent_expr_cleanup, x);
|
||
}
|
||
|
||
|
||
/* Make sure that X has room for at least N more bytes. This doesn't
|
||
affect the length, just the allocated size. */
|
||
static void
|
||
grow_expr (struct agent_expr *x, int n)
|
||
{
|
||
if (x->len + n > x->size)
|
||
{
|
||
x->size *= 2;
|
||
if (x->size < x->len + n)
|
||
x->size = x->len + n + 10;
|
||
x->buf = (unsigned char *) xrealloc (x->buf, x->size);
|
||
}
|
||
}
|
||
|
||
|
||
/* Append the low N bytes of VAL as an N-byte integer to the
|
||
expression X, in big-endian order. */
|
||
static void
|
||
append_const (struct agent_expr *x, LONGEST val, int n)
|
||
{
|
||
int i;
|
||
|
||
grow_expr (x, n);
|
||
for (i = n - 1; i >= 0; i--)
|
||
{
|
||
x->buf[x->len + i] = val & 0xff;
|
||
val >>= 8;
|
||
}
|
||
x->len += n;
|
||
}
|
||
|
||
|
||
/* Extract an N-byte big-endian unsigned integer from expression X at
|
||
offset O. */
|
||
static LONGEST
|
||
read_const (struct agent_expr *x, int o, int n)
|
||
{
|
||
int i;
|
||
LONGEST accum = 0;
|
||
|
||
/* Make sure we're not reading off the end of the expression. */
|
||
if (o + n > x->len)
|
||
error (_("GDB bug: ax-general.c (read_const): incomplete constant"));
|
||
|
||
for (i = 0; i < n; i++)
|
||
accum = (accum << 8) | x->buf[o + i];
|
||
|
||
return accum;
|
||
}
|
||
|
||
|
||
/* Append a simple operator OP to EXPR. */
|
||
void
|
||
ax_simple (struct agent_expr *x, enum agent_op op)
|
||
{
|
||
grow_expr (x, 1);
|
||
x->buf[x->len++] = op;
|
||
}
|
||
|
||
/* Append a pick operator to EXPR. DEPTH is the stack item to pick,
|
||
with 0 being top of stack. */
|
||
|
||
void
|
||
ax_pick (struct agent_expr *x, int depth)
|
||
{
|
||
if (depth < 0 || depth > 255)
|
||
error (_("GDB bug: ax-general.c (ax_pick): stack depth out of range"));
|
||
ax_simple (x, aop_pick);
|
||
append_const (x, 1, depth);
|
||
}
|
||
|
||
|
||
/* Append a sign-extension or zero-extension instruction to EXPR, to
|
||
extend an N-bit value. */
|
||
static void
|
||
generic_ext (struct agent_expr *x, enum agent_op op, int n)
|
||
{
|
||
/* N must fit in a byte. */
|
||
if (n < 0 || n > 255)
|
||
error (_("GDB bug: ax-general.c (generic_ext): bit count out of range"));
|
||
/* That had better be enough range. */
|
||
if (sizeof (LONGEST) * 8 > 255)
|
||
error (_("GDB bug: ax-general.c (generic_ext): "
|
||
"opcode has inadequate range"));
|
||
|
||
grow_expr (x, 2);
|
||
x->buf[x->len++] = op;
|
||
x->buf[x->len++] = n;
|
||
}
|
||
|
||
|
||
/* Append a sign-extension instruction to EXPR, to extend an N-bit value. */
|
||
void
|
||
ax_ext (struct agent_expr *x, int n)
|
||
{
|
||
generic_ext (x, aop_ext, n);
|
||
}
|
||
|
||
|
||
/* Append a zero-extension instruction to EXPR, to extend an N-bit value. */
|
||
void
|
||
ax_zero_ext (struct agent_expr *x, int n)
|
||
{
|
||
generic_ext (x, aop_zero_ext, n);
|
||
}
|
||
|
||
|
||
/* Append a trace_quick instruction to EXPR, to record N bytes. */
|
||
void
|
||
ax_trace_quick (struct agent_expr *x, int n)
|
||
{
|
||
/* N must fit in a byte. */
|
||
if (n < 0 || n > 255)
|
||
error (_("GDB bug: ax-general.c (ax_trace_quick): "
|
||
"size out of range for trace_quick"));
|
||
|
||
grow_expr (x, 2);
|
||
x->buf[x->len++] = aop_trace_quick;
|
||
x->buf[x->len++] = n;
|
||
}
|
||
|
||
|
||
/* Append a goto op to EXPR. OP is the actual op (must be aop_goto or
|
||
aop_if_goto). We assume we don't know the target offset yet,
|
||
because it's probably a forward branch, so we leave space in EXPR
|
||
for the target, and return the offset in EXPR of that space, so we
|
||
can backpatch it once we do know the target offset. Use ax_label
|
||
to do the backpatching. */
|
||
int
|
||
ax_goto (struct agent_expr *x, enum agent_op op)
|
||
{
|
||
grow_expr (x, 3);
|
||
x->buf[x->len + 0] = op;
|
||
x->buf[x->len + 1] = 0xff;
|
||
x->buf[x->len + 2] = 0xff;
|
||
x->len += 3;
|
||
return x->len - 2;
|
||
}
|
||
|
||
/* Suppose a given call to ax_goto returns some value PATCH. When you
|
||
know the offset TARGET that goto should jump to, call
|
||
ax_label (EXPR, PATCH, TARGET)
|
||
to patch TARGET into the ax_goto instruction. */
|
||
void
|
||
ax_label (struct agent_expr *x, int patch, int target)
|
||
{
|
||
/* Make sure the value is in range. Don't accept 0xffff as an
|
||
offset; that's our magic sentinel value for unpatched branches. */
|
||
if (target < 0 || target >= 0xffff)
|
||
error (_("GDB bug: ax-general.c (ax_label): label target out of range"));
|
||
|
||
x->buf[patch] = (target >> 8) & 0xff;
|
||
x->buf[patch + 1] = target & 0xff;
|
||
}
|
||
|
||
|
||
/* Assemble code to push a constant on the stack. */
|
||
void
|
||
ax_const_l (struct agent_expr *x, LONGEST l)
|
||
{
|
||
static enum agent_op ops[]
|
||
=
|
||
{aop_const8, aop_const16, aop_const32, aop_const64};
|
||
int size;
|
||
int op;
|
||
|
||
/* How big is the number? 'op' keeps track of which opcode to use.
|
||
Notice that we don't really care whether the original number was
|
||
signed or unsigned; we always reproduce the value exactly, and
|
||
use the shortest representation. */
|
||
for (op = 0, size = 8; size < 64; size *= 2, op++)
|
||
{
|
||
LONGEST lim = ((LONGEST) 1) << (size - 1);
|
||
|
||
if (-lim <= l && l <= lim - 1)
|
||
break;
|
||
}
|
||
|
||
/* Emit the right opcode... */
|
||
ax_simple (x, ops[op]);
|
||
|
||
/* Emit the low SIZE bytes as an unsigned number. We know that
|
||
sign-extending this will yield l. */
|
||
append_const (x, l, size / 8);
|
||
|
||
/* Now, if it was negative, and not full-sized, sign-extend it. */
|
||
if (l < 0 && size < 64)
|
||
ax_ext (x, size);
|
||
}
|
||
|
||
|
||
void
|
||
ax_const_d (struct agent_expr *x, LONGEST d)
|
||
{
|
||
/* FIXME: floating-point support not present yet. */
|
||
error (_("GDB bug: ax-general.c (ax_const_d): "
|
||
"floating point not supported yet"));
|
||
}
|
||
|
||
|
||
/* Assemble code to push the value of register number REG on the
|
||
stack. */
|
||
void
|
||
ax_reg (struct agent_expr *x, int reg)
|
||
{
|
||
if (reg >= gdbarch_num_regs (x->gdbarch))
|
||
{
|
||
/* This is a pseudo-register. */
|
||
if (!gdbarch_ax_pseudo_register_push_stack_p (x->gdbarch))
|
||
error (_("'%s' is a pseudo-register; "
|
||
"GDB cannot yet trace its contents."),
|
||
user_reg_map_regnum_to_name (x->gdbarch, reg));
|
||
if (gdbarch_ax_pseudo_register_push_stack (x->gdbarch, x, reg))
|
||
error (_("Trace '%s' failed."),
|
||
user_reg_map_regnum_to_name (x->gdbarch, reg));
|
||
}
|
||
else
|
||
{
|
||
/* Make sure the register number is in range. */
|
||
if (reg < 0 || reg > 0xffff)
|
||
error (_("GDB bug: ax-general.c (ax_reg): "
|
||
"register number out of range"));
|
||
grow_expr (x, 3);
|
||
x->buf[x->len] = aop_reg;
|
||
x->buf[x->len + 1] = (reg >> 8) & 0xff;
|
||
x->buf[x->len + 2] = (reg) & 0xff;
|
||
x->len += 3;
|
||
}
|
||
}
|
||
|
||
/* Assemble code to operate on a trace state variable. */
|
||
|
||
void
|
||
ax_tsv (struct agent_expr *x, enum agent_op op, int num)
|
||
{
|
||
/* Make sure the tsv number is in range. */
|
||
if (num < 0 || num > 0xffff)
|
||
internal_error (__FILE__, __LINE__,
|
||
_("ax-general.c (ax_tsv): variable "
|
||
"number is %d, out of range"), num);
|
||
|
||
grow_expr (x, 3);
|
||
x->buf[x->len] = op;
|
||
x->buf[x->len + 1] = (num >> 8) & 0xff;
|
||
x->buf[x->len + 2] = (num) & 0xff;
|
||
x->len += 3;
|
||
}
|
||
|
||
/* Append a string to the expression. Note that the string is going
|
||
into the bytecodes directly, not on the stack. As a precaution,
|
||
include both length as prefix, and terminate with a NUL. (The NUL
|
||
is counted in the length.) */
|
||
|
||
void
|
||
ax_string (struct agent_expr *x, const char *str, int slen)
|
||
{
|
||
int i;
|
||
|
||
/* Make sure the string length is reasonable. */
|
||
if (slen < 0 || slen > 0xffff)
|
||
internal_error (__FILE__, __LINE__,
|
||
_("ax-general.c (ax_string): string "
|
||
"length is %d, out of allowed range"), slen);
|
||
|
||
grow_expr (x, 2 + slen + 1);
|
||
x->buf[x->len++] = ((slen + 1) >> 8) & 0xff;
|
||
x->buf[x->len++] = (slen + 1) & 0xff;
|
||
for (i = 0; i < slen; ++i)
|
||
x->buf[x->len++] = str[i];
|
||
x->buf[x->len++] = '\0';
|
||
}
|
||
|
||
|
||
|
||
/* Functions for disassembling agent expressions, and otherwise
|
||
debugging the expression compiler. */
|
||
|
||
struct aop_map aop_map[] =
|
||
{
|
||
{0, 0, 0, 0, 0}
|
||
#define DEFOP(NAME, SIZE, DATA_SIZE, CONSUMED, PRODUCED, VALUE) \
|
||
, { # NAME, SIZE, DATA_SIZE, CONSUMED, PRODUCED }
|
||
#include "ax.def"
|
||
#undef DEFOP
|
||
};
|
||
|
||
|
||
/* Disassemble the expression EXPR, writing to F. */
|
||
void
|
||
ax_print (struct ui_file *f, struct agent_expr *x)
|
||
{
|
||
int i;
|
||
|
||
fprintf_filtered (f, _("Scope: %s\n"), paddress (x->gdbarch, x->scope));
|
||
fprintf_filtered (f, _("Reg mask:"));
|
||
for (i = 0; i < x->reg_mask_len; ++i)
|
||
fprintf_filtered (f, _(" %02x"), x->reg_mask[i]);
|
||
fprintf_filtered (f, _("\n"));
|
||
|
||
/* Check the size of the name array against the number of entries in
|
||
the enum, to catch additions that people didn't sync. */
|
||
if ((sizeof (aop_map) / sizeof (aop_map[0]))
|
||
!= aop_last)
|
||
error (_("GDB bug: ax-general.c (ax_print): opcode map out of sync"));
|
||
|
||
for (i = 0; i < x->len;)
|
||
{
|
||
enum agent_op op = (enum agent_op) x->buf[i];
|
||
|
||
if (op >= (sizeof (aop_map) / sizeof (aop_map[0]))
|
||
|| !aop_map[op].name)
|
||
{
|
||
fprintf_filtered (f, _("%3d <bad opcode %02x>\n"), i, op);
|
||
i++;
|
||
continue;
|
||
}
|
||
if (i + 1 + aop_map[op].op_size > x->len)
|
||
{
|
||
fprintf_filtered (f, _("%3d <incomplete opcode %s>\n"),
|
||
i, aop_map[op].name);
|
||
break;
|
||
}
|
||
|
||
fprintf_filtered (f, "%3d %s", i, aop_map[op].name);
|
||
if (aop_map[op].op_size > 0)
|
||
{
|
||
fputs_filtered (" ", f);
|
||
|
||
print_longest (f, 'd', 0,
|
||
read_const (x, i + 1, aop_map[op].op_size));
|
||
}
|
||
/* Handle the complicated printf arguments specially. */
|
||
else if (op == aop_printf)
|
||
{
|
||
int slen, nargs;
|
||
|
||
i++;
|
||
nargs = x->buf[i++];
|
||
slen = x->buf[i++];
|
||
slen = slen * 256 + x->buf[i++];
|
||
fprintf_filtered (f, _(" \"%s\", %d args"),
|
||
&(x->buf[i]), nargs);
|
||
i += slen - 1;
|
||
}
|
||
fprintf_filtered (f, "\n");
|
||
i += 1 + aop_map[op].op_size;
|
||
}
|
||
}
|
||
|
||
/* Add register REG to the register mask for expression AX. */
|
||
void
|
||
ax_reg_mask (struct agent_expr *ax, int reg)
|
||
{
|
||
if (reg >= gdbarch_num_regs (ax->gdbarch))
|
||
{
|
||
/* This is a pseudo-register. */
|
||
if (!gdbarch_ax_pseudo_register_collect_p (ax->gdbarch))
|
||
error (_("'%s' is a pseudo-register; "
|
||
"GDB cannot yet trace its contents."),
|
||
user_reg_map_regnum_to_name (ax->gdbarch, reg));
|
||
if (gdbarch_ax_pseudo_register_collect (ax->gdbarch, ax, reg))
|
||
error (_("Trace '%s' failed."),
|
||
user_reg_map_regnum_to_name (ax->gdbarch, reg));
|
||
}
|
||
else
|
||
{
|
||
int byte = reg / 8;
|
||
|
||
/* Grow the bit mask if necessary. */
|
||
if (byte >= ax->reg_mask_len)
|
||
{
|
||
/* It's not appropriate to double here. This isn't a
|
||
string buffer. */
|
||
int new_len = byte + 1;
|
||
unsigned char *new_reg_mask
|
||
= XRESIZEVEC (unsigned char, ax->reg_mask, new_len);
|
||
|
||
memset (new_reg_mask + ax->reg_mask_len, 0,
|
||
(new_len - ax->reg_mask_len) * sizeof (ax->reg_mask[0]));
|
||
ax->reg_mask_len = new_len;
|
||
ax->reg_mask = new_reg_mask;
|
||
}
|
||
|
||
ax->reg_mask[byte] |= 1 << (reg % 8);
|
||
}
|
||
}
|
||
|
||
/* Given an agent expression AX, fill in requirements and other descriptive
|
||
bits. */
|
||
void
|
||
ax_reqs (struct agent_expr *ax)
|
||
{
|
||
int i;
|
||
int height;
|
||
|
||
/* Jump target table. targets[i] is non-zero iff we have found a
|
||
jump to offset i. */
|
||
char *targets = (char *) alloca (ax->len * sizeof (targets[0]));
|
||
|
||
/* Instruction boundary table. boundary[i] is non-zero iff our scan
|
||
has reached an instruction starting at offset i. */
|
||
char *boundary = (char *) alloca (ax->len * sizeof (boundary[0]));
|
||
|
||
/* Stack height record. If either targets[i] or boundary[i] is
|
||
non-zero, heights[i] is the height the stack should have before
|
||
executing the bytecode at that point. */
|
||
int *heights = (int *) alloca (ax->len * sizeof (heights[0]));
|
||
|
||
/* Pointer to a description of the present op. */
|
||
struct aop_map *op;
|
||
|
||
memset (targets, 0, ax->len * sizeof (targets[0]));
|
||
memset (boundary, 0, ax->len * sizeof (boundary[0]));
|
||
|
||
ax->max_height = ax->min_height = height = 0;
|
||
ax->flaw = agent_flaw_none;
|
||
ax->max_data_size = 0;
|
||
|
||
for (i = 0; i < ax->len; i += 1 + op->op_size)
|
||
{
|
||
if (ax->buf[i] > (sizeof (aop_map) / sizeof (aop_map[0])))
|
||
{
|
||
ax->flaw = agent_flaw_bad_instruction;
|
||
return;
|
||
}
|
||
|
||
op = &aop_map[ax->buf[i]];
|
||
|
||
if (!op->name)
|
||
{
|
||
ax->flaw = agent_flaw_bad_instruction;
|
||
return;
|
||
}
|
||
|
||
if (i + 1 + op->op_size > ax->len)
|
||
{
|
||
ax->flaw = agent_flaw_incomplete_instruction;
|
||
return;
|
||
}
|
||
|
||
/* If this instruction is a forward jump target, does the
|
||
current stack height match the stack height at the jump
|
||
source? */
|
||
if (targets[i] && (heights[i] != height))
|
||
{
|
||
ax->flaw = agent_flaw_height_mismatch;
|
||
return;
|
||
}
|
||
|
||
boundary[i] = 1;
|
||
heights[i] = height;
|
||
|
||
height -= op->consumed;
|
||
if (height < ax->min_height)
|
||
ax->min_height = height;
|
||
height += op->produced;
|
||
if (height > ax->max_height)
|
||
ax->max_height = height;
|
||
|
||
if (op->data_size > ax->max_data_size)
|
||
ax->max_data_size = op->data_size;
|
||
|
||
/* For jump instructions, check that the target is a valid
|
||
offset. If it is, record the fact that that location is a
|
||
jump target, and record the height we expect there. */
|
||
if (aop_goto == op - aop_map
|
||
|| aop_if_goto == op - aop_map)
|
||
{
|
||
int target = read_const (ax, i + 1, 2);
|
||
if (target < 0 || target >= ax->len)
|
||
{
|
||
ax->flaw = agent_flaw_bad_jump;
|
||
return;
|
||
}
|
||
|
||
/* Do we have any information about what the stack height
|
||
should be at the target? */
|
||
if (targets[target] || boundary[target])
|
||
{
|
||
if (heights[target] != height)
|
||
{
|
||
ax->flaw = agent_flaw_height_mismatch;
|
||
return;
|
||
}
|
||
}
|
||
|
||
/* Record the target, along with the stack height we expect. */
|
||
targets[target] = 1;
|
||
heights[target] = height;
|
||
}
|
||
|
||
/* For unconditional jumps with a successor, check that the
|
||
successor is a target, and pick up its stack height. */
|
||
if (aop_goto == op - aop_map
|
||
&& i + 3 < ax->len)
|
||
{
|
||
if (!targets[i + 3])
|
||
{
|
||
ax->flaw = agent_flaw_hole;
|
||
return;
|
||
}
|
||
|
||
height = heights[i + 3];
|
||
}
|
||
|
||
/* For reg instructions, record the register in the bit mask. */
|
||
if (aop_reg == op - aop_map)
|
||
{
|
||
int reg = read_const (ax, i + 1, 2);
|
||
|
||
ax_reg_mask (ax, reg);
|
||
}
|
||
}
|
||
|
||
/* Check that all the targets are on boundaries. */
|
||
for (i = 0; i < ax->len; i++)
|
||
if (targets[i] && !boundary[i])
|
||
{
|
||
ax->flaw = agent_flaw_bad_jump;
|
||
return;
|
||
}
|
||
|
||
ax->final_height = height;
|
||
}
|