mirror of
https://sourceware.org/git/binutils-gdb.git
synced 2024-12-21 04:42:53 +08:00
998a4f589d
Made sure there is no implicit conversion between signed and unsigned return value for functions setting the ctf_errno value. An example of the problem is that in ctf_member_next, the "offset" value is either 0L or (ctf_id_t)-1L, but it should have been 0L or -1L. The issue was discovered while building a 64 bit ld binary to be executed on the Windows platform. Example object file that demonstrates the issue is attached in the PR. libctf/ Affected functions adjusted. Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com>
115 lines
2.7 KiB
C
115 lines
2.7 KiB
C
/* Inline functions.
|
|
Copyright (C) 2020-2023 Free Software Foundation, Inc.
|
|
|
|
This file is part of libctf.
|
|
|
|
libctf is free software; you can redistribute it and/or modify it under
|
|
the terms of the GNU General Public License as published by the Free
|
|
Software Foundation; either version 3, or (at your option) any later
|
|
version.
|
|
|
|
This program is distributed in the hope that it will be useful, but
|
|
WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
|
|
See the GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; see the file COPYING. If not see
|
|
<http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef _CTF_INLINES_H
|
|
#define _CTF_INLINES_H
|
|
|
|
#ifdef __cplusplus
|
|
extern "C"
|
|
{
|
|
#endif
|
|
|
|
#include "config.h"
|
|
|
|
#ifndef _libctf_malloc_
|
|
#error "ctf-inlines.h" should not be included directly: include "ctf-impl.h".
|
|
#endif
|
|
|
|
static inline ssize_t
|
|
ctf_get_ctt_size (const ctf_dict_t *fp,
|
|
const ctf_type_t *tp,
|
|
ssize_t *sizep,
|
|
ssize_t *incrementp)
|
|
{
|
|
return (fp->ctf_dictops->ctfo_get_ctt_size (fp, tp, sizep, incrementp));
|
|
}
|
|
|
|
static inline int
|
|
ctf_forwardable_kind (int kind)
|
|
{
|
|
return (kind == CTF_K_STRUCT || kind == CTF_K_UNION || kind == CTF_K_ENUM);
|
|
}
|
|
|
|
static inline int
|
|
ctf_dynhash_cnext_sorted (ctf_dynhash_t *h, ctf_next_t **i, const void **key,
|
|
const void **value, ctf_hash_sort_f sort_fun,
|
|
void *sort_arg)
|
|
{
|
|
return ctf_dynhash_next_sorted (h, i, (void **) key, (void **) value,
|
|
sort_fun, sort_arg);
|
|
}
|
|
|
|
static inline int
|
|
ctf_dynhash_cnext (ctf_dynhash_t *h, ctf_next_t **it,
|
|
const void **key, const void **value)
|
|
{
|
|
return ctf_dynhash_next (h, it, (void **) key, (void **) value);
|
|
}
|
|
|
|
static inline int
|
|
ctf_dynhash_cinsert (ctf_dynhash_t *h, const void *k, const void *v)
|
|
{
|
|
return ctf_dynhash_insert (h, (void *) k, (void *) v);
|
|
}
|
|
|
|
static inline int
|
|
ctf_dynset_cnext (ctf_dynset_t *h, ctf_next_t **it, const void **key)
|
|
{
|
|
return ctf_dynset_next (h, it, (void **) key);
|
|
}
|
|
|
|
static inline int
|
|
ctf_dynset_cinsert (ctf_dynset_t *h, const void *k)
|
|
{
|
|
return ctf_dynset_insert (h, (void *) k);
|
|
}
|
|
|
|
static inline int
|
|
ctf_assert_internal (ctf_dict_t *fp, const char *file, size_t line,
|
|
const char *exprstr, int expr)
|
|
{
|
|
if (_libctf_unlikely_ (!expr))
|
|
ctf_assert_fail_internal (fp, file, line, exprstr);
|
|
|
|
return expr;
|
|
}
|
|
|
|
static inline int
|
|
ctf_set_errno (ctf_dict_t *fp, int err)
|
|
{
|
|
fp->ctf_errno = err;
|
|
/* Don't rely on CTF_ERR here as it will not properly sign extend on 64-bit
|
|
Windows ABI. */
|
|
return -1;
|
|
}
|
|
|
|
static inline ctf_id_t
|
|
ctf_set_typed_errno (ctf_dict_t *fp, int err)
|
|
{
|
|
fp->ctf_errno = err;
|
|
return CTF_ERR;
|
|
}
|
|
|
|
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif
|
|
|
|
#endif /* _CTF_INLINES_H */
|